carstenklapp [Sun, 21 Dec 2003 00:29:45 +0000 (00:29 +0000)]
Minor bugfix: Fixed broken debug argument.
Internal changes: Only create a DebugTimer when actually called for;
moved debug message out of page content and into deferred page error
notification via trigger_error. Memory management: Only include_once
lib/PageList when absolutely necessary (at this time, this will
probably only benefit the PluginManager as an incremental speedup &
slightly reduced memory).
carstenklapp [Sun, 14 Dec 2003 05:36:31 +0000 (05:36 +0000)]
Internal changes to prepare for an upcoming feature: Added some
conditions and alternate phrases (alternate wording of text srings
when referring to a non-existant page (i.e. WikiLink 'unknown')) when
calling the BackLinks plugin *within* a non-existant page, such as
from within an editpage or browse template while editing a new page.
carstenklapp [Fri, 12 Dec 2003 01:01:46 +0000 (01:01 +0000)]
New feature: Plugin to download page dumps of individual pages. In the
future this could be used as a rudimentary way to sync pages between
wikis.
Internal changes: enhanced and renamed from the experimental
_MailifyPage plugin.
carstenklapp [Fri, 12 Dec 2003 00:52:55 +0000 (00:52 +0000)]
New feature: Plugin to download page dumps of individual pages. In the
future this could be used as a rudimentary way to sync pages between
wikis.
Internal changes: enhanced and renamed from the experimental
_MailifyPage plugin.
carstenklapp [Wed, 10 Dec 2003 01:01:24 +0000 (01:01 +0000)]
New features: Also show plugin pages for localized variants.
Gracefully handle broken plugins in the plugins folder (such as other
lingering php files).
Bugfix: Cleaned up Php warnings related to oddities of UserPreference
plugin (whose default value contains an array).
Internal changes: Gave GoodVariableNames to the nightmarish
ones. Simplified some code with WikiLink 'if_known'.
carstenklapp [Tue, 9 Dec 2003 20:00:43 +0000 (20:00 +0000)]
Bugfix: The last BogoUserPrefs-bugfix prevented the admin from saving
prefs into his own homepage, fixed broken logic. Tightened up BogoUser
prefs saving ability by checking for true existance of homepage
(previously a page revision of 0 also counted as valid, again due to
somewhat flawed logic).
carstenklapp [Mon, 8 Dec 2003 22:43:30 +0000 (22:43 +0000)]
New experimental plugin to provide a different kind of
PageHistory. Functional as-is, but is in need of much cleanup and
refactoring. Probably very, very slow on wikis with many pages!
carstenklapp [Sun, 7 Dec 2003 20:35:26 +0000 (20:35 +0000)]
Bugfix: Concurrent updates broken since after 1.3.4 release: Fatal
error: Call to undefined function: gettransformedcontent() in
/home/groups/p/ph/phpwiki/htdocs/phpwiki2/lib/editpage.php on line
205.
carstenklapp [Sat, 6 Dec 2003 04:56:23 +0000 (04:56 +0000)]
Security bugfix (minor): Prevent BogoUser~s from saving extraneous
_pref object meta-data within locked pages.
Previously, BogoUser~s who signed in with a (valid) WikiWord such as
"HomePage" could actually save preferences into that page, even though
it was already locked by the administrator. Thus, any subsequent
WikiLink~s to that page would become prefixed with "that nice little"
UserIcon, as if that page represented a valid user.
Note that the admin can lock (even) non-existant pages as desired or
necessary (i.e. any DB page whose revision==0), to prevent the
arbitrary BogoUser from saving preference metadata into such a page;
for example, the silly WikiName "@qmgi`Vcft_x|" (that is the
\$examplechars presented in login.tmpl, in case it is not visible here
in the CVS comments).
To remove the prefs metadata from a page, the admin can use the
EditMetaData plugin, enter pref as the key, leave the value box empty
and then submit the change. For example:
(It seems a rethinking of WikiUserNew.php with its WikiUser and
UserPreferences classes is in order. Ideally the WikiDB would
transparently handle such a situation, perhaps BogoUser~s should
simply be restricted to saving preferences into a cookie until his/her
e-mail address has been verified.)
carstenklapp [Fri, 5 Dec 2003 20:54:14 +0000 (20:54 +0000)]
CSS tweaks: Removed the recently added border from definition lists
<dl>. It looks very bad with OldStyleMarkup, where dl~s were often
used to simply indent text.
carstenklapp [Fri, 5 Dec 2003 15:51:37 +0000 (15:51 +0000)]
Added note that use of the configurator is depreciated.
Enable localization/gettextification of $KeywordLinkRegexp. (Also, now
users not familiar with regex can more easily just edit the $keywords
array).
Added four new constants to define author and copyright link rel~s
used in html head. This makes it easier to run multiple wikis off of
one set of code.
Eliminated RECENT_CHANGES constant for RSS auto discovery because it's
another step to watch out for when running a non-english wiki. Now
simply defined as _("RecentChanges") in head.tmpl itself. Non-standard
wikis where the RecentChanges page has been named to something else
will have to modify this in head.tmpl (along with all other places the
word RecentChanges appears in the code, something that already would
have had to be done on such a wiki anyway).
Added a little more info and instructions to flesh out:
DEBUG, WIKI_NAME, ADMIN_USER, $DisabledActions, $DBParams, CHARSET.
A few typos and spelling mistakes corrected, and some text rewrapped.
carstenklapp [Fri, 5 Dec 2003 15:36:39 +0000 (15:36 +0000)]
Improvements: to make it easier to run multiple wikis off of one set
of code, urls for link rel author and copyright now defined in
index.php.
Bugfix: updated language meta tag to use DEFAULT_LANGUAGE constant
instead of old LANG global.
Internal change: Eliminated RECENT_CHANGES constant from RSS link,
just use the easily localizable _("RecentChanges").
Typo fixed.
carstenklapp [Fri, 5 Dec 2003 01:32:28 +0000 (01:32 +0000)]
New feature: Easier to run multiple wiks off of one set of code. Name
your logo and signature image files "YourWikiNameLogo.png" and
"YourWikiNameSignature.png" and put them all into
themes/default/images. YourWikiName should match what is defined as
WIKI_NAME in index.php. In case the image is not found, the default
shipped with PhpWiki will be used.
carstenklapp [Thu, 4 Dec 2003 19:33:30 +0000 (19:33 +0000)]
Bugfix: Under certain PhpWiki installations (such as the PhpWiki at
SF), the user was unable to select a theme other than the server's
default. (Use the more robust Theme::findFile instead of PHP's
file_exists function to detect installed themes).
carstenklapp [Wed, 3 Dec 2003 21:45:48 +0000 (21:45 +0000)]
Added admin user, password user, and preference classes. Added
password checking functions for users and the admin. (Now the easy
parts are nearly done).
carstenklapp [Wed, 3 Dec 2003 02:09:26 +0000 (02:09 +0000)]
Minor new feature: Added 'PurgeHtmlCache' "convenience" button for the
admin and for everyone when DEBUGging, to purge html cache for only
the current page. (Admin can still purge the html cache for all pages
in PhpWikiAdministration).
carstenklapp [Tue, 2 Dec 2003 05:46:36 +0000 (05:46 +0000)]
Complete rewrite of WikiUser.php.
This should make it easier to hook in user permission groups etc. some
time in the future. Most importantly, to finally get UserPreferences
fully working properly for all classes of users: AnonUser, BogoUser,
AdminUser; whether they have a NamesakePage (PersonalHomePage) or not,
want a cookie or not, and to bring back optional AutoLogin with the
UserName stored in a cookie--something that was lost after PhpWiki had
dropped the default http auth login method.
Added WikiUser classes which will (almost) work together with existing
UserPreferences class. Other parts of PhpWiki need to be updated yet
before this code can be hooked up.
carstenklapp [Mon, 1 Dec 2003 22:23:01 +0000 (22:23 +0000)]
Bugfix: UserPreferences are no longer clobbered when signing in after
the previous session has ended (i.e. user closed browser then signed
in again). This is still a bit of a mess, and the preferences do not
take effect until the next page browse/link has been clicked.
carstenklapp [Sat, 29 Nov 2003 20:06:43 +0000 (20:06 +0000)]
New features: Added two new column types 'size' and 'content' (first 50
bytes shown only). Added new "action" column 'remove' to help admin
remove multiple pages (at least a little bit) easier.
carstenklapp [Fri, 28 Nov 2003 21:06:31 +0000 (21:06 +0000)]
Enhancement: Mozilla RecentChanges sidebar now defaults to 10 changes
instead of 1. Make diff buttons smaller with css. Added description
line back in at the top.
carstenklapp [Thu, 27 Nov 2003 15:17:01 +0000 (15:17 +0000)]
Theme & appearance tweaks: Converted Mozilla sidebar link into a Theme
button, to allow an image button for it to be added to Themes. Output
RSS button in small text size when theme has no button image.
carstenklapp [Tue, 25 Nov 2003 22:55:32 +0000 (22:55 +0000)]
Localization bugfix: For wikis where English is not the default system
language, make sure that the authority error message (i.e. "You must
sign in to edit pages in this wiki" etc.) is displayed in the wiki's
default language. Previously it would always display in English.
(Added call to update_locale() before displaying any messages prior to
the login prompt.)
carstenklapp [Tue, 25 Nov 2003 21:58:33 +0000 (21:58 +0000)]
Bugfix: reverting this file to CVS Revision 1.18, since the localized
ActionPages finder problem was with lib/main.php and not really in
here. (See main.php,v 1.101 2003/11/25 21:49:44).
carstenklapp [Tue, 25 Nov 2003 21:49:44 +0000 (21:49 +0000)]
Bugfix: For a non-english wiki or when the user's preference is not
english, the wiki would always use the english ActionPage first if it
was present rather than the appropriate localised variant. (PhpWikis
running only in english or Wikis running ONLY without any english
ActionPages would not notice this bug, only when both english and
localised ActionPages were in the DB.) Now we check for the localised
variant first.
carstenklapp [Tue, 25 Nov 2003 16:36:53 +0000 (16:36 +0000)]
Formatting changes: <br> past logo before displaying login
instructions, in case logo is tall.
New feature: Added call to TransformText of BlockParser, to allow
WikiLinks within login instructions. (Localizations of login
instructions will have to be updated.)
carstenklapp [Sun, 23 Nov 2003 16:33:02 +0000 (16:33 +0000)]
New plugin to list names of SubPages of the currrent
page. (Unfortunately this plugin reveals a bug in
stdlib/explodePageList(), the function doesn't seem to work as
expected when there are no subpages (see also UnfoldSubPages plugin).
carstenklapp [Fri, 21 Nov 2003 23:06:12 +0000 (23:06 +0000)]
Bugfix: Some <link rel=...> links in Mozilla/iCab were always linking
to the english pages even when DEFAULT_LANGUAGE != 'en'. (Rewrapped
text for a more complete xgettext string extraction: 'cd
phpwiki/locale;make' to update po/mo files).
carstenklapp [Fri, 21 Nov 2003 21:32:39 +0000 (21:32 +0000)]
Bugfix: When DEFAULT_LANGUAGE was not 'en', a user's language prefs
would revert to 'en' when the default <system language> was selected
in UserPreferences and the user saved his preferences. (Check for
empty or blank language pref in sanify function of class
_UserPreference_language and return DEFAULT_LANGUAGE if nothing or
default selected in UserPreferences.)
carstenklapp [Fri, 21 Nov 2003 16:54:58 +0000 (16:54 +0000)]
Bugfix: login.tmpl was always displayed in English despite
DEFAULT_LANGUAGE set in index.php. (Added call to
update_locale(DEFAULT_LANGUAGE) before printing login form).
carstenklapp [Thu, 20 Nov 2003 22:18:54 +0000 (22:18 +0000)]
New feature: h1 during merge-edit displays WikiLink to original page.
Internal changes: Replaced some hackish url-generation code in
function SavePage (for pgsrc merge-edit) with appropriate Button()
calls.
carstenklapp [Thu, 20 Nov 2003 20:51:06 +0000 (20:51 +0000)]
Added css-formatting for definition lists (dl/dt/dd), also used by
FullTextSearch results list. Tested with Mozilla, IE5Mac, OmniWeb and
Safari (both use same engines as Konquorer so it should look the same
there). Not yet tested against Netscape 4.
carstenklapp [Thu, 20 Nov 2003 19:28:47 +0000 (19:28 +0000)]
----------------------------------------------------------------------
----------------------------------------------------------------------
Bugfix: Localized LikePages and BackLinks were using the english pages
instead of the localized variants. Other minor code refactoring
(WikiLink()--->Button()).