From d365024556b2794b5c2e278ea3d78e103c769041 Mon Sep 17 00:00:00 2001 From: dim Date: Tue, 19 Feb 2013 08:07:11 +0000 Subject: [PATCH] MFC r246875: Import change 40eebf235370b6fe6353784ccf01ab92eed062a5 from upstream wpa: From: Jouni Malinen Date: Fri, 15 Jul 2011 13:42:06 +0300 Subject: [PATCH] MD5: Fix clearing of temporary stack memory to use correct length sizeof of the structure instead of the pointer was supposed to be used here. Fix this to clear the full structure at the end of MD5Final(). Found by: clang ToT Reviewed by: rpaulo git-svn-id: svn://svn.freebsd.org/base/stable/8@246982 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- contrib/wpa/src/crypto/md5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/wpa/src/crypto/md5.c b/contrib/wpa/src/crypto/md5.c index a7db7aa9a..e13ce7d49 100644 --- a/contrib/wpa/src/crypto/md5.c +++ b/contrib/wpa/src/crypto/md5.c @@ -287,7 +287,7 @@ void MD5Final(unsigned char digest[16], struct MD5Context *ctx) MD5Transform(ctx->buf, (u32 *) ctx->in); byteReverse((unsigned char *) ctx->buf, 4); os_memcpy(digest, ctx->buf, 16); - os_memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */ + os_memset(ctx, 0, sizeof(*ctx)); /* In case it's sensitive */ } /* The four core functions - F1 is optimized somewhat */ -- 2.45.0