]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
net80211: correct length check in ieee80211_ies_expand()
authorBjoern A. Zeeb <bz@FreeBSD.org>
Wed, 6 Oct 2021 18:09:39 +0000 (18:09 +0000)
committerMark Johnston <markj@FreeBSD.org>
Tue, 15 Mar 2022 17:45:36 +0000 (13:45 -0400)
commit0d1db5c3257e7cd1708b21dc4c6b14c9b1a41ec4
treebaa3612852e70b642b2c825be120715a90c89719
parent6eb932a969139b9f42f0ad130bda36f0d709e2a9
net80211: correct length check in ieee80211_ies_expand()

In ieee80211_ies_expand() we are looping over Elements
(also known as Information Elements or IEs).
The comment suggests that we assume well-formedness of
the IEs themselves.
Checking the buffer length being least 2 (1 byte Element ID and
1 byte Length fields) rather than just 1 before accessing ie[1]
is still good practise and can prevent and out-of-bounds read in
case the input is not behaving according to the comment.

Reported by: (coypu sdf.org)
admbugs: 857

(cherry picked from commit 09dd08f167812a5fdb516fc98f14dbb43221432f)
(cherry picked from commit 32c2c00e3f90d3a01a03ebdf7131c7e300da034c)

Approved by: so
Security: FreeBSD-SA-22:02.wifi
sys/net80211/ieee80211_node.c