From 552a29b8ec3f5d30a96a5480cf5dbf47683f5eac Mon Sep 17 00:00:00 2001 From: hselasky Date: Mon, 7 Mar 2016 09:35:20 +0000 Subject: [PATCH] MFC r295608: Fix variable assignment inside if-clause in the smsc driver. Found by D5245 / PVS. git-svn-id: svn://svn.freebsd.org/base/stable/10@296443 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- sys/dev/usb/net/if_smsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c index c8f220252..34c3ae9c4 100644 --- a/sys/dev/usb/net/if_smsc.c +++ b/sys/dev/usb/net/if_smsc.c @@ -1341,7 +1341,7 @@ smsc_chip_init(struct smsc_softc *sc) /* Reset the PHY */ smsc_write_reg(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST); - if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST) != 0)) { + if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST)) != 0) { smsc_warn_printf(sc, "timed-out waiting for phy reset to complete\n"); goto init_failed; } -- 2.45.0