//=== InnerPointerChecker.cpp -------------------------------------*- C++ -*--// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // This file defines a check that marks a raw pointer to a C++ container's // inner buffer released when the object is destroyed. This information can // be used by MallocChecker to detect use-after-free problems. // //===----------------------------------------------------------------------===// #include "AllocationState.h" #include "ClangSACheckers.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" #include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" using namespace clang; using namespace ento; using PtrSet = llvm::ImmutableSet; // Associate container objects with a set of raw pointer symbols. REGISTER_MAP_WITH_PROGRAMSTATE(RawPtrMap, const MemRegion *, PtrSet) // This is a trick to gain access to PtrSet's Factory. namespace clang { namespace ento { template <> struct ProgramStateTrait : public ProgramStatePartialTrait { static void *GDMIndex() { static int Index = 0; return &Index; } }; } // end namespace ento } // end namespace clang namespace { class InnerPointerChecker : public Checker { CallDescription AppendFn, AssignFn, ClearFn, CStrFn, DataFn, EraseFn, InsertFn, PopBackFn, PushBackFn, ReplaceFn, ReserveFn, ResizeFn, ShrinkToFitFn, SwapFn; public: class InnerPointerBRVisitor : public BugReporterVisitor { SymbolRef PtrToBuf; public: InnerPointerBRVisitor(SymbolRef Sym) : PtrToBuf(Sym) {} static void *getTag() { static int Tag = 0; return &Tag; } void Profile(llvm::FoldingSetNodeID &ID) const override { ID.AddPointer(getTag()); } std::shared_ptr VisitNode(const ExplodedNode *N, const ExplodedNode *PrevN, BugReporterContext &BRC, BugReport &BR) override; // FIXME: Scan the map once in the visitor's constructor and do a direct // lookup by region. bool isSymbolTracked(ProgramStateRef State, SymbolRef Sym) { RawPtrMapTy Map = State->get(); for (const auto Entry : Map) { if (Entry.second.contains(Sym)) return true; } return false; } }; InnerPointerChecker() : AppendFn("append"), AssignFn("assign"), ClearFn("clear"), CStrFn("c_str"), DataFn("data"), EraseFn("erase"), InsertFn("insert"), PopBackFn("pop_back"), PushBackFn("push_back"), ReplaceFn("replace"), ReserveFn("reserve"), ResizeFn("resize"), ShrinkToFitFn("shrink_to_fit"), SwapFn("swap") {} /// Check whether the function called on the container object is a /// member function that potentially invalidates pointers referring /// to the objects's internal buffer. bool mayInvalidateBuffer(const CallEvent &Call) const; /// Record the connection between the symbol returned by c_str() and the /// corresponding string object region in the ProgramState. Mark the symbol /// released if the string object is destroyed. void checkPostCall(const CallEvent &Call, CheckerContext &C) const; /// Clean up the ProgramState map. void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; }; } // end anonymous namespace // [string.require] // // "References, pointers, and iterators referring to the elements of a // basic_string sequence may be invalidated by the following uses of that // basic_string object: // // -- TODO: As an argument to any standard library function taking a reference // to non-const basic_string as an argument. For example, as an argument to // non-member functions swap(), operator>>(), and getline(), or as an argument // to basic_string::swap(). // // -- Calling non-const member functions, except operator[], at, front, back, // begin, rbegin, end, and rend." // bool InnerPointerChecker::mayInvalidateBuffer(const CallEvent &Call) const { if (const auto *MemOpCall = dyn_cast(&Call)) { OverloadedOperatorKind Opc = MemOpCall->getOriginExpr()->getOperator(); if (Opc == OO_Equal || Opc == OO_PlusEqual) return true; return false; } return (isa(Call) || Call.isCalled(AppendFn) || Call.isCalled(AssignFn) || Call.isCalled(ClearFn) || Call.isCalled(EraseFn) || Call.isCalled(InsertFn) || Call.isCalled(PopBackFn) || Call.isCalled(PushBackFn) || Call.isCalled(ReplaceFn) || Call.isCalled(ReserveFn) || Call.isCalled(ResizeFn) || Call.isCalled(ShrinkToFitFn) || Call.isCalled(SwapFn)); } void InnerPointerChecker::checkPostCall(const CallEvent &Call, CheckerContext &C) const { const auto *ICall = dyn_cast(&Call); if (!ICall) return; SVal Obj = ICall->getCXXThisVal(); const auto *ObjRegion = dyn_cast_or_null(Obj.getAsRegion()); if (!ObjRegion) return; auto *TypeDecl = ObjRegion->getValueType()->getAsCXXRecordDecl(); if (TypeDecl->getName() != "basic_string") return; ProgramStateRef State = C.getState(); if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) { SVal RawPtr = Call.getReturnValue(); if (SymbolRef Sym = RawPtr.getAsSymbol(/*IncludeBaseRegions=*/true)) { // Start tracking this raw pointer by adding it to the set of symbols // associated with this container object in the program state map. PtrSet::Factory &F = State->getStateManager().get_context(); const PtrSet *SetPtr = State->get(ObjRegion); PtrSet Set = SetPtr ? *SetPtr : F.getEmptySet(); assert(C.wasInlined || !Set.contains(Sym)); Set = F.add(Set, Sym); State = State->set(ObjRegion, Set); C.addTransition(State); } return; } if (mayInvalidateBuffer(Call)) { if (const PtrSet *PS = State->get(ObjRegion)) { // Mark all pointer symbols associated with the deleted object released. const Expr *Origin = Call.getOriginExpr(); for (const auto Symbol : *PS) { // NOTE: `Origin` may be null, and will be stored so in the symbol's // `RefState` in MallocChecker's `RegionState` program state map. State = allocation_state::markReleased(State, Symbol, Origin); } State = State->remove(ObjRegion); C.addTransition(State); return; } } } void InnerPointerChecker::checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const { ProgramStateRef State = C.getState(); PtrSet::Factory &F = State->getStateManager().get_context(); RawPtrMapTy RPM = State->get(); for (const auto Entry : RPM) { if (!SymReaper.isLiveRegion(Entry.first)) { // Due to incomplete destructor support, some dead regions might // remain in the program state map. Clean them up. State = State->remove(Entry.first); } if (const PtrSet *OldSet = State->get(Entry.first)) { PtrSet CleanedUpSet = *OldSet; for (const auto Symbol : Entry.second) { if (!SymReaper.isLive(Symbol)) CleanedUpSet = F.remove(CleanedUpSet, Symbol); } State = CleanedUpSet.isEmpty() ? State->remove(Entry.first) : State->set(Entry.first, CleanedUpSet); } } C.addTransition(State); } std::shared_ptr InnerPointerChecker::InnerPointerBRVisitor::VisitNode(const ExplodedNode *N, const ExplodedNode *PrevN, BugReporterContext &BRC, BugReport &BR) { if (!isSymbolTracked(N->getState(), PtrToBuf) || isSymbolTracked(PrevN->getState(), PtrToBuf)) return nullptr; const Stmt *S = PathDiagnosticLocation::getStmt(N); if (!S) return nullptr; SmallString<256> Buf; llvm::raw_svector_ostream OS(Buf); OS << "Dangling inner pointer obtained here"; PathDiagnosticLocation Pos(S, BRC.getSourceManager(), N->getLocationContext()); return std::make_shared(Pos, OS.str(), true, nullptr); } namespace clang { namespace ento { namespace allocation_state { std::unique_ptr getInnerPointerBRVisitor(SymbolRef Sym) { return llvm::make_unique(Sym); } } // end namespace allocation_state } // end namespace ento } // end namespace clang void ento::registerInnerPointerChecker(CheckerManager &Mgr) { registerNewDeleteChecker(Mgr); Mgr.registerChecker(); }