From 02087c75b8956c94cbd531e3c7b7de6d37f94088 Mon Sep 17 00:00:00 2001 From: kevans Date: Tue, 7 Aug 2018 03:26:32 +0000 Subject: [PATCH] libbe(3): Document that we'll clobber previous errors set by set_error --- lib/libbe/be_error.c | 1 - lib/libbe/be_impl.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libbe/be_error.c b/lib/libbe/be_error.c index 9da17eb492b..58df17ba4e2 100644 --- a/lib/libbe/be_error.c +++ b/lib/libbe/be_error.c @@ -107,7 +107,6 @@ int set_error(libbe_handle_t *lbh, be_error_t err) { - /* XXX TODO: should the old error be overwritten or no? */ lbh->error = err; if (lbh->print_on_err && (err != BE_ERR_SUCCESS)) fprintf(stderr, "%s\n", libbe_error_description(lbh)); diff --git a/lib/libbe/be_impl.h b/lib/libbe/be_impl.h index 0b40a285b6e..f92d22f4d99 100644 --- a/lib/libbe/be_impl.h +++ b/lib/libbe/be_impl.h @@ -64,6 +64,7 @@ typedef struct prop_data { int prop_list_builder_cb(zfs_handle_t *, void *); int be_proplist_update(prop_data_t *); +/* Clobbers any previous errors */ int set_error(libbe_handle_t *, be_error_t); #endif /* _LIBBE_IMPL_H */ -- 2.45.0