From 12acc2ced0e98641dc6535cc16ea620bd6224427 Mon Sep 17 00:00:00 2001 From: imp Date: Mon, 15 Jul 2019 20:25:41 +0000 Subject: [PATCH] Use the more proper term of SATL instead of ATA_BEHIND_SCSI. Most people know SAS attached SATA devices by the name SAT or SATL (with the latter being a little more common). Change the device type ATA_BEHIND_SCSI to SATL since it's more specific and meaningful. Suggested by: scottl@ --- sbin/camcontrol/camcontrol.c | 2 +- sbin/camcontrol/camcontrol.h | 2 +- sbin/camcontrol/epc.c | 2 +- sbin/camcontrol/fwdownload.c | 6 +++--- sbin/camcontrol/zone.c | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/sbin/camcontrol/camcontrol.c b/sbin/camcontrol/camcontrol.c index 5b8d47a66b1..58319eb5893 100644 --- a/sbin/camcontrol/camcontrol.c +++ b/sbin/camcontrol/camcontrol.c @@ -5391,7 +5391,7 @@ get_device_type(struct cam_device *dev, int retry_count, int timeout, retval = dev_has_vpd_page(dev, SVPD_ATA_INFORMATION, retry_count, timeout, verbosemode); if (retval == 1) - *devtype = CC_DT_ATA_BEHIND_SCSI; + *devtype = CC_DT_SATL; else *devtype = CC_DT_SCSI; diff --git a/sbin/camcontrol/camcontrol.h b/sbin/camcontrol/camcontrol.h index 7c3f7da1f5c..438331c4945 100644 --- a/sbin/camcontrol/camcontrol.h +++ b/sbin/camcontrol/camcontrol.h @@ -42,7 +42,7 @@ typedef enum { typedef enum { CC_DT_NONE, CC_DT_SCSI, - CC_DT_ATA_BEHIND_SCSI, + CC_DT_SATL, CC_DT_ATA, CC_DT_NVME, CC_DT_MMCSD, diff --git a/sbin/camcontrol/epc.c b/sbin/camcontrol/epc.c index 3b74d08a4eb..8b42f63c752 100644 --- a/sbin/camcontrol/epc.c +++ b/sbin/camcontrol/epc.c @@ -767,7 +767,7 @@ epc(struct cam_device *device, int argc, char **argv, char *combinedopt, switch (devtype) { case CC_DT_ATA: - case CC_DT_ATA_BEHIND_SCSI: + case CC_DT_SATL: break; default: warnx("The epc subcommand only works with ATA protocol " diff --git a/sbin/camcontrol/fwdownload.c b/sbin/camcontrol/fwdownload.c index ef6fe98015d..53a76084115 100644 --- a/sbin/camcontrol/fwdownload.c +++ b/sbin/camcontrol/fwdownload.c @@ -694,7 +694,7 @@ fw_check_device_ready(struct cam_device *dev, camcontrol_devtype devtype, /*sense_len*/ SSD_FULL_SIZE, /*timeout*/ 5000); break; - case CC_DT_ATA_BEHIND_SCSI: + case CC_DT_SATL: case CC_DT_ATA: { retval = build_ata_cmd(ccb, /*retries*/ 1, @@ -853,7 +853,7 @@ fw_download_img(struct cam_device *cam_dev, struct fw_vendor *vp, timeout ? timeout : WB_TIMEOUT); /* timeout*/ break; case CC_DT_ATA: - case CC_DT_ATA_BEHIND_SCSI: { + case CC_DT_SATL: { uint32_t off; off = (uint32_t)(pkt_ptr - buf); @@ -969,7 +969,7 @@ fwdownload(struct cam_device *device, int argc, char **argv, errx(1, "Unable to determine device type"); if ((devtype == CC_DT_ATA) - || (devtype == CC_DT_ATA_BEHIND_SCSI)) { + || (devtype == CC_DT_SATL)) { ccb = cam_getccb(device); if (ccb == NULL) { warnx("couldn't allocate CCB"); diff --git a/sbin/camcontrol/zone.c b/sbin/camcontrol/zone.c index 853607d7ea8..130f53226f5 100644 --- a/sbin/camcontrol/zone.c +++ b/sbin/camcontrol/zone.c @@ -466,7 +466,7 @@ zone(struct cam_device *device, int argc, char **argv, char *combinedopt, /*timeout*/ timeout ? timeout : 60000); break; case CC_DT_ATA: - case CC_DT_ATA_BEHIND_SCSI: { + case CC_DT_SATL: { uint8_t command = 0; uint8_t protocol = 0; uint16_t features = 0, sector_count = 0; @@ -558,7 +558,7 @@ zone(struct cam_device *device, int argc, char **argv, char *combinedopt, /*timeout*/ timeout ? timeout : 60000); break; case CC_DT_ATA: - case CC_DT_ATA_BEHIND_SCSI: { + case CC_DT_SATL: { uint8_t command = 0; uint8_t protocol = 0; uint16_t features = 0, sector_count = 0; -- 2.45.0