From 55d72309e60d591c9988c21be0956a182ae086c3 Mon Sep 17 00:00:00 2001 From: markj Date: Fri, 13 Nov 2015 01:25:02 +0000 Subject: [PATCH] MFC r290320: Have elf_lookup() return an error if the specified non-weak symbol could not be found. Otherwise, relocations against such symbols will be silently ignored instead of causing an error to be raised. git-svn-id: svn://svn.freebsd.org/base/stable/10@290737 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- sys/kern/link_elf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kern/link_elf.c b/sys/kern/link_elf.c index b4f65864a..3b03d6f0e 100644 --- a/sys/kern/link_elf.c +++ b/sys/kern/link_elf.c @@ -1544,6 +1544,10 @@ elf_lookup(linker_file_t lf, Elf_Size symidx, int deps, Elf_Addr *res) } addr = ((Elf_Addr)linker_file_lookup_symbol(lf, symbol, deps)); + if (addr == 0 && ELF_ST_BIND(sym->st_info) != STB_WEAK) { + *res = 0; + return (EINVAL); + } if (elf_set_find(&set_pcpu_list, addr, &start, &base)) addr = addr - start + base; -- 2.45.0