From 5b330ddf5424d28413bbbd45a6c52aed4ee98c37 Mon Sep 17 00:00:00 2001 From: trasz Date: Wed, 13 Aug 2014 11:11:27 +0000 Subject: [PATCH] MFC r269197: Fix potential double free that could happen after connection error. git-svn-id: svn://svn.freebsd.org/base/stable/10@269925 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- sys/dev/iscsi/icl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/iscsi/icl.c b/sys/dev/iscsi/icl.c index 20b184cae..464f33905 100644 --- a/sys/dev/iscsi/icl.c +++ b/sys/dev/iscsi/icl.c @@ -669,7 +669,10 @@ icl_conn_receive_pdu(struct icl_conn *ic, size_t *availablep) } if (error != 0) { - icl_pdu_free(request); + /* + * Don't free the PDU; it's pointed to by ic->ic_receive_pdu + * and will get freed in icl_conn_close(). + */ icl_conn_fail(ic); } -- 2.45.0