From 60c64b939b3b2ad9a74eb1689758d535bd4de796 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Fri, 27 Jun 2003 03:25:43 +0000 Subject: [PATCH] Remove check to see if the get resource for the second resource succeeds. There is a difference between how OLDCARD and NEWCARD deal with their resources, and this code exposes that difference. I'm not sure which behavior is correct, and will need to look into that in more detail. However, it appears that we go ahead and allocate the right thing in both cases that I have access to (CF cards, CDROM, and external ata enclosures), so go ahead and ignore the failure to get the resource for the other rid. There's already another check to make sure that the actual allocation works correctly, and that should be sufficient to catch cases that don't work. Submitted by: wpaul and iedowse --- sys/dev/ata/ata-card.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/ata/ata-card.c b/sys/dev/ata/ata-card.c index 4e75c68c85d..1f4ba3a91fb 100644 --- a/sys/dev/ata/ata-card.c +++ b/sys/dev/ata/ata-card.c @@ -131,10 +131,6 @@ ata_pccard_probe(device_t dev) start + ATA_ALTOFFSET, ATA_ALTIOSIZE); } } - else { - bus_release_resource(dev, SYS_RES_IOPORT, rid, io); - return ENXIO; - } /* allocate the altport range */ rid = ATA_ALTADDR_RID; -- 2.45.2