From 67c0796ca306af8094b74bd5f2b73bfb64c2a5ad Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Tue, 7 Mar 2006 21:31:20 +0000 Subject: [PATCH] For consistency sake, use >= MINCLSIZE rather than > MINCLSIZE to determine whether or not to allocate a full mbuf cluster rather than just a plain mbuf when adding on additional mbufs in m_getm(). In practice, there wasn't any resulting mem trashing since m_getm() doesn't ever allocate an mbuf with a packet header, and MINCLSIZE is the available payload in an mbuf with a header rather than the available payload in a plain mbuf. Discussed with: andre (lightly) --- sys/kern/uipc_mbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/uipc_mbuf.c b/sys/kern/uipc_mbuf.c index d2b11303de5..0eb8a701932 100644 --- a/sys/kern/uipc_mbuf.c +++ b/sys/kern/uipc_mbuf.c @@ -131,7 +131,7 @@ m_getm(struct mbuf *m, int len, int how, short type) cur = (cur->m_next = mb); } if (rem > 0) { - mb = (rem > MINCLSIZE) ? + mb = (rem >= MINCLSIZE) ? m_getcl(how, type, 0) : m_get(how, type); if (mb == NULL) goto failed; -- 2.45.2