From 6ba78aaafb78c36b304cf8bd0e524c7d180b4e15 Mon Sep 17 00:00:00 2001
From: dairiki <dairiki@96ab9672-09ca-45d6-a79d-3d69d39ca109>
Date: Fri, 21 Sep 2001 19:15:12 +0000
Subject: [PATCH] Efficiency patch from Gary Benson <gary@inauspicious.org>:
 don't compute MostPopular list unless it's needed.

git-svn-id: svn://svn.code.sf.net/p/phpwiki/code/branches/release-1_2-branch@578 96ab9672-09ca-45d6-a79d-3d69d39ca109
---
 lib/transform.php | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/lib/transform.php b/lib/transform.php
index e70c5a6cb..7c39c6e53 100644
--- a/lib/transform.php
+++ b/lib/transform.php
@@ -1,4 +1,4 @@
-<?php rcs_id('$Id: transform.php,v 1.8.2.1 2001-03-02 03:48:47 dairiki Exp $');
+<?php rcs_id('$Id: transform.php,v 1.8.2.2 2001-09-21 19:15:12 dairiki Exp $');
    // expects $pagehash and $html to be set
 
    function tokenize($str, $pattern, &$orig, &$ntokens) {
@@ -32,12 +32,6 @@
    }
 
 
-   // only call these once, for efficiency
-   $quick_search_box  = RenderQuickSearch();
-   $full_search_box   = RenderFullSearch();
-   $most_popular_list = RenderMostPopular();
-
-
    // Loop over all lines of the page and apply transformation rules
    $numlines = count($pagehash["content"]);
 
@@ -245,9 +239,12 @@ your web server it is highly advised that you do not allow this.
       // These are still problems as far as generating correct HTML is
       // concerned.  Paragraph (<p>) elements are not allowed to contain
       // other block-level elements (like <form>s). 
-      $tmpline = str_replace('%%Search%%', $quick_search_box, $tmpline);
-      $tmpline = str_replace('%%Fullsearch%%', $full_search_box, $tmpline);
-      $tmpline = str_replace('%%Mostpopular%%', $most_popular_list, $tmpline);
+      if (strstr($tmpline, '%%Search%%'))
+         $tmpline = str_replace('%%Search%%', RenderQuickSearch(), $tmpline);
+      if (strstr($tmpline, '%%Fullsearch%%'))
+         $tmpline = str_replace('%%Fullsearch%%', RenderFullSearch(), $tmpline);
+      if (strstr($tmpline, '%%Mostpopular%%'))
+         $tmpline = str_replace('%%Mostpopular%%', RenderMostPopular(), $tmpline);
       if(defined('WIKI_ADMIN') && strstr($tmpline, '%%ADMIN-'))
          $tmpline = ParseAdminTokens($tmpline);
 
-- 
2.45.2