From 95f16c1e2c97fa321ac6a7122c8e8602e8f01214 Mon Sep 17 00:00:00 2001 From: Paul Saab Date: Fri, 21 Apr 2006 19:26:21 +0000 Subject: [PATCH] Don't try to kill embryonic processes in killpg1(). This prevents a race condition between fork() and kill(pid,sig) with pid < 0 that can cause a kernel panic. Submitted by: up MFC after: 3 weeks --- sys/kern/kern_sig.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index 2d99ff110d5..c39dfa4aed7 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -1674,7 +1674,7 @@ killpg1(td, sig, pgid, all) LIST_FOREACH(p, &allproc, p_list) { PROC_LOCK(p); if (p->p_pid <= 1 || p->p_flag & P_SYSTEM || - p == td->td_proc) { + p == td->td_proc || p->p_state == PRS_NEW) { PROC_UNLOCK(p); continue; } @@ -1704,7 +1704,8 @@ killpg1(td, sig, pgid, all) sx_sunlock(&proctree_lock); LIST_FOREACH(p, &pgrp->pg_members, p_pglist) { PROC_LOCK(p); - if (p->p_pid <= 1 || p->p_flag & P_SYSTEM) { + if (p->p_pid <= 1 || p->p_flag & P_SYSTEM || + p->p_state == PRS_NEW ) { PROC_UNLOCK(p); continue; } -- 2.45.2