From 96b8eccb40ce370c378cb4c173dbf4b69cf04ecd Mon Sep 17 00:00:00 2001 From: vargenau Date: Fri, 27 Mar 2009 10:07:24 +0000 Subject: [PATCH] jsFlipAll Javascript code was inserted inside the table, leading to invalid XHTML code. Better use a separate Javascript file. git-svn-id: svn://svn.code.sf.net/p/phpwiki/code/trunk@6724 96ab9672-09ca-45d6-a79d-3d69d39ca109 --- lib/PageList.php | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/lib/PageList.php b/lib/PageList.php index 3d6eebf6b..f9b1a8005 100644 --- a/lib/PageList.php +++ b/lib/PageList.php @@ -1423,12 +1423,6 @@ class PageList { $table->pushContent(HTML::caption(array('align'=>'top'), $caption)); } - //Warning: This is quite fragile. It depends solely on a private variable - // in ->_addColumn() - if (!empty($this->_columns_seen['checkbox'])) { - $table->pushContent($this->_jsFlipAll()); - } - $row = HTML::tr(); $table_summary = array(); $i = 1; // start with 1! @@ -1470,21 +1464,6 @@ class PageList { } } - function _jsFlipAll() { - return JavaScript(" -function flipAll(formObj) { - var isFirstSet = -1; - for (var i=0; i < formObj.length; i++) { - fldObj = formObj.elements[i]; - if ((fldObj.type == 'checkbox') && (fldObj.name.substring(0,2) == 'p[')) { - if (isFirstSet == -1) - isFirstSet = (fldObj.checked) ? true : false; - fldObj.checked = (isFirstSet) ? false : true; - } - } -}"); - } - /* recursive stack for private sublist options (azhead, cols) */ function _saveOptions($opts) { $stack = array('pages' => $this->_pages); -- 2.45.0