From a9b06ad81d842fe5c468e5968044f2f07ffd8c81 Mon Sep 17 00:00:00 2001 From: hselasky Date: Fri, 31 Oct 2014 08:10:26 +0000 Subject: [PATCH] MFC r250986: Fix some statical clang analyzer warnings. git-svn-id: svn://svn.freebsd.org/base/stable/9@273890 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- sys/dev/usb/usb_device.c | 3 --- sys/dev/usb/usb_hub.c | 1 - sys/dev/usb/usb_msctest.c | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sys/dev/usb/usb_device.c b/sys/dev/usb/usb_device.c index 48939742d..a4aa3a3a5 100644 --- a/sys/dev/usb/usb_device.c +++ b/sys/dev/usb/usb_device.c @@ -845,9 +845,6 @@ usb_config_parse(struct usb_device *udev, uint8_t iface_index, uint8_t cmd) /* find maximum number of endpoints */ if (ep_max < temp) ep_max = temp; - - /* optimalisation */ - id = (struct usb_interface_descriptor *)ed; } } diff --git a/sys/dev/usb/usb_hub.c b/sys/dev/usb/usb_hub.c index 53f7cd0e5..5713277b0 100644 --- a/sys/dev/usb/usb_hub.c +++ b/sys/dev/usb/usb_hub.c @@ -601,7 +601,6 @@ uhub_reattach_port(struct uhub_softc *sc, uint8_t portno) DPRINTF("reattaching port %d\n", portno); - err = 0; timeout = 0; udev = sc->sc_udev; child = usb_bus_port_get_device(udev->bus, diff --git a/sys/dev/usb/usb_msctest.c b/sys/dev/usb/usb_msctest.c index 166abb53a..61ff733d1 100644 --- a/sys/dev/usb/usb_msctest.c +++ b/sys/dev/usb/usb_msctest.c @@ -798,7 +798,6 @@ usb_msc_eject(struct usb_device *udev, uint8_t iface_index, int method) if (sc == NULL) return (USB_ERR_INVAL); - err = 0; switch (method) { case MSC_EJECT_STOPUNIT: err = bbb_command_start(sc, DIR_IN, 0, NULL, 0, @@ -840,6 +839,7 @@ usb_msc_eject(struct usb_device *udev, uint8_t iface_index, int method) break; default: DPRINTF("Unknown eject method (%d)\n", method); + err = 0; break; } DPRINTF("Eject CD command status: %s\n", usbd_errstr(err)); -- 2.45.0