From b93118048b2d39b62109594a932ea8ee809fbbb5 Mon Sep 17 00:00:00 2001 From: dim Date: Mon, 24 Feb 2020 06:56:38 +0000 Subject: [PATCH] Merge ^/head r358263 through r358268. --- share/misc/bsd-family-tree | 2 +- sys/vm/swap_pager.c | 19 ++++++++++--------- usr.sbin/config/config.5 | 3 ++- usr.sbin/config/config.y | 7 +++++-- usr.sbin/config/configvers.h | 2 +- 5 files changed, 19 insertions(+), 14 deletions(-) diff --git a/share/misc/bsd-family-tree b/share/misc/bsd-family-tree index 0141a4a4668..02dedcbbc40 100644 --- a/share/misc/bsd-family-tree +++ b/share/misc/bsd-family-tree @@ -799,7 +799,7 @@ OpenBSD 6.6 2019-10-17 [OBD] macOS 10.15 2019-10-07 [APL] macOS 10.15.1 2019-10-29 [APL] (security/critical release) FreeBSD 12.1 2019-11-04 [FBD] -NetBSD 9.0 2020-02-15 [NBD] +NetBSD 9.0 2020-02-14 [NBD] Bibliography ------------------------ diff --git a/sys/vm/swap_pager.c b/sys/vm/swap_pager.c index 8697fe20648..d4292f7c783 100644 --- a/sys/vm/swap_pager.c +++ b/sys/vm/swap_pager.c @@ -427,7 +427,7 @@ static int swapoff_one(struct swdevt *sp, struct ucred *cred); * Swap bitmap functions */ static void swp_pager_freeswapspace(daddr_t blk, daddr_t npages); -static daddr_t swp_pager_getswapspace(int *npages, int limit); +static daddr_t swp_pager_getswapspace(int *npages); /* * Metadata functions @@ -741,10 +741,9 @@ swap_pager_dealloc(vm_object_t object) /* * SWP_PAGER_GETSWAPSPACE() - allocate raw swap space * - * Allocate swap for up to the requested number of pages, and at - * least a minimum number of pages. The starting swap block number - * (a page index) is returned or SWAPBLK_NONE if the allocation - * failed. + * Allocate swap for up to the requested number of pages. The + * starting swap block number (a page index) is returned or + * SWAPBLK_NONE if the allocation failed. * * Also has the side effect of advising that somebody made a mistake * when they configured swap and didn't configure enough. @@ -754,12 +753,14 @@ swap_pager_dealloc(vm_object_t object) * We allocate in round-robin fashion from the configured devices. */ static daddr_t -swp_pager_getswapspace(int *io_npages, int limit) +swp_pager_getswapspace(int *io_npages) { daddr_t blk; struct swdevt *sp; int mpages, npages; + KASSERT(*io_npages >= 1, + ("%s: npages not positive", __func__)); blk = SWAPBLK_NONE; mpages = *io_npages; npages = imin(BLIST_MAX_ALLOC, mpages); @@ -774,7 +775,7 @@ swp_pager_getswapspace(int *io_npages, int limit) break; sp = TAILQ_NEXT(sp, sw_list); if (swdevhd == sp) { - if (npages <= limit) + if (npages == 1) break; mpages = npages - 1; npages >>= 1; @@ -937,7 +938,7 @@ swap_pager_reserve(vm_object_t object, vm_pindex_t start, vm_size_t size) VM_OBJECT_WLOCK(object); for (i = 0; i < size; i += n) { n = size - i; - blk = swp_pager_getswapspace(&n, 1); + blk = swp_pager_getswapspace(&n); if (blk == SWAPBLK_NONE) { swp_pager_meta_free(object, start, i); VM_OBJECT_WUNLOCK(object); @@ -1464,7 +1465,7 @@ swap_pager_putpages(vm_object_t object, vm_page_t *ma, int count, /* Get a block of swap of size up to size n. */ VM_OBJECT_WLOCK(object); - blk = swp_pager_getswapspace(&n, 1); + blk = swp_pager_getswapspace(&n); if (blk == SWAPBLK_NONE) { VM_OBJECT_WUNLOCK(object); mtx_lock(&swbuf_mtx); diff --git a/usr.sbin/config/config.5 b/usr.sbin/config/config.5 index dc8bdeb86ec..fdcbb1399ed 100644 --- a/usr.sbin/config/config.5 +++ b/usr.sbin/config/config.5 @@ -283,7 +283,8 @@ corresponds to MACHINE_ARCH. .Pp A kernel configuration file may have only one .Ic machine -directive. +directive, unless the second one matches the +machine argument in the first one exactly. .\" -------- MAKEOPTION -------- .Pp .It Ic makeoption Ar options diff --git a/usr.sbin/config/config.y b/usr.sbin/config/config.y index e6504500454..6fcd93aa19f 100644 --- a/usr.sbin/config/config.y +++ b/usr.sbin/config/config.y @@ -155,8 +155,11 @@ Config_spec: machinearch = $2; } | ARCH Save_id Save_id { - if (machinename != NULL && - !(eq($2, machinename) && eq($3, machinearch))) + /* + * Allow the machinearch to change with a second machine directive, + * but still enforce no changes to the machinename. + */ + if (machinename != NULL && !eq($2, machinename)) errx(1, "%s:%d: only one machine directive is allowed", yyfile, yyline); machinename = $2; diff --git a/usr.sbin/config/configvers.h b/usr.sbin/config/configvers.h index e65986f19fc..6fc8587a98e 100644 --- a/usr.sbin/config/configvers.h +++ b/usr.sbin/config/configvers.h @@ -49,7 +49,7 @@ * * $FreeBSD$ */ -#define CONFIGVERS 600016 +#define CONFIGVERS 600017 #define MAJOR_VERS(x) ((x) / 100000) /* Last config(8) version to require envmode/hintmode */ -- 2.45.0