From c352317370e1e753db7166823233e2890179527b Mon Sep 17 00:00:00 2001 From: mjg Date: Thu, 26 Nov 2020 06:59:27 +0000 Subject: [PATCH] thread: staticize thread_reap and move td_allocdomain thread_init is a much better fit as the the value is constant after initialization. --- sys/kern/kern_thread.c | 5 +++-- sys/sys/proc.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/kern/kern_thread.c b/sys/kern/kern_thread.c index 10de1470946..3561895d9ff 100644 --- a/sys/kern/kern_thread.c +++ b/sys/kern/kern_thread.c @@ -143,6 +143,7 @@ static struct task thread_reap_task; static struct callout thread_reap_callout; static void thread_zombie(struct thread *); +static void thread_reap(void); static void thread_reap_all(void); static void thread_reap_task_cb(void *, int); static void thread_reap_callout_cb(void *); @@ -347,7 +348,6 @@ thread_ctor(void *mem, int size, void *arg, int flags) td = (struct thread *)mem; td->td_state = TDS_INACTIVE; td->td_lastcpu = td->td_oncpu = NOCPU; - td->td_allocdomain = vm_phys_domain(vtophys(td)); /* * Note that td_critnest begins life as 1 because the thread is not @@ -420,6 +420,7 @@ thread_init(void *mem, int size, int flags) td = (struct thread *)mem; + td->td_allocdomain = vm_phys_domain(vtophys(td)); td->td_sleepqueue = sleepq_alloc(); td->td_turnstile = turnstile_alloc(); td->td_rlqe = NULL; @@ -663,7 +664,7 @@ thread_reap_all(void) /* * Reap zombies from local domain. */ -void +static void thread_reap(void) { struct thread_domain_data *tdd; diff --git a/sys/sys/proc.h b/sys/sys/proc.h index 95e73fa19e2..23bac23b518 100644 --- a/sys/sys/proc.h +++ b/sys/sys/proc.h @@ -1142,7 +1142,6 @@ int thread_create(struct thread *td, struct rtprio *rtp, void thread_exit(void) __dead2; void thread_free(struct thread *td); void thread_link(struct thread *td, struct proc *p); -void thread_reap(void); int thread_single(struct proc *p, int how); void thread_single_end(struct proc *p, int how); void thread_stash(struct thread *td); -- 2.45.0