From cf670bded417ef9f0446fb1326d76f4d9fcdb4cf Mon Sep 17 00:00:00 2001 From: msmith Date: Mon, 24 Apr 2000 19:56:26 +0000 Subject: [PATCH] Disable the returning of "wedged" commands; this is wrong and needs to be rethought. --- sys/dev/amr/amr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/dev/amr/amr.c b/sys/dev/amr/amr.c index de6f965a334..b81403e5998 100644 --- a/sys/dev/amr/amr.c +++ b/sys/dev/amr/amr.c @@ -688,7 +688,13 @@ amr_periodic(void *data) debug("called"); - +#if 0 + /* + * XXX this is basically wrong - returning a command that's wedged + * leaves us vulnerable to the controller later completing the command + * and overwriting memory that may have subsequently been reused. + */ + /* * Check for commands that are massively late. This will need to be * revisited if/when we deal with eg. device format commands. @@ -711,6 +717,7 @@ amr_periodic(void *data) } } splx(s); +#endif /* reschedule */ sc->amr_timeout = timeout(amr_periodic, sc, hz); -- 2.45.2