From a0bed901984022e6e0fdfc017c70e31302de878e Mon Sep 17 00:00:00 2001 From: "Pedro F. Giffuni" Date: Sat, 19 Dec 2020 02:42:14 +0000 Subject: [PATCH] Revert r368776: login(1): when exporting variables check the result of setenv(3) mismatch: the return value upon error is -1, so the code was not doing nothing. --- usr.bin/login/login.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/usr.bin/login/login.c b/usr.bin/login/login.c index 380e813f4b0..e99ee5efc2e 100644 --- a/usr.bin/login/login.c +++ b/usr.bin/login/login.c @@ -793,7 +793,6 @@ export(const char *s) char *p; const char **pp; size_t n; - int rv; if (strlen(s) > 1024 || (p = strchr(s, '=')) == NULL) return (0); @@ -805,10 +804,8 @@ export(const char *s) return (0); } *p = '\0'; - rv = setenv(s, p + 1, 1); + (void)setenv(s, p + 1, 1); *p = '='; - if (rv == 1) - return (0); return (1); } -- 2.42.0