From 2a1659e83448ac74f8ff286feb041584910ff1de Mon Sep 17 00:00:00 2001 From: delphij Date: Mon, 3 Jul 2017 05:30:31 +0000 Subject: [PATCH] MFC r320093: Check return value of seteuid() and bail out if we fail. git-svn-id: svn://svn.freebsd.org/base/stable/10@320587 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- usr.sbin/rpc.lockd/lock_proc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usr.sbin/rpc.lockd/lock_proc.c b/usr.sbin/rpc.lockd/lock_proc.c index 40cbe80cd..36850d36a 100644 --- a/usr.sbin/rpc.lockd/lock_proc.c +++ b/usr.sbin/rpc.lockd/lock_proc.c @@ -283,7 +283,10 @@ get_client(host_addr, vers) /* Regain root privileges, for bindresvport. */ old_euid = geteuid(); - seteuid(0); + if (seteuid(0) != 0) { + syslog(LOG_ERR, "seteuid(0) failed"); + return NULL; + } /* * Bind the client FD to a reserved port. @@ -292,7 +295,10 @@ get_client(host_addr, vers) bindresvport(clnt_fd, NULL); /* Drop root privileges again. */ - seteuid(old_euid); + if (seteuid(old_euid) != 0) { + syslog(LOG_ERR, "seteuid(%d) failed", old_euid); + return NULL; + } /* Success - update the cache entry */ clnt_cache_ptr[clnt_cache_next_to_use] = client; -- 2.45.0