From 3742c1f20826520b12653668f4aaca38390dc5bf Mon Sep 17 00:00:00 2001 From: dim Date: Wed, 7 Sep 2016 18:33:18 +0000 Subject: [PATCH] MFC r305085: Fix warnings in tnftp about invalid constant conversions, e.g.: contrib/tnftp/src/ftp.c:2067:11: error: implicit conversion from 'int' to 'char' changes value from 255 to -1 [-Werror,-Wconstant-conversion] buf[0] = IAC; ~ ^~~ /usr/include/arpa/telnet.h:39:13: note: expanded from macro 'IAC' #define IAC 255 /* interpret as command: */ ^~~ contrib/tnftp/src/ftp.c:2068:11: error: implicit conversion from 'int' to 'char' changes value from 244 to -12 [-Werror,-Wconstant-conversion] buf[1] = IP; ~ ^~ /usr/include/arpa/telnet.h:50:12: note: expanded from macro 'IP' #define IP 244 /* interrupt process--permanently */ ^~~ Use an unsigned char buffer instead. git-svn-id: svn://svn.freebsd.org/base/stable/10@305553 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- contrib/tnftp/src/ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/tnftp/src/ftp.c b/contrib/tnftp/src/ftp.c index 4c4942f1b..82d4042e1 100644 --- a/contrib/tnftp/src/ftp.c +++ b/contrib/tnftp/src/ftp.c @@ -2050,7 +2050,7 @@ abort_squared(int dummy) void abort_remote(FILE *din) { - char buf[BUFSIZ]; + unsigned char buf[BUFSIZ]; int nfnd; if (cout == NULL) { -- 2.45.0