From 4165849b0693995d1f778f33763b5edf8d7ac103 Mon Sep 17 00:00:00 2001
From: bdrewery <bdrewery@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Date: Wed, 22 Mar 2017 17:49:56 +0000
Subject: [PATCH] MFC r314714:

  Don't kill pid -1 on overflow from strtol(3).


git-svn-id: svn://svn.freebsd.org/base/stable/10@315722 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
---
 bin/kill/kill.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/bin/kill/kill.c b/bin/kill/kill.c
index 2d41f7865..df5b70d6c 100644
--- a/bin/kill/kill.c
+++ b/bin/kill/kill.c
@@ -67,7 +67,9 @@ static void usage(void);
 int
 main(int argc, char *argv[])
 {
-	int errors, numsig, pid;
+	long pidl;
+	pid_t pid;
+	int errors, numsig;
 	char *ep;
 
 	if (argc < 2)
@@ -138,8 +140,10 @@ main(int argc, char *argv[])
 		else
 #endif
 		{
-			pid = strtol(*argv, &ep, 10);
-			if (!**argv || *ep)
+			pidl = strtol(*argv, &ep, 10);
+			/* Check for overflow of pid_t. */
+			pid = (pid_t)pidl;
+			if (!**argv || *ep || pid != pidl)
 				errx(2, "illegal process id: %s", *argv);
 		}
 		if (kill(pid, numsig) == -1) {
-- 
2.42.0