From f3b0ed1a7b16bf15dc00fe326a30524e6f54e568 Mon Sep 17 00:00:00 2001 From: ngie Date: Fri, 13 May 2016 09:14:43 +0000 Subject: [PATCH] MFC r298462: Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This will also now detect error conditions with value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)` could fail if iifp->physaddr and/or iifp->physaddrlen were deemed invalid. CID: 1006551 git-svn-id: svn://svn.freebsd.org/base/stable/10@299638 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- contrib/bsnmp/snmp_mibII/mibII_interfaces.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/bsnmp/snmp_mibII/mibII_interfaces.c b/contrib/bsnmp/snmp_mibII/mibII_interfaces.c index f425a2703..1e3b7daa7 100644 --- a/contrib/bsnmp/snmp_mibII/mibII_interfaces.c +++ b/contrib/bsnmp/snmp_mibII/mibII_interfaces.c @@ -356,7 +356,7 @@ op_ifentry(struct snmp_context *ctx, struct snmp_value *value, value->v.oid = ifp->spec_oid; break; } - return (SNMP_ERR_NOERROR); + return (ret); } /* -- 2.45.0