From b0add3ab4316994e1b5545ff33f2a0cb4fa713e0 Mon Sep 17 00:00:00 2001 From: kib Date: Wed, 25 Apr 2012 04:57:29 +0000 Subject: [PATCH] MFC r234416: Fix string buffer overflow when preparing the line of output. PR: bin/161739 git-svn-id: svn://svn.freebsd.org/base/stable/8@234668 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f --- usr.bin/top/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.bin/top/machine.c b/usr.bin/top/machine.c index 043416b32..c7f43bf06 100644 --- a/usr.bin/top/machine.c +++ b/usr.bin/top/machine.c @@ -932,7 +932,7 @@ format_next_process(caddr_t handle, char *(*get_userid)(int), int flags) p_tot = rup->ru_inblock + rup->ru_oublock + rup->ru_majflt; s_tot = total_inblock + total_oublock + total_majflt; - sprintf(fmt, io_Proc_format, + snprintf(fmt, sizeof(fmt), io_Proc_format, pp->ki_pid, jid_buf, namelength, namelength, (*get_userid)(pp->ki_ruid), @@ -960,7 +960,7 @@ format_next_process(caddr_t handle, char *(*get_userid)(int), int flags) snprintf(thr_buf, sizeof(thr_buf), "%*d ", sizeof(thr_buf) - 2, pp->ki_numthreads); - sprintf(fmt, proc_fmt, + snprintf(fmt, sizeof(fmt), proc_fmt, pp->ki_pid, jid_buf, namelength, namelength, (*get_userid)(pp->ki_ruid), -- 2.45.0