From 5d279803b09661951925a08063e38211461a07c8 Mon Sep 17 00:00:00 2001 From: ozhozh Date: Tue, 24 Aug 2010 11:53:01 +0000 Subject: [PATCH] Better display of titles in list and share box. Fixes issue 433. Fixes issue 455. git-svn-id: http://yourls.googlecode.com/svn/trunk@493 12232710-3e20-11de-b438-597f59cd7555 --- includes/functions.php | 5 +++-- js/insert.js | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/functions.php b/includes/functions.php index cf72a63..939bddc 100644 --- a/includes/functions.php +++ b/includes/functions.php @@ -250,8 +250,9 @@ function yourls_table_add_row( $keyword, $url, $title = '', $ip, $clicks, $times $url = yourls_sanitize_url( $url ); $display_url = htmlentities( yourls_trim_long_string( $url ) ); - $title = yourls_sanitize_title( $title ) ; + $title = yourls_sanitize_title( $title ) ; $display_title = yourls_trim_long_string( $title ); + $title = htmlspecialchars( $title ); $id = yourls_string2int( $keyword ); // used as HTML #id $date = date( 'M d, Y H:i', $timestamp+( YOURLS_HOURS_OFFSET * 3600) ); @@ -261,7 +262,7 @@ function yourls_table_add_row( $keyword, $url, $title = '', $ip, $clicks, $times $statlink = $shorturl.'+'; if( $title ) { - $display_link = "$display_title
$display_url"; + $display_link = "$display_title
$display_url"; } else { $display_link = "$display_url"; } diff --git a/js/insert.js b/js/insert.js index 71550e1..ae2da49 100644 --- a/js/insert.js +++ b/js/insert.js @@ -175,7 +175,7 @@ function decrement() { function toggle_share(id) { var link = $('#url-'+id+' a:first'); var longurl = link.attr('href'); - var title = link.text(); + var title = link.attr('title'); var shorturl = $('#keyword-'+id+' a:first').attr('href'); toggle_share_fill_boxes( longurl, shorturl, title ); -- 2.45.0