1 //== ObjCAtSyncChecker.cpp - nil mutex checker for @synchronized -*- C++ -*--=//
3 // The LLVM Compiler Infrastructure
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
8 //===----------------------------------------------------------------------===//
10 // This defines ObjCAtSyncChecker, a builtin check that checks for null pointers
11 // used as mutexes for @synchronized.
13 //===----------------------------------------------------------------------===//
15 #include "ClangSACheckers.h"
16 #include "clang/AST/StmtObjC.h"
17 #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
18 #include "clang/StaticAnalyzer/Core/Checker.h"
19 #include "clang/StaticAnalyzer/Core/CheckerManager.h"
20 #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
21 #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
23 using namespace clang;
27 class ObjCAtSyncChecker
28 : public Checker< check::PreStmt<ObjCAtSynchronizedStmt> > {
29 mutable OwningPtr<BuiltinBug> BT_null;
30 mutable OwningPtr<BuiltinBug> BT_undef;
33 void checkPreStmt(const ObjCAtSynchronizedStmt *S, CheckerContext &C) const;
35 } // end anonymous namespace
37 void ObjCAtSyncChecker::checkPreStmt(const ObjCAtSynchronizedStmt *S,
38 CheckerContext &C) const {
40 const Expr *Ex = S->getSynchExpr();
41 ProgramStateRef state = C.getState();
42 SVal V = state->getSVal(Ex, C.getLocationContext());
44 // Uninitialized value used for the mutex?
45 if (V.getAs<UndefinedVal>()) {
46 if (ExplodedNode *N = C.generateSink()) {
48 BT_undef.reset(new BuiltinBug("Uninitialized value used as mutex "
49 "for @synchronized"));
51 new BugReport(*BT_undef, BT_undef->getDescription(), N);
52 bugreporter::trackNullOrUndefValue(N, Ex, *report);
61 // Check for null mutexes.
62 ProgramStateRef notNullState, nullState;
63 llvm::tie(notNullState, nullState) = state->assume(V.castAs<DefinedSVal>());
67 // Generate an error node. This isn't a sink since
68 // a null mutex just means no synchronization occurs.
69 if (ExplodedNode *N = C.addTransition(nullState)) {
71 BT_null.reset(new BuiltinBug("Nil value used as mutex for @synchronized() "
72 "(no synchronization will occur)"));
74 new BugReport(*BT_null, BT_null->getDescription(), N);
75 bugreporter::trackNullOrUndefValue(N, Ex, *report);
81 // Don't add a transition for 'nullState'. If the value is
82 // under-constrained to be null or non-null, assume it is non-null
87 C.addTransition(notNullState);
90 void ento::registerObjCAtSyncChecker(CheckerManager &mgr) {
91 if (mgr.getLangOpts().ObjC2)
92 mgr.registerChecker<ObjCAtSyncChecker>();