]> CyberLeo.Net >> Repos - FreeBSD/stable/10.git/commit
MFC r284346:
authordim <dim@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Sat, 20 Jun 2015 13:30:09 +0000 (13:30 +0000)
committerdim <dim@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Sat, 20 Jun 2015 13:30:09 +0000 (13:30 +0000)
commit786c21d4844b57dade378356ca6afe8cfce9e194
treed0321fe7bc33d5a523ce82e71fc6ec23d37d83f8
parentcc6cb3bfb575234180f8528536bf1606ce151db7
MFC r284346:

Fix the following clang 3.7.0 warnings in lib/libfetch/http.c:

    lib/libfetch/http.c:1628:26: error: address of array 'purl->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = purl->user ?
                                                   ~~~~~~^~~~ ~
    lib/libfetch/http.c:1630:30: error: address of array 'purl->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = purl->pwd?
                                                       ~~~~~~^~~~
    lib/libfetch/http.c:1657:25: error: address of array 'url->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = url->user ?
                                                   ~~~~~^~~~ ~
    lib/libfetch/http.c:1659:29: error: address of array 'url->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = url->pwd ?
                                                       ~~~~~^~~ ~
    lib/libfetch/http.c:1669:25: error: address of array 'url->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = url->user ?
                                                   ~~~~~^~~~ ~
    lib/libfetch/http.c:1671:29: error: address of array 'url->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = url->pwd ?
                                                       ~~~~~^~~ ~

Since url->user and url->pwd are arrays, they can never be NULL, so the
checks can be removed.

Reviewed by: bapt
Differential Revision: https://reviews.freebsd.org/D2673

git-svn-id: svn://svn.freebsd.org/base/stable/10@284643 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
lib/libfetch/http.c