]> CyberLeo.Net >> Repos - FreeBSD/stable/8.git/commit
MFC: r207608, r207614, r212651, r212665
authormarius <marius@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Wed, 22 Sep 2010 21:54:30 +0000 (21:54 +0000)
committermarius <marius@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Wed, 22 Sep 2010 21:54:30 +0000 (21:54 +0000)
commitb5e192d9ff0c9d105439263bc1d1558a9ef430a2
tree3da9d492e4be65d2c2c6b048bc85fc5a17cb098e
parent23ab0cb688f739ea51dea1c27a572f9e85dd2873
MFC: r207608, r207614, r212651, r212665

Go ahead and merge the work edwin@ on tftpd into the tree.  It is a
lot better than what's in the tree now.  Edwin tested it at a prior
employer, but can't test it today.  I've found that it works a lot
better with the various uboot versions that I've used in my embedded
work.  Here's the pkg-descr from the port that describes the changes:

It all started when we got some new routers, which told me the
following when trying to upload configuration or download images
from it: The TFTP server doesn't support the blocksize option.

My curiousity was triggered, it took me some reading of RFCs and
other documentation to find out what was possible and what could
be done. Was plain TFTP very simple in its handshake, TFTP with
options was kind of messy because of its backwards capability: The
first packet returned could either be an acknowledgement of options,
or the first data packet.

Going through the source code of src/libexec/tftpd and going through
the code of src/usr.bin/tftp showed that there was a lot of duplicate
code, and the addition of options would only increase the amount
of duplicate code. After all, both the client and the server can
act as a sender and receiver.

At the end, it ended up with a nearly complete rewrite of the tftp
client and server. It has been tested against the following TFTP
clients and servers:

- Itself (yay!)
- The standard FreeBSD tftp client and server
- The Fedora Core 6 tftp client and server
- Cisco router tftp client
- Extreme Networks tftp client

It supports the following RFCs:

RFC1350 - THE TFTP PROTOCOL (REVISION 2)
RFC2347 - TFTP Option Extension
RFC2348 - TFTP Blocksize Option
RFC2349 - TFTP Timeout Interval and Transfer Size Options
RFC3617 - Uniform Resource Identifier (URI) Scheme and Applicability
          Statement for the Trivial File Transfer Protocol (TFTP)

It supports the following unofficial TFTP Options as described at
http://www.compuphase.com/tftp.htm:

blksize2 - Block size restricted to powers of 2, excluding protocol headers
rollover - Block counter roll-over (roll back to zero or to one)

From the tftp program point of view the following things are changed:

- New commands: "blocksize", "blocksize2", "rollover" and "options"
- Development features: "debug" and "packetdrop"

If you try this tftp/tftpd implementation, please let me know if
it works (or doesn't work) and against which implementaion so I can
get a list of confirmed working systems.

Author: Edwin Groothuis <edwin@FreeBSD.org>

git-svn-id: svn://svn.freebsd.org/base/stable/8@213038 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
13 files changed:
libexec/tftpd/Makefile
libexec/tftpd/tftp-file.c [new file with mode: 0644]
libexec/tftpd/tftp-file.h [new file with mode: 0644]
libexec/tftpd/tftp-io.c [new file with mode: 0644]
libexec/tftpd/tftp-io.h [new file with mode: 0644]
libexec/tftpd/tftp-options.c [new file with mode: 0644]
libexec/tftpd/tftp-options.h [new file with mode: 0644]
libexec/tftpd/tftp-transfer.c [new file with mode: 0644]
libexec/tftpd/tftp-transfer.h [new file with mode: 0644]
libexec/tftpd/tftp-utils.c [new file with mode: 0644]
libexec/tftpd/tftp-utils.h [new file with mode: 0644]
libexec/tftpd/tftpd.8
libexec/tftpd/tftpd.c