1 //===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
3 // The LLVM Compiler Infrastructure
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
8 //===----------------------------------------------------------------------===//
10 // This file implements extra semantic analysis beyond what is enforced
11 // by the C type system.
13 //===----------------------------------------------------------------------===//
15 #include "clang/AST/ASTContext.h"
16 #include "clang/AST/CharUnits.h"
17 #include "clang/AST/DeclCXX.h"
18 #include "clang/AST/DeclObjC.h"
19 #include "clang/AST/EvaluatedExprVisitor.h"
20 #include "clang/AST/Expr.h"
21 #include "clang/AST/ExprCXX.h"
22 #include "clang/AST/ExprObjC.h"
23 #include "clang/AST/ExprOpenMP.h"
24 #include "clang/AST/StmtCXX.h"
25 #include "clang/AST/StmtObjC.h"
26 #include "clang/Analysis/Analyses/FormatString.h"
27 #include "clang/Basic/CharInfo.h"
28 #include "clang/Basic/TargetBuiltins.h"
29 #include "clang/Basic/TargetInfo.h"
30 #include "clang/Lex/Lexer.h" // TODO: Extract static functions to fix layering.
31 #include "clang/Sema/Initialization.h"
32 #include "clang/Sema/Lookup.h"
33 #include "clang/Sema/ScopeInfo.h"
34 #include "clang/Sema/Sema.h"
35 #include "clang/Sema/SemaInternal.h"
36 #include "llvm/ADT/STLExtras.h"
37 #include "llvm/ADT/SmallBitVector.h"
38 #include "llvm/ADT/SmallString.h"
39 #include "llvm/Support/ConvertUTF.h"
40 #include "llvm/Support/Format.h"
41 #include "llvm/Support/Locale.h"
42 #include "llvm/Support/raw_ostream.h"
44 using namespace clang;
47 SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
48 unsigned ByteNo) const {
49 return SL->getLocationOfByte(ByteNo, getSourceManager(), LangOpts,
50 Context.getTargetInfo());
53 /// Checks that a call expression's argument count is the desired number.
54 /// This is useful when doing custom type-checking. Returns true on error.
55 static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
56 unsigned argCount = call->getNumArgs();
57 if (argCount == desiredArgCount) return false;
59 if (argCount < desiredArgCount)
60 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
61 << 0 /*function call*/ << desiredArgCount << argCount
62 << call->getSourceRange();
64 // Highlight all the excess arguments.
65 SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
66 call->getArg(argCount - 1)->getLocEnd());
68 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
69 << 0 /*function call*/ << desiredArgCount << argCount
70 << call->getArg(1)->getSourceRange();
73 /// Check that the first argument to __builtin_annotation is an integer
74 /// and the second argument is a non-wide string literal.
75 static bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
76 if (checkArgCount(S, TheCall, 2))
79 // First argument should be an integer.
80 Expr *ValArg = TheCall->getArg(0);
81 QualType Ty = ValArg->getType();
82 if (!Ty->isIntegerType()) {
83 S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
84 << ValArg->getSourceRange();
88 // Second argument should be a constant string.
89 Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
90 StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
91 if (!Literal || !Literal->isAscii()) {
92 S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
93 << StrArg->getSourceRange();
101 /// Check that the argument to __builtin_addressof is a glvalue, and set the
102 /// result type to the corresponding pointer type.
103 static bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) {
104 if (checkArgCount(S, TheCall, 1))
107 ExprResult Arg(TheCall->getArg(0));
108 QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart());
109 if (ResultType.isNull())
112 TheCall->setArg(0, Arg.get());
113 TheCall->setType(ResultType);
117 static bool SemaBuiltinOverflow(Sema &S, CallExpr *TheCall) {
118 if (checkArgCount(S, TheCall, 3))
121 // First two arguments should be integers.
122 for (unsigned I = 0; I < 2; ++I) {
123 Expr *Arg = TheCall->getArg(I);
124 QualType Ty = Arg->getType();
125 if (!Ty->isIntegerType()) {
126 S.Diag(Arg->getLocStart(), diag::err_overflow_builtin_must_be_int)
127 << Ty << Arg->getSourceRange();
132 // Third argument should be a pointer to a non-const integer.
133 // IRGen correctly handles volatile, restrict, and address spaces, and
134 // the other qualifiers aren't possible.
136 Expr *Arg = TheCall->getArg(2);
137 QualType Ty = Arg->getType();
138 const auto *PtrTy = Ty->getAs<PointerType>();
139 if (!(PtrTy && PtrTy->getPointeeType()->isIntegerType() &&
140 !PtrTy->getPointeeType().isConstQualified())) {
141 S.Diag(Arg->getLocStart(), diag::err_overflow_builtin_must_be_ptr_int)
142 << Ty << Arg->getSourceRange();
150 static void SemaBuiltinMemChkCall(Sema &S, FunctionDecl *FDecl,
151 CallExpr *TheCall, unsigned SizeIdx,
152 unsigned DstSizeIdx) {
153 if (TheCall->getNumArgs() <= SizeIdx ||
154 TheCall->getNumArgs() <= DstSizeIdx)
157 const Expr *SizeArg = TheCall->getArg(SizeIdx);
158 const Expr *DstSizeArg = TheCall->getArg(DstSizeIdx);
160 llvm::APSInt Size, DstSize;
162 // find out if both sizes are known at compile time
163 if (!SizeArg->EvaluateAsInt(Size, S.Context) ||
164 !DstSizeArg->EvaluateAsInt(DstSize, S.Context))
167 if (Size.ule(DstSize))
170 // confirmed overflow so generate the diagnostic.
171 IdentifierInfo *FnName = FDecl->getIdentifier();
172 SourceLocation SL = TheCall->getLocStart();
173 SourceRange SR = TheCall->getSourceRange();
175 S.Diag(SL, diag::warn_memcpy_chk_overflow) << SR << FnName;
178 static bool SemaBuiltinCallWithStaticChain(Sema &S, CallExpr *BuiltinCall) {
179 if (checkArgCount(S, BuiltinCall, 2))
182 SourceLocation BuiltinLoc = BuiltinCall->getLocStart();
183 Expr *Builtin = BuiltinCall->getCallee()->IgnoreImpCasts();
184 Expr *Call = BuiltinCall->getArg(0);
185 Expr *Chain = BuiltinCall->getArg(1);
187 if (Call->getStmtClass() != Stmt::CallExprClass) {
188 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_not_call)
189 << Call->getSourceRange();
193 auto CE = cast<CallExpr>(Call);
194 if (CE->getCallee()->getType()->isBlockPointerType()) {
195 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_block_call)
196 << Call->getSourceRange();
200 const Decl *TargetDecl = CE->getCalleeDecl();
201 if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(TargetDecl))
202 if (FD->getBuiltinID()) {
203 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_builtin_call)
204 << Call->getSourceRange();
208 if (isa<CXXPseudoDestructorExpr>(CE->getCallee()->IgnoreParens())) {
209 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_pdtor_call)
210 << Call->getSourceRange();
214 ExprResult ChainResult = S.UsualUnaryConversions(Chain);
215 if (ChainResult.isInvalid())
217 if (!ChainResult.get()->getType()->isPointerType()) {
218 S.Diag(BuiltinLoc, diag::err_second_argument_to_cwsc_not_pointer)
219 << Chain->getSourceRange();
223 QualType ReturnTy = CE->getCallReturnType(S.Context);
224 QualType ArgTys[2] = { ReturnTy, ChainResult.get()->getType() };
225 QualType BuiltinTy = S.Context.getFunctionType(
226 ReturnTy, ArgTys, FunctionProtoType::ExtProtoInfo());
227 QualType BuiltinPtrTy = S.Context.getPointerType(BuiltinTy);
230 S.ImpCastExprToType(Builtin, BuiltinPtrTy, CK_BuiltinFnToFnPtr).get();
232 BuiltinCall->setType(CE->getType());
233 BuiltinCall->setValueKind(CE->getValueKind());
234 BuiltinCall->setObjectKind(CE->getObjectKind());
235 BuiltinCall->setCallee(Builtin);
236 BuiltinCall->setArg(1, ChainResult.get());
241 static bool SemaBuiltinSEHScopeCheck(Sema &SemaRef, CallExpr *TheCall,
242 Scope::ScopeFlags NeededScopeFlags,
244 // Scopes aren't available during instantiation. Fortunately, builtin
245 // functions cannot be template args so they cannot be formed through template
246 // instantiation. Therefore checking once during the parse is sufficient.
247 if (SemaRef.inTemplateInstantiation())
250 Scope *S = SemaRef.getCurScope();
251 while (S && !S->isSEHExceptScope())
253 if (!S || !(S->getFlags() & NeededScopeFlags)) {
254 auto *DRE = cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
255 SemaRef.Diag(TheCall->getExprLoc(), DiagID)
256 << DRE->getDecl()->getIdentifier();
263 static inline bool isBlockPointer(Expr *Arg) {
264 return Arg->getType()->isBlockPointerType();
267 /// OpenCL C v2.0, s6.13.17.2 - Checks that the block parameters are all local
268 /// void*, which is a requirement of device side enqueue.
269 static bool checkOpenCLBlockArgs(Sema &S, Expr *BlockArg) {
270 const BlockPointerType *BPT =
271 cast<BlockPointerType>(BlockArg->getType().getCanonicalType());
272 ArrayRef<QualType> Params =
273 BPT->getPointeeType()->getAs<FunctionProtoType>()->getParamTypes();
274 unsigned ArgCounter = 0;
275 bool IllegalParams = false;
276 // Iterate through the block parameters until either one is found that is not
277 // a local void*, or the block is valid.
278 for (ArrayRef<QualType>::iterator I = Params.begin(), E = Params.end();
279 I != E; ++I, ++ArgCounter) {
280 if (!(*I)->isPointerType() || !(*I)->getPointeeType()->isVoidType() ||
281 (*I)->getPointeeType().getQualifiers().getAddressSpace() !=
282 LangAS::opencl_local) {
283 // Get the location of the error. If a block literal has been passed
284 // (BlockExpr) then we can point straight to the offending argument,
285 // else we just point to the variable reference.
286 SourceLocation ErrorLoc;
287 if (isa<BlockExpr>(BlockArg)) {
288 BlockDecl *BD = cast<BlockExpr>(BlockArg)->getBlockDecl();
289 ErrorLoc = BD->getParamDecl(ArgCounter)->getLocStart();
290 } else if (isa<DeclRefExpr>(BlockArg)) {
291 ErrorLoc = cast<DeclRefExpr>(BlockArg)->getLocStart();
294 diag::err_opencl_enqueue_kernel_blocks_non_local_void_args);
295 IllegalParams = true;
299 return IllegalParams;
302 /// OpenCL C v2.0, s6.13.17.6 - Check the argument to the
303 /// get_kernel_work_group_size
304 /// and get_kernel_preferred_work_group_size_multiple builtin functions.
305 static bool SemaOpenCLBuiltinKernelWorkGroupSize(Sema &S, CallExpr *TheCall) {
306 if (checkArgCount(S, TheCall, 1))
309 Expr *BlockArg = TheCall->getArg(0);
310 if (!isBlockPointer(BlockArg)) {
311 S.Diag(BlockArg->getLocStart(),
312 diag::err_opencl_enqueue_kernel_expected_type) << "block";
315 return checkOpenCLBlockArgs(S, BlockArg);
318 /// Diagnose integer type and any valid implicit conversion to it.
319 static bool checkOpenCLEnqueueIntType(Sema &S, Expr *E,
320 const QualType &IntType);
322 static bool checkOpenCLEnqueueLocalSizeArgs(Sema &S, CallExpr *TheCall,
323 unsigned Start, unsigned End) {
324 bool IllegalParams = false;
325 for (unsigned I = Start; I <= End; ++I)
326 IllegalParams |= checkOpenCLEnqueueIntType(S, TheCall->getArg(I),
327 S.Context.getSizeType());
328 return IllegalParams;
331 /// OpenCL v2.0, s6.13.17.1 - Check that sizes are provided for all
332 /// 'local void*' parameter of passed block.
333 static bool checkOpenCLEnqueueVariadicArgs(Sema &S, CallExpr *TheCall,
335 unsigned NumNonVarArgs) {
336 const BlockPointerType *BPT =
337 cast<BlockPointerType>(BlockArg->getType().getCanonicalType());
338 unsigned NumBlockParams =
339 BPT->getPointeeType()->getAs<FunctionProtoType>()->getNumParams();
340 unsigned TotalNumArgs = TheCall->getNumArgs();
342 // For each argument passed to the block, a corresponding uint needs to
343 // be passed to describe the size of the local memory.
344 if (TotalNumArgs != NumBlockParams + NumNonVarArgs) {
345 S.Diag(TheCall->getLocStart(),
346 diag::err_opencl_enqueue_kernel_local_size_args);
350 // Check that the sizes of the local memory are specified by integers.
351 return checkOpenCLEnqueueLocalSizeArgs(S, TheCall, NumNonVarArgs,
355 /// OpenCL C v2.0, s6.13.17 - Enqueue kernel function contains four different
356 /// overload formats specified in Table 6.13.17.1.
357 /// int enqueue_kernel(queue_t queue,
358 /// kernel_enqueue_flags_t flags,
359 /// const ndrange_t ndrange,
360 /// void (^block)(void))
361 /// int enqueue_kernel(queue_t queue,
362 /// kernel_enqueue_flags_t flags,
363 /// const ndrange_t ndrange,
364 /// uint num_events_in_wait_list,
365 /// clk_event_t *event_wait_list,
366 /// clk_event_t *event_ret,
367 /// void (^block)(void))
368 /// int enqueue_kernel(queue_t queue,
369 /// kernel_enqueue_flags_t flags,
370 /// const ndrange_t ndrange,
371 /// void (^block)(local void*, ...),
373 /// int enqueue_kernel(queue_t queue,
374 /// kernel_enqueue_flags_t flags,
375 /// const ndrange_t ndrange,
376 /// uint num_events_in_wait_list,
377 /// clk_event_t *event_wait_list,
378 /// clk_event_t *event_ret,
379 /// void (^block)(local void*, ...),
381 static bool SemaOpenCLBuiltinEnqueueKernel(Sema &S, CallExpr *TheCall) {
382 unsigned NumArgs = TheCall->getNumArgs();
385 S.Diag(TheCall->getLocStart(), diag::err_typecheck_call_too_few_args);
389 Expr *Arg0 = TheCall->getArg(0);
390 Expr *Arg1 = TheCall->getArg(1);
391 Expr *Arg2 = TheCall->getArg(2);
392 Expr *Arg3 = TheCall->getArg(3);
394 // First argument always needs to be a queue_t type.
395 if (!Arg0->getType()->isQueueT()) {
396 S.Diag(TheCall->getArg(0)->getLocStart(),
397 diag::err_opencl_enqueue_kernel_expected_type)
398 << S.Context.OCLQueueTy;
402 // Second argument always needs to be a kernel_enqueue_flags_t enum value.
403 if (!Arg1->getType()->isIntegerType()) {
404 S.Diag(TheCall->getArg(1)->getLocStart(),
405 diag::err_opencl_enqueue_kernel_expected_type)
406 << "'kernel_enqueue_flags_t' (i.e. uint)";
410 // Third argument is always an ndrange_t type.
411 if (Arg2->getType().getAsString() != "ndrange_t") {
412 S.Diag(TheCall->getArg(2)->getLocStart(),
413 diag::err_opencl_enqueue_kernel_expected_type)
418 // With four arguments, there is only one form that the function could be
419 // called in: no events and no variable arguments.
421 // check that the last argument is the right block type.
422 if (!isBlockPointer(Arg3)) {
423 S.Diag(Arg3->getLocStart(), diag::err_opencl_enqueue_kernel_expected_type)
427 // we have a block type, check the prototype
428 const BlockPointerType *BPT =
429 cast<BlockPointerType>(Arg3->getType().getCanonicalType());
430 if (BPT->getPointeeType()->getAs<FunctionProtoType>()->getNumParams() > 0) {
431 S.Diag(Arg3->getLocStart(),
432 diag::err_opencl_enqueue_kernel_blocks_no_args);
437 // we can have block + varargs.
438 if (isBlockPointer(Arg3))
439 return (checkOpenCLBlockArgs(S, Arg3) ||
440 checkOpenCLEnqueueVariadicArgs(S, TheCall, Arg3, 4));
441 // last two cases with either exactly 7 args or 7 args and varargs.
443 // check common block argument.
444 Expr *Arg6 = TheCall->getArg(6);
445 if (!isBlockPointer(Arg6)) {
446 S.Diag(Arg6->getLocStart(), diag::err_opencl_enqueue_kernel_expected_type)
450 if (checkOpenCLBlockArgs(S, Arg6))
453 // Forth argument has to be any integer type.
454 if (!Arg3->getType()->isIntegerType()) {
455 S.Diag(TheCall->getArg(3)->getLocStart(),
456 diag::err_opencl_enqueue_kernel_expected_type)
460 // check remaining common arguments.
461 Expr *Arg4 = TheCall->getArg(4);
462 Expr *Arg5 = TheCall->getArg(5);
464 // Fifth argument is always passed as a pointer to clk_event_t.
465 if (!Arg4->isNullPointerConstant(S.Context,
466 Expr::NPC_ValueDependentIsNotNull) &&
467 !Arg4->getType()->getPointeeOrArrayElementType()->isClkEventT()) {
468 S.Diag(TheCall->getArg(4)->getLocStart(),
469 diag::err_opencl_enqueue_kernel_expected_type)
470 << S.Context.getPointerType(S.Context.OCLClkEventTy);
474 // Sixth argument is always passed as a pointer to clk_event_t.
475 if (!Arg5->isNullPointerConstant(S.Context,
476 Expr::NPC_ValueDependentIsNotNull) &&
477 !(Arg5->getType()->isPointerType() &&
478 Arg5->getType()->getPointeeType()->isClkEventT())) {
479 S.Diag(TheCall->getArg(5)->getLocStart(),
480 diag::err_opencl_enqueue_kernel_expected_type)
481 << S.Context.getPointerType(S.Context.OCLClkEventTy);
488 return checkOpenCLEnqueueVariadicArgs(S, TheCall, Arg6, 7);
491 // None of the specific case has been detected, give generic error
492 S.Diag(TheCall->getLocStart(),
493 diag::err_opencl_enqueue_kernel_incorrect_args);
497 /// Returns OpenCL access qual.
498 static OpenCLAccessAttr *getOpenCLArgAccess(const Decl *D) {
499 return D->getAttr<OpenCLAccessAttr>();
502 /// Returns true if pipe element type is different from the pointer.
503 static bool checkOpenCLPipeArg(Sema &S, CallExpr *Call) {
504 const Expr *Arg0 = Call->getArg(0);
505 // First argument type should always be pipe.
506 if (!Arg0->getType()->isPipeType()) {
507 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_first_arg)
508 << Call->getDirectCallee() << Arg0->getSourceRange();
511 OpenCLAccessAttr *AccessQual =
512 getOpenCLArgAccess(cast<DeclRefExpr>(Arg0)->getDecl());
513 // Validates the access qualifier is compatible with the call.
514 // OpenCL v2.0 s6.13.16 - The access qualifiers for pipe should only be
515 // read_only and write_only, and assumed to be read_only if no qualifier is
517 switch (Call->getDirectCallee()->getBuiltinID()) {
518 case Builtin::BIread_pipe:
519 case Builtin::BIreserve_read_pipe:
520 case Builtin::BIcommit_read_pipe:
521 case Builtin::BIwork_group_reserve_read_pipe:
522 case Builtin::BIsub_group_reserve_read_pipe:
523 case Builtin::BIwork_group_commit_read_pipe:
524 case Builtin::BIsub_group_commit_read_pipe:
525 if (!(!AccessQual || AccessQual->isReadOnly())) {
526 S.Diag(Arg0->getLocStart(),
527 diag::err_opencl_builtin_pipe_invalid_access_modifier)
528 << "read_only" << Arg0->getSourceRange();
532 case Builtin::BIwrite_pipe:
533 case Builtin::BIreserve_write_pipe:
534 case Builtin::BIcommit_write_pipe:
535 case Builtin::BIwork_group_reserve_write_pipe:
536 case Builtin::BIsub_group_reserve_write_pipe:
537 case Builtin::BIwork_group_commit_write_pipe:
538 case Builtin::BIsub_group_commit_write_pipe:
539 if (!(AccessQual && AccessQual->isWriteOnly())) {
540 S.Diag(Arg0->getLocStart(),
541 diag::err_opencl_builtin_pipe_invalid_access_modifier)
542 << "write_only" << Arg0->getSourceRange();
552 /// Returns true if pipe element type is different from the pointer.
553 static bool checkOpenCLPipePacketType(Sema &S, CallExpr *Call, unsigned Idx) {
554 const Expr *Arg0 = Call->getArg(0);
555 const Expr *ArgIdx = Call->getArg(Idx);
556 const PipeType *PipeTy = cast<PipeType>(Arg0->getType());
557 const QualType EltTy = PipeTy->getElementType();
558 const PointerType *ArgTy = ArgIdx->getType()->getAs<PointerType>();
559 // The Idx argument should be a pointer and the type of the pointer and
560 // the type of pipe element should also be the same.
562 !S.Context.hasSameType(
563 EltTy, ArgTy->getPointeeType()->getCanonicalTypeInternal())) {
564 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg)
565 << Call->getDirectCallee() << S.Context.getPointerType(EltTy)
566 << ArgIdx->getType() << ArgIdx->getSourceRange();
572 // \brief Performs semantic analysis for the read/write_pipe call.
573 // \param S Reference to the semantic analyzer.
574 // \param Call A pointer to the builtin call.
575 // \return True if a semantic error has been found, false otherwise.
576 static bool SemaBuiltinRWPipe(Sema &S, CallExpr *Call) {
577 // OpenCL v2.0 s6.13.16.2 - The built-in read/write
578 // functions have two forms.
579 switch (Call->getNumArgs()) {
581 if (checkOpenCLPipeArg(S, Call))
583 // The call with 2 arguments should be
584 // read/write_pipe(pipe T, T*).
585 // Check packet type T.
586 if (checkOpenCLPipePacketType(S, Call, 1))
591 if (checkOpenCLPipeArg(S, Call))
593 // The call with 4 arguments should be
594 // read/write_pipe(pipe T, reserve_id_t, uint, T*).
595 // Check reserve_id_t.
596 if (!Call->getArg(1)->getType()->isReserveIDT()) {
597 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg)
598 << Call->getDirectCallee() << S.Context.OCLReserveIDTy
599 << Call->getArg(1)->getType() << Call->getArg(1)->getSourceRange();
604 const Expr *Arg2 = Call->getArg(2);
605 if (!Arg2->getType()->isIntegerType() &&
606 !Arg2->getType()->isUnsignedIntegerType()) {
607 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg)
608 << Call->getDirectCallee() << S.Context.UnsignedIntTy
609 << Arg2->getType() << Arg2->getSourceRange();
613 // Check packet type T.
614 if (checkOpenCLPipePacketType(S, Call, 3))
618 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_arg_num)
619 << Call->getDirectCallee() << Call->getSourceRange();
626 // \brief Performs a semantic analysis on the {work_group_/sub_group_
627 // /_}reserve_{read/write}_pipe
628 // \param S Reference to the semantic analyzer.
629 // \param Call The call to the builtin function to be analyzed.
630 // \return True if a semantic error was found, false otherwise.
631 static bool SemaBuiltinReserveRWPipe(Sema &S, CallExpr *Call) {
632 if (checkArgCount(S, Call, 2))
635 if (checkOpenCLPipeArg(S, Call))
638 // Check the reserve size.
639 if (!Call->getArg(1)->getType()->isIntegerType() &&
640 !Call->getArg(1)->getType()->isUnsignedIntegerType()) {
641 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg)
642 << Call->getDirectCallee() << S.Context.UnsignedIntTy
643 << Call->getArg(1)->getType() << Call->getArg(1)->getSourceRange();
650 // \brief Performs a semantic analysis on {work_group_/sub_group_
651 // /_}commit_{read/write}_pipe
652 // \param S Reference to the semantic analyzer.
653 // \param Call The call to the builtin function to be analyzed.
654 // \return True if a semantic error was found, false otherwise.
655 static bool SemaBuiltinCommitRWPipe(Sema &S, CallExpr *Call) {
656 if (checkArgCount(S, Call, 2))
659 if (checkOpenCLPipeArg(S, Call))
662 // Check reserve_id_t.
663 if (!Call->getArg(1)->getType()->isReserveIDT()) {
664 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg)
665 << Call->getDirectCallee() << S.Context.OCLReserveIDTy
666 << Call->getArg(1)->getType() << Call->getArg(1)->getSourceRange();
673 // \brief Performs a semantic analysis on the call to built-in Pipe
675 // \param S Reference to the semantic analyzer.
676 // \param Call The call to the builtin function to be analyzed.
677 // \return True if a semantic error was found, false otherwise.
678 static bool SemaBuiltinPipePackets(Sema &S, CallExpr *Call) {
679 if (checkArgCount(S, Call, 1))
682 if (!Call->getArg(0)->getType()->isPipeType()) {
683 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_first_arg)
684 << Call->getDirectCallee() << Call->getArg(0)->getSourceRange();
690 // \brief OpenCL v2.0 s6.13.9 - Address space qualifier functions.
691 // \brief Performs semantic analysis for the to_global/local/private call.
692 // \param S Reference to the semantic analyzer.
693 // \param BuiltinID ID of the builtin function.
694 // \param Call A pointer to the builtin call.
695 // \return True if a semantic error has been found, false otherwise.
696 static bool SemaOpenCLBuiltinToAddr(Sema &S, unsigned BuiltinID,
698 if (Call->getNumArgs() != 1) {
699 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_arg_num)
700 << Call->getDirectCallee() << Call->getSourceRange();
704 auto RT = Call->getArg(0)->getType();
705 if (!RT->isPointerType() || RT->getPointeeType()
706 .getAddressSpace() == LangAS::opencl_constant) {
707 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_invalid_arg)
708 << Call->getArg(0) << Call->getDirectCallee() << Call->getSourceRange();
712 RT = RT->getPointeeType();
713 auto Qual = RT.getQualifiers();
715 case Builtin::BIto_global:
716 Qual.setAddressSpace(LangAS::opencl_global);
718 case Builtin::BIto_local:
719 Qual.setAddressSpace(LangAS::opencl_local);
722 Qual.removeAddressSpace();
724 Call->setType(S.Context.getPointerType(S.Context.getQualifiedType(
725 RT.getUnqualifiedType(), Qual)));
731 Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
733 ExprResult TheCallResult(TheCall);
735 // Find out if any arguments are required to be integer constant expressions.
736 unsigned ICEArguments = 0;
737 ASTContext::GetBuiltinTypeError Error;
738 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
739 if (Error != ASTContext::GE_None)
740 ICEArguments = 0; // Don't diagnose previously diagnosed errors.
742 // If any arguments are required to be ICE's, check and diagnose.
743 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
744 // Skip arguments not required to be ICE's.
745 if ((ICEArguments & (1 << ArgNo)) == 0) continue;
748 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
750 ICEArguments &= ~(1 << ArgNo);
754 case Builtin::BI__builtin___CFStringMakeConstantString:
755 assert(TheCall->getNumArgs() == 1 &&
756 "Wrong # arguments to builtin CFStringMakeConstantString");
757 if (CheckObjCString(TheCall->getArg(0)))
760 case Builtin::BI__builtin_stdarg_start:
761 case Builtin::BI__builtin_va_start:
762 if (SemaBuiltinVAStart(TheCall))
765 case Builtin::BI__va_start: {
766 switch (Context.getTargetInfo().getTriple().getArch()) {
767 case llvm::Triple::arm:
768 case llvm::Triple::thumb:
769 if (SemaBuiltinVAStartARM(TheCall))
773 if (SemaBuiltinVAStart(TheCall))
779 case Builtin::BI__builtin_isgreater:
780 case Builtin::BI__builtin_isgreaterequal:
781 case Builtin::BI__builtin_isless:
782 case Builtin::BI__builtin_islessequal:
783 case Builtin::BI__builtin_islessgreater:
784 case Builtin::BI__builtin_isunordered:
785 if (SemaBuiltinUnorderedCompare(TheCall))
788 case Builtin::BI__builtin_fpclassify:
789 if (SemaBuiltinFPClassification(TheCall, 6))
792 case Builtin::BI__builtin_isfinite:
793 case Builtin::BI__builtin_isinf:
794 case Builtin::BI__builtin_isinf_sign:
795 case Builtin::BI__builtin_isnan:
796 case Builtin::BI__builtin_isnormal:
797 if (SemaBuiltinFPClassification(TheCall, 1))
800 case Builtin::BI__builtin_shufflevector:
801 return SemaBuiltinShuffleVector(TheCall);
802 // TheCall will be freed by the smart pointer here, but that's fine, since
803 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
804 case Builtin::BI__builtin_prefetch:
805 if (SemaBuiltinPrefetch(TheCall))
808 case Builtin::BI__builtin_alloca_with_align:
809 if (SemaBuiltinAllocaWithAlign(TheCall))
812 case Builtin::BI__assume:
813 case Builtin::BI__builtin_assume:
814 if (SemaBuiltinAssume(TheCall))
817 case Builtin::BI__builtin_assume_aligned:
818 if (SemaBuiltinAssumeAligned(TheCall))
821 case Builtin::BI__builtin_object_size:
822 if (SemaBuiltinConstantArgRange(TheCall, 1, 0, 3))
825 case Builtin::BI__builtin_longjmp:
826 if (SemaBuiltinLongjmp(TheCall))
829 case Builtin::BI__builtin_setjmp:
830 if (SemaBuiltinSetjmp(TheCall))
833 case Builtin::BI_setjmp:
834 case Builtin::BI_setjmpex:
835 if (checkArgCount(*this, TheCall, 1))
839 case Builtin::BI__builtin_classify_type:
840 if (checkArgCount(*this, TheCall, 1)) return true;
841 TheCall->setType(Context.IntTy);
843 case Builtin::BI__builtin_constant_p:
844 if (checkArgCount(*this, TheCall, 1)) return true;
845 TheCall->setType(Context.IntTy);
847 case Builtin::BI__sync_fetch_and_add:
848 case Builtin::BI__sync_fetch_and_add_1:
849 case Builtin::BI__sync_fetch_and_add_2:
850 case Builtin::BI__sync_fetch_and_add_4:
851 case Builtin::BI__sync_fetch_and_add_8:
852 case Builtin::BI__sync_fetch_and_add_16:
853 case Builtin::BI__sync_fetch_and_sub:
854 case Builtin::BI__sync_fetch_and_sub_1:
855 case Builtin::BI__sync_fetch_and_sub_2:
856 case Builtin::BI__sync_fetch_and_sub_4:
857 case Builtin::BI__sync_fetch_and_sub_8:
858 case Builtin::BI__sync_fetch_and_sub_16:
859 case Builtin::BI__sync_fetch_and_or:
860 case Builtin::BI__sync_fetch_and_or_1:
861 case Builtin::BI__sync_fetch_and_or_2:
862 case Builtin::BI__sync_fetch_and_or_4:
863 case Builtin::BI__sync_fetch_and_or_8:
864 case Builtin::BI__sync_fetch_and_or_16:
865 case Builtin::BI__sync_fetch_and_and:
866 case Builtin::BI__sync_fetch_and_and_1:
867 case Builtin::BI__sync_fetch_and_and_2:
868 case Builtin::BI__sync_fetch_and_and_4:
869 case Builtin::BI__sync_fetch_and_and_8:
870 case Builtin::BI__sync_fetch_and_and_16:
871 case Builtin::BI__sync_fetch_and_xor:
872 case Builtin::BI__sync_fetch_and_xor_1:
873 case Builtin::BI__sync_fetch_and_xor_2:
874 case Builtin::BI__sync_fetch_and_xor_4:
875 case Builtin::BI__sync_fetch_and_xor_8:
876 case Builtin::BI__sync_fetch_and_xor_16:
877 case Builtin::BI__sync_fetch_and_nand:
878 case Builtin::BI__sync_fetch_and_nand_1:
879 case Builtin::BI__sync_fetch_and_nand_2:
880 case Builtin::BI__sync_fetch_and_nand_4:
881 case Builtin::BI__sync_fetch_and_nand_8:
882 case Builtin::BI__sync_fetch_and_nand_16:
883 case Builtin::BI__sync_add_and_fetch:
884 case Builtin::BI__sync_add_and_fetch_1:
885 case Builtin::BI__sync_add_and_fetch_2:
886 case Builtin::BI__sync_add_and_fetch_4:
887 case Builtin::BI__sync_add_and_fetch_8:
888 case Builtin::BI__sync_add_and_fetch_16:
889 case Builtin::BI__sync_sub_and_fetch:
890 case Builtin::BI__sync_sub_and_fetch_1:
891 case Builtin::BI__sync_sub_and_fetch_2:
892 case Builtin::BI__sync_sub_and_fetch_4:
893 case Builtin::BI__sync_sub_and_fetch_8:
894 case Builtin::BI__sync_sub_and_fetch_16:
895 case Builtin::BI__sync_and_and_fetch:
896 case Builtin::BI__sync_and_and_fetch_1:
897 case Builtin::BI__sync_and_and_fetch_2:
898 case Builtin::BI__sync_and_and_fetch_4:
899 case Builtin::BI__sync_and_and_fetch_8:
900 case Builtin::BI__sync_and_and_fetch_16:
901 case Builtin::BI__sync_or_and_fetch:
902 case Builtin::BI__sync_or_and_fetch_1:
903 case Builtin::BI__sync_or_and_fetch_2:
904 case Builtin::BI__sync_or_and_fetch_4:
905 case Builtin::BI__sync_or_and_fetch_8:
906 case Builtin::BI__sync_or_and_fetch_16:
907 case Builtin::BI__sync_xor_and_fetch:
908 case Builtin::BI__sync_xor_and_fetch_1:
909 case Builtin::BI__sync_xor_and_fetch_2:
910 case Builtin::BI__sync_xor_and_fetch_4:
911 case Builtin::BI__sync_xor_and_fetch_8:
912 case Builtin::BI__sync_xor_and_fetch_16:
913 case Builtin::BI__sync_nand_and_fetch:
914 case Builtin::BI__sync_nand_and_fetch_1:
915 case Builtin::BI__sync_nand_and_fetch_2:
916 case Builtin::BI__sync_nand_and_fetch_4:
917 case Builtin::BI__sync_nand_and_fetch_8:
918 case Builtin::BI__sync_nand_and_fetch_16:
919 case Builtin::BI__sync_val_compare_and_swap:
920 case Builtin::BI__sync_val_compare_and_swap_1:
921 case Builtin::BI__sync_val_compare_and_swap_2:
922 case Builtin::BI__sync_val_compare_and_swap_4:
923 case Builtin::BI__sync_val_compare_and_swap_8:
924 case Builtin::BI__sync_val_compare_and_swap_16:
925 case Builtin::BI__sync_bool_compare_and_swap:
926 case Builtin::BI__sync_bool_compare_and_swap_1:
927 case Builtin::BI__sync_bool_compare_and_swap_2:
928 case Builtin::BI__sync_bool_compare_and_swap_4:
929 case Builtin::BI__sync_bool_compare_and_swap_8:
930 case Builtin::BI__sync_bool_compare_and_swap_16:
931 case Builtin::BI__sync_lock_test_and_set:
932 case Builtin::BI__sync_lock_test_and_set_1:
933 case Builtin::BI__sync_lock_test_and_set_2:
934 case Builtin::BI__sync_lock_test_and_set_4:
935 case Builtin::BI__sync_lock_test_and_set_8:
936 case Builtin::BI__sync_lock_test_and_set_16:
937 case Builtin::BI__sync_lock_release:
938 case Builtin::BI__sync_lock_release_1:
939 case Builtin::BI__sync_lock_release_2:
940 case Builtin::BI__sync_lock_release_4:
941 case Builtin::BI__sync_lock_release_8:
942 case Builtin::BI__sync_lock_release_16:
943 case Builtin::BI__sync_swap:
944 case Builtin::BI__sync_swap_1:
945 case Builtin::BI__sync_swap_2:
946 case Builtin::BI__sync_swap_4:
947 case Builtin::BI__sync_swap_8:
948 case Builtin::BI__sync_swap_16:
949 return SemaBuiltinAtomicOverloaded(TheCallResult);
950 case Builtin::BI__builtin_nontemporal_load:
951 case Builtin::BI__builtin_nontemporal_store:
952 return SemaBuiltinNontemporalOverloaded(TheCallResult);
953 #define BUILTIN(ID, TYPE, ATTRS)
954 #define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
955 case Builtin::BI##ID: \
956 return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID);
957 #include "clang/Basic/Builtins.def"
958 case Builtin::BI__builtin_annotation:
959 if (SemaBuiltinAnnotation(*this, TheCall))
962 case Builtin::BI__builtin_addressof:
963 if (SemaBuiltinAddressof(*this, TheCall))
966 case Builtin::BI__builtin_add_overflow:
967 case Builtin::BI__builtin_sub_overflow:
968 case Builtin::BI__builtin_mul_overflow:
969 if (SemaBuiltinOverflow(*this, TheCall))
972 case Builtin::BI__builtin_operator_new:
973 case Builtin::BI__builtin_operator_delete:
974 if (!getLangOpts().CPlusPlus) {
975 Diag(TheCall->getExprLoc(), diag::err_builtin_requires_language)
976 << (BuiltinID == Builtin::BI__builtin_operator_new
977 ? "__builtin_operator_new"
978 : "__builtin_operator_delete")
982 // CodeGen assumes it can find the global new and delete to call,
983 // so ensure that they are declared.
984 DeclareGlobalNewDelete();
987 // check secure string manipulation functions where overflows
988 // are detectable at compile time
989 case Builtin::BI__builtin___memcpy_chk:
990 case Builtin::BI__builtin___memmove_chk:
991 case Builtin::BI__builtin___memset_chk:
992 case Builtin::BI__builtin___strlcat_chk:
993 case Builtin::BI__builtin___strlcpy_chk:
994 case Builtin::BI__builtin___strncat_chk:
995 case Builtin::BI__builtin___strncpy_chk:
996 case Builtin::BI__builtin___stpncpy_chk:
997 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 2, 3);
999 case Builtin::BI__builtin___memccpy_chk:
1000 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 3, 4);
1002 case Builtin::BI__builtin___snprintf_chk:
1003 case Builtin::BI__builtin___vsnprintf_chk:
1004 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 1, 3);
1006 case Builtin::BI__builtin_call_with_static_chain:
1007 if (SemaBuiltinCallWithStaticChain(*this, TheCall))
1010 case Builtin::BI__exception_code:
1011 case Builtin::BI_exception_code:
1012 if (SemaBuiltinSEHScopeCheck(*this, TheCall, Scope::SEHExceptScope,
1013 diag::err_seh___except_block))
1016 case Builtin::BI__exception_info:
1017 case Builtin::BI_exception_info:
1018 if (SemaBuiltinSEHScopeCheck(*this, TheCall, Scope::SEHFilterScope,
1019 diag::err_seh___except_filter))
1022 case Builtin::BI__GetExceptionInfo:
1023 if (checkArgCount(*this, TheCall, 1))
1026 if (CheckCXXThrowOperand(
1027 TheCall->getLocStart(),
1028 Context.getExceptionObjectType(FDecl->getParamDecl(0)->getType()),
1032 TheCall->setType(Context.VoidPtrTy);
1034 // OpenCL v2.0, s6.13.16 - Pipe functions
1035 case Builtin::BIread_pipe:
1036 case Builtin::BIwrite_pipe:
1037 // Since those two functions are declared with var args, we need a semantic
1038 // check for the argument.
1039 if (SemaBuiltinRWPipe(*this, TheCall))
1041 TheCall->setType(Context.IntTy);
1043 case Builtin::BIreserve_read_pipe:
1044 case Builtin::BIreserve_write_pipe:
1045 case Builtin::BIwork_group_reserve_read_pipe:
1046 case Builtin::BIwork_group_reserve_write_pipe:
1047 case Builtin::BIsub_group_reserve_read_pipe:
1048 case Builtin::BIsub_group_reserve_write_pipe:
1049 if (SemaBuiltinReserveRWPipe(*this, TheCall))
1051 // Since return type of reserve_read/write_pipe built-in function is
1052 // reserve_id_t, which is not defined in the builtin def file , we used int
1053 // as return type and need to override the return type of these functions.
1054 TheCall->setType(Context.OCLReserveIDTy);
1056 case Builtin::BIcommit_read_pipe:
1057 case Builtin::BIcommit_write_pipe:
1058 case Builtin::BIwork_group_commit_read_pipe:
1059 case Builtin::BIwork_group_commit_write_pipe:
1060 case Builtin::BIsub_group_commit_read_pipe:
1061 case Builtin::BIsub_group_commit_write_pipe:
1062 if (SemaBuiltinCommitRWPipe(*this, TheCall))
1065 case Builtin::BIget_pipe_num_packets:
1066 case Builtin::BIget_pipe_max_packets:
1067 if (SemaBuiltinPipePackets(*this, TheCall))
1069 TheCall->setType(Context.UnsignedIntTy);
1071 case Builtin::BIto_global:
1072 case Builtin::BIto_local:
1073 case Builtin::BIto_private:
1074 if (SemaOpenCLBuiltinToAddr(*this, BuiltinID, TheCall))
1077 // OpenCL v2.0, s6.13.17 - Enqueue kernel functions.
1078 case Builtin::BIenqueue_kernel:
1079 if (SemaOpenCLBuiltinEnqueueKernel(*this, TheCall))
1082 case Builtin::BIget_kernel_work_group_size:
1083 case Builtin::BIget_kernel_preferred_work_group_size_multiple:
1084 if (SemaOpenCLBuiltinKernelWorkGroupSize(*this, TheCall))
1087 case Builtin::BI__builtin_os_log_format:
1088 case Builtin::BI__builtin_os_log_format_buffer_size:
1089 if (SemaBuiltinOSLogFormat(TheCall)) {
1095 // Since the target specific builtins for each arch overlap, only check those
1096 // of the arch we are compiling for.
1097 if (Context.BuiltinInfo.isTSBuiltin(BuiltinID)) {
1098 switch (Context.getTargetInfo().getTriple().getArch()) {
1099 case llvm::Triple::arm:
1100 case llvm::Triple::armeb:
1101 case llvm::Triple::thumb:
1102 case llvm::Triple::thumbeb:
1103 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
1106 case llvm::Triple::aarch64:
1107 case llvm::Triple::aarch64_be:
1108 if (CheckAArch64BuiltinFunctionCall(BuiltinID, TheCall))
1111 case llvm::Triple::mips:
1112 case llvm::Triple::mipsel:
1113 case llvm::Triple::mips64:
1114 case llvm::Triple::mips64el:
1115 if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
1118 case llvm::Triple::systemz:
1119 if (CheckSystemZBuiltinFunctionCall(BuiltinID, TheCall))
1122 case llvm::Triple::x86:
1123 case llvm::Triple::x86_64:
1124 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
1127 case llvm::Triple::ppc:
1128 case llvm::Triple::ppc64:
1129 case llvm::Triple::ppc64le:
1130 if (CheckPPCBuiltinFunctionCall(BuiltinID, TheCall))
1138 return TheCallResult;
1141 // Get the valid immediate range for the specified NEON type code.
1142 static unsigned RFT(unsigned t, bool shift = false, bool ForceQuad = false) {
1143 NeonTypeFlags Type(t);
1144 int IsQuad = ForceQuad ? true : Type.isQuad();
1145 switch (Type.getEltType()) {
1146 case NeonTypeFlags::Int8:
1147 case NeonTypeFlags::Poly8:
1148 return shift ? 7 : (8 << IsQuad) - 1;
1149 case NeonTypeFlags::Int16:
1150 case NeonTypeFlags::Poly16:
1151 return shift ? 15 : (4 << IsQuad) - 1;
1152 case NeonTypeFlags::Int32:
1153 return shift ? 31 : (2 << IsQuad) - 1;
1154 case NeonTypeFlags::Int64:
1155 case NeonTypeFlags::Poly64:
1156 return shift ? 63 : (1 << IsQuad) - 1;
1157 case NeonTypeFlags::Poly128:
1158 return shift ? 127 : (1 << IsQuad) - 1;
1159 case NeonTypeFlags::Float16:
1160 assert(!shift && "cannot shift float types!");
1161 return (4 << IsQuad) - 1;
1162 case NeonTypeFlags::Float32:
1163 assert(!shift && "cannot shift float types!");
1164 return (2 << IsQuad) - 1;
1165 case NeonTypeFlags::Float64:
1166 assert(!shift && "cannot shift float types!");
1167 return (1 << IsQuad) - 1;
1169 llvm_unreachable("Invalid NeonTypeFlag!");
1172 /// getNeonEltType - Return the QualType corresponding to the elements of
1173 /// the vector type specified by the NeonTypeFlags. This is used to check
1174 /// the pointer arguments for Neon load/store intrinsics.
1175 static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context,
1176 bool IsPolyUnsigned, bool IsInt64Long) {
1177 switch (Flags.getEltType()) {
1178 case NeonTypeFlags::Int8:
1179 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
1180 case NeonTypeFlags::Int16:
1181 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
1182 case NeonTypeFlags::Int32:
1183 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
1184 case NeonTypeFlags::Int64:
1186 return Flags.isUnsigned() ? Context.UnsignedLongTy : Context.LongTy;
1188 return Flags.isUnsigned() ? Context.UnsignedLongLongTy
1189 : Context.LongLongTy;
1190 case NeonTypeFlags::Poly8:
1191 return IsPolyUnsigned ? Context.UnsignedCharTy : Context.SignedCharTy;
1192 case NeonTypeFlags::Poly16:
1193 return IsPolyUnsigned ? Context.UnsignedShortTy : Context.ShortTy;
1194 case NeonTypeFlags::Poly64:
1196 return Context.UnsignedLongTy;
1198 return Context.UnsignedLongLongTy;
1199 case NeonTypeFlags::Poly128:
1201 case NeonTypeFlags::Float16:
1202 return Context.HalfTy;
1203 case NeonTypeFlags::Float32:
1204 return Context.FloatTy;
1205 case NeonTypeFlags::Float64:
1206 return Context.DoubleTy;
1208 llvm_unreachable("Invalid NeonTypeFlag!");
1211 bool Sema::CheckNeonBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
1212 llvm::APSInt Result;
1216 bool HasConstPtr = false;
1217 switch (BuiltinID) {
1218 #define GET_NEON_OVERLOAD_CHECK
1219 #include "clang/Basic/arm_neon.inc"
1220 #undef GET_NEON_OVERLOAD_CHECK
1223 // For NEON intrinsics which are overloaded on vector element type, validate
1224 // the immediate which specifies which variant to emit.
1225 unsigned ImmArg = TheCall->getNumArgs()-1;
1227 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
1230 TV = Result.getLimitedValue(64);
1231 if ((TV > 63) || (mask & (1ULL << TV)) == 0)
1232 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
1233 << TheCall->getArg(ImmArg)->getSourceRange();
1236 if (PtrArgNum >= 0) {
1237 // Check that pointer arguments have the specified type.
1238 Expr *Arg = TheCall->getArg(PtrArgNum);
1239 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
1240 Arg = ICE->getSubExpr();
1241 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
1242 QualType RHSTy = RHS.get()->getType();
1244 llvm::Triple::ArchType Arch = Context.getTargetInfo().getTriple().getArch();
1245 bool IsPolyUnsigned = Arch == llvm::Triple::aarch64 ||
1246 Arch == llvm::Triple::aarch64_be;
1248 Context.getTargetInfo().getInt64Type() == TargetInfo::SignedLong;
1250 getNeonEltType(NeonTypeFlags(TV), Context, IsPolyUnsigned, IsInt64Long);
1252 EltTy = EltTy.withConst();
1253 QualType LHSTy = Context.getPointerType(EltTy);
1254 AssignConvertType ConvTy;
1255 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
1256 if (RHS.isInvalid())
1258 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
1259 RHS.get(), AA_Assigning))
1263 // For NEON intrinsics which take an immediate value as part of the
1264 // instruction, range check them here.
1265 unsigned i = 0, l = 0, u = 0;
1266 switch (BuiltinID) {
1269 #define GET_NEON_IMMEDIATE_CHECK
1270 #include "clang/Basic/arm_neon.inc"
1271 #undef GET_NEON_IMMEDIATE_CHECK
1274 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l);
1277 bool Sema::CheckARMBuiltinExclusiveCall(unsigned BuiltinID, CallExpr *TheCall,
1278 unsigned MaxWidth) {
1279 assert((BuiltinID == ARM::BI__builtin_arm_ldrex ||
1280 BuiltinID == ARM::BI__builtin_arm_ldaex ||
1281 BuiltinID == ARM::BI__builtin_arm_strex ||
1282 BuiltinID == ARM::BI__builtin_arm_stlex ||
1283 BuiltinID == AArch64::BI__builtin_arm_ldrex ||
1284 BuiltinID == AArch64::BI__builtin_arm_ldaex ||
1285 BuiltinID == AArch64::BI__builtin_arm_strex ||
1286 BuiltinID == AArch64::BI__builtin_arm_stlex) &&
1287 "unexpected ARM builtin");
1288 bool IsLdrex = BuiltinID == ARM::BI__builtin_arm_ldrex ||
1289 BuiltinID == ARM::BI__builtin_arm_ldaex ||
1290 BuiltinID == AArch64::BI__builtin_arm_ldrex ||
1291 BuiltinID == AArch64::BI__builtin_arm_ldaex;
1293 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1295 // Ensure that we have the proper number of arguments.
1296 if (checkArgCount(*this, TheCall, IsLdrex ? 1 : 2))
1299 // Inspect the pointer argument of the atomic builtin. This should always be
1300 // a pointer type, whose element is an integral scalar or pointer type.
1301 // Because it is a pointer type, we don't have to worry about any implicit
1303 Expr *PointerArg = TheCall->getArg(IsLdrex ? 0 : 1);
1304 ExprResult PointerArgRes = DefaultFunctionArrayLvalueConversion(PointerArg);
1305 if (PointerArgRes.isInvalid())
1307 PointerArg = PointerArgRes.get();
1309 const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>();
1311 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
1312 << PointerArg->getType() << PointerArg->getSourceRange();
1316 // ldrex takes a "const volatile T*" and strex takes a "volatile T*". Our next
1317 // task is to insert the appropriate casts into the AST. First work out just
1318 // what the appropriate type is.
1319 QualType ValType = pointerType->getPointeeType();
1320 QualType AddrType = ValType.getUnqualifiedType().withVolatile();
1322 AddrType.addConst();
1324 // Issue a warning if the cast is dodgy.
1325 CastKind CastNeeded = CK_NoOp;
1326 if (!AddrType.isAtLeastAsQualifiedAs(ValType)) {
1327 CastNeeded = CK_BitCast;
1328 Diag(DRE->getLocStart(), diag::ext_typecheck_convert_discards_qualifiers)
1329 << PointerArg->getType()
1330 << Context.getPointerType(AddrType)
1331 << AA_Passing << PointerArg->getSourceRange();
1334 // Finally, do the cast and replace the argument with the corrected version.
1335 AddrType = Context.getPointerType(AddrType);
1336 PointerArgRes = ImpCastExprToType(PointerArg, AddrType, CastNeeded);
1337 if (PointerArgRes.isInvalid())
1339 PointerArg = PointerArgRes.get();
1341 TheCall->setArg(IsLdrex ? 0 : 1, PointerArg);
1343 // In general, we allow ints, floats and pointers to be loaded and stored.
1344 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
1345 !ValType->isBlockPointerType() && !ValType->isFloatingType()) {
1346 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intfltptr)
1347 << PointerArg->getType() << PointerArg->getSourceRange();
1351 // But ARM doesn't have instructions to deal with 128-bit versions.
1352 if (Context.getTypeSize(ValType) > MaxWidth) {
1353 assert(MaxWidth == 64 && "Diagnostic unexpectedly inaccurate");
1354 Diag(DRE->getLocStart(), diag::err_atomic_exclusive_builtin_pointer_size)
1355 << PointerArg->getType() << PointerArg->getSourceRange();
1359 switch (ValType.getObjCLifetime()) {
1360 case Qualifiers::OCL_None:
1361 case Qualifiers::OCL_ExplicitNone:
1365 case Qualifiers::OCL_Weak:
1366 case Qualifiers::OCL_Strong:
1367 case Qualifiers::OCL_Autoreleasing:
1368 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
1369 << ValType << PointerArg->getSourceRange();
1374 TheCall->setType(ValType);
1378 // Initialize the argument to be stored.
1379 ExprResult ValArg = TheCall->getArg(0);
1380 InitializedEntity Entity = InitializedEntity::InitializeParameter(
1381 Context, ValType, /*consume*/ false);
1382 ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg);
1383 if (ValArg.isInvalid())
1385 TheCall->setArg(0, ValArg.get());
1387 // __builtin_arm_strex always returns an int. It's marked as such in the .def,
1388 // but the custom checker bypasses all default analysis.
1389 TheCall->setType(Context.IntTy);
1393 bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
1394 llvm::APSInt Result;
1396 if (BuiltinID == ARM::BI__builtin_arm_ldrex ||
1397 BuiltinID == ARM::BI__builtin_arm_ldaex ||
1398 BuiltinID == ARM::BI__builtin_arm_strex ||
1399 BuiltinID == ARM::BI__builtin_arm_stlex) {
1400 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall, 64);
1403 if (BuiltinID == ARM::BI__builtin_arm_prefetch) {
1404 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) ||
1405 SemaBuiltinConstantArgRange(TheCall, 2, 0, 1);
1408 if (BuiltinID == ARM::BI__builtin_arm_rsr64 ||
1409 BuiltinID == ARM::BI__builtin_arm_wsr64)
1410 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 3, false);
1412 if (BuiltinID == ARM::BI__builtin_arm_rsr ||
1413 BuiltinID == ARM::BI__builtin_arm_rsrp ||
1414 BuiltinID == ARM::BI__builtin_arm_wsr ||
1415 BuiltinID == ARM::BI__builtin_arm_wsrp)
1416 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 5, true);
1418 if (CheckNeonBuiltinFunctionCall(BuiltinID, TheCall))
1421 // For intrinsics which take an immediate value as part of the instruction,
1422 // range check them here.
1423 unsigned i = 0, l = 0, u = 0;
1424 switch (BuiltinID) {
1425 default: return false;
1426 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
1427 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
1428 case ARM::BI__builtin_arm_vcvtr_f:
1429 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
1430 case ARM::BI__builtin_arm_dmb:
1431 case ARM::BI__builtin_arm_dsb:
1432 case ARM::BI__builtin_arm_isb:
1433 case ARM::BI__builtin_arm_dbg: l = 0; u = 15; break;
1436 // FIXME: VFP Intrinsics should error if VFP not present.
1437 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l);
1440 bool Sema::CheckAArch64BuiltinFunctionCall(unsigned BuiltinID,
1441 CallExpr *TheCall) {
1442 llvm::APSInt Result;
1444 if (BuiltinID == AArch64::BI__builtin_arm_ldrex ||
1445 BuiltinID == AArch64::BI__builtin_arm_ldaex ||
1446 BuiltinID == AArch64::BI__builtin_arm_strex ||
1447 BuiltinID == AArch64::BI__builtin_arm_stlex) {
1448 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall, 128);
1451 if (BuiltinID == AArch64::BI__builtin_arm_prefetch) {
1452 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) ||
1453 SemaBuiltinConstantArgRange(TheCall, 2, 0, 2) ||
1454 SemaBuiltinConstantArgRange(TheCall, 3, 0, 1) ||
1455 SemaBuiltinConstantArgRange(TheCall, 4, 0, 1);
1458 if (BuiltinID == AArch64::BI__builtin_arm_rsr64 ||
1459 BuiltinID == AArch64::BI__builtin_arm_wsr64)
1460 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 5, true);
1462 if (BuiltinID == AArch64::BI__builtin_arm_rsr ||
1463 BuiltinID == AArch64::BI__builtin_arm_rsrp ||
1464 BuiltinID == AArch64::BI__builtin_arm_wsr ||
1465 BuiltinID == AArch64::BI__builtin_arm_wsrp)
1466 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 5, true);
1468 if (CheckNeonBuiltinFunctionCall(BuiltinID, TheCall))
1471 // For intrinsics which take an immediate value as part of the instruction,
1472 // range check them here.
1473 unsigned i = 0, l = 0, u = 0;
1474 switch (BuiltinID) {
1475 default: return false;
1476 case AArch64::BI__builtin_arm_dmb:
1477 case AArch64::BI__builtin_arm_dsb:
1478 case AArch64::BI__builtin_arm_isb: l = 0; u = 15; break;
1481 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l);
1484 // CheckMipsBuiltinFunctionCall - Checks the constant value passed to the
1485 // intrinsic is correct. The switch statement is ordered by DSP, MSA. The
1486 // ordering for DSP is unspecified. MSA is ordered by the data format used
1487 // by the underlying instruction i.e., df/m, df/n and then by size.
1489 // FIXME: The size tests here should instead be tablegen'd along with the
1490 // definitions from include/clang/Basic/BuiltinsMips.def.
1491 // FIXME: GCC is strict on signedness for some of these intrinsics, we should
1493 bool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
1494 unsigned i = 0, l = 0, u = 0, m = 0;
1495 switch (BuiltinID) {
1496 default: return false;
1497 case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
1498 case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
1499 case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break;
1500 case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break;
1501 case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break;
1502 case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break;
1503 case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break;
1504 // MSA instrinsics. Instructions (which the intrinsics maps to) which use the
1506 // These intrinsics take an unsigned 3 bit immediate.
1507 case Mips::BI__builtin_msa_bclri_b:
1508 case Mips::BI__builtin_msa_bnegi_b:
1509 case Mips::BI__builtin_msa_bseti_b:
1510 case Mips::BI__builtin_msa_sat_s_b:
1511 case Mips::BI__builtin_msa_sat_u_b:
1512 case Mips::BI__builtin_msa_slli_b:
1513 case Mips::BI__builtin_msa_srai_b:
1514 case Mips::BI__builtin_msa_srari_b:
1515 case Mips::BI__builtin_msa_srli_b:
1516 case Mips::BI__builtin_msa_srlri_b: i = 1; l = 0; u = 7; break;
1517 case Mips::BI__builtin_msa_binsli_b:
1518 case Mips::BI__builtin_msa_binsri_b: i = 2; l = 0; u = 7; break;
1519 // These intrinsics take an unsigned 4 bit immediate.
1520 case Mips::BI__builtin_msa_bclri_h:
1521 case Mips::BI__builtin_msa_bnegi_h:
1522 case Mips::BI__builtin_msa_bseti_h:
1523 case Mips::BI__builtin_msa_sat_s_h:
1524 case Mips::BI__builtin_msa_sat_u_h:
1525 case Mips::BI__builtin_msa_slli_h:
1526 case Mips::BI__builtin_msa_srai_h:
1527 case Mips::BI__builtin_msa_srari_h:
1528 case Mips::BI__builtin_msa_srli_h:
1529 case Mips::BI__builtin_msa_srlri_h: i = 1; l = 0; u = 15; break;
1530 case Mips::BI__builtin_msa_binsli_h:
1531 case Mips::BI__builtin_msa_binsri_h: i = 2; l = 0; u = 15; break;
1532 // These intrinsics take an unsigned 5 bit immedate.
1533 // The first block of intrinsics actually have an unsigned 5 bit field,
1534 // not a df/n field.
1535 case Mips::BI__builtin_msa_clei_u_b:
1536 case Mips::BI__builtin_msa_clei_u_h:
1537 case Mips::BI__builtin_msa_clei_u_w:
1538 case Mips::BI__builtin_msa_clei_u_d:
1539 case Mips::BI__builtin_msa_clti_u_b:
1540 case Mips::BI__builtin_msa_clti_u_h:
1541 case Mips::BI__builtin_msa_clti_u_w:
1542 case Mips::BI__builtin_msa_clti_u_d:
1543 case Mips::BI__builtin_msa_maxi_u_b:
1544 case Mips::BI__builtin_msa_maxi_u_h:
1545 case Mips::BI__builtin_msa_maxi_u_w:
1546 case Mips::BI__builtin_msa_maxi_u_d:
1547 case Mips::BI__builtin_msa_mini_u_b:
1548 case Mips::BI__builtin_msa_mini_u_h:
1549 case Mips::BI__builtin_msa_mini_u_w:
1550 case Mips::BI__builtin_msa_mini_u_d:
1551 case Mips::BI__builtin_msa_addvi_b:
1552 case Mips::BI__builtin_msa_addvi_h:
1553 case Mips::BI__builtin_msa_addvi_w:
1554 case Mips::BI__builtin_msa_addvi_d:
1555 case Mips::BI__builtin_msa_bclri_w:
1556 case Mips::BI__builtin_msa_bnegi_w:
1557 case Mips::BI__builtin_msa_bseti_w:
1558 case Mips::BI__builtin_msa_sat_s_w:
1559 case Mips::BI__builtin_msa_sat_u_w:
1560 case Mips::BI__builtin_msa_slli_w:
1561 case Mips::BI__builtin_msa_srai_w:
1562 case Mips::BI__builtin_msa_srari_w:
1563 case Mips::BI__builtin_msa_srli_w:
1564 case Mips::BI__builtin_msa_srlri_w:
1565 case Mips::BI__builtin_msa_subvi_b:
1566 case Mips::BI__builtin_msa_subvi_h:
1567 case Mips::BI__builtin_msa_subvi_w:
1568 case Mips::BI__builtin_msa_subvi_d: i = 1; l = 0; u = 31; break;
1569 case Mips::BI__builtin_msa_binsli_w:
1570 case Mips::BI__builtin_msa_binsri_w: i = 2; l = 0; u = 31; break;
1571 // These intrinsics take an unsigned 6 bit immediate.
1572 case Mips::BI__builtin_msa_bclri_d:
1573 case Mips::BI__builtin_msa_bnegi_d:
1574 case Mips::BI__builtin_msa_bseti_d:
1575 case Mips::BI__builtin_msa_sat_s_d:
1576 case Mips::BI__builtin_msa_sat_u_d:
1577 case Mips::BI__builtin_msa_slli_d:
1578 case Mips::BI__builtin_msa_srai_d:
1579 case Mips::BI__builtin_msa_srari_d:
1580 case Mips::BI__builtin_msa_srli_d:
1581 case Mips::BI__builtin_msa_srlri_d: i = 1; l = 0; u = 63; break;
1582 case Mips::BI__builtin_msa_binsli_d:
1583 case Mips::BI__builtin_msa_binsri_d: i = 2; l = 0; u = 63; break;
1584 // These intrinsics take a signed 5 bit immediate.
1585 case Mips::BI__builtin_msa_ceqi_b:
1586 case Mips::BI__builtin_msa_ceqi_h:
1587 case Mips::BI__builtin_msa_ceqi_w:
1588 case Mips::BI__builtin_msa_ceqi_d:
1589 case Mips::BI__builtin_msa_clti_s_b:
1590 case Mips::BI__builtin_msa_clti_s_h:
1591 case Mips::BI__builtin_msa_clti_s_w:
1592 case Mips::BI__builtin_msa_clti_s_d:
1593 case Mips::BI__builtin_msa_clei_s_b:
1594 case Mips::BI__builtin_msa_clei_s_h:
1595 case Mips::BI__builtin_msa_clei_s_w:
1596 case Mips::BI__builtin_msa_clei_s_d:
1597 case Mips::BI__builtin_msa_maxi_s_b:
1598 case Mips::BI__builtin_msa_maxi_s_h:
1599 case Mips::BI__builtin_msa_maxi_s_w:
1600 case Mips::BI__builtin_msa_maxi_s_d:
1601 case Mips::BI__builtin_msa_mini_s_b:
1602 case Mips::BI__builtin_msa_mini_s_h:
1603 case Mips::BI__builtin_msa_mini_s_w:
1604 case Mips::BI__builtin_msa_mini_s_d: i = 1; l = -16; u = 15; break;
1605 // These intrinsics take an unsigned 8 bit immediate.
1606 case Mips::BI__builtin_msa_andi_b:
1607 case Mips::BI__builtin_msa_nori_b:
1608 case Mips::BI__builtin_msa_ori_b:
1609 case Mips::BI__builtin_msa_shf_b:
1610 case Mips::BI__builtin_msa_shf_h:
1611 case Mips::BI__builtin_msa_shf_w:
1612 case Mips::BI__builtin_msa_xori_b: i = 1; l = 0; u = 255; break;
1613 case Mips::BI__builtin_msa_bseli_b:
1614 case Mips::BI__builtin_msa_bmnzi_b:
1615 case Mips::BI__builtin_msa_bmzi_b: i = 2; l = 0; u = 255; break;
1617 // These intrinsics take an unsigned 4 bit immediate.
1618 case Mips::BI__builtin_msa_copy_s_b:
1619 case Mips::BI__builtin_msa_copy_u_b:
1620 case Mips::BI__builtin_msa_insve_b:
1621 case Mips::BI__builtin_msa_splati_b: i = 1; l = 0; u = 15; break;
1622 case Mips::BI__builtin_msa_sldi_b: i = 2; l = 0; u = 15; break;
1623 // These intrinsics take an unsigned 3 bit immediate.
1624 case Mips::BI__builtin_msa_copy_s_h:
1625 case Mips::BI__builtin_msa_copy_u_h:
1626 case Mips::BI__builtin_msa_insve_h:
1627 case Mips::BI__builtin_msa_splati_h: i = 1; l = 0; u = 7; break;
1628 case Mips::BI__builtin_msa_sldi_h: i = 2; l = 0; u = 7; break;
1629 // These intrinsics take an unsigned 2 bit immediate.
1630 case Mips::BI__builtin_msa_copy_s_w:
1631 case Mips::BI__builtin_msa_copy_u_w:
1632 case Mips::BI__builtin_msa_insve_w:
1633 case Mips::BI__builtin_msa_splati_w: i = 1; l = 0; u = 3; break;
1634 case Mips::BI__builtin_msa_sldi_w: i = 2; l = 0; u = 3; break;
1635 // These intrinsics take an unsigned 1 bit immediate.
1636 case Mips::BI__builtin_msa_copy_s_d:
1637 case Mips::BI__builtin_msa_copy_u_d:
1638 case Mips::BI__builtin_msa_insve_d:
1639 case Mips::BI__builtin_msa_splati_d: i = 1; l = 0; u = 1; break;
1640 case Mips::BI__builtin_msa_sldi_d: i = 2; l = 0; u = 1; break;
1641 // Memory offsets and immediate loads.
1642 // These intrinsics take a signed 10 bit immediate.
1643 case Mips::BI__builtin_msa_ldi_b: i = 0; l = -128; u = 255; break;
1644 case Mips::BI__builtin_msa_ldi_h:
1645 case Mips::BI__builtin_msa_ldi_w:
1646 case Mips::BI__builtin_msa_ldi_d: i = 0; l = -512; u = 511; break;
1647 case Mips::BI__builtin_msa_ld_b: i = 1; l = -512; u = 511; m = 16; break;
1648 case Mips::BI__builtin_msa_ld_h: i = 1; l = -1024; u = 1022; m = 16; break;
1649 case Mips::BI__builtin_msa_ld_w: i = 1; l = -2048; u = 2044; m = 16; break;
1650 case Mips::BI__builtin_msa_ld_d: i = 1; l = -4096; u = 4088; m = 16; break;
1651 case Mips::BI__builtin_msa_st_b: i = 2; l = -512; u = 511; m = 16; break;
1652 case Mips::BI__builtin_msa_st_h: i = 2; l = -1024; u = 1022; m = 16; break;
1653 case Mips::BI__builtin_msa_st_w: i = 2; l = -2048; u = 2044; m = 16; break;
1654 case Mips::BI__builtin_msa_st_d: i = 2; l = -4096; u = 4088; m = 16; break;
1658 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
1660 return SemaBuiltinConstantArgRange(TheCall, i, l, u) ||
1661 SemaBuiltinConstantArgMultiple(TheCall, i, m);
1664 bool Sema::CheckPPCBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
1665 unsigned i = 0, l = 0, u = 0;
1666 bool Is64BitBltin = BuiltinID == PPC::BI__builtin_divde ||
1667 BuiltinID == PPC::BI__builtin_divdeu ||
1668 BuiltinID == PPC::BI__builtin_bpermd;
1669 bool IsTarget64Bit = Context.getTargetInfo()
1670 .getTypeWidth(Context
1672 .getIntPtrType()) == 64;
1673 bool IsBltinExtDiv = BuiltinID == PPC::BI__builtin_divwe ||
1674 BuiltinID == PPC::BI__builtin_divweu ||
1675 BuiltinID == PPC::BI__builtin_divde ||
1676 BuiltinID == PPC::BI__builtin_divdeu;
1678 if (Is64BitBltin && !IsTarget64Bit)
1679 return Diag(TheCall->getLocStart(), diag::err_64_bit_builtin_32_bit_tgt)
1680 << TheCall->getSourceRange();
1682 if ((IsBltinExtDiv && !Context.getTargetInfo().hasFeature("extdiv")) ||
1683 (BuiltinID == PPC::BI__builtin_bpermd &&
1684 !Context.getTargetInfo().hasFeature("bpermd")))
1685 return Diag(TheCall->getLocStart(), diag::err_ppc_builtin_only_on_pwr7)
1686 << TheCall->getSourceRange();
1688 switch (BuiltinID) {
1689 default: return false;
1690 case PPC::BI__builtin_altivec_crypto_vshasigmaw:
1691 case PPC::BI__builtin_altivec_crypto_vshasigmad:
1692 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) ||
1693 SemaBuiltinConstantArgRange(TheCall, 2, 0, 15);
1694 case PPC::BI__builtin_tbegin:
1695 case PPC::BI__builtin_tend: i = 0; l = 0; u = 1; break;
1696 case PPC::BI__builtin_tsr: i = 0; l = 0; u = 7; break;
1697 case PPC::BI__builtin_tabortwc:
1698 case PPC::BI__builtin_tabortdc: i = 0; l = 0; u = 31; break;
1699 case PPC::BI__builtin_tabortwci:
1700 case PPC::BI__builtin_tabortdci:
1701 return SemaBuiltinConstantArgRange(TheCall, 0, 0, 31) ||
1702 SemaBuiltinConstantArgRange(TheCall, 2, 0, 31);
1704 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
1707 bool Sema::CheckSystemZBuiltinFunctionCall(unsigned BuiltinID,
1708 CallExpr *TheCall) {
1709 if (BuiltinID == SystemZ::BI__builtin_tabort) {
1710 Expr *Arg = TheCall->getArg(0);
1711 llvm::APSInt AbortCode(32);
1712 if (Arg->isIntegerConstantExpr(AbortCode, Context) &&
1713 AbortCode.getSExtValue() >= 0 && AbortCode.getSExtValue() < 256)
1714 return Diag(Arg->getLocStart(), diag::err_systemz_invalid_tabort_code)
1715 << Arg->getSourceRange();
1718 // For intrinsics which take an immediate value as part of the instruction,
1719 // range check them here.
1720 unsigned i = 0, l = 0, u = 0;
1721 switch (BuiltinID) {
1722 default: return false;
1723 case SystemZ::BI__builtin_s390_lcbb: i = 1; l = 0; u = 15; break;
1724 case SystemZ::BI__builtin_s390_verimb:
1725 case SystemZ::BI__builtin_s390_verimh:
1726 case SystemZ::BI__builtin_s390_verimf:
1727 case SystemZ::BI__builtin_s390_verimg: i = 3; l = 0; u = 255; break;
1728 case SystemZ::BI__builtin_s390_vfaeb:
1729 case SystemZ::BI__builtin_s390_vfaeh:
1730 case SystemZ::BI__builtin_s390_vfaef:
1731 case SystemZ::BI__builtin_s390_vfaebs:
1732 case SystemZ::BI__builtin_s390_vfaehs:
1733 case SystemZ::BI__builtin_s390_vfaefs:
1734 case SystemZ::BI__builtin_s390_vfaezb:
1735 case SystemZ::BI__builtin_s390_vfaezh:
1736 case SystemZ::BI__builtin_s390_vfaezf:
1737 case SystemZ::BI__builtin_s390_vfaezbs:
1738 case SystemZ::BI__builtin_s390_vfaezhs:
1739 case SystemZ::BI__builtin_s390_vfaezfs: i = 2; l = 0; u = 15; break;
1740 case SystemZ::BI__builtin_s390_vfidb:
1741 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 15) ||
1742 SemaBuiltinConstantArgRange(TheCall, 2, 0, 15);
1743 case SystemZ::BI__builtin_s390_vftcidb: i = 1; l = 0; u = 4095; break;
1744 case SystemZ::BI__builtin_s390_vlbb: i = 1; l = 0; u = 15; break;
1745 case SystemZ::BI__builtin_s390_vpdi: i = 2; l = 0; u = 15; break;
1746 case SystemZ::BI__builtin_s390_vsldb: i = 2; l = 0; u = 15; break;
1747 case SystemZ::BI__builtin_s390_vstrcb:
1748 case SystemZ::BI__builtin_s390_vstrch:
1749 case SystemZ::BI__builtin_s390_vstrcf:
1750 case SystemZ::BI__builtin_s390_vstrczb:
1751 case SystemZ::BI__builtin_s390_vstrczh:
1752 case SystemZ::BI__builtin_s390_vstrczf:
1753 case SystemZ::BI__builtin_s390_vstrcbs:
1754 case SystemZ::BI__builtin_s390_vstrchs:
1755 case SystemZ::BI__builtin_s390_vstrcfs:
1756 case SystemZ::BI__builtin_s390_vstrczbs:
1757 case SystemZ::BI__builtin_s390_vstrczhs:
1758 case SystemZ::BI__builtin_s390_vstrczfs: i = 3; l = 0; u = 15; break;
1760 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
1763 /// SemaBuiltinCpuSupports - Handle __builtin_cpu_supports(char *).
1764 /// This checks that the target supports __builtin_cpu_supports and
1765 /// that the string argument is constant and valid.
1766 static bool SemaBuiltinCpuSupports(Sema &S, CallExpr *TheCall) {
1767 Expr *Arg = TheCall->getArg(0);
1769 // Check if the argument is a string literal.
1770 if (!isa<StringLiteral>(Arg->IgnoreParenImpCasts()))
1771 return S.Diag(TheCall->getLocStart(), diag::err_expr_not_string_literal)
1772 << Arg->getSourceRange();
1774 // Check the contents of the string.
1776 cast<StringLiteral>(Arg->IgnoreParenImpCasts())->getString();
1777 if (!S.Context.getTargetInfo().validateCpuSupports(Feature))
1778 return S.Diag(TheCall->getLocStart(), diag::err_invalid_cpu_supports)
1779 << Arg->getSourceRange();
1783 // Check if the rounding mode is legal.
1784 bool Sema::CheckX86BuiltinRoundingOrSAE(unsigned BuiltinID, CallExpr *TheCall) {
1785 // Indicates if this instruction has rounding control or just SAE.
1788 unsigned ArgNum = 0;
1789 switch (BuiltinID) {
1792 case X86::BI__builtin_ia32_vcvttsd2si32:
1793 case X86::BI__builtin_ia32_vcvttsd2si64:
1794 case X86::BI__builtin_ia32_vcvttsd2usi32:
1795 case X86::BI__builtin_ia32_vcvttsd2usi64:
1796 case X86::BI__builtin_ia32_vcvttss2si32:
1797 case X86::BI__builtin_ia32_vcvttss2si64:
1798 case X86::BI__builtin_ia32_vcvttss2usi32:
1799 case X86::BI__builtin_ia32_vcvttss2usi64:
1802 case X86::BI__builtin_ia32_cvtps2pd512_mask:
1803 case X86::BI__builtin_ia32_cvttpd2dq512_mask:
1804 case X86::BI__builtin_ia32_cvttpd2qq512_mask:
1805 case X86::BI__builtin_ia32_cvttpd2udq512_mask:
1806 case X86::BI__builtin_ia32_cvttpd2uqq512_mask:
1807 case X86::BI__builtin_ia32_cvttps2dq512_mask:
1808 case X86::BI__builtin_ia32_cvttps2qq512_mask:
1809 case X86::BI__builtin_ia32_cvttps2udq512_mask:
1810 case X86::BI__builtin_ia32_cvttps2uqq512_mask:
1811 case X86::BI__builtin_ia32_exp2pd_mask:
1812 case X86::BI__builtin_ia32_exp2ps_mask:
1813 case X86::BI__builtin_ia32_getexppd512_mask:
1814 case X86::BI__builtin_ia32_getexpps512_mask:
1815 case X86::BI__builtin_ia32_rcp28pd_mask:
1816 case X86::BI__builtin_ia32_rcp28ps_mask:
1817 case X86::BI__builtin_ia32_rsqrt28pd_mask:
1818 case X86::BI__builtin_ia32_rsqrt28ps_mask:
1819 case X86::BI__builtin_ia32_vcomisd:
1820 case X86::BI__builtin_ia32_vcomiss:
1821 case X86::BI__builtin_ia32_vcvtph2ps512_mask:
1824 case X86::BI__builtin_ia32_cmppd512_mask:
1825 case X86::BI__builtin_ia32_cmpps512_mask:
1826 case X86::BI__builtin_ia32_cmpsd_mask:
1827 case X86::BI__builtin_ia32_cmpss_mask:
1828 case X86::BI__builtin_ia32_cvtss2sd_round_mask:
1829 case X86::BI__builtin_ia32_getexpsd128_round_mask:
1830 case X86::BI__builtin_ia32_getexpss128_round_mask:
1831 case X86::BI__builtin_ia32_maxpd512_mask:
1832 case X86::BI__builtin_ia32_maxps512_mask:
1833 case X86::BI__builtin_ia32_maxsd_round_mask:
1834 case X86::BI__builtin_ia32_maxss_round_mask:
1835 case X86::BI__builtin_ia32_minpd512_mask:
1836 case X86::BI__builtin_ia32_minps512_mask:
1837 case X86::BI__builtin_ia32_minsd_round_mask:
1838 case X86::BI__builtin_ia32_minss_round_mask:
1839 case X86::BI__builtin_ia32_rcp28sd_round_mask:
1840 case X86::BI__builtin_ia32_rcp28ss_round_mask:
1841 case X86::BI__builtin_ia32_reducepd512_mask:
1842 case X86::BI__builtin_ia32_reduceps512_mask:
1843 case X86::BI__builtin_ia32_rndscalepd_mask:
1844 case X86::BI__builtin_ia32_rndscaleps_mask:
1845 case X86::BI__builtin_ia32_rsqrt28sd_round_mask:
1846 case X86::BI__builtin_ia32_rsqrt28ss_round_mask:
1849 case X86::BI__builtin_ia32_fixupimmpd512_mask:
1850 case X86::BI__builtin_ia32_fixupimmpd512_maskz:
1851 case X86::BI__builtin_ia32_fixupimmps512_mask:
1852 case X86::BI__builtin_ia32_fixupimmps512_maskz:
1853 case X86::BI__builtin_ia32_fixupimmsd_mask:
1854 case X86::BI__builtin_ia32_fixupimmsd_maskz:
1855 case X86::BI__builtin_ia32_fixupimmss_mask:
1856 case X86::BI__builtin_ia32_fixupimmss_maskz:
1857 case X86::BI__builtin_ia32_rangepd512_mask:
1858 case X86::BI__builtin_ia32_rangeps512_mask:
1859 case X86::BI__builtin_ia32_rangesd128_round_mask:
1860 case X86::BI__builtin_ia32_rangess128_round_mask:
1861 case X86::BI__builtin_ia32_reducesd_mask:
1862 case X86::BI__builtin_ia32_reducess_mask:
1863 case X86::BI__builtin_ia32_rndscalesd_round_mask:
1864 case X86::BI__builtin_ia32_rndscaless_round_mask:
1867 case X86::BI__builtin_ia32_vcvtsd2si64:
1868 case X86::BI__builtin_ia32_vcvtsd2si32:
1869 case X86::BI__builtin_ia32_vcvtsd2usi32:
1870 case X86::BI__builtin_ia32_vcvtsd2usi64:
1871 case X86::BI__builtin_ia32_vcvtss2si32:
1872 case X86::BI__builtin_ia32_vcvtss2si64:
1873 case X86::BI__builtin_ia32_vcvtss2usi32:
1874 case X86::BI__builtin_ia32_vcvtss2usi64:
1878 case X86::BI__builtin_ia32_cvtsi2sd64:
1879 case X86::BI__builtin_ia32_cvtsi2ss32:
1880 case X86::BI__builtin_ia32_cvtsi2ss64:
1881 case X86::BI__builtin_ia32_cvtusi2sd64:
1882 case X86::BI__builtin_ia32_cvtusi2ss32:
1883 case X86::BI__builtin_ia32_cvtusi2ss64:
1887 case X86::BI__builtin_ia32_cvtdq2ps512_mask:
1888 case X86::BI__builtin_ia32_cvtudq2ps512_mask:
1889 case X86::BI__builtin_ia32_cvtpd2ps512_mask:
1890 case X86::BI__builtin_ia32_cvtpd2qq512_mask:
1891 case X86::BI__builtin_ia32_cvtpd2uqq512_mask:
1892 case X86::BI__builtin_ia32_cvtps2qq512_mask:
1893 case X86::BI__builtin_ia32_cvtps2uqq512_mask:
1894 case X86::BI__builtin_ia32_cvtqq2pd512_mask:
1895 case X86::BI__builtin_ia32_cvtqq2ps512_mask:
1896 case X86::BI__builtin_ia32_cvtuqq2pd512_mask:
1897 case X86::BI__builtin_ia32_cvtuqq2ps512_mask:
1898 case X86::BI__builtin_ia32_sqrtpd512_mask:
1899 case X86::BI__builtin_ia32_sqrtps512_mask:
1903 case X86::BI__builtin_ia32_addpd512_mask:
1904 case X86::BI__builtin_ia32_addps512_mask:
1905 case X86::BI__builtin_ia32_divpd512_mask:
1906 case X86::BI__builtin_ia32_divps512_mask:
1907 case X86::BI__builtin_ia32_mulpd512_mask:
1908 case X86::BI__builtin_ia32_mulps512_mask:
1909 case X86::BI__builtin_ia32_subpd512_mask:
1910 case X86::BI__builtin_ia32_subps512_mask:
1911 case X86::BI__builtin_ia32_addss_round_mask:
1912 case X86::BI__builtin_ia32_addsd_round_mask:
1913 case X86::BI__builtin_ia32_divss_round_mask:
1914 case X86::BI__builtin_ia32_divsd_round_mask:
1915 case X86::BI__builtin_ia32_mulss_round_mask:
1916 case X86::BI__builtin_ia32_mulsd_round_mask:
1917 case X86::BI__builtin_ia32_subss_round_mask:
1918 case X86::BI__builtin_ia32_subsd_round_mask:
1919 case X86::BI__builtin_ia32_scalefpd512_mask:
1920 case X86::BI__builtin_ia32_scalefps512_mask:
1921 case X86::BI__builtin_ia32_scalefsd_round_mask:
1922 case X86::BI__builtin_ia32_scalefss_round_mask:
1923 case X86::BI__builtin_ia32_getmantpd512_mask:
1924 case X86::BI__builtin_ia32_getmantps512_mask:
1925 case X86::BI__builtin_ia32_cvtsd2ss_round_mask:
1926 case X86::BI__builtin_ia32_sqrtsd_round_mask:
1927 case X86::BI__builtin_ia32_sqrtss_round_mask:
1928 case X86::BI__builtin_ia32_vfmaddpd512_mask:
1929 case X86::BI__builtin_ia32_vfmaddpd512_mask3:
1930 case X86::BI__builtin_ia32_vfmaddpd512_maskz:
1931 case X86::BI__builtin_ia32_vfmaddps512_mask:
1932 case X86::BI__builtin_ia32_vfmaddps512_mask3:
1933 case X86::BI__builtin_ia32_vfmaddps512_maskz:
1934 case X86::BI__builtin_ia32_vfmaddsubpd512_mask:
1935 case X86::BI__builtin_ia32_vfmaddsubpd512_mask3:
1936 case X86::BI__builtin_ia32_vfmaddsubpd512_maskz:
1937 case X86::BI__builtin_ia32_vfmaddsubps512_mask:
1938 case X86::BI__builtin_ia32_vfmaddsubps512_mask3:
1939 case X86::BI__builtin_ia32_vfmaddsubps512_maskz:
1940 case X86::BI__builtin_ia32_vfmsubpd512_mask3:
1941 case X86::BI__builtin_ia32_vfmsubps512_mask3:
1942 case X86::BI__builtin_ia32_vfmsubaddpd512_mask3:
1943 case X86::BI__builtin_ia32_vfmsubaddps512_mask3:
1944 case X86::BI__builtin_ia32_vfnmaddpd512_mask:
1945 case X86::BI__builtin_ia32_vfnmaddps512_mask:
1946 case X86::BI__builtin_ia32_vfnmsubpd512_mask:
1947 case X86::BI__builtin_ia32_vfnmsubpd512_mask3:
1948 case X86::BI__builtin_ia32_vfnmsubps512_mask:
1949 case X86::BI__builtin_ia32_vfnmsubps512_mask3:
1950 case X86::BI__builtin_ia32_vfmaddsd3_mask:
1951 case X86::BI__builtin_ia32_vfmaddsd3_maskz:
1952 case X86::BI__builtin_ia32_vfmaddsd3_mask3:
1953 case X86::BI__builtin_ia32_vfmaddss3_mask:
1954 case X86::BI__builtin_ia32_vfmaddss3_maskz:
1955 case X86::BI__builtin_ia32_vfmaddss3_mask3:
1959 case X86::BI__builtin_ia32_getmantsd_round_mask:
1960 case X86::BI__builtin_ia32_getmantss_round_mask:
1966 llvm::APSInt Result;
1968 // We can't check the value of a dependent argument.
1969 Expr *Arg = TheCall->getArg(ArgNum);
1970 if (Arg->isTypeDependent() || Arg->isValueDependent())
1973 // Check constant-ness first.
1974 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result))
1977 // Make sure rounding mode is either ROUND_CUR_DIRECTION or ROUND_NO_EXC bit
1978 // is set. If the intrinsic has rounding control(bits 1:0), make sure its only
1979 // combined with ROUND_NO_EXC.
1980 if (Result == 4/*ROUND_CUR_DIRECTION*/ ||
1981 Result == 8/*ROUND_NO_EXC*/ ||
1982 (HasRC && Result.getZExtValue() >= 8 && Result.getZExtValue() <= 11))
1985 return Diag(TheCall->getLocStart(), diag::err_x86_builtin_invalid_rounding)
1986 << Arg->getSourceRange();
1989 // Check if the gather/scatter scale is legal.
1990 bool Sema::CheckX86BuiltinGatherScatterScale(unsigned BuiltinID,
1991 CallExpr *TheCall) {
1992 unsigned ArgNum = 0;
1993 switch (BuiltinID) {
1996 case X86::BI__builtin_ia32_gatherpfdpd:
1997 case X86::BI__builtin_ia32_gatherpfdps:
1998 case X86::BI__builtin_ia32_gatherpfqpd:
1999 case X86::BI__builtin_ia32_gatherpfqps:
2000 case X86::BI__builtin_ia32_scatterpfdpd:
2001 case X86::BI__builtin_ia32_scatterpfdps:
2002 case X86::BI__builtin_ia32_scatterpfqpd:
2003 case X86::BI__builtin_ia32_scatterpfqps:
2006 case X86::BI__builtin_ia32_gatherd_pd:
2007 case X86::BI__builtin_ia32_gatherd_pd256:
2008 case X86::BI__builtin_ia32_gatherq_pd:
2009 case X86::BI__builtin_ia32_gatherq_pd256:
2010 case X86::BI__builtin_ia32_gatherd_ps:
2011 case X86::BI__builtin_ia32_gatherd_ps256:
2012 case X86::BI__builtin_ia32_gatherq_ps:
2013 case X86::BI__builtin_ia32_gatherq_ps256:
2014 case X86::BI__builtin_ia32_gatherd_q:
2015 case X86::BI__builtin_ia32_gatherd_q256:
2016 case X86::BI__builtin_ia32_gatherq_q:
2017 case X86::BI__builtin_ia32_gatherq_q256:
2018 case X86::BI__builtin_ia32_gatherd_d:
2019 case X86::BI__builtin_ia32_gatherd_d256:
2020 case X86::BI__builtin_ia32_gatherq_d:
2021 case X86::BI__builtin_ia32_gatherq_d256:
2022 case X86::BI__builtin_ia32_gather3div2df:
2023 case X86::BI__builtin_ia32_gather3div2di:
2024 case X86::BI__builtin_ia32_gather3div4df:
2025 case X86::BI__builtin_ia32_gather3div4di:
2026 case X86::BI__builtin_ia32_gather3div4sf:
2027 case X86::BI__builtin_ia32_gather3div4si:
2028 case X86::BI__builtin_ia32_gather3div8sf:
2029 case X86::BI__builtin_ia32_gather3div8si:
2030 case X86::BI__builtin_ia32_gather3siv2df:
2031 case X86::BI__builtin_ia32_gather3siv2di:
2032 case X86::BI__builtin_ia32_gather3siv4df:
2033 case X86::BI__builtin_ia32_gather3siv4di:
2034 case X86::BI__builtin_ia32_gather3siv4sf:
2035 case X86::BI__builtin_ia32_gather3siv4si:
2036 case X86::BI__builtin_ia32_gather3siv8sf:
2037 case X86::BI__builtin_ia32_gather3siv8si:
2038 case X86::BI__builtin_ia32_gathersiv8df:
2039 case X86::BI__builtin_ia32_gathersiv16sf:
2040 case X86::BI__builtin_ia32_gatherdiv8df:
2041 case X86::BI__builtin_ia32_gatherdiv16sf:
2042 case X86::BI__builtin_ia32_gathersiv8di:
2043 case X86::BI__builtin_ia32_gathersiv16si:
2044 case X86::BI__builtin_ia32_gatherdiv8di:
2045 case X86::BI__builtin_ia32_gatherdiv16si:
2046 case X86::BI__builtin_ia32_scatterdiv2df:
2047 case X86::BI__builtin_ia32_scatterdiv2di:
2048 case X86::BI__builtin_ia32_scatterdiv4df:
2049 case X86::BI__builtin_ia32_scatterdiv4di:
2050 case X86::BI__builtin_ia32_scatterdiv4sf:
2051 case X86::BI__builtin_ia32_scatterdiv4si:
2052 case X86::BI__builtin_ia32_scatterdiv8sf:
2053 case X86::BI__builtin_ia32_scatterdiv8si:
2054 case X86::BI__builtin_ia32_scattersiv2df:
2055 case X86::BI__builtin_ia32_scattersiv2di:
2056 case X86::BI__builtin_ia32_scattersiv4df:
2057 case X86::BI__builtin_ia32_scattersiv4di:
2058 case X86::BI__builtin_ia32_scattersiv4sf:
2059 case X86::BI__builtin_ia32_scattersiv4si:
2060 case X86::BI__builtin_ia32_scattersiv8sf:
2061 case X86::BI__builtin_ia32_scattersiv8si:
2062 case X86::BI__builtin_ia32_scattersiv8df:
2063 case X86::BI__builtin_ia32_scattersiv16sf:
2064 case X86::BI__builtin_ia32_scatterdiv8df:
2065 case X86::BI__builtin_ia32_scatterdiv16sf:
2066 case X86::BI__builtin_ia32_scattersiv8di:
2067 case X86::BI__builtin_ia32_scattersiv16si:
2068 case X86::BI__builtin_ia32_scatterdiv8di:
2069 case X86::BI__builtin_ia32_scatterdiv16si:
2074 llvm::APSInt Result;
2076 // We can't check the value of a dependent argument.
2077 Expr *Arg = TheCall->getArg(ArgNum);
2078 if (Arg->isTypeDependent() || Arg->isValueDependent())
2081 // Check constant-ness first.
2082 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result))
2085 if (Result == 1 || Result == 2 || Result == 4 || Result == 8)
2088 return Diag(TheCall->getLocStart(), diag::err_x86_builtin_invalid_scale)
2089 << Arg->getSourceRange();
2092 bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
2093 if (BuiltinID == X86::BI__builtin_cpu_supports)
2094 return SemaBuiltinCpuSupports(*this, TheCall);
2096 if (BuiltinID == X86::BI__builtin_ms_va_start)
2097 return SemaBuiltinMSVAStart(TheCall);
2099 // If the intrinsic has rounding or SAE make sure its valid.
2100 if (CheckX86BuiltinRoundingOrSAE(BuiltinID, TheCall))
2103 // If the intrinsic has a gather/scatter scale immediate make sure its valid.
2104 if (CheckX86BuiltinGatherScatterScale(BuiltinID, TheCall))
2107 // For intrinsics which take an immediate value as part of the instruction,
2108 // range check them here.
2109 int i = 0, l = 0, u = 0;
2110 switch (BuiltinID) {
2113 case X86::BI_mm_prefetch:
2114 i = 1; l = 0; u = 3;
2116 case X86::BI__builtin_ia32_sha1rnds4:
2117 case X86::BI__builtin_ia32_shuf_f32x4_256_mask:
2118 case X86::BI__builtin_ia32_shuf_f64x2_256_mask:
2119 case X86::BI__builtin_ia32_shuf_i32x4_256_mask:
2120 case X86::BI__builtin_ia32_shuf_i64x2_256_mask:
2121 i = 2; l = 0; u = 3;
2123 case X86::BI__builtin_ia32_vpermil2pd:
2124 case X86::BI__builtin_ia32_vpermil2pd256:
2125 case X86::BI__builtin_ia32_vpermil2ps:
2126 case X86::BI__builtin_ia32_vpermil2ps256:
2127 i = 3; l = 0; u = 3;
2129 case X86::BI__builtin_ia32_cmpb128_mask:
2130 case X86::BI__builtin_ia32_cmpw128_mask:
2131 case X86::BI__builtin_ia32_cmpd128_mask:
2132 case X86::BI__builtin_ia32_cmpq128_mask:
2133 case X86::BI__builtin_ia32_cmpb256_mask:
2134 case X86::BI__builtin_ia32_cmpw256_mask:
2135 case X86::BI__builtin_ia32_cmpd256_mask:
2136 case X86::BI__builtin_ia32_cmpq256_mask:
2137 case X86::BI__builtin_ia32_cmpb512_mask:
2138 case X86::BI__builtin_ia32_cmpw512_mask:
2139 case X86::BI__builtin_ia32_cmpd512_mask:
2140 case X86::BI__builtin_ia32_cmpq512_mask:
2141 case X86::BI__builtin_ia32_ucmpb128_mask:
2142 case X86::BI__builtin_ia32_ucmpw128_mask:
2143 case X86::BI__builtin_ia32_ucmpd128_mask:
2144 case X86::BI__builtin_ia32_ucmpq128_mask:
2145 case X86::BI__builtin_ia32_ucmpb256_mask:
2146 case X86::BI__builtin_ia32_ucmpw256_mask:
2147 case X86::BI__builtin_ia32_ucmpd256_mask:
2148 case X86::BI__builtin_ia32_ucmpq256_mask:
2149 case X86::BI__builtin_ia32_ucmpb512_mask:
2150 case X86::BI__builtin_ia32_ucmpw512_mask:
2151 case X86::BI__builtin_ia32_ucmpd512_mask:
2152 case X86::BI__builtin_ia32_ucmpq512_mask:
2153 case X86::BI__builtin_ia32_vpcomub:
2154 case X86::BI__builtin_ia32_vpcomuw:
2155 case X86::BI__builtin_ia32_vpcomud:
2156 case X86::BI__builtin_ia32_vpcomuq:
2157 case X86::BI__builtin_ia32_vpcomb:
2158 case X86::BI__builtin_ia32_vpcomw:
2159 case X86::BI__builtin_ia32_vpcomd:
2160 case X86::BI__builtin_ia32_vpcomq:
2161 i = 2; l = 0; u = 7;
2163 case X86::BI__builtin_ia32_roundps:
2164 case X86::BI__builtin_ia32_roundpd:
2165 case X86::BI__builtin_ia32_roundps256:
2166 case X86::BI__builtin_ia32_roundpd256:
2167 i = 1; l = 0; u = 15;
2169 case X86::BI__builtin_ia32_roundss:
2170 case X86::BI__builtin_ia32_roundsd:
2171 case X86::BI__builtin_ia32_rangepd128_mask:
2172 case X86::BI__builtin_ia32_rangepd256_mask:
2173 case X86::BI__builtin_ia32_rangepd512_mask:
2174 case X86::BI__builtin_ia32_rangeps128_mask:
2175 case X86::BI__builtin_ia32_rangeps256_mask:
2176 case X86::BI__builtin_ia32_rangeps512_mask:
2177 case X86::BI__builtin_ia32_getmantsd_round_mask:
2178 case X86::BI__builtin_ia32_getmantss_round_mask:
2179 i = 2; l = 0; u = 15;
2181 case X86::BI__builtin_ia32_cmpps:
2182 case X86::BI__builtin_ia32_cmpss:
2183 case X86::BI__builtin_ia32_cmppd:
2184 case X86::BI__builtin_ia32_cmpsd:
2185 case X86::BI__builtin_ia32_cmpps256:
2186 case X86::BI__builtin_ia32_cmppd256:
2187 case X86::BI__builtin_ia32_cmpps128_mask:
2188 case X86::BI__builtin_ia32_cmppd128_mask:
2189 case X86::BI__builtin_ia32_cmpps256_mask:
2190 case X86::BI__builtin_ia32_cmppd256_mask:
2191 case X86::BI__builtin_ia32_cmpps512_mask:
2192 case X86::BI__builtin_ia32_cmppd512_mask:
2193 case X86::BI__builtin_ia32_cmpsd_mask:
2194 case X86::BI__builtin_ia32_cmpss_mask:
2195 i = 2; l = 0; u = 31;
2197 case X86::BI__builtin_ia32_xabort:
2198 i = 0; l = -128; u = 255;
2200 case X86::BI__builtin_ia32_pshufw:
2201 case X86::BI__builtin_ia32_aeskeygenassist128:
2202 i = 1; l = -128; u = 255;
2204 case X86::BI__builtin_ia32_vcvtps2ph:
2205 case X86::BI__builtin_ia32_vcvtps2ph256:
2206 case X86::BI__builtin_ia32_rndscaleps_128_mask:
2207 case X86::BI__builtin_ia32_rndscalepd_128_mask:
2208 case X86::BI__builtin_ia32_rndscaleps_256_mask:
2209 case X86::BI__builtin_ia32_rndscalepd_256_mask:
2210 case X86::BI__builtin_ia32_rndscaleps_mask:
2211 case X86::BI__builtin_ia32_rndscalepd_mask:
2212 case X86::BI__builtin_ia32_reducepd128_mask:
2213 case X86::BI__builtin_ia32_reducepd256_mask:
2214 case X86::BI__builtin_ia32_reducepd512_mask:
2215 case X86::BI__builtin_ia32_reduceps128_mask:
2216 case X86::BI__builtin_ia32_reduceps256_mask:
2217 case X86::BI__builtin_ia32_reduceps512_mask:
2218 case X86::BI__builtin_ia32_prold512_mask:
2219 case X86::BI__builtin_ia32_prolq512_mask:
2220 case X86::BI__builtin_ia32_prold128_mask:
2221 case X86::BI__builtin_ia32_prold256_mask:
2222 case X86::BI__builtin_ia32_prolq128_mask:
2223 case X86::BI__builtin_ia32_prolq256_mask:
2224 case X86::BI__builtin_ia32_prord128_mask:
2225 case X86::BI__builtin_ia32_prord256_mask:
2226 case X86::BI__builtin_ia32_prorq128_mask:
2227 case X86::BI__builtin_ia32_prorq256_mask:
2228 case X86::BI__builtin_ia32_fpclasspd128_mask:
2229 case X86::BI__builtin_ia32_fpclasspd256_mask:
2230 case X86::BI__builtin_ia32_fpclassps128_mask:
2231 case X86::BI__builtin_ia32_fpclassps256_mask:
2232 case X86::BI__builtin_ia32_fpclassps512_mask:
2233 case X86::BI__builtin_ia32_fpclasspd512_mask:
2234 case X86::BI__builtin_ia32_fpclasssd_mask:
2235 case X86::BI__builtin_ia32_fpclassss_mask:
2236 i = 1; l = 0; u = 255;
2238 case X86::BI__builtin_ia32_palignr:
2239 case X86::BI__builtin_ia32_insertps128:
2240 case X86::BI__builtin_ia32_dpps:
2241 case X86::BI__builtin_ia32_dppd:
2242 case X86::BI__builtin_ia32_dpps256:
2243 case X86::BI__builtin_ia32_mpsadbw128:
2244 case X86::BI__builtin_ia32_mpsadbw256:
2245 case X86::BI__builtin_ia32_pcmpistrm128:
2246 case X86::BI__builtin_ia32_pcmpistri128:
2247 case X86::BI__builtin_ia32_pcmpistria128:
2248 case X86::BI__builtin_ia32_pcmpistric128:
2249 case X86::BI__builtin_ia32_pcmpistrio128:
2250 case X86::BI__builtin_ia32_pcmpistris128:
2251 case X86::BI__builtin_ia32_pcmpistriz128:
2252 case X86::BI__builtin_ia32_pclmulqdq128:
2253 case X86::BI__builtin_ia32_vperm2f128_pd256:
2254 case X86::BI__builtin_ia32_vperm2f128_ps256:
2255 case X86::BI__builtin_ia32_vperm2f128_si256:
2256 case X86::BI__builtin_ia32_permti256:
2257 i = 2; l = -128; u = 255;
2259 case X86::BI__builtin_ia32_palignr128:
2260 case X86::BI__builtin_ia32_palignr256:
2261 case X86::BI__builtin_ia32_palignr512_mask:
2262 case X86::BI__builtin_ia32_vcomisd:
2263 case X86::BI__builtin_ia32_vcomiss:
2264 case X86::BI__builtin_ia32_shuf_f32x4_mask:
2265 case X86::BI__builtin_ia32_shuf_f64x2_mask:
2266 case X86::BI__builtin_ia32_shuf_i32x4_mask:
2267 case X86::BI__builtin_ia32_shuf_i64x2_mask:
2268 case X86::BI__builtin_ia32_dbpsadbw128_mask:
2269 case X86::BI__builtin_ia32_dbpsadbw256_mask:
2270 case X86::BI__builtin_ia32_dbpsadbw512_mask:
2271 i = 2; l = 0; u = 255;
2273 case X86::BI__builtin_ia32_fixupimmpd512_mask:
2274 case X86::BI__builtin_ia32_fixupimmpd512_maskz:
2275 case X86::BI__builtin_ia32_fixupimmps512_mask:
2276 case X86::BI__builtin_ia32_fixupimmps512_maskz:
2277 case X86::BI__builtin_ia32_fixupimmsd_mask:
2278 case X86::BI__builtin_ia32_fixupimmsd_maskz:
2279 case X86::BI__builtin_ia32_fixupimmss_mask:
2280 case X86::BI__builtin_ia32_fixupimmss_maskz:
2281 case X86::BI__builtin_ia32_fixupimmpd128_mask:
2282 case X86::BI__builtin_ia32_fixupimmpd128_maskz:
2283 case X86::BI__builtin_ia32_fixupimmpd256_mask:
2284 case X86::BI__builtin_ia32_fixupimmpd256_maskz:
2285 case X86::BI__builtin_ia32_fixupimmps128_mask:
2286 case X86::BI__builtin_ia32_fixupimmps128_maskz:
2287 case X86::BI__builtin_ia32_fixupimmps256_mask:
2288 case X86::BI__builtin_ia32_fixupimmps256_maskz:
2289 case X86::BI__builtin_ia32_pternlogd512_mask:
2290 case X86::BI__builtin_ia32_pternlogd512_maskz:
2291 case X86::BI__builtin_ia32_pternlogq512_mask:
2292 case X86::BI__builtin_ia32_pternlogq512_maskz:
2293 case X86::BI__builtin_ia32_pternlogd128_mask:
2294 case X86::BI__builtin_ia32_pternlogd128_maskz:
2295 case X86::BI__builtin_ia32_pternlogd256_mask:
2296 case X86::BI__builtin_ia32_pternlogd256_maskz:
2297 case X86::BI__builtin_ia32_pternlogq128_mask:
2298 case X86::BI__builtin_ia32_pternlogq128_maskz:
2299 case X86::BI__builtin_ia32_pternlogq256_mask:
2300 case X86::BI__builtin_ia32_pternlogq256_maskz:
2301 i = 3; l = 0; u = 255;
2303 case X86::BI__builtin_ia32_gatherpfdpd:
2304 case X86::BI__builtin_ia32_gatherpfdps:
2305 case X86::BI__builtin_ia32_gatherpfqpd:
2306 case X86::BI__builtin_ia32_gatherpfqps:
2307 case X86::BI__builtin_ia32_scatterpfdpd:
2308 case X86::BI__builtin_ia32_scatterpfdps:
2309 case X86::BI__builtin_ia32_scatterpfqpd:
2310 case X86::BI__builtin_ia32_scatterpfqps:
2311 i = 4; l = 2; u = 3;
2313 case X86::BI__builtin_ia32_pcmpestrm128:
2314 case X86::BI__builtin_ia32_pcmpestri128:
2315 case X86::BI__builtin_ia32_pcmpestria128:
2316 case X86::BI__builtin_ia32_pcmpestric128:
2317 case X86::BI__builtin_ia32_pcmpestrio128:
2318 case X86::BI__builtin_ia32_pcmpestris128:
2319 case X86::BI__builtin_ia32_pcmpestriz128:
2320 i = 4; l = -128; u = 255;
2322 case X86::BI__builtin_ia32_rndscalesd_round_mask:
2323 case X86::BI__builtin_ia32_rndscaless_round_mask:
2324 i = 4; l = 0; u = 255;
2327 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
2330 /// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
2331 /// parameter with the FormatAttr's correct format_idx and firstDataArg.
2332 /// Returns true when the format fits the function and the FormatStringInfo has
2334 bool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
2335 FormatStringInfo *FSI) {
2336 FSI->HasVAListArg = Format->getFirstArg() == 0;
2337 FSI->FormatIdx = Format->getFormatIdx() - 1;
2338 FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
2340 // The way the format attribute works in GCC, the implicit this argument
2341 // of member functions is counted. However, it doesn't appear in our own
2342 // lists, so decrement format_idx in that case.
2344 if(FSI->FormatIdx == 0)
2347 if (FSI->FirstDataArg != 0)
2348 --FSI->FirstDataArg;
2353 /// Checks if a the given expression evaluates to null.
2355 /// \brief Returns true if the value evaluates to null.
2356 static bool CheckNonNullExpr(Sema &S, const Expr *Expr) {
2357 // If the expression has non-null type, it doesn't evaluate to null.
2358 if (auto nullability
2359 = Expr->IgnoreImplicit()->getType()->getNullability(S.Context)) {
2360 if (*nullability == NullabilityKind::NonNull)
2364 // As a special case, transparent unions initialized with zero are
2365 // considered null for the purposes of the nonnull attribute.
2366 if (const RecordType *UT = Expr->getType()->getAsUnionType()) {
2367 if (UT->getDecl()->hasAttr<TransparentUnionAttr>())
2368 if (const CompoundLiteralExpr *CLE =
2369 dyn_cast<CompoundLiteralExpr>(Expr))
2370 if (const InitListExpr *ILE =
2371 dyn_cast<InitListExpr>(CLE->getInitializer()))
2372 Expr = ILE->getInit(0);
2376 return (!Expr->isValueDependent() &&
2377 Expr->EvaluateAsBooleanCondition(Result, S.Context) &&
2381 static void CheckNonNullArgument(Sema &S,
2382 const Expr *ArgExpr,
2383 SourceLocation CallSiteLoc) {
2384 if (CheckNonNullExpr(S, ArgExpr))
2385 S.DiagRuntimeBehavior(CallSiteLoc, ArgExpr,
2386 S.PDiag(diag::warn_null_arg) << ArgExpr->getSourceRange());
2389 bool Sema::GetFormatNSStringIdx(const FormatAttr *Format, unsigned &Idx) {
2390 FormatStringInfo FSI;
2391 if ((GetFormatStringType(Format) == FST_NSString) &&
2392 getFormatStringInfo(Format, false, &FSI)) {
2393 Idx = FSI.FormatIdx;
2398 /// \brief Diagnose use of %s directive in an NSString which is being passed
2399 /// as formatting string to formatting method.
2401 DiagnoseCStringFormatDirectiveInCFAPI(Sema &S,
2402 const NamedDecl *FDecl,
2406 bool Format = false;
2407 ObjCStringFormatFamily SFFamily = FDecl->getObjCFStringFormattingFamily();
2408 if (SFFamily == ObjCStringFormatFamily::SFF_CFString) {
2413 for (const auto *I : FDecl->specific_attrs<FormatAttr>()) {
2414 if (S.GetFormatNSStringIdx(I, Idx)) {
2419 if (!Format || NumArgs <= Idx)
2421 const Expr *FormatExpr = Args[Idx];
2422 if (const CStyleCastExpr *CSCE = dyn_cast<CStyleCastExpr>(FormatExpr))
2423 FormatExpr = CSCE->getSubExpr();
2424 const StringLiteral *FormatString;
2425 if (const ObjCStringLiteral *OSL =
2426 dyn_cast<ObjCStringLiteral>(FormatExpr->IgnoreParenImpCasts()))
2427 FormatString = OSL->getString();
2429 FormatString = dyn_cast<StringLiteral>(FormatExpr->IgnoreParenImpCasts());
2432 if (S.FormatStringHasSArg(FormatString)) {
2433 S.Diag(FormatExpr->getExprLoc(), diag::warn_objc_cdirective_format_string)
2435 S.Diag(FDecl->getLocation(), diag::note_entity_declared_at)
2436 << FDecl->getDeclName();
2440 /// Determine whether the given type has a non-null nullability annotation.
2441 static bool isNonNullType(ASTContext &ctx, QualType type) {
2442 if (auto nullability = type->getNullability(ctx))
2443 return *nullability == NullabilityKind::NonNull;
2448 static void CheckNonNullArguments(Sema &S,
2449 const NamedDecl *FDecl,
2450 const FunctionProtoType *Proto,
2451 ArrayRef<const Expr *> Args,
2452 SourceLocation CallSiteLoc) {
2453 assert((FDecl || Proto) && "Need a function declaration or prototype");
2455 // Check the attributes attached to the method/function itself.
2456 llvm::SmallBitVector NonNullArgs;
2458 // Handle the nonnull attribute on the function/method declaration itself.
2459 for (const auto *NonNull : FDecl->specific_attrs<NonNullAttr>()) {
2460 if (!NonNull->args_size()) {
2461 // Easy case: all pointer arguments are nonnull.
2462 for (const auto *Arg : Args)
2463 if (S.isValidPointerAttrType(Arg->getType()))
2464 CheckNonNullArgument(S, Arg, CallSiteLoc);
2468 for (unsigned Val : NonNull->args()) {
2469 if (Val >= Args.size())
2471 if (NonNullArgs.empty())
2472 NonNullArgs.resize(Args.size());
2473 NonNullArgs.set(Val);
2478 if (FDecl && (isa<FunctionDecl>(FDecl) || isa<ObjCMethodDecl>(FDecl))) {
2479 // Handle the nonnull attribute on the parameters of the
2481 ArrayRef<ParmVarDecl*> parms;
2482 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(FDecl))
2483 parms = FD->parameters();
2485 parms = cast<ObjCMethodDecl>(FDecl)->parameters();
2487 unsigned ParamIndex = 0;
2488 for (ArrayRef<ParmVarDecl*>::iterator I = parms.begin(), E = parms.end();
2489 I != E; ++I, ++ParamIndex) {
2490 const ParmVarDecl *PVD = *I;
2491 if (PVD->hasAttr<NonNullAttr>() ||
2492 isNonNullType(S.Context, PVD->getType())) {
2493 if (NonNullArgs.empty())
2494 NonNullArgs.resize(Args.size());
2496 NonNullArgs.set(ParamIndex);
2500 // If we have a non-function, non-method declaration but no
2501 // function prototype, try to dig out the function prototype.
2503 if (const ValueDecl *VD = dyn_cast<ValueDecl>(FDecl)) {
2504 QualType type = VD->getType().getNonReferenceType();
2505 if (auto pointerType = type->getAs<PointerType>())
2506 type = pointerType->getPointeeType();
2507 else if (auto blockType = type->getAs<BlockPointerType>())
2508 type = blockType->getPointeeType();
2509 // FIXME: data member pointers?
2511 // Dig out the function prototype, if there is one.
2512 Proto = type->getAs<FunctionProtoType>();
2516 // Fill in non-null argument information from the nullability
2517 // information on the parameter types (if we have them).
2520 for (auto paramType : Proto->getParamTypes()) {
2521 if (isNonNullType(S.Context, paramType)) {
2522 if (NonNullArgs.empty())
2523 NonNullArgs.resize(Args.size());
2525 NonNullArgs.set(Index);
2533 // Check for non-null arguments.
2534 for (unsigned ArgIndex = 0, ArgIndexEnd = NonNullArgs.size();
2535 ArgIndex != ArgIndexEnd; ++ArgIndex) {
2536 if (NonNullArgs[ArgIndex])
2537 CheckNonNullArgument(S, Args[ArgIndex], CallSiteLoc);
2541 /// Handles the checks for format strings, non-POD arguments to vararg
2542 /// functions, NULL arguments passed to non-NULL parameters, and diagnose_if
2544 void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto,
2545 const Expr *ThisArg, ArrayRef<const Expr *> Args,
2546 bool IsMemberFunction, SourceLocation Loc,
2547 SourceRange Range, VariadicCallType CallType) {
2548 // FIXME: We should check as much as we can in the template definition.
2549 if (CurContext->isDependentContext())
2552 // Printf and scanf checking.
2553 llvm::SmallBitVector CheckedVarArgs;
2555 for (const auto *I : FDecl->specific_attrs<FormatAttr>()) {
2556 // Only create vector if there are format attributes.
2557 CheckedVarArgs.resize(Args.size());
2559 CheckFormatArguments(I, Args, IsMemberFunction, CallType, Loc, Range,
2564 // Refuse POD arguments that weren't caught by the format string
2566 auto *FD = dyn_cast_or_null<FunctionDecl>(FDecl);
2567 if (CallType != VariadicDoesNotApply &&
2568 (!FD || FD->getBuiltinID() != Builtin::BI__noop)) {
2569 unsigned NumParams = Proto ? Proto->getNumParams()
2570 : FDecl && isa<FunctionDecl>(FDecl)
2571 ? cast<FunctionDecl>(FDecl)->getNumParams()
2572 : FDecl && isa<ObjCMethodDecl>(FDecl)
2573 ? cast<ObjCMethodDecl>(FDecl)->param_size()
2576 for (unsigned ArgIdx = NumParams; ArgIdx < Args.size(); ++ArgIdx) {
2577 // Args[ArgIdx] can be null in malformed code.
2578 if (const Expr *Arg = Args[ArgIdx]) {
2579 if (CheckedVarArgs.empty() || !CheckedVarArgs[ArgIdx])
2580 checkVariadicArgument(Arg, CallType);
2585 if (FDecl || Proto) {
2586 CheckNonNullArguments(*this, FDecl, Proto, Args, Loc);
2588 // Type safety checking.
2590 for (const auto *I : FDecl->specific_attrs<ArgumentWithTypeTagAttr>())
2591 CheckArgumentWithTypeTag(I, Args.data());
2596 diagnoseArgDependentDiagnoseIfAttrs(FD, ThisArg, Args, Loc);
2599 /// CheckConstructorCall - Check a constructor call for correctness and safety
2600 /// properties not enforced by the C type system.
2601 void Sema::CheckConstructorCall(FunctionDecl *FDecl,
2602 ArrayRef<const Expr *> Args,
2603 const FunctionProtoType *Proto,
2604 SourceLocation Loc) {
2605 VariadicCallType CallType =
2606 Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
2607 checkCall(FDecl, Proto, /*ThisArg=*/nullptr, Args, /*IsMemberFunction=*/true,
2608 Loc, SourceRange(), CallType);
2611 /// CheckFunctionCall - Check a direct function call for various correctness
2612 /// and safety properties not strictly enforced by the C type system.
2613 bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
2614 const FunctionProtoType *Proto) {
2615 bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) &&
2616 isa<CXXMethodDecl>(FDecl);
2617 bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) ||
2618 IsMemberOperatorCall;
2619 VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
2620 TheCall->getCallee());
2621 Expr** Args = TheCall->getArgs();
2622 unsigned NumArgs = TheCall->getNumArgs();
2624 Expr *ImplicitThis = nullptr;
2625 if (IsMemberOperatorCall) {
2626 // If this is a call to a member operator, hide the first argument
2628 // FIXME: Our choice of AST representation here is less than ideal.
2629 ImplicitThis = Args[0];
2632 } else if (IsMemberFunction)
2634 cast<CXXMemberCallExpr>(TheCall)->getImplicitObjectArgument();
2636 checkCall(FDecl, Proto, ImplicitThis, llvm::makeArrayRef(Args, NumArgs),
2637 IsMemberFunction, TheCall->getRParenLoc(),
2638 TheCall->getCallee()->getSourceRange(), CallType);
2640 IdentifierInfo *FnInfo = FDecl->getIdentifier();
2641 // None of the checks below are needed for functions that don't have
2642 // simple names (e.g., C++ conversion functions).
2646 CheckAbsoluteValueFunction(TheCall, FDecl);
2647 CheckMaxUnsignedZero(TheCall, FDecl);
2649 if (getLangOpts().ObjC1)
2650 DiagnoseCStringFormatDirectiveInCFAPI(*this, FDecl, Args, NumArgs);
2652 unsigned CMId = FDecl->getMemoryFunctionKind();
2656 // Handle memory setting and copying functions.
2657 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
2658 CheckStrlcpycatArguments(TheCall, FnInfo);
2659 else if (CMId == Builtin::BIstrncat)
2660 CheckStrncatArguments(TheCall, FnInfo);
2662 CheckMemaccessArguments(TheCall, CMId, FnInfo);
2667 bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
2668 ArrayRef<const Expr *> Args) {
2669 VariadicCallType CallType =
2670 Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
2672 checkCall(Method, nullptr, /*ThisArg=*/nullptr, Args,
2673 /*IsMemberFunction=*/false, lbrac, Method->getSourceRange(),
2679 bool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall,
2680 const FunctionProtoType *Proto) {
2682 if (const auto *V = dyn_cast<VarDecl>(NDecl))
2683 Ty = V->getType().getNonReferenceType();
2684 else if (const auto *F = dyn_cast<FieldDecl>(NDecl))
2685 Ty = F->getType().getNonReferenceType();
2689 if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType() &&
2690 !Ty->isFunctionProtoType())
2693 VariadicCallType CallType;
2694 if (!Proto || !Proto->isVariadic()) {
2695 CallType = VariadicDoesNotApply;
2696 } else if (Ty->isBlockPointerType()) {
2697 CallType = VariadicBlock;
2698 } else { // Ty->isFunctionPointerType()
2699 CallType = VariadicFunction;
2702 checkCall(NDecl, Proto, /*ThisArg=*/nullptr,
2703 llvm::makeArrayRef(TheCall->getArgs(), TheCall->getNumArgs()),
2704 /*IsMemberFunction=*/false, TheCall->getRParenLoc(),
2705 TheCall->getCallee()->getSourceRange(), CallType);
2710 /// Checks function calls when a FunctionDecl or a NamedDecl is not available,
2711 /// such as function pointers returned from functions.
2712 bool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) {
2713 VariadicCallType CallType = getVariadicCallType(/*FDecl=*/nullptr, Proto,
2714 TheCall->getCallee());
2715 checkCall(/*FDecl=*/nullptr, Proto, /*ThisArg=*/nullptr,
2716 llvm::makeArrayRef(TheCall->getArgs(), TheCall->getNumArgs()),
2717 /*IsMemberFunction=*/false, TheCall->getRParenLoc(),
2718 TheCall->getCallee()->getSourceRange(), CallType);
2723 static bool isValidOrderingForOp(int64_t Ordering, AtomicExpr::AtomicOp Op) {
2724 if (!llvm::isValidAtomicOrderingCABI(Ordering))
2727 auto OrderingCABI = (llvm::AtomicOrderingCABI)Ordering;
2729 case AtomicExpr::AO__c11_atomic_init:
2730 llvm_unreachable("There is no ordering argument for an init");
2732 case AtomicExpr::AO__c11_atomic_load:
2733 case AtomicExpr::AO__atomic_load_n:
2734 case AtomicExpr::AO__atomic_load:
2735 return OrderingCABI != llvm::AtomicOrderingCABI::release &&
2736 OrderingCABI != llvm::AtomicOrderingCABI::acq_rel;
2738 case AtomicExpr::AO__c11_atomic_store:
2739 case AtomicExpr::AO__atomic_store:
2740 case AtomicExpr::AO__atomic_store_n:
2741 return OrderingCABI != llvm::AtomicOrderingCABI::consume &&
2742 OrderingCABI != llvm::AtomicOrderingCABI::acquire &&
2743 OrderingCABI != llvm::AtomicOrderingCABI::acq_rel;
2750 ExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
2751 AtomicExpr::AtomicOp Op) {
2752 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
2753 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
2755 // All these operations take one of the following forms:
2757 // C __c11_atomic_init(A *, C)
2759 // C __c11_atomic_load(A *, int)
2761 // void __atomic_load(A *, CP, int)
2763 // void __atomic_store(A *, CP, int)
2765 // C __c11_atomic_add(A *, M, int)
2767 // C __atomic_exchange_n(A *, CP, int)
2769 // void __atomic_exchange(A *, C *, CP, int)
2771 // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
2773 // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
2776 const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 3, 4, 5, 6 };
2777 const unsigned NumVals[] = { 1, 0, 1, 1, 1, 1, 2, 2, 3 };
2779 // C is an appropriate type,
2780 // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
2781 // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
2782 // M is C if C is an integer, and ptrdiff_t if C is a pointer, and
2783 // the int parameters are for orderings.
2785 static_assert(AtomicExpr::AO__c11_atomic_init == 0 &&
2786 AtomicExpr::AO__c11_atomic_fetch_xor + 1 ==
2787 AtomicExpr::AO__atomic_load,
2788 "need to update code for modified C11 atomics");
2789 bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
2790 Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
2791 bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
2792 Op == AtomicExpr::AO__atomic_store_n ||
2793 Op == AtomicExpr::AO__atomic_exchange_n ||
2794 Op == AtomicExpr::AO__atomic_compare_exchange_n;
2795 bool IsAddSub = false;
2798 case AtomicExpr::AO__c11_atomic_init:
2802 case AtomicExpr::AO__c11_atomic_load:
2803 case AtomicExpr::AO__atomic_load_n:
2807 case AtomicExpr::AO__atomic_load:
2811 case AtomicExpr::AO__c11_atomic_store:
2812 case AtomicExpr::AO__atomic_store:
2813 case AtomicExpr::AO__atomic_store_n:
2817 case AtomicExpr::AO__c11_atomic_fetch_add:
2818 case AtomicExpr::AO__c11_atomic_fetch_sub:
2819 case AtomicExpr::AO__atomic_fetch_add:
2820 case AtomicExpr::AO__atomic_fetch_sub:
2821 case AtomicExpr::AO__atomic_add_fetch:
2822 case AtomicExpr::AO__atomic_sub_fetch:
2825 case AtomicExpr::AO__c11_atomic_fetch_and:
2826 case AtomicExpr::AO__c11_atomic_fetch_or:
2827 case AtomicExpr::AO__c11_atomic_fetch_xor:
2828 case AtomicExpr::AO__atomic_fetch_and:
2829 case AtomicExpr::AO__atomic_fetch_or:
2830 case AtomicExpr::AO__atomic_fetch_xor:
2831 case AtomicExpr::AO__atomic_fetch_nand:
2832 case AtomicExpr::AO__atomic_and_fetch:
2833 case AtomicExpr::AO__atomic_or_fetch:
2834 case AtomicExpr::AO__atomic_xor_fetch:
2835 case AtomicExpr::AO__atomic_nand_fetch:
2839 case AtomicExpr::AO__c11_atomic_exchange:
2840 case AtomicExpr::AO__atomic_exchange_n:
2844 case AtomicExpr::AO__atomic_exchange:
2848 case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
2849 case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
2853 case AtomicExpr::AO__atomic_compare_exchange:
2854 case AtomicExpr::AO__atomic_compare_exchange_n:
2859 // Check we have the right number of arguments.
2860 if (TheCall->getNumArgs() < NumArgs[Form]) {
2861 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
2862 << 0 << NumArgs[Form] << TheCall->getNumArgs()
2863 << TheCall->getCallee()->getSourceRange();
2865 } else if (TheCall->getNumArgs() > NumArgs[Form]) {
2866 Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
2867 diag::err_typecheck_call_too_many_args)
2868 << 0 << NumArgs[Form] << TheCall->getNumArgs()
2869 << TheCall->getCallee()->getSourceRange();
2873 // Inspect the first argument of the atomic operation.
2874 Expr *Ptr = TheCall->getArg(0);
2875 ExprResult ConvertedPtr = DefaultFunctionArrayLvalueConversion(Ptr);
2876 if (ConvertedPtr.isInvalid())
2879 Ptr = ConvertedPtr.get();
2880 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
2882 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
2883 << Ptr->getType() << Ptr->getSourceRange();
2887 // For a __c11 builtin, this should be a pointer to an _Atomic type.
2888 QualType AtomTy = pointerType->getPointeeType(); // 'A'
2889 QualType ValType = AtomTy; // 'C'
2891 if (!AtomTy->isAtomicType()) {
2892 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
2893 << Ptr->getType() << Ptr->getSourceRange();
2896 if (AtomTy.isConstQualified()) {
2897 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic)
2898 << Ptr->getType() << Ptr->getSourceRange();
2901 ValType = AtomTy->getAs<AtomicType>()->getValueType();
2902 } else if (Form != Load && Form != LoadCopy) {
2903 if (ValType.isConstQualified()) {
2904 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_pointer)
2905 << Ptr->getType() << Ptr->getSourceRange();
2910 // For an arithmetic operation, the implied arithmetic must be well-formed.
2911 if (Form == Arithmetic) {
2912 // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
2913 if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
2914 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
2915 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
2918 if (!IsAddSub && !ValType->isIntegerType()) {
2919 Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
2920 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
2923 if (IsC11 && ValType->isPointerType() &&
2924 RequireCompleteType(Ptr->getLocStart(), ValType->getPointeeType(),
2925 diag::err_incomplete_type)) {
2928 } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
2929 // For __atomic_*_n operations, the value type must be a scalar integral or
2930 // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
2931 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
2932 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
2936 if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context) &&
2937 !AtomTy->isScalarType()) {
2938 // For GNU atomics, require a trivially-copyable type. This is not part of
2939 // the GNU atomics specification, but we enforce it for sanity.
2940 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
2941 << Ptr->getType() << Ptr->getSourceRange();
2945 switch (ValType.getObjCLifetime()) {
2946 case Qualifiers::OCL_None:
2947 case Qualifiers::OCL_ExplicitNone:
2951 case Qualifiers::OCL_Weak:
2952 case Qualifiers::OCL_Strong:
2953 case Qualifiers::OCL_Autoreleasing:
2954 // FIXME: Can this happen? By this point, ValType should be known
2955 // to be trivially copyable.
2956 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
2957 << ValType << Ptr->getSourceRange();
2961 // atomic_fetch_or takes a pointer to a volatile 'A'. We shouldn't let the
2962 // volatile-ness of the pointee-type inject itself into the result or the
2963 // other operands. Similarly atomic_load can take a pointer to a const 'A'.
2964 ValType.removeLocalVolatile();
2965 ValType.removeLocalConst();
2966 QualType ResultType = ValType;
2967 if (Form == Copy || Form == LoadCopy || Form == GNUXchg || Form == Init)
2968 ResultType = Context.VoidTy;
2969 else if (Form == C11CmpXchg || Form == GNUCmpXchg)
2970 ResultType = Context.BoolTy;
2972 // The type of a parameter passed 'by value'. In the GNU atomics, such
2973 // arguments are actually passed as pointers.
2974 QualType ByValType = ValType; // 'CP'
2976 ByValType = Ptr->getType();
2978 // The first argument --- the pointer --- has a fixed type; we
2979 // deduce the types of the rest of the arguments accordingly. Walk
2980 // the remaining arguments, converting them to the deduced value type.
2981 for (unsigned i = 1; i != NumArgs[Form]; ++i) {
2983 if (i < NumVals[Form] + 1) {
2986 // The second argument is the non-atomic operand. For arithmetic, this
2987 // is always passed by value, and for a compare_exchange it is always
2988 // passed by address. For the rest, GNU uses by-address and C11 uses
2990 assert(Form != Load);
2991 if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
2993 else if (Form == Copy || Form == Xchg)
2995 else if (Form == Arithmetic)
2996 Ty = Context.getPointerDiffType();
2998 Expr *ValArg = TheCall->getArg(i);
2999 // Treat this argument as _Nonnull as we want to show a warning if
3000 // NULL is passed into it.
3001 CheckNonNullArgument(*this, ValArg, DRE->getLocStart());
3003 // Keep address space of non-atomic pointer type.
3004 if (const PointerType *PtrTy =
3005 ValArg->getType()->getAs<PointerType>()) {
3006 AS = PtrTy->getPointeeType().getAddressSpace();
3008 Ty = Context.getPointerType(
3009 Context.getAddrSpaceQualType(ValType.getUnqualifiedType(), AS));
3013 // The third argument to compare_exchange / GNU exchange is a
3014 // (pointer to a) desired value.
3018 // The fourth argument to GNU compare_exchange is a 'weak' flag.
3019 Ty = Context.BoolTy;
3023 // The order(s) are always converted to int.
3027 InitializedEntity Entity =
3028 InitializedEntity::InitializeParameter(Context, Ty, false);
3029 ExprResult Arg = TheCall->getArg(i);
3030 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
3031 if (Arg.isInvalid())
3033 TheCall->setArg(i, Arg.get());
3036 // Permute the arguments into a 'consistent' order.
3037 SmallVector<Expr*, 5> SubExprs;
3038 SubExprs.push_back(Ptr);
3041 // Note, AtomicExpr::getVal1() has a special case for this atomic.
3042 SubExprs.push_back(TheCall->getArg(1)); // Val1
3045 SubExprs.push_back(TheCall->getArg(1)); // Order
3051 SubExprs.push_back(TheCall->getArg(2)); // Order
3052 SubExprs.push_back(TheCall->getArg(1)); // Val1
3055 // Note, AtomicExpr::getVal2() has a special case for this atomic.
3056 SubExprs.push_back(TheCall->getArg(3)); // Order
3057 SubExprs.push_back(TheCall->getArg(1)); // Val1
3058 SubExprs.push_back(TheCall->getArg(2)); // Val2
3061 SubExprs.push_back(TheCall->getArg(3)); // Order
3062 SubExprs.push_back(TheCall->getArg(1)); // Val1
3063 SubExprs.push_back(TheCall->getArg(4)); // OrderFail
3064 SubExprs.push_back(TheCall->getArg(2)); // Val2
3067 SubExprs.push_back(TheCall->getArg(4)); // Order
3068 SubExprs.push_back(TheCall->getArg(1)); // Val1
3069 SubExprs.push_back(TheCall->getArg(5)); // OrderFail
3070 SubExprs.push_back(TheCall->getArg(2)); // Val2
3071 SubExprs.push_back(TheCall->getArg(3)); // Weak
3075 if (SubExprs.size() >= 2 && Form != Init) {
3076 llvm::APSInt Result(32);
3077 if (SubExprs[1]->isIntegerConstantExpr(Result, Context) &&
3078 !isValidOrderingForOp(Result.getSExtValue(), Op))
3079 Diag(SubExprs[1]->getLocStart(),
3080 diag::warn_atomic_op_has_invalid_memory_order)
3081 << SubExprs[1]->getSourceRange();
3084 AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
3085 SubExprs, ResultType, Op,
3086 TheCall->getRParenLoc());
3088 if ((Op == AtomicExpr::AO__c11_atomic_load ||
3089 (Op == AtomicExpr::AO__c11_atomic_store)) &&
3090 Context.AtomicUsesUnsupportedLibcall(AE))
3091 Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) <<
3092 ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1);
3097 /// checkBuiltinArgument - Given a call to a builtin function, perform
3098 /// normal type-checking on the given argument, updating the call in
3099 /// place. This is useful when a builtin function requires custom
3100 /// type-checking for some of its arguments but not necessarily all of
3103 /// Returns true on error.
3104 static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
3105 FunctionDecl *Fn = E->getDirectCallee();
3106 assert(Fn && "builtin call without direct callee!");
3108 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
3109 InitializedEntity Entity =
3110 InitializedEntity::InitializeParameter(S.Context, Param);
3112 ExprResult Arg = E->getArg(0);
3113 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
3114 if (Arg.isInvalid())
3117 E->setArg(ArgIndex, Arg.get());
3121 /// SemaBuiltinAtomicOverloaded - We have a call to a function like
3122 /// __sync_fetch_and_add, which is an overloaded function based on the pointer
3123 /// type of its first argument. The main ActOnCallExpr routines have already
3124 /// promoted the types of arguments because all of these calls are prototyped as
3127 /// This function goes through and does final semantic checking for these
3130 Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
3131 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
3132 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
3133 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
3135 // Ensure that we have at least one argument to do type inference from.
3136 if (TheCall->getNumArgs() < 1) {
3137 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
3138 << 0 << 1 << TheCall->getNumArgs()
3139 << TheCall->getCallee()->getSourceRange();
3143 // Inspect the first argument of the atomic builtin. This should always be
3144 // a pointer type, whose element is an integral scalar or pointer type.
3145 // Because it is a pointer type, we don't have to worry about any implicit
3147 // FIXME: We don't allow floating point scalars as input.
3148 Expr *FirstArg = TheCall->getArg(0);
3149 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
3150 if (FirstArgResult.isInvalid())
3152 FirstArg = FirstArgResult.get();
3153 TheCall->setArg(0, FirstArg);
3155 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
3157 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
3158 << FirstArg->getType() << FirstArg->getSourceRange();
3162 QualType ValType = pointerType->getPointeeType();
3163 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
3164 !ValType->isBlockPointerType()) {
3165 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
3166 << FirstArg->getType() << FirstArg->getSourceRange();
3170 switch (ValType.getObjCLifetime()) {
3171 case Qualifiers::OCL_None:
3172 case Qualifiers::OCL_ExplicitNone:
3176 case Qualifiers::OCL_Weak:
3177 case Qualifiers::OCL_Strong:
3178 case Qualifiers::OCL_Autoreleasing:
3179 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
3180 << ValType << FirstArg->getSourceRange();
3184 // Strip any qualifiers off ValType.
3185 ValType = ValType.getUnqualifiedType();
3187 // The majority of builtins return a value, but a few have special return
3188 // types, so allow them to override appropriately below.
3189 QualType ResultType = ValType;
3191 // We need to figure out which concrete builtin this maps onto. For example,
3192 // __sync_fetch_and_add with a 2 byte object turns into
3193 // __sync_fetch_and_add_2.
3194 #define BUILTIN_ROW(x) \
3195 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
3196 Builtin::BI##x##_8, Builtin::BI##x##_16 }
3198 static const unsigned BuiltinIndices[][5] = {
3199 BUILTIN_ROW(__sync_fetch_and_add),
3200 BUILTIN_ROW(__sync_fetch_and_sub),
3201 BUILTIN_ROW(__sync_fetch_and_or),
3202 BUILTIN_ROW(__sync_fetch_and_and),
3203 BUILTIN_ROW(__sync_fetch_and_xor),
3204 BUILTIN_ROW(__sync_fetch_and_nand),
3206 BUILTIN_ROW(__sync_add_and_fetch),
3207 BUILTIN_ROW(__sync_sub_and_fetch),
3208 BUILTIN_ROW(__sync_and_and_fetch),
3209 BUILTIN_ROW(__sync_or_and_fetch),
3210 BUILTIN_ROW(__sync_xor_and_fetch),
3211 BUILTIN_ROW(__sync_nand_and_fetch),
3213 BUILTIN_ROW(__sync_val_compare_and_swap),
3214 BUILTIN_ROW(__sync_bool_compare_and_swap),
3215 BUILTIN_ROW(__sync_lock_test_and_set),
3216 BUILTIN_ROW(__sync_lock_release),
3217 BUILTIN_ROW(__sync_swap)
3221 // Determine the index of the size.
3223 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
3224 case 1: SizeIndex = 0; break;
3225 case 2: SizeIndex = 1; break;
3226 case 4: SizeIndex = 2; break;
3227 case 8: SizeIndex = 3; break;
3228 case 16: SizeIndex = 4; break;
3230 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
3231 << FirstArg->getType() << FirstArg->getSourceRange();
3235 // Each of these builtins has one pointer argument, followed by some number of
3236 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
3237 // that we ignore. Find out which row of BuiltinIndices to read from as well
3238 // as the number of fixed args.
3239 unsigned BuiltinID = FDecl->getBuiltinID();
3240 unsigned BuiltinIndex, NumFixed = 1;
3241 bool WarnAboutSemanticsChange = false;
3242 switch (BuiltinID) {
3243 default: llvm_unreachable("Unknown overloaded atomic builtin!");
3244 case Builtin::BI__sync_fetch_and_add:
3245 case Builtin::BI__sync_fetch_and_add_1:
3246 case Builtin::BI__sync_fetch_and_add_2:
3247 case Builtin::BI__sync_fetch_and_add_4:
3248 case Builtin::BI__sync_fetch_and_add_8:
3249 case Builtin::BI__sync_fetch_and_add_16:
3253 case Builtin::BI__sync_fetch_and_sub:
3254 case Builtin::BI__sync_fetch_and_sub_1:
3255 case Builtin::BI__sync_fetch_and_sub_2:
3256 case Builtin::BI__sync_fetch_and_sub_4:
3257 case Builtin::BI__sync_fetch_and_sub_8:
3258 case Builtin::BI__sync_fetch_and_sub_16:
3262 case Builtin::BI__sync_fetch_and_or:
3263 case Builtin::BI__sync_fetch_and_or_1:
3264 case Builtin::BI__sync_fetch_and_or_2:
3265 case Builtin::BI__sync_fetch_and_or_4:
3266 case Builtin::BI__sync_fetch_and_or_8:
3267 case Builtin::BI__sync_fetch_and_or_16:
3271 case Builtin::BI__sync_fetch_and_and:
3272 case Builtin::BI__sync_fetch_and_and_1:
3273 case Builtin::BI__sync_fetch_and_and_2:
3274 case Builtin::BI__sync_fetch_and_and_4:
3275 case Builtin::BI__sync_fetch_and_and_8:
3276 case Builtin::BI__sync_fetch_and_and_16:
3280 case Builtin::BI__sync_fetch_and_xor:
3281 case Builtin::BI__sync_fetch_and_xor_1:
3282 case Builtin::BI__sync_fetch_and_xor_2:
3283 case Builtin::BI__sync_fetch_and_xor_4:
3284 case Builtin::BI__sync_fetch_and_xor_8:
3285 case Builtin::BI__sync_fetch_and_xor_16:
3289 case Builtin::BI__sync_fetch_and_nand:
3290 case Builtin::BI__sync_fetch_and_nand_1:
3291 case Builtin::BI__sync_fetch_and_nand_2:
3292 case Builtin::BI__sync_fetch_and_nand_4:
3293 case Builtin::BI__sync_fetch_and_nand_8:
3294 case Builtin::BI__sync_fetch_and_nand_16:
3296 WarnAboutSemanticsChange = true;
3299 case Builtin::BI__sync_add_and_fetch:
3300 case Builtin::BI__sync_add_and_fetch_1:
3301 case Builtin::BI__sync_add_and_fetch_2:
3302 case Builtin::BI__sync_add_and_fetch_4:
3303 case Builtin::BI__sync_add_and_fetch_8:
3304 case Builtin::BI__sync_add_and_fetch_16:
3308 case Builtin::BI__sync_sub_and_fetch:
3309 case Builtin::BI__sync_sub_and_fetch_1:
3310 case Builtin::BI__sync_sub_and_fetch_2:
3311 case Builtin::BI__sync_sub_and_fetch_4:
3312 case Builtin::BI__sync_sub_and_fetch_8:
3313 case Builtin::BI__sync_sub_and_fetch_16:
3317 case Builtin::BI__sync_and_and_fetch:
3318 case Builtin::BI__sync_and_and_fetch_1:
3319 case Builtin::BI__sync_and_and_fetch_2:
3320 case Builtin::BI__sync_and_and_fetch_4:
3321 case Builtin::BI__sync_and_and_fetch_8:
3322 case Builtin::BI__sync_and_and_fetch_16:
3326 case Builtin::BI__sync_or_and_fetch:
3327 case Builtin::BI__sync_or_and_fetch_1:
3328 case Builtin::BI__sync_or_and_fetch_2:
3329 case Builtin::BI__sync_or_and_fetch_4:
3330 case Builtin::BI__sync_or_and_fetch_8:
3331 case Builtin::BI__sync_or_and_fetch_16:
3335 case Builtin::BI__sync_xor_and_fetch:
3336 case Builtin::BI__sync_xor_and_fetch_1:
3337 case Builtin::BI__sync_xor_and_fetch_2:
3338 case Builtin::BI__sync_xor_and_fetch_4:
3339 case Builtin::BI__sync_xor_and_fetch_8:
3340 case Builtin::BI__sync_xor_and_fetch_16:
3344 case Builtin::BI__sync_nand_and_fetch:
3345 case Builtin::BI__sync_nand_and_fetch_1:
3346 case Builtin::BI__sync_nand_and_fetch_2:
3347 case Builtin::BI__sync_nand_and_fetch_4:
3348 case Builtin::BI__sync_nand_and_fetch_8:
3349 case Builtin::BI__sync_nand_and_fetch_16:
3351 WarnAboutSemanticsChange = true;
3354 case Builtin::BI__sync_val_compare_and_swap:
3355 case Builtin::BI__sync_val_compare_and_swap_1:
3356 case Builtin::BI__sync_val_compare_and_swap_2:
3357 case Builtin::BI__sync_val_compare_and_swap_4:
3358 case Builtin::BI__sync_val_compare_and_swap_8:
3359 case Builtin::BI__sync_val_compare_and_swap_16:
3364 case Builtin::BI__sync_bool_compare_and_swap:
3365 case Builtin::BI__sync_bool_compare_and_swap_1:
3366 case Builtin::BI__sync_bool_compare_and_swap_2:
3367 case Builtin::BI__sync_bool_compare_and_swap_4:
3368 case Builtin::BI__sync_bool_compare_and_swap_8:
3369 case Builtin::BI__sync_bool_compare_and_swap_16:
3372 ResultType = Context.BoolTy;
3375 case Builtin::BI__sync_lock_test_and_set:
3376 case Builtin::BI__sync_lock_test_and_set_1:
3377 case Builtin::BI__sync_lock_test_and_set_2:
3378 case Builtin::BI__sync_lock_test_and_set_4:
3379 case Builtin::BI__sync_lock_test_and_set_8:
3380 case Builtin::BI__sync_lock_test_and_set_16:
3384 case Builtin::BI__sync_lock_release:
3385 case Builtin::BI__sync_lock_release_1:
3386 case Builtin::BI__sync_lock_release_2:
3387 case Builtin::BI__sync_lock_release_4:
3388 case Builtin::BI__sync_lock_release_8:
3389 case Builtin::BI__sync_lock_release_16:
3392 ResultType = Context.VoidTy;
3395 case Builtin::BI__sync_swap:
3396 case Builtin::BI__sync_swap_1:
3397 case Builtin::BI__sync_swap_2:
3398 case Builtin::BI__sync_swap_4:
3399 case Builtin::BI__sync_swap_8:
3400 case Builtin::BI__sync_swap_16:
3405 // Now that we know how many fixed arguments we expect, first check that we
3406 // have at least that many.
3407 if (TheCall->getNumArgs() < 1+NumFixed) {
3408 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
3409 << 0 << 1+NumFixed << TheCall->getNumArgs()
3410 << TheCall->getCallee()->getSourceRange();
3414 if (WarnAboutSemanticsChange) {
3415 Diag(TheCall->getLocEnd(), diag::warn_sync_fetch_and_nand_semantics_change)
3416 << TheCall->getCallee()->getSourceRange();
3419 // Get the decl for the concrete builtin from this, we can tell what the
3420 // concrete integer type we should convert to is.
3421 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
3422 const char *NewBuiltinName = Context.BuiltinInfo.getName(NewBuiltinID);
3423 FunctionDecl *NewBuiltinDecl;
3424 if (NewBuiltinID == BuiltinID)
3425 NewBuiltinDecl = FDecl;
3427 // Perform builtin lookup to avoid redeclaring it.
3428 DeclarationName DN(&Context.Idents.get(NewBuiltinName));
3429 LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName);
3430 LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true);
3431 assert(Res.getFoundDecl());
3432 NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl());
3433 if (!NewBuiltinDecl)
3437 // The first argument --- the pointer --- has a fixed type; we
3438 // deduce the types of the rest of the arguments accordingly. Walk
3439 // the remaining arguments, converting them to the deduced value type.
3440 for (unsigned i = 0; i != NumFixed; ++i) {
3441 ExprResult Arg = TheCall->getArg(i+1);
3443 // GCC does an implicit conversion to the pointer or integer ValType. This
3444 // can fail in some cases (1i -> int**), check for this error case now.
3445 // Initialize the argument.
3446 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
3447 ValType, /*consume*/ false);
3448 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
3449 if (Arg.isInvalid())
3452 // Okay, we have something that *can* be converted to the right type. Check
3453 // to see if there is a potentially weird extension going on here. This can
3454 // happen when you do an atomic operation on something like an char* and
3455 // pass in 42. The 42 gets converted to char. This is even more strange
3456 // for things like 45.123 -> char, etc.
3457 // FIXME: Do this check.
3458 TheCall->setArg(i+1, Arg.get());
3461 ASTContext& Context = this->getASTContext();
3463 // Create a new DeclRefExpr to refer to the new decl.
3464 DeclRefExpr* NewDRE = DeclRefExpr::Create(
3466 DRE->getQualifierLoc(),
3469 /*enclosing*/ false,
3471 Context.BuiltinFnTy,
3472 DRE->getValueKind());
3474 // Set the callee in the CallExpr.
3475 // FIXME: This loses syntactic information.
3476 QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType());
3477 ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy,
3478 CK_BuiltinFnToFnPtr);
3479 TheCall->setCallee(PromotedCall.get());
3481 // Change the result type of the call to match the original value type. This
3482 // is arbitrary, but the codegen for these builtins ins design to handle it
3484 TheCall->setType(ResultType);
3486 return TheCallResult;
3489 /// SemaBuiltinNontemporalOverloaded - We have a call to
3490 /// __builtin_nontemporal_store or __builtin_nontemporal_load, which is an
3491 /// overloaded function based on the pointer type of its last argument.
3493 /// This function goes through and does final semantic checking for these
3495 ExprResult Sema::SemaBuiltinNontemporalOverloaded(ExprResult TheCallResult) {
3496 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
3498 cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
3499 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
3500 unsigned BuiltinID = FDecl->getBuiltinID();
3501 assert((BuiltinID == Builtin::BI__builtin_nontemporal_store ||
3502 BuiltinID == Builtin::BI__builtin_nontemporal_load) &&
3503 "Unexpected nontemporal load/store builtin!");
3504 bool isStore = BuiltinID == Builtin::BI__builtin_nontemporal_store;
3505 unsigned numArgs = isStore ? 2 : 1;
3507 // Ensure that we have the proper number of arguments.
3508 if (checkArgCount(*this, TheCall, numArgs))
3511 // Inspect the last argument of the nontemporal builtin. This should always
3512 // be a pointer type, from which we imply the type of the memory access.
3513 // Because it is a pointer type, we don't have to worry about any implicit
3515 Expr *PointerArg = TheCall->getArg(numArgs - 1);
3516 ExprResult PointerArgResult =
3517 DefaultFunctionArrayLvalueConversion(PointerArg);
3519 if (PointerArgResult.isInvalid())
3521 PointerArg = PointerArgResult.get();
3522 TheCall->setArg(numArgs - 1, PointerArg);
3524 const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>();
3526 Diag(DRE->getLocStart(), diag::err_nontemporal_builtin_must_be_pointer)
3527 << PointerArg->getType() << PointerArg->getSourceRange();
3531 QualType ValType = pointerType->getPointeeType();
3533 // Strip any qualifiers off ValType.
3534 ValType = ValType.getUnqualifiedType();
3535 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
3536 !ValType->isBlockPointerType() && !ValType->isFloatingType() &&
3537 !ValType->isVectorType()) {
3538 Diag(DRE->getLocStart(),
3539 diag::err_nontemporal_builtin_must_be_pointer_intfltptr_or_vector)
3540 << PointerArg->getType() << PointerArg->getSourceRange();
3545 TheCall->setType(ValType);
3546 return TheCallResult;
3549 ExprResult ValArg = TheCall->getArg(0);
3550 InitializedEntity Entity = InitializedEntity::InitializeParameter(
3551 Context, ValType, /*consume*/ false);
3552 ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg);
3553 if (ValArg.isInvalid())
3556 TheCall->setArg(0, ValArg.get());
3557 TheCall->setType(Context.VoidTy);
3558 return TheCallResult;
3561 /// CheckObjCString - Checks that the argument to the builtin
3562 /// CFString constructor is correct
3563 /// Note: It might also make sense to do the UTF-16 conversion here (would
3564 /// simplify the backend).
3565 bool Sema::CheckObjCString(Expr *Arg) {
3566 Arg = Arg->IgnoreParenCasts();
3567 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
3569 if (!Literal || !Literal->isAscii()) {
3570 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
3571 << Arg->getSourceRange();
3575 if (Literal->containsNonAsciiOrNull()) {
3576 StringRef String = Literal->getString();
3577 unsigned NumBytes = String.size();
3578 SmallVector<llvm::UTF16, 128> ToBuf(NumBytes);
3579 const llvm::UTF8 *FromPtr = (const llvm::UTF8 *)String.data();
3580 llvm::UTF16 *ToPtr = &ToBuf[0];
3582 llvm::ConversionResult Result =
3583 llvm::ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, &ToPtr,
3584 ToPtr + NumBytes, llvm::strictConversion);
3585 // Check for conversion failure.
3586 if (Result != llvm::conversionOK)
3587 Diag(Arg->getLocStart(),
3588 diag::warn_cfstring_truncated) << Arg->getSourceRange();
3593 /// CheckObjCString - Checks that the format string argument to the os_log()
3594 /// and os_trace() functions is correct, and converts it to const char *.
3595 ExprResult Sema::CheckOSLogFormatStringArg(Expr *Arg) {
3596 Arg = Arg->IgnoreParenCasts();
3597 auto *Literal = dyn_cast<StringLiteral>(Arg);
3599 if (auto *ObjcLiteral = dyn_cast<ObjCStringLiteral>(Arg)) {
3600 Literal = ObjcLiteral->getString();
3604 if (!Literal || (!Literal->isAscii() && !Literal->isUTF8())) {
3606 Diag(Arg->getLocStart(), diag::err_os_log_format_not_string_constant)
3607 << Arg->getSourceRange());
3610 ExprResult Result(Literal);
3611 QualType ResultTy = Context.getPointerType(Context.CharTy.withConst());
3612 InitializedEntity Entity =
3613 InitializedEntity::InitializeParameter(Context, ResultTy, false);
3614 Result = PerformCopyInitialization(Entity, SourceLocation(), Result);
3618 /// Check the arguments to '__builtin_va_start' or '__builtin_ms_va_start'
3619 /// for validity. Emit an error and return true on failure; return false
3621 bool Sema::SemaBuiltinVAStartImpl(CallExpr *TheCall) {
3622 Expr *Fn = TheCall->getCallee();
3623 if (TheCall->getNumArgs() > 2) {
3624 Diag(TheCall->getArg(2)->getLocStart(),
3625 diag::err_typecheck_call_too_many_args)
3626 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
3627 << Fn->getSourceRange()
3628 << SourceRange(TheCall->getArg(2)->getLocStart(),
3629 (*(TheCall->arg_end()-1))->getLocEnd());
3633 if (TheCall->getNumArgs() < 2) {
3634 return Diag(TheCall->getLocEnd(),
3635 diag::err_typecheck_call_too_few_args_at_least)
3636 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
3639 // Type-check the first argument normally.
3640 if (checkBuiltinArgument(*this, TheCall, 0))
3643 // Determine whether the current function is variadic or not.
3644 BlockScopeInfo *CurBlock = getCurBlock();
3647 isVariadic = CurBlock->TheDecl->isVariadic();
3648 else if (FunctionDecl *FD = getCurFunctionDecl())
3649 isVariadic = FD->isVariadic();
3651 isVariadic = getCurMethodDecl()->isVariadic();
3654 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
3658 // Verify that the second argument to the builtin is the last argument of the
3659 // current function or method.
3660 bool SecondArgIsLastNamedArgument = false;
3661 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
3663 // These are valid if SecondArgIsLastNamedArgument is false after the next
3666 SourceLocation ParamLoc;
3667 bool IsCRegister = false;
3669 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
3670 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
3671 // FIXME: This isn't correct for methods (results in bogus warning).
3672 // Get the last formal in the current function.
3673 const ParmVarDecl *LastArg;
3675 LastArg = CurBlock->TheDecl->parameters().back();
3676 else if (FunctionDecl *FD = getCurFunctionDecl())
3677 LastArg = FD->parameters().back();
3679 LastArg = getCurMethodDecl()->parameters().back();
3680 SecondArgIsLastNamedArgument = PV == LastArg;
3682 Type = PV->getType();
3683 ParamLoc = PV->getLocation();
3685 PV->getStorageClass() == SC_Register && !getLangOpts().CPlusPlus;
3689 if (!SecondArgIsLastNamedArgument)
3690 Diag(TheCall->getArg(1)->getLocStart(),
3691 diag::warn_second_arg_of_va_start_not_last_named_param);
3692 else if (IsCRegister || Type->isReferenceType() ||
3693 Type->isSpecificBuiltinType(BuiltinType::Float) || [=] {
3694 // Promotable integers are UB, but enumerations need a bit of
3695 // extra checking to see what their promotable type actually is.
3696 if (!Type->isPromotableIntegerType())
3698 if (!Type->isEnumeralType())
3700 const EnumDecl *ED = Type->getAs<EnumType>()->getDecl();
3702 Context.typesAreCompatible(ED->getPromotionType(), Type));
3704 unsigned Reason = 0;
3705 if (Type->isReferenceType()) Reason = 1;
3706 else if (IsCRegister) Reason = 2;
3707 Diag(Arg->getLocStart(), diag::warn_va_start_type_is_undefined) << Reason;
3708 Diag(ParamLoc, diag::note_parameter_type) << Type;
3711 TheCall->setType(Context.VoidTy);
3715 /// Check the arguments to '__builtin_va_start' for validity, and that
3716 /// it was called from a function of the native ABI.
3717 /// Emit an error and return true on failure; return false on success.
3718 bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
3719 // On x86-64 Unix, don't allow this in Win64 ABI functions.
3720 // On x64 Windows, don't allow this in System V ABI functions.
3721 // (Yes, that means there's no corresponding way to support variadic
3722 // System V ABI functions on Windows.)
3723 if (Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86_64) {
3724 unsigned OS = Context.getTargetInfo().getTriple().getOS();
3725 clang::CallingConv CC = CC_C;
3726 if (const FunctionDecl *FD = getCurFunctionDecl())
3727 CC = FD->getType()->getAs<FunctionType>()->getCallConv();
3728 if ((OS == llvm::Triple::Win32 && CC == CC_X86_64SysV) ||
3729 (OS != llvm::Triple::Win32 && CC == CC_X86_64Win64))
3730 return Diag(TheCall->getCallee()->getLocStart(),
3731 diag::err_va_start_used_in_wrong_abi_function)
3732 << (OS != llvm::Triple::Win32);
3734 return SemaBuiltinVAStartImpl(TheCall);
3737 /// Check the arguments to '__builtin_ms_va_start' for validity, and that
3738 /// it was called from a Win64 ABI function.
3739 /// Emit an error and return true on failure; return false on success.
3740 bool Sema::SemaBuiltinMSVAStart(CallExpr *TheCall) {
3741 // This only makes sense for x86-64.
3742 const llvm::Triple &TT = Context.getTargetInfo().getTriple();
3743 Expr *Callee = TheCall->getCallee();
3744 if (TT.getArch() != llvm::Triple::x86_64)
3745 return Diag(Callee->getLocStart(), diag::err_x86_builtin_32_bit_tgt);
3746 // Don't allow this in System V ABI functions.
3747 clang::CallingConv CC = CC_C;
3748 if (const FunctionDecl *FD = getCurFunctionDecl())
3749 CC = FD->getType()->getAs<FunctionType>()->getCallConv();
3750 if (CC == CC_X86_64SysV ||
3751 (TT.getOS() != llvm::Triple::Win32 && CC != CC_X86_64Win64))
3752 return Diag(Callee->getLocStart(),
3753 diag::err_ms_va_start_used_in_sysv_function);
3754 return SemaBuiltinVAStartImpl(TheCall);
3757 bool Sema::SemaBuiltinVAStartARM(CallExpr *Call) {
3758 // void __va_start(va_list *ap, const char *named_addr, size_t slot_size,
3759 // const char *named_addr);
3761 Expr *Func = Call->getCallee();
3763 if (Call->getNumArgs() < 3)
3764 return Diag(Call->getLocEnd(),
3765 diag::err_typecheck_call_too_few_args_at_least)
3766 << 0 /*function call*/ << 3 << Call->getNumArgs();
3768 // Determine whether the current function is variadic or not.
3770 if (BlockScopeInfo *CurBlock = getCurBlock())
3771 IsVariadic = CurBlock->TheDecl->isVariadic();
3772 else if (FunctionDecl *FD = getCurFunctionDecl())
3773 IsVariadic = FD->isVariadic();
3774 else if (ObjCMethodDecl *MD = getCurMethodDecl())
3775 IsVariadic = MD->isVariadic();
3777 llvm_unreachable("unexpected statement type");
3780 Diag(Func->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
3784 // Type-check the first argument normally.
3785 if (checkBuiltinArgument(*this, Call, 0))
3791 } ArgumentTypes[] = {
3792 { 1, Context.getPointerType(Context.CharTy.withConst()) },
3793 { 2, Context.getSizeType() },
3796 for (const auto &AT : ArgumentTypes) {
3797 const Expr *Arg = Call->getArg(AT.ArgNo)->IgnoreParens();
3798 if (Arg->getType().getCanonicalType() == AT.Type.getCanonicalType())
3800 Diag(Arg->getLocStart(), diag::err_typecheck_convert_incompatible)
3801 << Arg->getType() << AT.Type << 1 /* different class */
3802 << 0 /* qualifier difference */ << 3 /* parameter mismatch */
3803 << AT.ArgNo + 1 << Arg->getType() << AT.Type;
3809 /// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
3810 /// friends. This is declared to take (...), so we have to check everything.
3811 bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
3812 if (TheCall->getNumArgs() < 2)
3813 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
3814 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
3815 if (TheCall->getNumArgs() > 2)
3816 return Diag(TheCall->getArg(2)->getLocStart(),
3817 diag::err_typecheck_call_too_many_args)
3818 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
3819 << SourceRange(TheCall->getArg(2)->getLocStart(),
3820 (*(TheCall->arg_end()-1))->getLocEnd());
3822 ExprResult OrigArg0 = TheCall->getArg(0);
3823 ExprResult OrigArg1 = TheCall->getArg(1);
3825 // Do standard promotions between the two arguments, returning their common
3827 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
3828 if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
3831 // Make sure any conversions are pushed back into the call; this is
3832 // type safe since unordered compare builtins are declared as "_Bool
3834 TheCall->setArg(0, OrigArg0.get());
3835 TheCall->setArg(1, OrigArg1.get());
3837 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
3840 // If the common type isn't a real floating type, then the arguments were
3841 // invalid for this operation.
3842 if (Res.isNull() || !Res->isRealFloatingType())
3843 return Diag(OrigArg0.get()->getLocStart(),
3844 diag::err_typecheck_call_invalid_ordered_compare)
3845 << OrigArg0.get()->getType() << OrigArg1.get()->getType()
3846 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
3851 /// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
3852 /// __builtin_isnan and friends. This is declared to take (...), so we have
3853 /// to check everything. We expect the last argument to be a floating point
3855 bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
3856 if (TheCall->getNumArgs() < NumArgs)
3857 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
3858 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
3859 if (TheCall->getNumArgs() > NumArgs)
3860 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
3861 diag::err_typecheck_call_too_many_args)
3862 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
3863 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
3864 (*(TheCall->arg_end()-1))->getLocEnd());
3866 Expr *OrigArg = TheCall->getArg(NumArgs-1);
3868 if (OrigArg->isTypeDependent())
3871 // This operation requires a non-_Complex floating-point number.
3872 if (!OrigArg->getType()->isRealFloatingType())
3873 return Diag(OrigArg->getLocStart(),
3874 diag::err_typecheck_call_invalid_unary_fp)
3875 << OrigArg->getType() << OrigArg->getSourceRange();
3877 // If this is an implicit conversion from float -> float or double, remove it.
3878 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
3879 // Only remove standard FloatCasts, leaving other casts inplace
3880 if (Cast->getCastKind() == CK_FloatingCast) {
3881 Expr *CastArg = Cast->getSubExpr();
3882 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
3883 assert((Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) ||
3884 Cast->getType()->isSpecificBuiltinType(BuiltinType::Float)) &&
3885 "promotion from float to either float or double is the only expected cast here");
3886 Cast->setSubExpr(nullptr);
3887 TheCall->setArg(NumArgs-1, CastArg);
3895 /// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
3896 // This is declared to take (...), so we have to check everything.
3897 ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
3898 if (TheCall->getNumArgs() < 2)
3899 return ExprError(Diag(TheCall->getLocEnd(),
3900 diag::err_typecheck_call_too_few_args_at_least)
3901 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
3902 << TheCall->getSourceRange());
3904 // Determine which of the following types of shufflevector we're checking:
3905 // 1) unary, vector mask: (lhs, mask)
3906 // 2) binary, scalar mask: (lhs, rhs, index, ..., index)
3907 QualType resType = TheCall->getArg(0)->getType();
3908 unsigned numElements = 0;
3910 if (!TheCall->getArg(0)->isTypeDependent() &&
3911 !TheCall->getArg(1)->isTypeDependent()) {
3912 QualType LHSType = TheCall->getArg(0)->getType();
3913 QualType RHSType = TheCall->getArg(1)->getType();
3915 if (!LHSType->isVectorType() || !RHSType->isVectorType())
3916 return ExprError(Diag(TheCall->getLocStart(),
3917 diag::err_shufflevector_non_vector)
3918 << SourceRange(TheCall->getArg(0)->getLocStart(),
3919 TheCall->getArg(1)->getLocEnd()));
3921 numElements = LHSType->getAs<VectorType>()->getNumElements();
3922 unsigned numResElements = TheCall->getNumArgs() - 2;
3924 // Check to see if we have a call with 2 vector arguments, the unary shuffle
3925 // with mask. If so, verify that RHS is an integer vector type with the
3926 // same number of elts as lhs.
3927 if (TheCall->getNumArgs() == 2) {
3928 if (!RHSType->hasIntegerRepresentation() ||
3929 RHSType->getAs<VectorType>()->getNumElements() != numElements)
3930 return ExprError(Diag(TheCall->getLocStart(),
3931 diag::err_shufflevector_incompatible_vector)
3932 << SourceRange(TheCall->getArg(1)->getLocStart(),
3933 TheCall->getArg(1)->getLocEnd()));
3934 } else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
3935 return ExprError(Diag(TheCall->getLocStart(),
3936 diag::err_shufflevector_incompatible_vector)
3937 << SourceRange(TheCall->getArg(0)->getLocStart(),
3938 TheCall->getArg(1)->getLocEnd()));
3939 } else if (numElements != numResElements) {
3940 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
3941 resType = Context.getVectorType(eltType, numResElements,
3942 VectorType::GenericVector);
3946 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
3947 if (TheCall->getArg(i)->isTypeDependent() ||
3948 TheCall->getArg(i)->isValueDependent())
3951 llvm::APSInt Result(32);
3952 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
3953 return ExprError(Diag(TheCall->getLocStart(),
3954 diag::err_shufflevector_nonconstant_argument)
3955 << TheCall->getArg(i)->getSourceRange());
3957 // Allow -1 which will be translated to undef in the IR.
3958 if (Result.isSigned() && Result.isAllOnesValue())
3961 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
3962 return ExprError(Diag(TheCall->getLocStart(),
3963 diag::err_shufflevector_argument_too_large)
3964 << TheCall->getArg(i)->getSourceRange());
3967 SmallVector<Expr*, 32> exprs;
3969 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
3970 exprs.push_back(TheCall->getArg(i));
3971 TheCall->setArg(i, nullptr);
3974 return new (Context) ShuffleVectorExpr(Context, exprs, resType,
3975 TheCall->getCallee()->getLocStart(),
3976 TheCall->getRParenLoc());
3979 /// SemaConvertVectorExpr - Handle __builtin_convertvector
3980 ExprResult Sema::SemaConvertVectorExpr(Expr *E, TypeSourceInfo *TInfo,
3981 SourceLocation BuiltinLoc,
3982 SourceLocation RParenLoc) {
3983 ExprValueKind VK = VK_RValue;
3984 ExprObjectKind OK = OK_Ordinary;
3985 QualType DstTy = TInfo->getType();
3986 QualType SrcTy = E->getType();
3988 if (!SrcTy->isVectorType() && !SrcTy->isDependentType())
3989 return ExprError(Diag(BuiltinLoc,
3990 diag::err_convertvector_non_vector)
3991 << E->getSourceRange());
3992 if (!DstTy->isVectorType() && !DstTy->isDependentType())
3993 return ExprError(Diag(BuiltinLoc,
3994 diag::err_convertvector_non_vector_type));
3996 if (!SrcTy->isDependentType() && !DstTy->isDependentType()) {
3997 unsigned SrcElts = SrcTy->getAs<VectorType>()->getNumElements();
3998 unsigned DstElts = DstTy->getAs<VectorType>()->getNumElements();
3999 if (SrcElts != DstElts)
4000 return ExprError(Diag(BuiltinLoc,
4001 diag::err_convertvector_incompatible_vector)
4002 << E->getSourceRange());
4005 return new (Context)
4006 ConvertVectorExpr(E, TInfo, DstTy, VK, OK, BuiltinLoc, RParenLoc);
4009 /// SemaBuiltinPrefetch - Handle __builtin_prefetch.
4010 // This is declared to take (const void*, ...) and can take two
4011 // optional constant int args.
4012 bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
4013 unsigned NumArgs = TheCall->getNumArgs();
4016 return Diag(TheCall->getLocEnd(),
4017 diag::err_typecheck_call_too_many_args_at_most)
4018 << 0 /*function call*/ << 3 << NumArgs
4019 << TheCall->getSourceRange();
4021 // Argument 0 is checked for us and the remaining arguments must be
4022 // constant integers.
4023 for (unsigned i = 1; i != NumArgs; ++i)
4024 if (SemaBuiltinConstantArgRange(TheCall, i, 0, i == 1 ? 1 : 3))
4030 /// SemaBuiltinAssume - Handle __assume (MS Extension).
4031 // __assume does not evaluate its arguments, and should warn if its argument
4032 // has side effects.
4033 bool Sema::SemaBuiltinAssume(CallExpr *TheCall) {
4034 Expr *Arg = TheCall->getArg(0);
4035 if (Arg->isInstantiationDependent()) return false;
4037 if (Arg->HasSideEffects(Context))
4038 Diag(Arg->getLocStart(), diag::warn_assume_side_effects)
4039 << Arg->getSourceRange()
4040 << cast<FunctionDecl>(TheCall->getCalleeDecl())->getIdentifier();
4045 /// Handle __builtin_alloca_with_align. This is declared
4046 /// as (size_t, size_t) where the second size_t must be a power of 2 greater
4048 bool Sema::SemaBuiltinAllocaWithAlign(CallExpr *TheCall) {
4049 // The alignment must be a constant integer.
4050 Expr *Arg = TheCall->getArg(1);
4052 // We can't check the value of a dependent argument.
4053 if (!Arg->isTypeDependent() && !Arg->isValueDependent()) {
4054 if (const auto *UE =
4055 dyn_cast<UnaryExprOrTypeTraitExpr>(Arg->IgnoreParenImpCasts()))
4056 if (UE->getKind() == UETT_AlignOf)
4057 Diag(TheCall->getLocStart(), diag::warn_alloca_align_alignof)
4058 << Arg->getSourceRange();
4060 llvm::APSInt Result = Arg->EvaluateKnownConstInt(Context);
4062 if (!Result.isPowerOf2())
4063 return Diag(TheCall->getLocStart(),
4064 diag::err_alignment_not_power_of_two)
4065 << Arg->getSourceRange();
4067 if (Result < Context.getCharWidth())
4068 return Diag(TheCall->getLocStart(), diag::err_alignment_too_small)
4069 << (unsigned)Context.getCharWidth()
4070 << Arg->getSourceRange();
4072 if (Result > INT32_MAX)
4073 return Diag(TheCall->getLocStart(), diag::err_alignment_too_big)
4075 << Arg->getSourceRange();
4081 /// Handle __builtin_assume_aligned. This is declared
4082 /// as (const void*, size_t, ...) and can take one optional constant int arg.
4083 bool Sema::SemaBuiltinAssumeAligned(CallExpr *TheCall) {
4084 unsigned NumArgs = TheCall->getNumArgs();
4087 return Diag(TheCall->getLocEnd(),
4088 diag::err_typecheck_call_too_many_args_at_most)
4089 << 0 /*function call*/ << 3 << NumArgs
4090 << TheCall->getSourceRange();
4092 // The alignment must be a constant integer.
4093 Expr *Arg = TheCall->getArg(1);
4095 // We can't check the value of a dependent argument.
4096 if (!Arg->isTypeDependent() && !Arg->isValueDependent()) {
4097 llvm::APSInt Result;
4098 if (SemaBuiltinConstantArg(TheCall, 1, Result))
4101 if (!Result.isPowerOf2())
4102 return Diag(TheCall->getLocStart(),
4103 diag::err_alignment_not_power_of_two)
4104 << Arg->getSourceRange();
4108 ExprResult Arg(TheCall->getArg(2));
4109 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
4110 Context.getSizeType(), false);
4111 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
4112 if (Arg.isInvalid()) return true;
4113 TheCall->setArg(2, Arg.get());
4119 bool Sema::SemaBuiltinOSLogFormat(CallExpr *TheCall) {
4120 unsigned BuiltinID =
4121 cast<FunctionDecl>(TheCall->getCalleeDecl())->getBuiltinID();
4122 bool IsSizeCall = BuiltinID == Builtin::BI__builtin_os_log_format_buffer_size;
4124 unsigned NumArgs = TheCall->getNumArgs();
4125 unsigned NumRequiredArgs = IsSizeCall ? 1 : 2;
4126 if (NumArgs < NumRequiredArgs) {
4127 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
4128 << 0 /* function call */ << NumRequiredArgs << NumArgs
4129 << TheCall->getSourceRange();
4131 if (NumArgs >= NumRequiredArgs + 0x100) {
4132 return Diag(TheCall->getLocEnd(),
4133 diag::err_typecheck_call_too_many_args_at_most)
4134 << 0 /* function call */ << (NumRequiredArgs + 0xff) << NumArgs
4135 << TheCall->getSourceRange();
4139 // For formatting call, check buffer arg.
4141 ExprResult Arg(TheCall->getArg(i));
4142 InitializedEntity Entity = InitializedEntity::InitializeParameter(
4143 Context, Context.VoidPtrTy, false);
4144 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
4145 if (Arg.isInvalid())
4147 TheCall->setArg(i, Arg.get());
4151 // Check string literal arg.
4152 unsigned FormatIdx = i;
4154 ExprResult Arg = CheckOSLogFormatStringArg(TheCall->getArg(i));
4155 if (Arg.isInvalid())
4157 TheCall->setArg(i, Arg.get());
4161 // Make sure variadic args are scalar.
4162 unsigned FirstDataArg = i;
4163 while (i < NumArgs) {
4164 ExprResult Arg = DefaultVariadicArgumentPromotion(
4165 TheCall->getArg(i), VariadicFunction, nullptr);
4166 if (Arg.isInvalid())
4168 CharUnits ArgSize = Context.getTypeSizeInChars(Arg.get()->getType());
4169 if (ArgSize.getQuantity() >= 0x100) {
4170 return Diag(Arg.get()->getLocEnd(), diag::err_os_log_argument_too_big)
4171 << i << (int)ArgSize.getQuantity() << 0xff
4172 << TheCall->getSourceRange();
4174 TheCall->setArg(i, Arg.get());
4178 // Check formatting specifiers. NOTE: We're only doing this for the non-size
4179 // call to avoid duplicate diagnostics.
4181 llvm::SmallBitVector CheckedVarArgs(NumArgs, false);
4182 ArrayRef<const Expr *> Args(TheCall->getArgs(), TheCall->getNumArgs());
4183 bool Success = CheckFormatArguments(
4184 Args, /*HasVAListArg*/ false, FormatIdx, FirstDataArg, FST_OSLog,
4185 VariadicFunction, TheCall->getLocStart(), SourceRange(),
4192 TheCall->setType(Context.getSizeType());
4194 TheCall->setType(Context.VoidPtrTy);
4199 /// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
4200 /// TheCall is a constant expression.
4201 bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
4202 llvm::APSInt &Result) {
4203 Expr *Arg = TheCall->getArg(ArgNum);
4204 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
4205 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
4207 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
4209 if (!Arg->isIntegerConstantExpr(Result, Context))
4210 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
4211 << FDecl->getDeclName() << Arg->getSourceRange();
4216 /// SemaBuiltinConstantArgRange - Handle a check if argument ArgNum of CallExpr
4217 /// TheCall is a constant expression in the range [Low, High].
4218 bool Sema::SemaBuiltinConstantArgRange(CallExpr *TheCall, int ArgNum,
4219 int Low, int High) {
4220 llvm::APSInt Result;
4222 // We can't check the value of a dependent argument.
4223 Expr *Arg = TheCall->getArg(ArgNum);
4224 if (Arg->isTypeDependent() || Arg->isValueDependent())
4227 // Check constant-ness first.
4228 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result))
4231 if (Result.getSExtValue() < Low || Result.getSExtValue() > High)
4232 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
4233 << Low << High << Arg->getSourceRange();
4238 /// SemaBuiltinConstantArgMultiple - Handle a check if argument ArgNum of CallExpr
4239 /// TheCall is a constant expression is a multiple of Num..
4240 bool Sema::SemaBuiltinConstantArgMultiple(CallExpr *TheCall, int ArgNum,
4242 llvm::APSInt Result;
4244 // We can't check the value of a dependent argument.
4245 Expr *Arg = TheCall->getArg(ArgNum);
4246 if (Arg->isTypeDependent() || Arg->isValueDependent())
4249 // Check constant-ness first.
4250 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result))
4253 if (Result.getSExtValue() % Num != 0)
4254 return Diag(TheCall->getLocStart(), diag::err_argument_not_multiple)
4255 << Num << Arg->getSourceRange();
4260 /// SemaBuiltinARMSpecialReg - Handle a check if argument ArgNum of CallExpr
4261 /// TheCall is an ARM/AArch64 special register string literal.
4262 bool Sema::SemaBuiltinARMSpecialReg(unsigned BuiltinID, CallExpr *TheCall,
4263 int ArgNum, unsigned ExpectedFieldNum,
4265 bool IsARMBuiltin = BuiltinID == ARM::BI__builtin_arm_rsr64 ||
4266 BuiltinID == ARM::BI__builtin_arm_wsr64 ||
4267 BuiltinID == ARM::BI__builtin_arm_rsr ||
4268 BuiltinID == ARM::BI__builtin_arm_rsrp ||
4269 BuiltinID == ARM::BI__builtin_arm_wsr ||
4270 BuiltinID == ARM::BI__builtin_arm_wsrp;
4271 bool IsAArch64Builtin = BuiltinID == AArch64::BI__builtin_arm_rsr64 ||
4272 BuiltinID == AArch64::BI__builtin_arm_wsr64 ||
4273 BuiltinID == AArch64::BI__builtin_arm_rsr ||
4274 BuiltinID == AArch64::BI__builtin_arm_rsrp ||
4275 BuiltinID == AArch64::BI__builtin_arm_wsr ||
4276 BuiltinID == AArch64::BI__builtin_arm_wsrp;
4277 assert((IsARMBuiltin || IsAArch64Builtin) && "Unexpected ARM builtin.");
4279 // We can't check the value of a dependent argument.
4280 Expr *Arg = TheCall->getArg(ArgNum);
4281 if (Arg->isTypeDependent() || Arg->isValueDependent())
4284 // Check if the argument is a string literal.
4285 if (!isa<StringLiteral>(Arg->IgnoreParenImpCasts()))
4286 return Diag(TheCall->getLocStart(), diag::err_expr_not_string_literal)
4287 << Arg->getSourceRange();
4289 // Check the type of special register given.
4290 StringRef Reg = cast<StringLiteral>(Arg->IgnoreParenImpCasts())->getString();
4291 SmallVector<StringRef, 6> Fields;
4292 Reg.split(Fields, ":");
4294 if (Fields.size() != ExpectedFieldNum && !(AllowName && Fields.size() == 1))
4295 return Diag(TheCall->getLocStart(), diag::err_arm_invalid_specialreg)
4296 << Arg->getSourceRange();
4298 // If the string is the name of a register then we cannot check that it is
4299 // valid here but if the string is of one the forms described in ACLE then we
4300 // can check that the supplied fields are integers and within the valid
4302 if (Fields.size() > 1) {
4303 bool FiveFields = Fields.size() == 5;
4305 bool ValidString = true;
4307 ValidString &= Fields[0].startswith_lower("cp") ||
4308 Fields[0].startswith_lower("p");
4311 Fields[0].drop_front(Fields[0].startswith_lower("cp") ? 2 : 1);
4313 ValidString &= Fields[2].startswith_lower("c");
4315 Fields[2] = Fields[2].drop_front(1);
4318 ValidString &= Fields[3].startswith_lower("c");
4320 Fields[3] = Fields[3].drop_front(1);
4324 SmallVector<int, 5> Ranges;
4326 Ranges.append({IsAArch64Builtin ? 1 : 15, 7, 15, 15, 7});
4328 Ranges.append({15, 7, 15});
4330 for (unsigned i=0; i<Fields.size(); ++i) {
4332 ValidString &= !Fields[i].getAsInteger(10, IntField);
4333 ValidString &= (IntField >= 0 && IntField <= Ranges[i]);
4337 return Diag(TheCall->getLocStart(), diag::err_arm_invalid_specialreg)
4338 << Arg->getSourceRange();
4340 } else if (IsAArch64Builtin && Fields.size() == 1) {
4341 // If the register name is one of those that appear in the condition below
4342 // and the special register builtin being used is one of the write builtins,
4343 // then we require that the argument provided for writing to the register
4344 // is an integer constant expression. This is because it will be lowered to
4345 // an MSR (immediate) instruction, so we need to know the immediate at
4347 if (TheCall->getNumArgs() != 2)
4350 std::string RegLower = Reg.lower();
4351 if (RegLower != "spsel" && RegLower != "daifset" && RegLower != "daifclr" &&
4352 RegLower != "pan" && RegLower != "uao")
4355 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 15);
4361 /// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
4362 /// This checks that the target supports __builtin_longjmp and
4363 /// that val is a constant 1.
4364 bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
4365 if (!Context.getTargetInfo().hasSjLjLowering())
4366 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_unsupported)
4367 << SourceRange(TheCall->getLocStart(), TheCall->getLocEnd());
4369 Expr *Arg = TheCall->getArg(1);
4370 llvm::APSInt Result;
4372 // TODO: This is less than ideal. Overload this to take a value.
4373 if (SemaBuiltinConstantArg(TheCall, 1, Result))
4377 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
4378 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
4383 /// SemaBuiltinSetjmp - Handle __builtin_setjmp(void *env[5]).
4384 /// This checks that the target supports __builtin_setjmp.
4385 bool Sema::SemaBuiltinSetjmp(CallExpr *TheCall) {
4386 if (!Context.getTargetInfo().hasSjLjLowering())
4387 return Diag(TheCall->getLocStart(), diag::err_builtin_setjmp_unsupported)
4388 << SourceRange(TheCall->getLocStart(), TheCall->getLocEnd());
4393 class UncoveredArgHandler {
4394 enum { Unknown = -1, AllCovered = -2 };
4395 signed FirstUncoveredArg;
4396 SmallVector<const Expr *, 4> DiagnosticExprs;
4399 UncoveredArgHandler() : FirstUncoveredArg(Unknown) { }
4401 bool hasUncoveredArg() const {
4402 return (FirstUncoveredArg >= 0);
4405 unsigned getUncoveredArg() const {
4406 assert(hasUncoveredArg() && "no uncovered argument");
4407 return FirstUncoveredArg;
4410 void setAllCovered() {
4411 // A string has been found with all arguments covered, so clear out
4413 DiagnosticExprs.clear();
4414 FirstUncoveredArg = AllCovered;
4417 void Update(signed NewFirstUncoveredArg, const Expr *StrExpr) {
4418 assert(NewFirstUncoveredArg >= 0 && "Outside range");
4420 // Don't update if a previous string covers all arguments.
4421 if (FirstUncoveredArg == AllCovered)
4424 // UncoveredArgHandler tracks the highest uncovered argument index
4425 // and with it all the strings that match this index.
4426 if (NewFirstUncoveredArg == FirstUncoveredArg)
4427 DiagnosticExprs.push_back(StrExpr);
4428 else if (NewFirstUncoveredArg > FirstUncoveredArg) {
4429 DiagnosticExprs.clear();
4430 DiagnosticExprs.push_back(StrExpr);
4431 FirstUncoveredArg = NewFirstUncoveredArg;
4435 void Diagnose(Sema &S, bool IsFunctionCall, const Expr *ArgExpr);
4438 enum StringLiteralCheckType {
4440 SLCT_UncheckedLiteral,
4443 } // end anonymous namespace
4445 static void sumOffsets(llvm::APSInt &Offset, llvm::APSInt Addend,
4446 BinaryOperatorKind BinOpKind,
4447 bool AddendIsRight) {
4448 unsigned BitWidth = Offset.getBitWidth();
4449 unsigned AddendBitWidth = Addend.getBitWidth();
4450 // There might be negative interim results.
4451 if (Addend.isUnsigned()) {
4452 Addend = Addend.zext(++AddendBitWidth);
4453 Addend.setIsSigned(true);
4455 // Adjust the bit width of the APSInts.
4456 if (AddendBitWidth > BitWidth) {
4457 Offset = Offset.sext(AddendBitWidth);
4458 BitWidth = AddendBitWidth;
4459 } else if (BitWidth > AddendBitWidth) {
4460 Addend = Addend.sext(BitWidth);
4464 llvm::APSInt ResOffset = Offset;
4465 if (BinOpKind == BO_Add)
4466 ResOffset = Offset.sadd_ov(Addend, Ov);
4468 assert(AddendIsRight && BinOpKind == BO_Sub &&
4469 "operator must be add or sub with addend on the right");
4470 ResOffset = Offset.ssub_ov(Addend, Ov);
4473 // We add an offset to a pointer here so we should support an offset as big as
4476 assert(BitWidth <= UINT_MAX / 2 && "index (intermediate) result too big");
4477 Offset = Offset.sext(2 * BitWidth);
4478 sumOffsets(Offset, Addend, BinOpKind, AddendIsRight);
4486 // This is a wrapper class around StringLiteral to support offsetted string
4487 // literals as format strings. It takes the offset into account when returning
4488 // the string and its length or the source locations to display notes correctly.
4489 class FormatStringLiteral {
4490 const StringLiteral *FExpr;
4494 FormatStringLiteral(const StringLiteral *fexpr, int64_t Offset = 0)
4495 : FExpr(fexpr), Offset(Offset) {}
4497 StringRef getString() const {
4498 return FExpr->getString().drop_front(Offset);
4501 unsigned getByteLength() const {
4502 return FExpr->getByteLength() - getCharByteWidth() * Offset;
4504 unsigned getLength() const { return FExpr->getLength() - Offset; }
4505 unsigned getCharByteWidth() const { return FExpr->getCharByteWidth(); }
4507 StringLiteral::StringKind getKind() const { return FExpr->getKind(); }
4509 QualType getType() const { return FExpr->getType(); }
4511 bool isAscii() const { return FExpr->isAscii(); }
4512 bool isWide() const { return FExpr->isWide(); }
4513 bool isUTF8() const { return FExpr->isUTF8(); }
4514 bool isUTF16() const { return FExpr->isUTF16(); }
4515 bool isUTF32() const { return FExpr->isUTF32(); }
4516 bool isPascal() const { return FExpr->isPascal(); }
4518 SourceLocation getLocationOfByte(
4519 unsigned ByteNo, const SourceManager &SM, const LangOptions &Features,
4520 const TargetInfo &Target, unsigned *StartToken = nullptr,
4521 unsigned *StartTokenByteOffset = nullptr) const {
4522 return FExpr->getLocationOfByte(ByteNo + Offset, SM, Features, Target,
4523 StartToken, StartTokenByteOffset);
4526 SourceLocation getLocStart() const LLVM_READONLY {
4527 return FExpr->getLocStart().getLocWithOffset(Offset);
4529 SourceLocation getLocEnd() const LLVM_READONLY { return FExpr->getLocEnd(); }
4531 } // end anonymous namespace
4533 static void CheckFormatString(Sema &S, const FormatStringLiteral *FExpr,
4534 const Expr *OrigFormatExpr,
4535 ArrayRef<const Expr *> Args,
4536 bool HasVAListArg, unsigned format_idx,
4537 unsigned firstDataArg,
4538 Sema::FormatStringType Type,
4539 bool inFunctionCall,
4540 Sema::VariadicCallType CallType,
4541 llvm::SmallBitVector &CheckedVarArgs,
4542 UncoveredArgHandler &UncoveredArg);
4544 // Determine if an expression is a string literal or constant string.
4545 // If this function returns false on the arguments to a function expecting a
4546 // format string, we will usually need to emit a warning.
4547 // True string literals are then checked by CheckFormatString.
4548 static StringLiteralCheckType
4549 checkFormatStringExpr(Sema &S, const Expr *E, ArrayRef<const Expr *> Args,
4550 bool HasVAListArg, unsigned format_idx,
4551 unsigned firstDataArg, Sema::FormatStringType Type,
4552 Sema::VariadicCallType CallType, bool InFunctionCall,
4553 llvm::SmallBitVector &CheckedVarArgs,
4554 UncoveredArgHandler &UncoveredArg,
4555 llvm::APSInt Offset) {
4557 assert(Offset.isSigned() && "invalid offset");
4559 if (E->isTypeDependent() || E->isValueDependent())
4560 return SLCT_NotALiteral;
4562 E = E->IgnoreParenCasts();
4564 if (E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull))
4565 // Technically -Wformat-nonliteral does not warn about this case.
4566 // The behavior of printf and friends in this case is implementation
4567 // dependent. Ideally if the format string cannot be null then
4568 // it should have a 'nonnull' attribute in the function prototype.
4569 return SLCT_UncheckedLiteral;
4571 switch (E->getStmtClass()) {
4572 case Stmt::BinaryConditionalOperatorClass:
4573 case Stmt::ConditionalOperatorClass: {
4574 // The expression is a literal if both sub-expressions were, and it was
4575 // completely checked only if both sub-expressions were checked.
4576 const AbstractConditionalOperator *C =
4577 cast<AbstractConditionalOperator>(E);
4579 // Determine whether it is necessary to check both sub-expressions, for
4580 // example, because the condition expression is a constant that can be
4581 // evaluated at compile time.
4582 bool CheckLeft = true, CheckRight = true;
4585 if (C->getCond()->EvaluateAsBooleanCondition(Cond, S.getASTContext())) {
4592 // We need to maintain the offsets for the right and the left hand side
4593 // separately to check if every possible indexed expression is a valid
4594 // string literal. They might have different offsets for different string
4595 // literals in the end.
4596 StringLiteralCheckType Left;
4598 Left = SLCT_UncheckedLiteral;
4600 Left = checkFormatStringExpr(S, C->getTrueExpr(), Args,
4601 HasVAListArg, format_idx, firstDataArg,
4602 Type, CallType, InFunctionCall,
4603 CheckedVarArgs, UncoveredArg, Offset);
4604 if (Left == SLCT_NotALiteral || !CheckRight) {
4609 StringLiteralCheckType Right =
4610 checkFormatStringExpr(S, C->getFalseExpr(), Args,
4611 HasVAListArg, format_idx, firstDataArg,
4612 Type, CallType, InFunctionCall, CheckedVarArgs,
4613 UncoveredArg, Offset);
4615 return (CheckLeft && Left < Right) ? Left : Right;
4618 case Stmt::ImplicitCastExprClass: {
4619 E = cast<ImplicitCastExpr>(E)->getSubExpr();
4623 case Stmt::OpaqueValueExprClass:
4624 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
4628 return SLCT_NotALiteral;
4630 case Stmt::PredefinedExprClass:
4631 // While __func__, etc., are technically not string literals, they
4632 // cannot contain format specifiers and thus are not a security
4634 return SLCT_UncheckedLiteral;
4636 case Stmt::DeclRefExprClass: {
4637 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
4639 // As an exception, do not flag errors for variables binding to
4640 // const string literals.
4641 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
4642 bool isConstant = false;
4643 QualType T = DR->getType();
4645 if (const ArrayType *AT = S.Context.getAsArrayType(T)) {
4646 isConstant = AT->getElementType().isConstant(S.Context);
4647 } else if (const PointerType *PT = T->getAs<PointerType>()) {
4648 isConstant = T.isConstant(S.Context) &&
4649 PT->getPointeeType().isConstant(S.Context);
4650 } else if (T->isObjCObjectPointerType()) {
4651 // In ObjC, there is usually no "const ObjectPointer" type,
4652 // so don't check if the pointee type is constant.
4653 isConstant = T.isConstant(S.Context);
4657 if (const Expr *Init = VD->getAnyInitializer()) {
4658 // Look through initializers like const char c[] = { "foo" }
4659 if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
4660 if (InitList->isStringLiteralInit())
4661 Init = InitList->getInit(0)->IgnoreParenImpCasts();
4663 return checkFormatStringExpr(S, Init, Args,
4664 HasVAListArg, format_idx,
4665 firstDataArg, Type, CallType,
4666 /*InFunctionCall*/ false, CheckedVarArgs,
4667 UncoveredArg, Offset);
4671 // For vprintf* functions (i.e., HasVAListArg==true), we add a
4672 // special check to see if the format string is a function parameter
4673 // of the function calling the printf function. If the function
4674 // has an attribute indicating it is a printf-like function, then we
4675 // should suppress warnings concerning non-literals being used in a call
4676 // to a vprintf function. For example:
4679 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
4681 // va_start(ap, fmt);
4682 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
4686 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
4687 if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
4688 int PVIndex = PV->getFunctionScopeIndex() + 1;
4689 for (const auto *PVFormat : ND->specific_attrs<FormatAttr>()) {
4690 // adjust for implicit parameter
4691 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
4692 if (MD->isInstance())
4694 // We also check if the formats are compatible.
4695 // We can't pass a 'scanf' string to a 'printf' function.
4696 if (PVIndex == PVFormat->getFormatIdx() &&
4697 Type == S.GetFormatStringType(PVFormat))
4698 return SLCT_UncheckedLiteral;
4705 return SLCT_NotALiteral;
4708 case Stmt::CallExprClass:
4709 case Stmt::CXXMemberCallExprClass: {
4710 const CallExpr *CE = cast<CallExpr>(E);
4711 if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
4712 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
4713 unsigned ArgIndex = FA->getFormatIdx();
4714 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
4715 if (MD->isInstance())
4717 const Expr *Arg = CE->getArg(ArgIndex - 1);
4719 return checkFormatStringExpr(S, Arg, Args,
4720 HasVAListArg, format_idx, firstDataArg,
4721 Type, CallType, InFunctionCall,
4722 CheckedVarArgs, UncoveredArg, Offset);
4723 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
4724 unsigned BuiltinID = FD->getBuiltinID();
4725 if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
4726 BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
4727 const Expr *Arg = CE->getArg(0);
4728 return checkFormatStringExpr(S, Arg, Args,
4729 HasVAListArg, format_idx,
4730 firstDataArg, Type, CallType,
4731 InFunctionCall, CheckedVarArgs,
4732 UncoveredArg, Offset);
4737 return SLCT_NotALiteral;
4739 case Stmt::ObjCMessageExprClass: {
4740 const auto *ME = cast<ObjCMessageExpr>(E);
4741 if (const auto *ND = ME->getMethodDecl()) {
4742 if (const auto *FA = ND->getAttr<FormatArgAttr>()) {
4743 unsigned ArgIndex = FA->getFormatIdx();
4744 const Expr *Arg = ME->getArg(ArgIndex - 1);
4745 return checkFormatStringExpr(
4746 S, Arg, Args, HasVAListArg, format_idx, firstDataArg, Type,
4747 CallType, InFunctionCall, CheckedVarArgs, UncoveredArg, Offset);
4751 return SLCT_NotALiteral;
4753 case Stmt::ObjCStringLiteralClass:
4754 case Stmt::StringLiteralClass: {
4755 const StringLiteral *StrE = nullptr;
4757 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
4758 StrE = ObjCFExpr->getString();
4760 StrE = cast<StringLiteral>(E);
4763 if (Offset.isNegative() || Offset > StrE->getLength()) {
4764 // TODO: It would be better to have an explicit warning for out of
4766 return SLCT_NotALiteral;
4768 FormatStringLiteral FStr(StrE, Offset.sextOrTrunc(64).getSExtValue());
4769 CheckFormatString(S, &FStr, E, Args, HasVAListArg, format_idx,
4770 firstDataArg, Type, InFunctionCall, CallType,
4771 CheckedVarArgs, UncoveredArg);
4772 return SLCT_CheckedLiteral;
4775 return SLCT_NotALiteral;
4777 case Stmt::BinaryOperatorClass: {
4778 llvm::APSInt LResult;
4779 llvm::APSInt RResult;
4781 const BinaryOperator *BinOp = cast<BinaryOperator>(E);
4783 // A string literal + an int offset is still a string literal.
4784 if (BinOp->isAdditiveOp()) {
4785 bool LIsInt = BinOp->getLHS()->EvaluateAsInt(LResult, S.Context);
4786 bool RIsInt = BinOp->getRHS()->EvaluateAsInt(RResult, S.Context);
4788 if (LIsInt != RIsInt) {
4789 BinaryOperatorKind BinOpKind = BinOp->getOpcode();
4792 if (BinOpKind == BO_Add) {
4793 sumOffsets(Offset, LResult, BinOpKind, RIsInt);
4794 E = BinOp->getRHS();
4798 sumOffsets(Offset, RResult, BinOpKind, RIsInt);
4799 E = BinOp->getLHS();
4805 return SLCT_NotALiteral;
4807 case Stmt::UnaryOperatorClass: {
4808 const UnaryOperator *UnaOp = cast<UnaryOperator>(E);
4809 auto ASE = dyn_cast<ArraySubscriptExpr>(UnaOp->getSubExpr());
4810 if (UnaOp->getOpcode() == clang::UO_AddrOf && ASE) {
4811 llvm::APSInt IndexResult;
4812 if (ASE->getRHS()->EvaluateAsInt(IndexResult, S.Context)) {
4813 sumOffsets(Offset, IndexResult, BO_Add, /*RHS is int*/ true);
4819 return SLCT_NotALiteral;
4823 return SLCT_NotALiteral;
4827 Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
4828 return llvm::StringSwitch<FormatStringType>(Format->getType()->getName())
4829 .Case("scanf", FST_Scanf)
4830 .Cases("printf", "printf0", FST_Printf)
4831 .Cases("NSString", "CFString", FST_NSString)
4832 .Case("strftime", FST_Strftime)
4833 .Case("strfmon", FST_Strfmon)
4834 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
4835 .Case("freebsd_kprintf", FST_FreeBSDKPrintf)
4836 .Case("os_trace", FST_OSLog)
4837 .Case("os_log", FST_OSLog)
4838 .Default(FST_Unknown);
4841 /// CheckFormatArguments - Check calls to printf and scanf (and similar
4842 /// functions) for correct use of format strings.
4843 /// Returns true if a format string has been fully checked.
4844 bool Sema::CheckFormatArguments(const FormatAttr *Format,
4845 ArrayRef<const Expr *> Args,
4847 VariadicCallType CallType,
4848 SourceLocation Loc, SourceRange Range,
4849 llvm::SmallBitVector &CheckedVarArgs) {
4850 FormatStringInfo FSI;
4851 if (getFormatStringInfo(Format, IsCXXMember, &FSI))
4852 return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx,
4853 FSI.FirstDataArg, GetFormatStringType(Format),
4854 CallType, Loc, Range, CheckedVarArgs);
4858 bool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args,
4859 bool HasVAListArg, unsigned format_idx,
4860 unsigned firstDataArg, FormatStringType Type,
4861 VariadicCallType CallType,
4862 SourceLocation Loc, SourceRange Range,
4863 llvm::SmallBitVector &CheckedVarArgs) {
4864 // CHECK: printf/scanf-like function is called with no format string.
4865 if (format_idx >= Args.size()) {
4866 Diag(Loc, diag::warn_missing_format_string) << Range;
4870 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
4872 // CHECK: format string is not a string literal.
4874 // Dynamically generated format strings are difficult to
4875 // automatically vet at compile time. Requiring that format strings
4876 // are string literals: (1) permits the checking of format strings by
4877 // the compiler and thereby (2) can practically remove the source of
4878 // many format string exploits.
4880 // Format string can be either ObjC string (e.g. @"%d") or
4881 // C string (e.g. "%d")
4882 // ObjC string uses the same format specifiers as C string, so we can use
4883 // the same format string checking logic for both ObjC and C strings.
4884 UncoveredArgHandler UncoveredArg;
4885 StringLiteralCheckType CT =
4886 checkFormatStringExpr(*this, OrigFormatExpr, Args, HasVAListArg,
4887 format_idx, firstDataArg, Type, CallType,
4888 /*IsFunctionCall*/ true, CheckedVarArgs,
4890 /*no string offset*/ llvm::APSInt(64, false) = 0);
4892 // Generate a diagnostic where an uncovered argument is detected.
4893 if (UncoveredArg.hasUncoveredArg()) {
4894 unsigned ArgIdx = UncoveredArg.getUncoveredArg() + firstDataArg;
4895 assert(ArgIdx < Args.size() && "ArgIdx outside bounds");
4896 UncoveredArg.Diagnose(*this, /*IsFunctionCall*/true, Args[ArgIdx]);
4899 if (CT != SLCT_NotALiteral)
4900 // Literal format string found, check done!
4901 return CT == SLCT_CheckedLiteral;
4903 // Strftime is particular as it always uses a single 'time' argument,
4904 // so it is safe to pass a non-literal string.
4905 if (Type == FST_Strftime)
4908 // Do not emit diag when the string param is a macro expansion and the
4909 // format is either NSString or CFString. This is a hack to prevent
4910 // diag when using the NSLocalizedString and CFCopyLocalizedString macros
4911 // which are usually used in place of NS and CF string literals.
4912 SourceLocation FormatLoc = Args[format_idx]->getLocStart();
4913 if (Type == FST_NSString && SourceMgr.isInSystemMacro(FormatLoc))
4916 // If there are no arguments specified, warn with -Wformat-security, otherwise
4917 // warn only with -Wformat-nonliteral.
4918 if (Args.size() == firstDataArg) {
4919 Diag(FormatLoc, diag::warn_format_nonliteral_noargs)
4920 << OrigFormatExpr->getSourceRange();
4925 case FST_FreeBSDKPrintf:
4927 Diag(FormatLoc, diag::note_format_security_fixit)
4928 << FixItHint::CreateInsertion(FormatLoc, "\"%s\", ");
4931 Diag(FormatLoc, diag::note_format_security_fixit)
4932 << FixItHint::CreateInsertion(FormatLoc, "@\"%@\", ");
4936 Diag(FormatLoc, diag::warn_format_nonliteral)
4937 << OrigFormatExpr->getSourceRange();
4943 class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
4946 const FormatStringLiteral *FExpr;
4947 const Expr *OrigFormatExpr;
4948 const Sema::FormatStringType FSType;
4949 const unsigned FirstDataArg;
4950 const unsigned NumDataArgs;
4951 const char *Beg; // Start of format string.
4952 const bool HasVAListArg;
4953 ArrayRef<const Expr *> Args;
4955 llvm::SmallBitVector CoveredArgs;
4956 bool usesPositionalArgs;
4958 bool inFunctionCall;
4959 Sema::VariadicCallType CallType;
4960 llvm::SmallBitVector &CheckedVarArgs;
4961 UncoveredArgHandler &UncoveredArg;
4964 CheckFormatHandler(Sema &s, const FormatStringLiteral *fexpr,
4965 const Expr *origFormatExpr,
4966 const Sema::FormatStringType type, unsigned firstDataArg,
4967 unsigned numDataArgs, const char *beg, bool hasVAListArg,
4968 ArrayRef<const Expr *> Args, unsigned formatIdx,
4969 bool inFunctionCall, Sema::VariadicCallType callType,
4970 llvm::SmallBitVector &CheckedVarArgs,
4971 UncoveredArgHandler &UncoveredArg)
4972 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), FSType(type),
4973 FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), Beg(beg),
4974 HasVAListArg(hasVAListArg), Args(Args), FormatIdx(formatIdx),
4975 usesPositionalArgs(false), atFirstArg(true),
4976 inFunctionCall(inFunctionCall), CallType(callType),
4977 CheckedVarArgs(CheckedVarArgs), UncoveredArg(UncoveredArg) {
4978 CoveredArgs.resize(numDataArgs);
4979 CoveredArgs.reset();
4982 void DoneProcessing();
4984 void HandleIncompleteSpecifier(const char *startSpecifier,
4985 unsigned specifierLen) override;
4987 void HandleInvalidLengthModifier(
4988 const analyze_format_string::FormatSpecifier &FS,
4989 const analyze_format_string::ConversionSpecifier &CS,
4990 const char *startSpecifier, unsigned specifierLen,
4993 void HandleNonStandardLengthModifier(
4994 const analyze_format_string::FormatSpecifier &FS,
4995 const char *startSpecifier, unsigned specifierLen);
4997 void HandleNonStandardConversionSpecifier(
4998 const analyze_format_string::ConversionSpecifier &CS,
4999 const char *startSpecifier, unsigned specifierLen);
5001 void HandlePosition(const char *startPos, unsigned posLen) override;
5003 void HandleInvalidPosition(const char *startSpecifier,
5004 unsigned specifierLen,
5005 analyze_format_string::PositionContext p) override;
5007 void HandleZeroPosition(const char *startPos, unsigned posLen) override;
5009 void HandleNullChar(const char *nullCharacter) override;
5011 template <typename Range>
5013 EmitFormatDiagnostic(Sema &S, bool inFunctionCall, const Expr *ArgumentExpr,
5014 const PartialDiagnostic &PDiag, SourceLocation StringLoc,
5015 bool IsStringLocation, Range StringRange,
5016 ArrayRef<FixItHint> Fixit = None);
5019 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
5020 const char *startSpec,
5021 unsigned specifierLen,
5022 const char *csStart, unsigned csLen);
5024 void HandlePositionalNonpositionalArgs(SourceLocation Loc,
5025 const char *startSpec,
5026 unsigned specifierLen);
5028 SourceRange getFormatStringRange();
5029 CharSourceRange getSpecifierRange(const char *startSpecifier,
5030 unsigned specifierLen);
5031 SourceLocation getLocationOfByte(const char *x);
5033 const Expr *getDataArg(unsigned i) const;
5035 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
5036 const analyze_format_string::ConversionSpecifier &CS,
5037 const char *startSpecifier, unsigned specifierLen,
5040 template <typename Range>
5041 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
5042 bool IsStringLocation, Range StringRange,
5043 ArrayRef<FixItHint> Fixit = None);
5045 } // end anonymous namespace
5047 SourceRange CheckFormatHandler::getFormatStringRange() {
5048 return OrigFormatExpr->getSourceRange();
5051 CharSourceRange CheckFormatHandler::
5052 getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
5053 SourceLocation Start = getLocationOfByte(startSpecifier);
5054 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
5056 // Advance the end SourceLocation by one due to half-open ranges.
5057 End = End.getLocWithOffset(1);
5059 return CharSourceRange::getCharRange(Start, End);
5062 SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
5063 return FExpr->getLocationOfByte(x - Beg, S.getSourceManager(),
5064 S.getLangOpts(), S.Context.getTargetInfo());
5067 void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
5068 unsigned specifierLen){
5069 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
5070 getLocationOfByte(startSpecifier),
5071 /*IsStringLocation*/true,
5072 getSpecifierRange(startSpecifier, specifierLen));
5075 void CheckFormatHandler::HandleInvalidLengthModifier(
5076 const analyze_format_string::FormatSpecifier &FS,
5077 const analyze_format_string::ConversionSpecifier &CS,
5078 const char *startSpecifier, unsigned specifierLen, unsigned DiagID) {
5079 using namespace analyze_format_string;
5081 const LengthModifier &LM = FS.getLengthModifier();
5082 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
5084 // See if we know how to fix this length modifier.
5085 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
5087 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
5088 getLocationOfByte(LM.getStart()),
5089 /*IsStringLocation*/true,
5090 getSpecifierRange(startSpecifier, specifierLen));
5092 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
5093 << FixedLM->toString()
5094 << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
5098 if (DiagID == diag::warn_format_nonsensical_length)
5099 Hint = FixItHint::CreateRemoval(LMRange);
5101 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
5102 getLocationOfByte(LM.getStart()),
5103 /*IsStringLocation*/true,
5104 getSpecifierRange(startSpecifier, specifierLen),
5109 void CheckFormatHandler::HandleNonStandardLengthModifier(
5110 const analyze_format_string::FormatSpecifier &FS,
5111 const char *startSpecifier, unsigned specifierLen) {
5112 using namespace analyze_format_string;
5114 const LengthModifier &LM = FS.getLengthModifier();
5115 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
5117 // See if we know how to fix this length modifier.
5118 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
5120 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
5121 << LM.toString() << 0,
5122 getLocationOfByte(LM.getStart()),
5123 /*IsStringLocation*/true,
5124 getSpecifierRange(startSpecifier, specifierLen));
5126 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
5127 << FixedLM->toString()
5128 << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
5131 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
5132 << LM.toString() << 0,
5133 getLocationOfByte(LM.getStart()),
5134 /*IsStringLocation*/true,
5135 getSpecifierRange(startSpecifier, specifierLen));
5139 void CheckFormatHandler::HandleNonStandardConversionSpecifier(
5140 const analyze_format_string::ConversionSpecifier &CS,
5141 const char *startSpecifier, unsigned specifierLen) {
5142 using namespace analyze_format_string;
5144 // See if we know how to fix this conversion specifier.
5145 Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier();
5147 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
5148 << CS.toString() << /*conversion specifier*/1,
5149 getLocationOfByte(CS.getStart()),
5150 /*IsStringLocation*/true,
5151 getSpecifierRange(startSpecifier, specifierLen));
5153 CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength());
5154 S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier)
5155 << FixedCS->toString()
5156 << FixItHint::CreateReplacement(CSRange, FixedCS->toString());
5158 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
5159 << CS.toString() << /*conversion specifier*/1,
5160 getLocationOfByte(CS.getStart()),
5161 /*IsStringLocation*/true,
5162 getSpecifierRange(startSpecifier, specifierLen));
5166 void CheckFormatHandler::HandlePosition(const char *startPos,
5168 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
5169 getLocationOfByte(startPos),
5170 /*IsStringLocation*/true,
5171 getSpecifierRange(startPos, posLen));
5175 CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
5176 analyze_format_string::PositionContext p) {
5177 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
5179 getLocationOfByte(startPos), /*IsStringLocation*/true,
5180 getSpecifierRange(startPos, posLen));
5183 void CheckFormatHandler::HandleZeroPosition(const char *startPos,
5185 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
5186 getLocationOfByte(startPos),
5187 /*IsStringLocation*/true,
5188 getSpecifierRange(startPos, posLen));
5191 void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
5192 if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
5193 // The presence of a null character is likely an error.
5194 EmitFormatDiagnostic(
5195 S.PDiag(diag::warn_printf_format_string_contains_null_char),
5196 getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
5197 getFormatStringRange());
5201 // Note that this may return NULL if there was an error parsing or building
5202 // one of the argument expressions.
5203 const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
5204 return Args[FirstDataArg + i];
5207 void CheckFormatHandler::DoneProcessing() {
5208 // Does the number of data arguments exceed the number of
5209 // format conversions in the format string?
5210 if (!HasVAListArg) {
5211 // Find any arguments that weren't covered.
5213 signed notCoveredArg = CoveredArgs.find_first();
5214 if (notCoveredArg >= 0) {
5215 assert((unsigned)notCoveredArg < NumDataArgs);
5216 UncoveredArg.Update(notCoveredArg, OrigFormatExpr);
5218 UncoveredArg.setAllCovered();
5223 void UncoveredArgHandler::Diagnose(Sema &S, bool IsFunctionCall,
5224 const Expr *ArgExpr) {
5225 assert(hasUncoveredArg() && DiagnosticExprs.size() > 0 &&
5231 SourceLocation Loc = ArgExpr->getLocStart();
5233 if (S.getSourceManager().isInSystemMacro(Loc))
5236 PartialDiagnostic PDiag = S.PDiag(diag::warn_printf_data_arg_not_used);
5237 for (auto E : DiagnosticExprs)
5238 PDiag << E->getSourceRange();
5240 CheckFormatHandler::EmitFormatDiagnostic(
5241 S, IsFunctionCall, DiagnosticExprs[0],
5242 PDiag, Loc, /*IsStringLocation*/false,
5243 DiagnosticExprs[0]->getSourceRange());
5247 CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
5249 const char *startSpec,
5250 unsigned specifierLen,
5251 const char *csStart,
5253 bool keepGoing = true;
5254 if (argIndex < NumDataArgs) {
5255 // Consider the argument coverered, even though the specifier doesn't
5257 CoveredArgs.set(argIndex);
5260 // If argIndex exceeds the number of data arguments we
5261 // don't issue a warning because that is just a cascade of warnings (and
5262 // they may have intended '%%' anyway). We don't want to continue processing
5263 // the format string after this point, however, as we will like just get
5264 // gibberish when trying to match arguments.
5268 StringRef Specifier(csStart, csLen);
5270 // If the specifier in non-printable, it could be the first byte of a UTF-8
5271 // sequence. In that case, print the UTF-8 code point. If not, print the byte
5273 std::string CodePointStr;
5274 if (!llvm::sys::locale::isPrint(*csStart)) {
5275 llvm::UTF32 CodePoint;
5276 const llvm::UTF8 **B = reinterpret_cast<const llvm::UTF8 **>(&csStart);
5277 const llvm::UTF8 *E =
5278 reinterpret_cast<const llvm::UTF8 *>(csStart + csLen);
5279 llvm::ConversionResult Result =
5280 llvm::convertUTF8Sequence(B, E, &CodePoint, llvm::strictConversion);
5282 if (Result != llvm::conversionOK) {
5283 unsigned char FirstChar = *csStart;
5284 CodePoint = (llvm::UTF32)FirstChar;
5287 llvm::raw_string_ostream OS(CodePointStr);
5288 if (CodePoint < 256)
5289 OS << "\\x" << llvm::format("%02x", CodePoint);
5290 else if (CodePoint <= 0xFFFF)
5291 OS << "\\u" << llvm::format("%04x", CodePoint);
5293 OS << "\\U" << llvm::format("%08x", CodePoint);
5295 Specifier = CodePointStr;
5298 EmitFormatDiagnostic(
5299 S.PDiag(diag::warn_format_invalid_conversion) << Specifier, Loc,
5300 /*IsStringLocation*/ true, getSpecifierRange(startSpec, specifierLen));
5306 CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
5307 const char *startSpec,
5308 unsigned specifierLen) {
5309 EmitFormatDiagnostic(
5310 S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
5311 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
5315 CheckFormatHandler::CheckNumArgs(
5316 const analyze_format_string::FormatSpecifier &FS,
5317 const analyze_format_string::ConversionSpecifier &CS,
5318 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
5320 if (argIndex >= NumDataArgs) {
5321 PartialDiagnostic PDiag = FS.usesPositionalArg()
5322 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
5323 << (argIndex+1) << NumDataArgs)
5324 : S.PDiag(diag::warn_printf_insufficient_data_args);
5325 EmitFormatDiagnostic(
5326 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
5327 getSpecifierRange(startSpecifier, specifierLen));
5329 // Since more arguments than conversion tokens are given, by extension
5330 // all arguments are covered, so mark this as so.
5331 UncoveredArg.setAllCovered();
5337 template<typename Range>
5338 void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
5340 bool IsStringLocation,
5342 ArrayRef<FixItHint> FixIt) {
5343 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
5344 Loc, IsStringLocation, StringRange, FixIt);
5347 /// \brief If the format string is not within the funcion call, emit a note
5348 /// so that the function call and string are in diagnostic messages.
5350 /// \param InFunctionCall if true, the format string is within the function
5351 /// call and only one diagnostic message will be produced. Otherwise, an
5352 /// extra note will be emitted pointing to location of the format string.
5354 /// \param ArgumentExpr the expression that is passed as the format string
5355 /// argument in the function call. Used for getting locations when two
5356 /// diagnostics are emitted.
5358 /// \param PDiag the callee should already have provided any strings for the
5359 /// diagnostic message. This function only adds locations and fixits
5362 /// \param Loc primary location for diagnostic. If two diagnostics are
5363 /// required, one will be at Loc and a new SourceLocation will be created for
5366 /// \param IsStringLocation if true, Loc points to the format string should be
5367 /// used for the note. Otherwise, Loc points to the argument list and will
5368 /// be used with PDiag.
5370 /// \param StringRange some or all of the string to highlight. This is
5371 /// templated so it can accept either a CharSourceRange or a SourceRange.
5373 /// \param FixIt optional fix it hint for the format string.
5374 template <typename Range>
5375 void CheckFormatHandler::EmitFormatDiagnostic(
5376 Sema &S, bool InFunctionCall, const Expr *ArgumentExpr,
5377 const PartialDiagnostic &PDiag, SourceLocation Loc, bool IsStringLocation,
5378 Range StringRange, ArrayRef<FixItHint> FixIt) {
5379 if (InFunctionCall) {
5380 const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag);
5384 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
5385 << ArgumentExpr->getSourceRange();
5387 const Sema::SemaDiagnosticBuilder &Note =
5388 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
5389 diag::note_format_string_defined);
5391 Note << StringRange;
5396 //===--- CHECK: Printf format string checking ------------------------------===//
5399 class CheckPrintfHandler : public CheckFormatHandler {
5401 CheckPrintfHandler(Sema &s, const FormatStringLiteral *fexpr,
5402 const Expr *origFormatExpr,
5403 const Sema::FormatStringType type, unsigned firstDataArg,
5404 unsigned numDataArgs, bool isObjC, const char *beg,
5405 bool hasVAListArg, ArrayRef<const Expr *> Args,
5406 unsigned formatIdx, bool inFunctionCall,
5407 Sema::VariadicCallType CallType,
5408 llvm::SmallBitVector &CheckedVarArgs,
5409 UncoveredArgHandler &UncoveredArg)
5410 : CheckFormatHandler(s, fexpr, origFormatExpr, type, firstDataArg,
5411 numDataArgs, beg, hasVAListArg, Args, formatIdx,
5412 inFunctionCall, CallType, CheckedVarArgs,
5415 bool isObjCContext() const { return FSType == Sema::FST_NSString; }
5417 /// Returns true if '%@' specifiers are allowed in the format string.
5418 bool allowsObjCArg() const {
5419 return FSType == Sema::FST_NSString || FSType == Sema::FST_OSLog ||
5420 FSType == Sema::FST_OSTrace;
5423 bool HandleInvalidPrintfConversionSpecifier(
5424 const analyze_printf::PrintfSpecifier &FS,
5425 const char *startSpecifier,
5426 unsigned specifierLen) override;
5428 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
5429 const char *startSpecifier,
5430 unsigned specifierLen) override;
5431 bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
5432 const char *StartSpecifier,
5433 unsigned SpecifierLen,
5436 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
5437 const char *startSpecifier, unsigned specifierLen);
5438 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
5439 const analyze_printf::OptionalAmount &Amt,
5441 const char *startSpecifier, unsigned specifierLen);
5442 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
5443 const analyze_printf::OptionalFlag &flag,
5444 const char *startSpecifier, unsigned specifierLen);
5445 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
5446 const analyze_printf::OptionalFlag &ignoredFlag,
5447 const analyze_printf::OptionalFlag &flag,
5448 const char *startSpecifier, unsigned specifierLen);
5449 bool checkForCStrMembers(const analyze_printf::ArgType &AT,
5452 void HandleEmptyObjCModifierFlag(const char *startFlag,
5453 unsigned flagLen) override;
5455 void HandleInvalidObjCModifierFlag(const char *startFlag,
5456 unsigned flagLen) override;
5458 void HandleObjCFlagsWithNonObjCConversion(const char *flagsStart,
5459 const char *flagsEnd,
5460 const char *conversionPosition)
5463 } // end anonymous namespace
5465 bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
5466 const analyze_printf::PrintfSpecifier &FS,
5467 const char *startSpecifier,
5468 unsigned specifierLen) {
5469 const analyze_printf::PrintfConversionSpecifier &CS =
5470 FS.getConversionSpecifier();
5472 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
5473 getLocationOfByte(CS.getStart()),
5474 startSpecifier, specifierLen,
5475 CS.getStart(), CS.getLength());
5478 bool CheckPrintfHandler::HandleAmount(
5479 const analyze_format_string::OptionalAmount &Amt,
5480 unsigned k, const char *startSpecifier,
5481 unsigned specifierLen) {
5482 if (Amt.hasDataArgument()) {
5483 if (!HasVAListArg) {
5484 unsigned argIndex = Amt.getArgIndex();
5485 if (argIndex >= NumDataArgs) {
5486 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
5488 getLocationOfByte(Amt.getStart()),
5489 /*IsStringLocation*/true,
5490 getSpecifierRange(startSpecifier, specifierLen));
5491 // Don't do any more checking. We will just emit
5496 // Type check the data argument. It should be an 'int'.
5497 // Although not in conformance with C99, we also allow the argument to be
5498 // an 'unsigned int' as that is a reasonably safe case. GCC also
5499 // doesn't emit a warning for that case.
5500 CoveredArgs.set(argIndex);
5501 const Expr *Arg = getDataArg(argIndex);
5505 QualType T = Arg->getType();
5507 const analyze_printf::ArgType &AT = Amt.getArgType(S.Context);
5508 assert(AT.isValid());
5510 if (!AT.matchesType(S.Context, T)) {
5511 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
5512 << k << AT.getRepresentativeTypeName(S.Context)
5513 << T << Arg->getSourceRange(),
5514 getLocationOfByte(Amt.getStart()),
5515 /*IsStringLocation*/true,
5516 getSpecifierRange(startSpecifier, specifierLen));
5517 // Don't do any more checking. We will just emit
5526 void CheckPrintfHandler::HandleInvalidAmount(
5527 const analyze_printf::PrintfSpecifier &FS,
5528 const analyze_printf::OptionalAmount &Amt,
5530 const char *startSpecifier,
5531 unsigned specifierLen) {
5532 const analyze_printf::PrintfConversionSpecifier &CS =
5533 FS.getConversionSpecifier();
5536 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
5537 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
5538 Amt.getConstantLength()))
5541 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
5542 << type << CS.toString(),
5543 getLocationOfByte(Amt.getStart()),
5544 /*IsStringLocation*/true,
5545 getSpecifierRange(startSpecifier, specifierLen),
5549 void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
5550 const analyze_printf::OptionalFlag &flag,
5551 const char *startSpecifier,
5552 unsigned specifierLen) {
5553 // Warn about pointless flag with a fixit removal.
5554 const analyze_printf::PrintfConversionSpecifier &CS =
5555 FS.getConversionSpecifier();
5556 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
5557 << flag.toString() << CS.toString(),
5558 getLocationOfByte(flag.getPosition()),
5559 /*IsStringLocation*/true,
5560 getSpecifierRange(startSpecifier, specifierLen),
5561 FixItHint::CreateRemoval(
5562 getSpecifierRange(flag.getPosition(), 1)));
5565 void CheckPrintfHandler::HandleIgnoredFlag(
5566 const analyze_printf::PrintfSpecifier &FS,
5567 const analyze_printf::OptionalFlag &ignoredFlag,
5568 const analyze_printf::OptionalFlag &flag,
5569 const char *startSpecifier,
5570 unsigned specifierLen) {
5571 // Warn about ignored flag with a fixit removal.
5572 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
5573 << ignoredFlag.toString() << flag.toString(),
5574 getLocationOfByte(ignoredFlag.getPosition()),
5575 /*IsStringLocation*/true,
5576 getSpecifierRange(startSpecifier, specifierLen),
5577 FixItHint::CreateRemoval(
5578 getSpecifierRange(ignoredFlag.getPosition(), 1)));
5581 // void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
5582 // bool IsStringLocation, Range StringRange,
5583 // ArrayRef<FixItHint> Fixit = None);
5585 void CheckPrintfHandler::HandleEmptyObjCModifierFlag(const char *startFlag,
5587 // Warn about an empty flag.
5588 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_empty_objc_flag),
5589 getLocationOfByte(startFlag),
5590 /*IsStringLocation*/true,
5591 getSpecifierRange(startFlag, flagLen));
5594 void CheckPrintfHandler::HandleInvalidObjCModifierFlag(const char *startFlag,
5596 // Warn about an invalid flag.
5597 auto Range = getSpecifierRange(startFlag, flagLen);
5598 StringRef flag(startFlag, flagLen);
5599 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_invalid_objc_flag) << flag,
5600 getLocationOfByte(startFlag),
5601 /*IsStringLocation*/true,
5602 Range, FixItHint::CreateRemoval(Range));
5605 void CheckPrintfHandler::HandleObjCFlagsWithNonObjCConversion(
5606 const char *flagsStart, const char *flagsEnd, const char *conversionPosition) {
5607 // Warn about using '[...]' without a '@' conversion.
5608 auto Range = getSpecifierRange(flagsStart, flagsEnd - flagsStart + 1);
5609 auto diag = diag::warn_printf_ObjCflags_without_ObjCConversion;
5610 EmitFormatDiagnostic(S.PDiag(diag) << StringRef(conversionPosition, 1),
5611 getLocationOfByte(conversionPosition),
5612 /*IsStringLocation*/true,
5613 Range, FixItHint::CreateRemoval(Range));
5616 // Determines if the specified is a C++ class or struct containing
5617 // a member with the specified name and kind (e.g. a CXXMethodDecl named
5619 template<typename MemberKind>
5620 static llvm::SmallPtrSet<MemberKind*, 1>
5621 CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
5622 const RecordType *RT = Ty->getAs<RecordType>();
5623 llvm::SmallPtrSet<MemberKind*, 1> Results;
5627 const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
5628 if (!RD || !RD->getDefinition())
5631 LookupResult R(S, &S.Context.Idents.get(Name), SourceLocation(),
5632 Sema::LookupMemberName);
5633 R.suppressDiagnostics();
5635 // We just need to include all members of the right kind turned up by the
5636 // filter, at this point.
5637 if (S.LookupQualifiedName(R, RT->getDecl()))
5638 for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
5639 NamedDecl *decl = (*I)->getUnderlyingDecl();
5640 if (MemberKind *FK = dyn_cast<MemberKind>(decl))
5646 /// Check if we could call '.c_str()' on an object.
5648 /// FIXME: This returns the wrong results in some cases (if cv-qualifiers don't
5649 /// allow the call, or if it would be ambiguous).
5650 bool Sema::hasCStrMethod(const Expr *E) {
5651 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
5653 CXXRecordMembersNamed<CXXMethodDecl>("c_str", *this, E->getType());
5654 for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
5656 if ((*MI)->getMinRequiredArguments() == 0)
5661 // Check if a (w)string was passed when a (w)char* was needed, and offer a
5662 // better diagnostic if so. AT is assumed to be valid.
5663 // Returns true when a c_str() conversion method is found.
5664 bool CheckPrintfHandler::checkForCStrMembers(
5665 const analyze_printf::ArgType &AT, const Expr *E) {
5666 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
5669 CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
5671 for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
5673 const CXXMethodDecl *Method = *MI;
5674 if (Method->getMinRequiredArguments() == 0 &&
5675 AT.matchesType(S.Context, Method->getReturnType())) {
5676 // FIXME: Suggest parens if the expression needs them.
5677 SourceLocation EndLoc = S.getLocForEndOfToken(E->getLocEnd());
5678 S.Diag(E->getLocStart(), diag::note_printf_c_str)
5680 << FixItHint::CreateInsertion(EndLoc, ".c_str()");
5689 CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
5691 const char *startSpecifier,
5692 unsigned specifierLen) {
5693 using namespace analyze_format_string;
5694 using namespace analyze_printf;
5695 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
5697 if (FS.consumesDataArgument()) {
5700 usesPositionalArgs = FS.usesPositionalArg();
5702 else if (usesPositionalArgs != FS.usesPositionalArg()) {
5703 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
5704 startSpecifier, specifierLen);
5709 // First check if the field width, precision, and conversion specifier
5710 // have matching data arguments.
5711 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
5712 startSpecifier, specifierLen)) {
5716 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
5717 startSpecifier, specifierLen)) {
5721 if (!CS.consumesDataArgument()) {
5722 // FIXME: Technically specifying a precision or field width here
5723 // makes no sense. Worth issuing a warning at some point.
5727 // Consume the argument.
5728 unsigned argIndex = FS.getArgIndex();
5729 if (argIndex < NumDataArgs) {
5730 // The check to see if the argIndex is valid will come later.
5731 // We set the bit here because we may exit early from this
5732 // function if we encounter some other error.
5733 CoveredArgs.set(argIndex);
5736 // FreeBSD kernel extensions.
5737 if (CS.getKind() == ConversionSpecifier::FreeBSDbArg ||
5738 CS.getKind() == ConversionSpecifier::FreeBSDDArg) {
5739 // We need at least two arguments.
5740 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex + 1))
5743 // Claim the second argument.
5744 CoveredArgs.set(argIndex + 1);
5746 // Type check the first argument (int for %b, pointer for %D)
5747 const Expr *Ex = getDataArg(argIndex);
5748 const analyze_printf::ArgType &AT =
5749 (CS.getKind() == ConversionSpecifier::FreeBSDbArg) ?
5750 ArgType(S.Context.IntTy) : ArgType::CPointerTy;
5751 if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType()))
5752 EmitFormatDiagnostic(
5753 S.PDiag(diag::warn_format_conversion_argument_type_mismatch)
5754 << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
5755 << false << Ex->getSourceRange(),
5756 Ex->getLocStart(), /*IsStringLocation*/false,
5757 getSpecifierRange(startSpecifier, specifierLen));
5759 // Type check the second argument (char * for both %b and %D)
5760 Ex = getDataArg(argIndex + 1);
5761 const analyze_printf::ArgType &AT2 = ArgType::CStrTy;
5762 if (AT2.isValid() && !AT2.matchesType(S.Context, Ex->getType()))
5763 EmitFormatDiagnostic(
5764 S.PDiag(diag::warn_format_conversion_argument_type_mismatch)
5765 << AT2.getRepresentativeTypeName(S.Context) << Ex->getType()
5766 << false << Ex->getSourceRange(),
5767 Ex->getLocStart(), /*IsStringLocation*/false,
5768 getSpecifierRange(startSpecifier, specifierLen));
5773 // Check for using an Objective-C specific conversion specifier
5774 // in a non-ObjC literal.
5775 if (!allowsObjCArg() && CS.isObjCArg()) {
5776 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
5780 // %P can only be used with os_log.
5781 if (FSType != Sema::FST_OSLog && CS.getKind() == ConversionSpecifier::PArg) {
5782 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
5786 // %n is not allowed with os_log.
5787 if (FSType == Sema::FST_OSLog && CS.getKind() == ConversionSpecifier::nArg) {
5788 EmitFormatDiagnostic(S.PDiag(diag::warn_os_log_format_narg),
5789 getLocationOfByte(CS.getStart()),
5790 /*IsStringLocation*/ false,
5791 getSpecifierRange(startSpecifier, specifierLen));
5796 // Only scalars are allowed for os_trace.
5797 if (FSType == Sema::FST_OSTrace &&
5798 (CS.getKind() == ConversionSpecifier::PArg ||
5799 CS.getKind() == ConversionSpecifier::sArg ||
5800 CS.getKind() == ConversionSpecifier::ObjCObjArg)) {
5801 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
5805 // Check for use of public/private annotation outside of os_log().
5806 if (FSType != Sema::FST_OSLog) {
5807 if (FS.isPublic().isSet()) {
5808 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_annotation)
5810 getLocationOfByte(FS.isPublic().getPosition()),
5811 /*IsStringLocation*/ false,
5812 getSpecifierRange(startSpecifier, specifierLen));
5814 if (FS.isPrivate().isSet()) {
5815 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_annotation)
5817 getLocationOfByte(FS.isPrivate().getPosition()),
5818 /*IsStringLocation*/ false,
5819 getSpecifierRange(startSpecifier, specifierLen));
5823 // Check for invalid use of field width
5824 if (!FS.hasValidFieldWidth()) {
5825 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
5826 startSpecifier, specifierLen);
5829 // Check for invalid use of precision
5830 if (!FS.hasValidPrecision()) {
5831 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
5832 startSpecifier, specifierLen);
5835 // Precision is mandatory for %P specifier.
5836 if (CS.getKind() == ConversionSpecifier::PArg &&
5837 FS.getPrecision().getHowSpecified() == OptionalAmount::NotSpecified) {
5838 EmitFormatDiagnostic(S.PDiag(diag::warn_format_P_no_precision),
5839 getLocationOfByte(startSpecifier),
5840 /*IsStringLocation*/ false,
5841 getSpecifierRange(startSpecifier, specifierLen));
5844 // Check each flag does not conflict with any other component.
5845 if (!FS.hasValidThousandsGroupingPrefix())
5846 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
5847 if (!FS.hasValidLeadingZeros())
5848 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
5849 if (!FS.hasValidPlusPrefix())
5850 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
5851 if (!FS.hasValidSpacePrefix())
5852 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
5853 if (!FS.hasValidAlternativeForm())
5854 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
5855 if (!FS.hasValidLeftJustified())
5856 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
5858 // Check that flags are not ignored by another flag
5859 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
5860 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
5861 startSpecifier, specifierLen);
5862 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
5863 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
5864 startSpecifier, specifierLen);
5866 // Check the length modifier is valid with the given conversion specifier.
5867 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
5868 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
5869 diag::warn_format_nonsensical_length);
5870 else if (!FS.hasStandardLengthModifier())
5871 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
5872 else if (!FS.hasStandardLengthConversionCombination())
5873 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
5874 diag::warn_format_non_standard_conversion_spec);
5876 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
5877 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
5879 // The remaining checks depend on the data arguments.
5883 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
5886 const Expr *Arg = getDataArg(argIndex);
5890 return checkFormatExpr(FS, startSpecifier, specifierLen, Arg);
5893 static bool requiresParensToAddCast(const Expr *E) {
5894 // FIXME: We should have a general way to reason about operator
5895 // precedence and whether parens are actually needed here.
5896 // Take care of a few common cases where they aren't.
5897 const Expr *Inside = E->IgnoreImpCasts();
5898 if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside))
5899 Inside = POE->getSyntacticForm()->IgnoreImpCasts();
5901 switch (Inside->getStmtClass()) {
5902 case Stmt::ArraySubscriptExprClass:
5903 case Stmt::CallExprClass:
5904 case Stmt::CharacterLiteralClass:
5905 case Stmt::CXXBoolLiteralExprClass:
5906 case Stmt::DeclRefExprClass:
5907 case Stmt::FloatingLiteralClass:
5908 case Stmt::IntegerLiteralClass:
5909 case Stmt::MemberExprClass:
5910 case Stmt::ObjCArrayLiteralClass:
5911 case Stmt::ObjCBoolLiteralExprClass:
5912 case Stmt::ObjCBoxedExprClass:
5913 case Stmt::ObjCDictionaryLiteralClass:
5914 case Stmt::ObjCEncodeExprClass:
5915 case Stmt::ObjCIvarRefExprClass:
5916 case Stmt::ObjCMessageExprClass:
5917 case Stmt::ObjCPropertyRefExprClass:
5918 case Stmt::ObjCStringLiteralClass:
5919 case Stmt::ObjCSubscriptRefExprClass:
5920 case Stmt::ParenExprClass:
5921 case Stmt::StringLiteralClass:
5922 case Stmt::UnaryOperatorClass:
5929 static std::pair<QualType, StringRef>
5930 shouldNotPrintDirectly(const ASTContext &Context,
5931 QualType IntendedTy,
5933 // Use a 'while' to peel off layers of typedefs.
5934 QualType TyTy = IntendedTy;
5935 while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) {
5936 StringRef Name = UserTy->getDecl()->getName();
5937 QualType CastTy = llvm::StringSwitch<QualType>(Name)
5938 .Case("NSInteger", Context.LongTy)
5939 .Case("NSUInteger", Context.UnsignedLongTy)
5940 .Case("SInt32", Context.IntTy)
5941 .Case("UInt32", Context.UnsignedIntTy)
5942 .Default(QualType());
5944 if (!CastTy.isNull())
5945 return std::make_pair(CastTy, Name);
5947 TyTy = UserTy->desugar();
5950 // Strip parens if necessary.
5951 if (const ParenExpr *PE = dyn_cast<ParenExpr>(E))
5952 return shouldNotPrintDirectly(Context,
5953 PE->getSubExpr()->getType(),
5956 // If this is a conditional expression, then its result type is constructed
5957 // via usual arithmetic conversions and thus there might be no necessary
5958 // typedef sugar there. Recurse to operands to check for NSInteger &
5959 // Co. usage condition.
5960 if (const ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
5961 QualType TrueTy, FalseTy;
5962 StringRef TrueName, FalseName;
5964 std::tie(TrueTy, TrueName) =
5965 shouldNotPrintDirectly(Context,
5966 CO->getTrueExpr()->getType(),
5968 std::tie(FalseTy, FalseName) =
5969 shouldNotPrintDirectly(Context,
5970 CO->getFalseExpr()->getType(),
5971 CO->getFalseExpr());
5973 if (TrueTy == FalseTy)
5974 return std::make_pair(TrueTy, TrueName);
5975 else if (TrueTy.isNull())
5976 return std::make_pair(FalseTy, FalseName);
5977 else if (FalseTy.isNull())
5978 return std::make_pair(TrueTy, TrueName);
5981 return std::make_pair(QualType(), StringRef());
5985 CheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
5986 const char *StartSpecifier,
5987 unsigned SpecifierLen,
5989 using namespace analyze_format_string;
5990 using namespace analyze_printf;
5991 // Now type check the data expression that matches the
5992 // format specifier.
5993 const analyze_printf::ArgType &AT = FS.getArgType(S.Context, isObjCContext());
5997 QualType ExprTy = E->getType();
5998 while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) {
5999 ExprTy = TET->getUnderlyingExpr()->getType();
6002 analyze_printf::ArgType::MatchKind match = AT.matchesType(S.Context, ExprTy);
6004 if (match == analyze_printf::ArgType::Match) {
6008 // Look through argument promotions for our error message's reported type.
6009 // This includes the integral and floating promotions, but excludes array
6010 // and function pointer decay; seeing that an argument intended to be a
6011 // string has type 'char [6]' is probably more confusing than 'char *'.
6012 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
6013 if (ICE->getCastKind() == CK_IntegralCast ||
6014 ICE->getCastKind() == CK_FloatingCast) {
6015 E = ICE->getSubExpr();
6016 ExprTy = E->getType();
6018 // Check if we didn't match because of an implicit cast from a 'char'
6019 // or 'short' to an 'int'. This is done because printf is a varargs
6021 if (ICE->getType() == S.Context.IntTy ||
6022 ICE->getType() == S.Context.UnsignedIntTy) {
6023 // All further checking is done on the subexpression.
6024 if (AT.matchesType(S.Context, ExprTy))
6028 } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) {
6029 // Special case for 'a', which has type 'int' in C.
6030 // Note, however, that we do /not/ want to treat multibyte constants like
6031 // 'MooV' as characters! This form is deprecated but still exists.
6032 if (ExprTy == S.Context.IntTy)
6033 if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue()))
6034 ExprTy = S.Context.CharTy;
6037 // Look through enums to their underlying type.
6038 bool IsEnum = false;
6039 if (auto EnumTy = ExprTy->getAs<EnumType>()) {
6040 ExprTy = EnumTy->getDecl()->getIntegerType();
6044 // %C in an Objective-C context prints a unichar, not a wchar_t.
6045 // If the argument is an integer of some kind, believe the %C and suggest
6046 // a cast instead of changing the conversion specifier.
6047 QualType IntendedTy = ExprTy;
6048 if (isObjCContext() &&
6049 FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) {
6050 if (ExprTy->isIntegralOrUnscopedEnumerationType() &&
6051 !ExprTy->isCharType()) {
6052 // 'unichar' is defined as a typedef of unsigned short, but we should
6053 // prefer using the typedef if it is visible.
6054 IntendedTy = S.Context.UnsignedShortTy;
6056 // While we are here, check if the value is an IntegerLiteral that happens
6057 // to be within the valid range.
6058 if (const IntegerLiteral *IL = dyn_cast<IntegerLiteral>(E)) {
6059 const llvm::APInt &V = IL->getValue();
6060 if (V.getActiveBits() <= S.Context.getTypeSize(IntendedTy))
6064 LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(),
6065 Sema::LookupOrdinaryName);
6066 if (S.LookupName(Result, S.getCurScope())) {
6067 NamedDecl *ND = Result.getFoundDecl();
6068 if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND))
6069 if (TD->getUnderlyingType() == IntendedTy)
6070 IntendedTy = S.Context.getTypedefType(TD);
6075 // Special-case some of Darwin's platform-independence types by suggesting
6076 // casts to primitive types that are known to be large enough.
6077 bool ShouldNotPrintDirectly = false; StringRef CastTyName;
6078 if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
6080 std::tie(CastTy, CastTyName) = shouldNotPrintDirectly(S.Context, IntendedTy, E);
6081 if (!CastTy.isNull()) {
6082 IntendedTy = CastTy;
6083 ShouldNotPrintDirectly = true;
6087 // We may be able to offer a FixItHint if it is a supported type.
6088 PrintfSpecifier fixedFS = FS;
6090 fixedFS.fixType(IntendedTy, S.getLangOpts(), S.Context, isObjCContext());
6093 // Get the fix string from the fixed format specifier
6094 SmallString<16> buf;
6095 llvm::raw_svector_ostream os(buf);
6096 fixedFS.toString(os);
6098 CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen);
6100 if (IntendedTy == ExprTy && !ShouldNotPrintDirectly) {
6101 unsigned diag = diag::warn_format_conversion_argument_type_mismatch;
6102 if (match == analyze_format_string::ArgType::NoMatchPedantic) {
6103 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic;
6105 // In this case, the specifier is wrong and should be changed to match
6107 EmitFormatDiagnostic(S.PDiag(diag)
6108 << AT.getRepresentativeTypeName(S.Context)
6109 << IntendedTy << IsEnum << E->getSourceRange(),
6111 /*IsStringLocation*/ false, SpecRange,
6112 FixItHint::CreateReplacement(SpecRange, os.str()));
6114 // The canonical type for formatting this value is different from the
6115 // actual type of the expression. (This occurs, for example, with Darwin's
6116 // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but
6117 // should be printed as 'long' for 64-bit compatibility.)
6118 // Rather than emitting a normal format/argument mismatch, we want to
6119 // add a cast to the recommended type (and correct the format string
6121 SmallString<16> CastBuf;
6122 llvm::raw_svector_ostream CastFix(CastBuf);
6124 IntendedTy.print(CastFix, S.Context.getPrintingPolicy());
6127 SmallVector<FixItHint,4> Hints;
6128 if (!AT.matchesType(S.Context, IntendedTy))
6129 Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str()));
6131 if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) {
6132 // If there's already a cast present, just replace it.
6133 SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc());
6134 Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str()));
6136 } else if (!requiresParensToAddCast(E)) {
6137 // If the expression has high enough precedence,
6138 // just write the C-style cast.
6139 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
6142 // Otherwise, add parens around the expression as well as the cast.
6144 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
6147 SourceLocation After = S.getLocForEndOfToken(E->getLocEnd());
6148 Hints.push_back(FixItHint::CreateInsertion(After, ")"));
6151 if (ShouldNotPrintDirectly) {
6152 // The expression has a type that should not be printed directly.
6153 // We extract the name from the typedef because we don't want to show
6154 // the underlying type in the diagnostic.
6156 if (const TypedefType *TypedefTy = dyn_cast<TypedefType>(ExprTy))
6157 Name = TypedefTy->getDecl()->getName();
6160 EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast)
6161 << Name << IntendedTy << IsEnum
6162 << E->getSourceRange(),
6163 E->getLocStart(), /*IsStringLocation=*/false,
6166 // In this case, the expression could be printed using a different
6167 // specifier, but we've decided that the specifier is probably correct
6168 // and we should cast instead. Just use the normal warning message.
6169 EmitFormatDiagnostic(
6170 S.PDiag(diag::warn_format_conversion_argument_type_mismatch)
6171 << AT.getRepresentativeTypeName(S.Context) << ExprTy << IsEnum
6172 << E->getSourceRange(),
6173 E->getLocStart(), /*IsStringLocation*/false,
6178 const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
6180 // Since the warning for passing non-POD types to variadic functions
6181 // was deferred until now, we emit a warning for non-POD
6183 switch (S.isValidVarArgType(ExprTy)) {
6184 case Sema::VAK_Valid:
6185 case Sema::VAK_ValidInCXX11: {
6186 unsigned diag = diag::warn_format_conversion_argument_type_mismatch;
6187 if (match == analyze_printf::ArgType::NoMatchPedantic) {
6188 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic;
6191 EmitFormatDiagnostic(
6192 S.PDiag(diag) << AT.getRepresentativeTypeName(S.Context) << ExprTy
6193 << IsEnum << CSR << E->getSourceRange(),
6194 E->getLocStart(), /*IsStringLocation*/ false, CSR);
6197 case Sema::VAK_Undefined:
6198 case Sema::VAK_MSVCUndefined:
6199 EmitFormatDiagnostic(
6200 S.PDiag(diag::warn_non_pod_vararg_with_format_string)
6201 << S.getLangOpts().CPlusPlus11
6204 << AT.getRepresentativeTypeName(S.Context)
6206 << E->getSourceRange(),
6207 E->getLocStart(), /*IsStringLocation*/false, CSR);
6208 checkForCStrMembers(AT, E);
6211 case Sema::VAK_Invalid:
6212 if (ExprTy->isObjCObjectType())
6213 EmitFormatDiagnostic(
6214 S.PDiag(diag::err_cannot_pass_objc_interface_to_vararg_format)
6215 << S.getLangOpts().CPlusPlus11
6218 << AT.getRepresentativeTypeName(S.Context)
6220 << E->getSourceRange(),
6221 E->getLocStart(), /*IsStringLocation*/false, CSR);
6223 // FIXME: If this is an initializer list, suggest removing the braces
6224 // or inserting a cast to the target type.
6225 S.Diag(E->getLocStart(), diag::err_cannot_pass_to_vararg_format)
6226 << isa<InitListExpr>(E) << ExprTy << CallType
6227 << AT.getRepresentativeTypeName(S.Context)
6228 << E->getSourceRange();
6232 assert(FirstDataArg + FS.getArgIndex() < CheckedVarArgs.size() &&
6233 "format string specifier index out of range");
6234 CheckedVarArgs[FirstDataArg + FS.getArgIndex()] = true;
6240 //===--- CHECK: Scanf format string checking ------------------------------===//
6243 class CheckScanfHandler : public CheckFormatHandler {
6245 CheckScanfHandler(Sema &s, const FormatStringLiteral *fexpr,
6246 const Expr *origFormatExpr, Sema::FormatStringType type,
6247 unsigned firstDataArg, unsigned numDataArgs,
6248 const char *beg, bool hasVAListArg,
6249 ArrayRef<const Expr *> Args, unsigned formatIdx,
6250 bool inFunctionCall, Sema::VariadicCallType CallType,
6251 llvm::SmallBitVector &CheckedVarArgs,
6252 UncoveredArgHandler &UncoveredArg)
6253 : CheckFormatHandler(s, fexpr, origFormatExpr, type, firstDataArg,
6254 numDataArgs, beg, hasVAListArg, Args, formatIdx,
6255 inFunctionCall, CallType, CheckedVarArgs,
6258 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
6259 const char *startSpecifier,
6260 unsigned specifierLen) override;
6262 bool HandleInvalidScanfConversionSpecifier(
6263 const analyze_scanf::ScanfSpecifier &FS,
6264 const char *startSpecifier,
6265 unsigned specifierLen) override;
6267 void HandleIncompleteScanList(const char *start, const char *end) override;
6269 } // end anonymous namespace
6271 void CheckScanfHandler::HandleIncompleteScanList(const char *start,
6273 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
6274 getLocationOfByte(end), /*IsStringLocation*/true,
6275 getSpecifierRange(start, end - start));
6278 bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
6279 const analyze_scanf::ScanfSpecifier &FS,
6280 const char *startSpecifier,
6281 unsigned specifierLen) {
6283 const analyze_scanf::ScanfConversionSpecifier &CS =
6284 FS.getConversionSpecifier();
6286 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
6287 getLocationOfByte(CS.getStart()),
6288 startSpecifier, specifierLen,
6289 CS.getStart(), CS.getLength());
6292 bool CheckScanfHandler::HandleScanfSpecifier(
6293 const analyze_scanf::ScanfSpecifier &FS,
6294 const char *startSpecifier,
6295 unsigned specifierLen) {
6296 using namespace analyze_scanf;
6297 using namespace analyze_format_string;
6299 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
6301 // Handle case where '%' and '*' don't consume an argument. These shouldn't
6302 // be used to decide if we are using positional arguments consistently.
6303 if (FS.consumesDataArgument()) {
6306 usesPositionalArgs = FS.usesPositionalArg();
6308 else if (usesPositionalArgs != FS.usesPositionalArg()) {
6309 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
6310 startSpecifier, specifierLen);
6315 // Check if the field with is non-zero.
6316 const OptionalAmount &Amt = FS.getFieldWidth();
6317 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
6318 if (Amt.getConstantAmount() == 0) {
6319 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
6320 Amt.getConstantLength());
6321 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
6322 getLocationOfByte(Amt.getStart()),
6323 /*IsStringLocation*/true, R,
6324 FixItHint::CreateRemoval(R));
6328 if (!FS.consumesDataArgument()) {
6329 // FIXME: Technically specifying a precision or field width here
6330 // makes no sense. Worth issuing a warning at some point.
6334 // Consume the argument.
6335 unsigned argIndex = FS.getArgIndex();
6336 if (argIndex < NumDataArgs) {
6337 // The check to see if the argIndex is valid will come later.
6338 // We set the bit here because we may exit early from this
6339 // function if we encounter some other error.
6340 CoveredArgs.set(argIndex);
6343 // Check the length modifier is valid with the given conversion specifier.
6344 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
6345 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
6346 diag::warn_format_nonsensical_length);
6347 else if (!FS.hasStandardLengthModifier())
6348 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
6349 else if (!FS.hasStandardLengthConversionCombination())
6350 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
6351 diag::warn_format_non_standard_conversion_spec);
6353 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
6354 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
6356 // The remaining checks depend on the data arguments.
6360 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
6363 // Check that the argument type matches the format specifier.
6364 const Expr *Ex = getDataArg(argIndex);
6368 const analyze_format_string::ArgType &AT = FS.getArgType(S.Context);
6370 if (!AT.isValid()) {
6374 analyze_format_string::ArgType::MatchKind match =
6375 AT.matchesType(S.Context, Ex->getType());
6376 if (match == analyze_format_string::ArgType::Match) {
6380 ScanfSpecifier fixedFS = FS;
6381 bool success = fixedFS.fixType(Ex->getType(), Ex->IgnoreImpCasts()->getType(),
6382 S.getLangOpts(), S.Context);
6384 unsigned diag = diag::warn_format_conversion_argument_type_mismatch;
6385 if (match == analyze_format_string::ArgType::NoMatchPedantic) {
6386 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic;
6390 // Get the fix string from the fixed format specifier.
6391 SmallString<128> buf;
6392 llvm::raw_svector_ostream os(buf);
6393 fixedFS.toString(os);
6395 EmitFormatDiagnostic(
6396 S.PDiag(diag) << AT.getRepresentativeTypeName(S.Context)
6397 << Ex->getType() << false << Ex->getSourceRange(),
6399 /*IsStringLocation*/ false,
6400 getSpecifierRange(startSpecifier, specifierLen),
6401 FixItHint::CreateReplacement(
6402 getSpecifierRange(startSpecifier, specifierLen), os.str()));
6404 EmitFormatDiagnostic(S.PDiag(diag)
6405 << AT.getRepresentativeTypeName(S.Context)
6406 << Ex->getType() << false << Ex->getSourceRange(),
6408 /*IsStringLocation*/ false,
6409 getSpecifierRange(startSpecifier, specifierLen));
6415 static void CheckFormatString(Sema &S, const FormatStringLiteral *FExpr,
6416 const Expr *OrigFormatExpr,
6417 ArrayRef<const Expr *> Args,
6418 bool HasVAListArg, unsigned format_idx,
6419 unsigned firstDataArg,
6420 Sema::FormatStringType Type,
6421 bool inFunctionCall,
6422 Sema::VariadicCallType CallType,
6423 llvm::SmallBitVector &CheckedVarArgs,
6424 UncoveredArgHandler &UncoveredArg) {
6425 // CHECK: is the format string a wide literal?
6426 if (!FExpr->isAscii() && !FExpr->isUTF8()) {
6427 CheckFormatHandler::EmitFormatDiagnostic(
6428 S, inFunctionCall, Args[format_idx],
6429 S.PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
6430 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
6434 // Str - The format string. NOTE: this is NOT null-terminated!
6435 StringRef StrRef = FExpr->getString();
6436 const char *Str = StrRef.data();
6437 // Account for cases where the string literal is truncated in a declaration.
6438 const ConstantArrayType *T =
6439 S.Context.getAsConstantArrayType(FExpr->getType());
6440 assert(T && "String literal not of constant array type!");
6441 size_t TypeSize = T->getSize().getZExtValue();
6442 size_t StrLen = std::min(std::max(TypeSize, size_t(1)) - 1, StrRef.size());
6443 const unsigned numDataArgs = Args.size() - firstDataArg;
6445 // Emit a warning if the string literal is truncated and does not contain an
6446 // embedded null character.
6447 if (TypeSize <= StrRef.size() &&
6448 StrRef.substr(0, TypeSize).find('\0') == StringRef::npos) {
6449 CheckFormatHandler::EmitFormatDiagnostic(
6450 S, inFunctionCall, Args[format_idx],
6451 S.PDiag(diag::warn_printf_format_string_not_null_terminated),
6452 FExpr->getLocStart(),
6453 /*IsStringLocation=*/true, OrigFormatExpr->getSourceRange());
6457 // CHECK: empty format string?
6458 if (StrLen == 0 && numDataArgs > 0) {
6459 CheckFormatHandler::EmitFormatDiagnostic(
6460 S, inFunctionCall, Args[format_idx],
6461 S.PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
6462 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
6466 if (Type == Sema::FST_Printf || Type == Sema::FST_NSString ||
6467 Type == Sema::FST_FreeBSDKPrintf || Type == Sema::FST_OSLog ||
6468 Type == Sema::FST_OSTrace) {
6469 CheckPrintfHandler H(
6470 S, FExpr, OrigFormatExpr, Type, firstDataArg, numDataArgs,
6471 (Type == Sema::FST_NSString || Type == Sema::FST_OSTrace), Str,
6472 HasVAListArg, Args, format_idx, inFunctionCall, CallType,
6473 CheckedVarArgs, UncoveredArg);
6475 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
6477 S.Context.getTargetInfo(),
6478 Type == Sema::FST_FreeBSDKPrintf))
6480 } else if (Type == Sema::FST_Scanf) {
6481 CheckScanfHandler H(S, FExpr, OrigFormatExpr, Type, firstDataArg,
6482 numDataArgs, Str, HasVAListArg, Args, format_idx,
6483 inFunctionCall, CallType, CheckedVarArgs, UncoveredArg);
6485 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
6487 S.Context.getTargetInfo()))
6489 } // TODO: handle other formats
6492 bool Sema::FormatStringHasSArg(const StringLiteral *FExpr) {
6493 // Str - The format string. NOTE: this is NOT null-terminated!
6494 StringRef StrRef = FExpr->getString();
6495 const char *Str = StrRef.data();
6496 // Account for cases where the string literal is truncated in a declaration.
6497 const ConstantArrayType *T = Context.getAsConstantArrayType(FExpr->getType());
6498 assert(T && "String literal not of constant array type!");
6499 size_t TypeSize = T->getSize().getZExtValue();
6500 size_t StrLen = std::min(std::max(TypeSize, size_t(1)) - 1, StrRef.size());
6501 return analyze_format_string::ParseFormatStringHasSArg(Str, Str + StrLen,
6503 Context.getTargetInfo());
6506 //===--- CHECK: Warn on use of wrong absolute value function. -------------===//
6508 // Returns the related absolute value function that is larger, of 0 if one
6510 static unsigned getLargerAbsoluteValueFunction(unsigned AbsFunction) {
6511 switch (AbsFunction) {
6515 case Builtin::BI__builtin_abs:
6516 return Builtin::BI__builtin_labs;
6517 case Builtin::BI__builtin_labs:
6518 return Builtin::BI__builtin_llabs;
6519 case Builtin::BI__builtin_llabs:
6522 case Builtin::BI__builtin_fabsf:
6523 return Builtin::BI__builtin_fabs;
6524 case Builtin::BI__builtin_fabs:
6525 return Builtin::BI__builtin_fabsl;
6526 case Builtin::BI__builtin_fabsl:
6529 case Builtin::BI__builtin_cabsf:
6530 return Builtin::BI__builtin_cabs;
6531 case Builtin::BI__builtin_cabs:
6532 return Builtin::BI__builtin_cabsl;
6533 case Builtin::BI__builtin_cabsl:
6536 case Builtin::BIabs:
6537 return Builtin::BIlabs;
6538 case Builtin::BIlabs:
6539 return Builtin::BIllabs;
6540 case Builtin::BIllabs:
6543 case Builtin::BIfabsf:
6544 return Builtin::BIfabs;
6545 case Builtin::BIfabs:
6546 return Builtin::BIfabsl;
6547 case Builtin::BIfabsl:
6550 case Builtin::BIcabsf:
6551 return Builtin::BIcabs;
6552 case Builtin::BIcabs:
6553 return Builtin::BIcabsl;
6554 case Builtin::BIcabsl:
6559 // Returns the argument type of the absolute value function.
6560 static QualType getAbsoluteValueArgumentType(ASTContext &Context,
6565 ASTContext::GetBuiltinTypeError Error = ASTContext::GE_None;
6566 QualType BuiltinType = Context.GetBuiltinType(AbsType, Error);
6567 if (Error != ASTContext::GE_None)
6570 const FunctionProtoType *FT = BuiltinType->getAs<FunctionProtoType>();
6574 if (FT->getNumParams() != 1)
6577 return FT->getParamType(0);
6580 // Returns the best absolute value function, or zero, based on type and
6581 // current absolute value function.
6582 static unsigned getBestAbsFunction(ASTContext &Context, QualType ArgType,
6583 unsigned AbsFunctionKind) {
6584 unsigned BestKind = 0;
6585 uint64_t ArgSize = Context.getTypeSize(ArgType);
6586 for (unsigned Kind = AbsFunctionKind; Kind != 0;
6587 Kind = getLargerAbsoluteValueFunction(Kind)) {
6588 QualType ParamType = getAbsoluteValueArgumentType(Context, Kind);
6589 if (Context.getTypeSize(ParamType) >= ArgSize) {
6592 else if (Context.hasSameType(ParamType, ArgType)) {
6601 enum AbsoluteValueKind {
6607 static AbsoluteValueKind getAbsoluteValueKind(QualType T) {
6608 if (T->isIntegralOrEnumerationType())
6610 if (T->isRealFloatingType())
6611 return AVK_Floating;
6612 if (T->isAnyComplexType())
6615 llvm_unreachable("Type not integer, floating, or complex");
6618 // Changes the absolute value function to a different type. Preserves whether
6619 // the function is a builtin.
6620 static unsigned changeAbsFunction(unsigned AbsKind,
6621 AbsoluteValueKind ValueKind) {
6622 switch (ValueKind) {
6627 case Builtin::BI__builtin_fabsf:
6628 case Builtin::BI__builtin_fabs:
6629 case Builtin::BI__builtin_fabsl:
6630 case Builtin::BI__builtin_cabsf:
6631 case Builtin::BI__builtin_cabs:
6632 case Builtin::BI__builtin_cabsl:
6633 return Builtin::BI__builtin_abs;
6634 case Builtin::BIfabsf:
6635 case Builtin::BIfabs:
6636 case Builtin::BIfabsl:
6637 case Builtin::BIcabsf:
6638 case Builtin::BIcabs:
6639 case Builtin::BIcabsl:
6640 return Builtin::BIabs;
6646 case Builtin::BI__builtin_abs:
6647 case Builtin::BI__builtin_labs:
6648 case Builtin::BI__builtin_llabs:
6649 case Builtin::BI__builtin_cabsf:
6650 case Builtin::BI__builtin_cabs:
6651 case Builtin::BI__builtin_cabsl:
6652 return Builtin::BI__builtin_fabsf;
6653 case Builtin::BIabs:
6654 case Builtin::BIlabs:
6655 case Builtin::BIllabs:
6656 case Builtin::BIcabsf:
6657 case Builtin::BIcabs:
6658 case Builtin::BIcabsl:
6659 return Builtin::BIfabsf;
6665 case Builtin::BI__builtin_abs:
6666 case Builtin::BI__builtin_labs:
6667 case Builtin::BI__builtin_llabs:
6668 case Builtin::BI__builtin_fabsf:
6669 case Builtin::BI__builtin_fabs:
6670 case Builtin::BI__builtin_fabsl:
6671 return Builtin::BI__builtin_cabsf;
6672 case Builtin::BIabs:
6673 case Builtin::BIlabs:
6674 case Builtin::BIllabs:
6675 case Builtin::BIfabsf:
6676 case Builtin::BIfabs:
6677 case Builtin::BIfabsl:
6678 return Builtin::BIcabsf;
6681 llvm_unreachable("Unable to convert function");
6684 static unsigned getAbsoluteValueFunctionKind(const FunctionDecl *FDecl) {
6685 const IdentifierInfo *FnInfo = FDecl->getIdentifier();
6689 switch (FDecl->getBuiltinID()) {
6692 case Builtin::BI__builtin_abs:
6693 case Builtin::BI__builtin_fabs:
6694 case Builtin::BI__builtin_fabsf:
6695 case Builtin::BI__builtin_fabsl:
6696 case Builtin::BI__builtin_labs:
6697 case Builtin::BI__builtin_llabs:
6698 case Builtin::BI__builtin_cabs:
6699 case Builtin::BI__builtin_cabsf:
6700 case Builtin::BI__builtin_cabsl:
6701 case Builtin::BIabs:
6702 case Builtin::BIlabs:
6703 case Builtin::BIllabs:
6704 case Builtin::BIfabs:
6705 case Builtin::BIfabsf:
6706 case Builtin::BIfabsl:
6707 case Builtin::BIcabs:
6708 case Builtin::BIcabsf:
6709 case Builtin::BIcabsl:
6710 return FDecl->getBuiltinID();
6712 llvm_unreachable("Unknown Builtin type");
6715 // If the replacement is valid, emit a note with replacement function.
6716 // Additionally, suggest including the proper header if not already included.
6717 static void emitReplacement(Sema &S, SourceLocation Loc, SourceRange Range,
6718 unsigned AbsKind, QualType ArgType) {
6719 bool EmitHeaderHint = true;
6720 const char *HeaderName = nullptr;
6721 const char *FunctionName = nullptr;
6722 if (S.getLangOpts().CPlusPlus && !ArgType->isAnyComplexType()) {
6723 FunctionName = "std::abs";
6724 if (ArgType->isIntegralOrEnumerationType()) {
6725 HeaderName = "cstdlib";
6726 } else if (ArgType->isRealFloatingType()) {
6727 HeaderName = "cmath";
6729 llvm_unreachable("Invalid Type");
6732 // Lookup all std::abs
6733 if (NamespaceDecl *Std = S.getStdNamespace()) {
6734 LookupResult R(S, &S.Context.Idents.get("abs"), Loc, Sema::LookupAnyName);
6735 R.suppressDiagnostics();
6736 S.LookupQualifiedName(R, Std);
6738 for (const auto *I : R) {
6739 const FunctionDecl *FDecl = nullptr;
6740 if (const UsingShadowDecl *UsingD = dyn_cast<UsingShadowDecl>(I)) {
6741 FDecl = dyn_cast<FunctionDecl>(UsingD->getTargetDecl());
6743 FDecl = dyn_cast<FunctionDecl>(I);
6748 // Found std::abs(), check that they are the right ones.
6749 if (FDecl->getNumParams() != 1)
6752 // Check that the parameter type can handle the argument.
6753 QualType ParamType = FDecl->getParamDecl(0)->getType();
6754 if (getAbsoluteValueKind(ArgType) == getAbsoluteValueKind(ParamType) &&
6755 S.Context.getTypeSize(ArgType) <=
6756 S.Context.getTypeSize(ParamType)) {
6757 // Found a function, don't need the header hint.
6758 EmitHeaderHint = false;
6764 FunctionName = S.Context.BuiltinInfo.getName(AbsKind);
6765 HeaderName = S.Context.BuiltinInfo.getHeaderName(AbsKind);
6768 DeclarationName DN(&S.Context.Idents.get(FunctionName));
6769 LookupResult R(S, DN, Loc, Sema::LookupAnyName);
6770 R.suppressDiagnostics();
6771 S.LookupName(R, S.getCurScope());
6773 if (R.isSingleResult()) {
6774 FunctionDecl *FD = dyn_cast<FunctionDecl>(R.getFoundDecl());
6775 if (FD && FD->getBuiltinID() == AbsKind) {
6776 EmitHeaderHint = false;
6780 } else if (!R.empty()) {
6786 S.Diag(Loc, diag::note_replace_abs_function)
6787 << FunctionName << FixItHint::CreateReplacement(Range, FunctionName);
6792 if (!EmitHeaderHint)
6795 S.Diag(Loc, diag::note_include_header_or_declare) << HeaderName
6799 template <std::size_t StrLen>
6800 static bool IsStdFunction(const FunctionDecl *FDecl,
6801 const char (&Str)[StrLen]) {
6804 if (!FDecl->getIdentifier() || !FDecl->getIdentifier()->isStr(Str))
6806 if (!FDecl->isInStdNamespace())
6812 // Warn when using the wrong abs() function.
6813 void Sema::CheckAbsoluteValueFunction(const CallExpr *Call,
6814 const FunctionDecl *FDecl) {
6815 if (Call->getNumArgs() != 1)
6818 unsigned AbsKind = getAbsoluteValueFunctionKind(FDecl);
6819 bool IsStdAbs = IsStdFunction(FDecl, "abs");
6820 if (AbsKind == 0 && !IsStdAbs)
6823 QualType ArgType = Call->getArg(0)->IgnoreParenImpCasts()->getType();
6824 QualType ParamType = Call->getArg(0)->getType();
6826 // Unsigned types cannot be negative. Suggest removing the absolute value
6828 if (ArgType->isUnsignedIntegerType()) {
6829 const char *FunctionName =
6830 IsStdAbs ? "std::abs" : Context.BuiltinInfo.getName(AbsKind);
6831 Diag(Call->getExprLoc(), diag::warn_unsigned_abs) << ArgType << ParamType;
6832 Diag(Call->getExprLoc(), diag::note_remove_abs)
6834 << FixItHint::CreateRemoval(Call->getCallee()->getSourceRange());
6838 // Taking the absolute value of a pointer is very suspicious, they probably
6839 // wanted to index into an array, dereference a pointer, call a function, etc.
6840 if (ArgType->isPointerType() || ArgType->canDecayToPointerType()) {
6841 unsigned DiagType = 0;
6842 if (ArgType->isFunctionType())
6844 else if (ArgType->isArrayType())
6847 Diag(Call->getExprLoc(), diag::warn_pointer_abs) << DiagType << ArgType;
6851 // std::abs has overloads which prevent most of the absolute value problems
6856 AbsoluteValueKind ArgValueKind = getAbsoluteValueKind(ArgType);
6857 AbsoluteValueKind ParamValueKind = getAbsoluteValueKind(ParamType);
6859 // The argument and parameter are the same kind. Check if they are the right
6861 if (ArgValueKind == ParamValueKind) {
6862 if (Context.getTypeSize(ArgType) <= Context.getTypeSize(ParamType))
6865 unsigned NewAbsKind = getBestAbsFunction(Context, ArgType, AbsKind);
6866 Diag(Call->getExprLoc(), diag::warn_abs_too_small)
6867 << FDecl << ArgType << ParamType;
6869 if (NewAbsKind == 0)
6872 emitReplacement(*this, Call->getExprLoc(),
6873 Call->getCallee()->getSourceRange(), NewAbsKind, ArgType);
6877 // ArgValueKind != ParamValueKind
6878 // The wrong type of absolute value function was used. Attempt to find the
6880 unsigned NewAbsKind = changeAbsFunction(AbsKind, ArgValueKind);
6881 NewAbsKind = getBestAbsFunction(Context, ArgType, NewAbsKind);
6882 if (NewAbsKind == 0)
6885 Diag(Call->getExprLoc(), diag::warn_wrong_absolute_value_type)
6886 << FDecl << ParamValueKind << ArgValueKind;
6888 emitReplacement(*this, Call->getExprLoc(),
6889 Call->getCallee()->getSourceRange(), NewAbsKind, ArgType);
6892 //===--- CHECK: Warn on use of std::max and unsigned zero. r---------------===//
6893 void Sema::CheckMaxUnsignedZero(const CallExpr *Call,
6894 const FunctionDecl *FDecl) {
6895 if (!Call || !FDecl) return;
6897 // Ignore template specializations and macros.
6898 if (inTemplateInstantiation()) return;
6899 if (Call->getExprLoc().isMacroID()) return;
6901 // Only care about the one template argument, two function parameter std::max
6902 if (Call->getNumArgs() != 2) return;
6903 if (!IsStdFunction(FDecl, "max")) return;
6904 const auto * ArgList = FDecl->getTemplateSpecializationArgs();
6905 if (!ArgList) return;
6906 if (ArgList->size() != 1) return;
6908 // Check that template type argument is unsigned integer.
6909 const auto& TA = ArgList->get(0);
6910 if (TA.getKind() != TemplateArgument::Type) return;
6911 QualType ArgType = TA.getAsType();
6912 if (!ArgType->isUnsignedIntegerType()) return;
6914 // See if either argument is a literal zero.
6915 auto IsLiteralZeroArg = [](const Expr* E) -> bool {
6916 const auto *MTE = dyn_cast<MaterializeTemporaryExpr>(E);
6917 if (!MTE) return false;
6918 const auto *Num = dyn_cast<IntegerLiteral>(MTE->GetTemporaryExpr());
6919 if (!Num) return false;
6920 if (Num->getValue() != 0) return false;
6924 const Expr *FirstArg = Call->getArg(0);
6925 const Expr *SecondArg = Call->getArg(1);
6926 const bool IsFirstArgZero = IsLiteralZeroArg(FirstArg);
6927 const bool IsSecondArgZero = IsLiteralZeroArg(SecondArg);
6929 // Only warn when exactly one argument is zero.
6930 if (IsFirstArgZero == IsSecondArgZero) return;
6932 SourceRange FirstRange = FirstArg->getSourceRange();
6933 SourceRange SecondRange = SecondArg->getSourceRange();
6935 SourceRange ZeroRange = IsFirstArgZero ? FirstRange : SecondRange;
6937 Diag(Call->getExprLoc(), diag::warn_max_unsigned_zero)
6938 << IsFirstArgZero << Call->getCallee()->getSourceRange() << ZeroRange;
6940 // Deduce what parts to remove so that "std::max(0u, foo)" becomes "(foo)".
6941 SourceRange RemovalRange;
6942 if (IsFirstArgZero) {
6943 RemovalRange = SourceRange(FirstRange.getBegin(),
6944 SecondRange.getBegin().getLocWithOffset(-1));
6946 RemovalRange = SourceRange(getLocForEndOfToken(FirstRange.getEnd()),
6947 SecondRange.getEnd());
6950 Diag(Call->getExprLoc(), diag::note_remove_max_call)
6951 << FixItHint::CreateRemoval(Call->getCallee()->getSourceRange())
6952 << FixItHint::CreateRemoval(RemovalRange);
6955 //===--- CHECK: Standard memory functions ---------------------------------===//
6957 /// \brief Takes the expression passed to the size_t parameter of functions
6958 /// such as memcmp, strncat, etc and warns if it's a comparison.
6960 /// This is to catch typos like `if (memcmp(&a, &b, sizeof(a) > 0))`.
6961 static bool CheckMemorySizeofForComparison(Sema &S, const Expr *E,
6962 IdentifierInfo *FnName,
6963 SourceLocation FnLoc,
6964 SourceLocation RParenLoc) {
6965 const BinaryOperator *Size = dyn_cast<BinaryOperator>(E);
6969 // if E is binop and op is >, <, >=, <=, ==, &&, ||:
6970 if (!Size->isComparisonOp() && !Size->isEqualityOp() && !Size->isLogicalOp())
6973 SourceRange SizeRange = Size->getSourceRange();
6974 S.Diag(Size->getOperatorLoc(), diag::warn_memsize_comparison)
6975 << SizeRange << FnName;
6976 S.Diag(FnLoc, diag::note_memsize_comparison_paren)
6977 << FnName << FixItHint::CreateInsertion(
6978 S.getLocForEndOfToken(Size->getLHS()->getLocEnd()), ")")
6979 << FixItHint::CreateRemoval(RParenLoc);
6980 S.Diag(SizeRange.getBegin(), diag::note_memsize_comparison_cast_silence)
6981 << FixItHint::CreateInsertion(SizeRange.getBegin(), "(size_t)(")
6982 << FixItHint::CreateInsertion(S.getLocForEndOfToken(SizeRange.getEnd()),
6988 /// \brief Determine whether the given type is or contains a dynamic class type
6989 /// (e.g., whether it has a vtable).
6990 static const CXXRecordDecl *getContainedDynamicClass(QualType T,
6991 bool &IsContained) {
6992 // Look through array types while ignoring qualifiers.
6993 const Type *Ty = T->getBaseElementTypeUnsafe();
6994 IsContained = false;
6996 const CXXRecordDecl *RD = Ty->getAsCXXRecordDecl();
6997 RD = RD ? RD->getDefinition() : nullptr;
6998 if (!RD || RD->isInvalidDecl())
7001 if (RD->isDynamicClass())
7004 // Check all the fields. If any bases were dynamic, the class is dynamic.
7005 // It's impossible for a class to transitively contain itself by value, so
7006 // infinite recursion is impossible.
7007 for (auto *FD : RD->fields()) {
7009 if (const CXXRecordDecl *ContainedRD =
7010 getContainedDynamicClass(FD->getType(), SubContained)) {
7019 /// \brief If E is a sizeof expression, returns its argument expression,
7020 /// otherwise returns NULL.
7021 static const Expr *getSizeOfExprArg(const Expr *E) {
7022 if (const UnaryExprOrTypeTraitExpr *SizeOf =
7023 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
7024 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
7025 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
7030 /// \brief If E is a sizeof expression, returns its argument type.
7031 static QualType getSizeOfArgType(const Expr *E) {
7032 if (const UnaryExprOrTypeTraitExpr *SizeOf =
7033 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
7034 if (SizeOf->getKind() == clang::UETT_SizeOf)
7035 return SizeOf->getTypeOfArgument();
7040 /// \brief Check for dangerous or invalid arguments to memset().
7042 /// This issues warnings on known problematic, dangerous or unspecified
7043 /// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
7046 /// \param Call The call expression to diagnose.
7047 void Sema::CheckMemaccessArguments(const CallExpr *Call,
7049 IdentifierInfo *FnName) {
7052 // It is possible to have a non-standard definition of memset. Validate
7053 // we have enough arguments, and if not, abort further checking.
7054 unsigned ExpectedNumArgs =
7055 (BId == Builtin::BIstrndup || BId == Builtin::BIbzero ? 2 : 3);
7056 if (Call->getNumArgs() < ExpectedNumArgs)
7059 unsigned LastArg = (BId == Builtin::BImemset || BId == Builtin::BIbzero ||
7060 BId == Builtin::BIstrndup ? 1 : 2);
7062 (BId == Builtin::BIbzero || BId == Builtin::BIstrndup ? 1 : 2);
7063 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
7065 if (CheckMemorySizeofForComparison(*this, LenExpr, FnName,
7066 Call->getLocStart(), Call->getRParenLoc()))
7069 // We have special checking when the length is a sizeof expression.
7070 QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
7071 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
7072 llvm::FoldingSetNodeID SizeOfArgID;
7074 // Although widely used, 'bzero' is not a standard function. Be more strict
7075 // with the argument types before allowing diagnostics and only allow the
7076 // form bzero(ptr, sizeof(...)).
7077 QualType FirstArgTy = Call->getArg(0)->IgnoreParenImpCasts()->getType();
7078 if (BId == Builtin::BIbzero && !FirstArgTy->getAs<PointerType>())
7081 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
7082 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
7083 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
7085 QualType DestTy = Dest->getType();
7087 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
7088 PointeeTy = DestPtrTy->getPointeeType();
7090 // Never warn about void type pointers. This can be used to suppress
7092 if (PointeeTy->isVoidType())
7095 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
7096 // actually comparing the expressions for equality. Because computing the
7097 // expression IDs can be expensive, we only do this if the diagnostic is
7100 !Diags.isIgnored(diag::warn_sizeof_pointer_expr_memaccess,
7101 SizeOfArg->getExprLoc())) {
7102 // We only compute IDs for expressions if the warning is enabled, and
7103 // cache the sizeof arg's ID.
7104 if (SizeOfArgID == llvm::FoldingSetNodeID())
7105 SizeOfArg->Profile(SizeOfArgID, Context, true);
7106 llvm::FoldingSetNodeID DestID;
7107 Dest->Profile(DestID, Context, true);
7108 if (DestID == SizeOfArgID) {
7109 // TODO: For strncpy() and friends, this could suggest sizeof(dst)
7110 // over sizeof(src) as well.
7111 unsigned ActionIdx = 0; // Default is to suggest dereferencing.
7112 StringRef ReadableName = FnName->getName();
7114 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
7115 if (UnaryOp->getOpcode() == UO_AddrOf)
7116 ActionIdx = 1; // If its an address-of operator, just remove it.
7117 if (!PointeeTy->isIncompleteType() &&
7118 (Context.getTypeSize(PointeeTy) == Context.getCharWidth()))
7119 ActionIdx = 2; // If the pointee's size is sizeof(char),
7120 // suggest an explicit length.
7122 // If the function is defined as a builtin macro, do not show macro
7124 SourceLocation SL = SizeOfArg->getExprLoc();
7125 SourceRange DSR = Dest->getSourceRange();
7126 SourceRange SSR = SizeOfArg->getSourceRange();
7127 SourceManager &SM = getSourceManager();
7129 if (SM.isMacroArgExpansion(SL)) {
7130 ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
7131 SL = SM.getSpellingLoc(SL);
7132 DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
7133 SM.getSpellingLoc(DSR.getEnd()));
7134 SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
7135 SM.getSpellingLoc(SSR.getEnd()));
7138 DiagRuntimeBehavior(SL, SizeOfArg,
7139 PDiag(diag::warn_sizeof_pointer_expr_memaccess)
7145 DiagRuntimeBehavior(SL, SizeOfArg,
7146 PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
7154 // Also check for cases where the sizeof argument is the exact same
7155 // type as the memory argument, and where it points to a user-defined
7157 if (SizeOfArgTy != QualType()) {
7158 if (PointeeTy->isRecordType() &&
7159 Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
7160 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
7161 PDiag(diag::warn_sizeof_pointer_type_memaccess)
7162 << FnName << SizeOfArgTy << ArgIdx
7163 << PointeeTy << Dest->getSourceRange()
7164 << LenExpr->getSourceRange());
7168 } else if (DestTy->isArrayType()) {
7172 if (PointeeTy == QualType())
7175 // Always complain about dynamic classes.
7177 if (const CXXRecordDecl *ContainedRD =
7178 getContainedDynamicClass(PointeeTy, IsContained)) {
7180 unsigned OperationType = 0;
7181 // "overwritten" if we're warning about the destination for any call
7182 // but memcmp; otherwise a verb appropriate to the call.
7183 if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
7184 if (BId == Builtin::BImemcpy)
7186 else if(BId == Builtin::BImemmove)
7188 else if (BId == Builtin::BImemcmp)
7192 DiagRuntimeBehavior(
7193 Dest->getExprLoc(), Dest,
7194 PDiag(diag::warn_dyn_class_memaccess)
7195 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
7196 << FnName << IsContained << ContainedRD << OperationType
7197 << Call->getCallee()->getSourceRange());
7198 } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
7199 BId != Builtin::BImemset)
7200 DiagRuntimeBehavior(
7201 Dest->getExprLoc(), Dest,
7202 PDiag(diag::warn_arc_object_memaccess)
7203 << ArgIdx << FnName << PointeeTy
7204 << Call->getCallee()->getSourceRange());
7208 DiagRuntimeBehavior(
7209 Dest->getExprLoc(), Dest,
7210 PDiag(diag::note_bad_memaccess_silence)
7211 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
7216 // A little helper routine: ignore addition and subtraction of integer literals.
7217 // This intentionally does not ignore all integer constant expressions because
7218 // we don't want to remove sizeof().
7219 static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
7220 Ex = Ex->IgnoreParenCasts();
7223 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
7224 if (!BO || !BO->isAdditiveOp())
7227 const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
7228 const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
7230 if (isa<IntegerLiteral>(RHS))
7232 else if (isa<IntegerLiteral>(LHS))
7241 static bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty,
7242 ASTContext &Context) {
7243 // Only handle constant-sized or VLAs, but not flexible members.
7244 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) {
7245 // Only issue the FIXIT for arrays of size > 1.
7246 if (CAT->getSize().getSExtValue() <= 1)
7248 } else if (!Ty->isVariableArrayType()) {
7254 // Warn if the user has made the 'size' argument to strlcpy or strlcat
7255 // be the size of the source, instead of the destination.
7256 void Sema::CheckStrlcpycatArguments(const CallExpr *Call,
7257 IdentifierInfo *FnName) {
7259 // Don't crash if the user has the wrong number of arguments
7260 unsigned NumArgs = Call->getNumArgs();
7261 if ((NumArgs != 3) && (NumArgs != 4))
7264 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
7265 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
7266 const Expr *CompareWithSrc = nullptr;
7268 if (CheckMemorySizeofForComparison(*this, SizeArg, FnName,
7269 Call->getLocStart(), Call->getRParenLoc()))
7272 // Look for 'strlcpy(dst, x, sizeof(x))'
7273 if (const Expr *Ex = getSizeOfExprArg(SizeArg))
7274 CompareWithSrc = Ex;
7276 // Look for 'strlcpy(dst, x, strlen(x))'
7277 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
7278 if (SizeCall->getBuiltinCallee() == Builtin::BIstrlen &&
7279 SizeCall->getNumArgs() == 1)
7280 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
7284 if (!CompareWithSrc)
7287 // Determine if the argument to sizeof/strlen is equal to the source
7288 // argument. In principle there's all kinds of things you could do
7289 // here, for instance creating an == expression and evaluating it with
7290 // EvaluateAsBooleanCondition, but this uses a more direct technique:
7291 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
7295 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
7296 if (!CompareWithSrcDRE ||
7297 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
7300 const Expr *OriginalSizeArg = Call->getArg(2);
7301 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
7302 << OriginalSizeArg->getSourceRange() << FnName;
7304 // Output a FIXIT hint if the destination is an array (rather than a
7305 // pointer to an array). This could be enhanced to handle some
7306 // pointers if we know the actual size, like if DstArg is 'array+2'
7307 // we could say 'sizeof(array)-2'.
7308 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
7309 if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context))
7312 SmallString<128> sizeString;
7313 llvm::raw_svector_ostream OS(sizeString);
7315 DstArg->printPretty(OS, nullptr, getPrintingPolicy());
7318 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
7319 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
7323 /// Check if two expressions refer to the same declaration.
7324 static bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
7325 if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
7326 if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
7327 return D1->getDecl() == D2->getDecl();
7331 static const Expr *getStrlenExprArg(const Expr *E) {
7332 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
7333 const FunctionDecl *FD = CE->getDirectCallee();
7334 if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
7336 return CE->getArg(0)->IgnoreParenCasts();
7341 // Warn on anti-patterns as the 'size' argument to strncat.
7342 // The correct size argument should look like following:
7343 // strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
7344 void Sema::CheckStrncatArguments(const CallExpr *CE,
7345 IdentifierInfo *FnName) {
7346 // Don't crash if the user has the wrong number of arguments.
7347 if (CE->getNumArgs() < 3)
7349 const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
7350 const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
7351 const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
7353 if (CheckMemorySizeofForComparison(*this, LenArg, FnName, CE->getLocStart(),
7354 CE->getRParenLoc()))
7357 // Identify common expressions, which are wrongly used as the size argument
7358 // to strncat and may lead to buffer overflows.
7359 unsigned PatternType = 0;
7360 if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
7362 if (referToTheSameDecl(SizeOfArg, DstArg))
7365 else if (referToTheSameDecl(SizeOfArg, SrcArg))
7367 } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
7368 if (BE->getOpcode() == BO_Sub) {
7369 const Expr *L = BE->getLHS()->IgnoreParenCasts();
7370 const Expr *R = BE->getRHS()->IgnoreParenCasts();
7371 // - sizeof(dst) - strlen(dst)
7372 if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
7373 referToTheSameDecl(DstArg, getStrlenExprArg(R)))
7375 // - sizeof(src) - (anything)
7376 else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
7381 if (PatternType == 0)
7384 // Generate the diagnostic.
7385 SourceLocation SL = LenArg->getLocStart();
7386 SourceRange SR = LenArg->getSourceRange();
7387 SourceManager &SM = getSourceManager();
7389 // If the function is defined as a builtin macro, do not show macro expansion.
7390 if (SM.isMacroArgExpansion(SL)) {
7391 SL = SM.getSpellingLoc(SL);
7392 SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
7393 SM.getSpellingLoc(SR.getEnd()));
7396 // Check if the destination is an array (rather than a pointer to an array).
7397 QualType DstTy = DstArg->getType();
7398 bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy,
7400 if (!isKnownSizeArray) {
7401 if (PatternType == 1)
7402 Diag(SL, diag::warn_strncat_wrong_size) << SR;
7404 Diag(SL, diag::warn_strncat_src_size) << SR;
7408 if (PatternType == 1)
7409 Diag(SL, diag::warn_strncat_large_size) << SR;
7411 Diag(SL, diag::warn_strncat_src_size) << SR;
7413 SmallString<128> sizeString;
7414 llvm::raw_svector_ostream OS(sizeString);
7416 DstArg->printPretty(OS, nullptr, getPrintingPolicy());
7419 DstArg->printPretty(OS, nullptr, getPrintingPolicy());
7422 Diag(SL, diag::note_strncat_wrong_size)
7423 << FixItHint::CreateReplacement(SR, OS.str());
7426 //===--- CHECK: Return Address of Stack Variable --------------------------===//
7428 static const Expr *EvalVal(const Expr *E,
7429 SmallVectorImpl<const DeclRefExpr *> &refVars,
7430 const Decl *ParentDecl);
7431 static const Expr *EvalAddr(const Expr *E,
7432 SmallVectorImpl<const DeclRefExpr *> &refVars,
7433 const Decl *ParentDecl);
7435 /// CheckReturnStackAddr - Check if a return statement returns the address
7436 /// of a stack variable.
7438 CheckReturnStackAddr(Sema &S, Expr *RetValExp, QualType lhsType,
7439 SourceLocation ReturnLoc) {
7441 const Expr *stackE = nullptr;
7442 SmallVector<const DeclRefExpr *, 8> refVars;
7444 // Perform checking for returned stack addresses, local blocks,
7445 // label addresses or references to temporaries.
7446 if (lhsType->isPointerType() ||
7447 (!S.getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
7448 stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/nullptr);
7449 } else if (lhsType->isReferenceType()) {
7450 stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/nullptr);
7454 return; // Nothing suspicious was found.
7456 // Parameters are initialized in the calling scope, so taking the address
7457 // of a parameter reference doesn't need a warning.
7458 for (auto *DRE : refVars)
7459 if (isa<ParmVarDecl>(DRE->getDecl()))
7462 SourceLocation diagLoc;
7463 SourceRange diagRange;
7464 if (refVars.empty()) {
7465 diagLoc = stackE->getLocStart();
7466 diagRange = stackE->getSourceRange();
7468 // We followed through a reference variable. 'stackE' contains the
7469 // problematic expression but we will warn at the return statement pointing
7470 // at the reference variable. We will later display the "trail" of
7471 // reference variables using notes.
7472 diagLoc = refVars[0]->getLocStart();
7473 diagRange = refVars[0]->getSourceRange();
7476 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) {
7477 // address of local var
7478 S.Diag(diagLoc, diag::warn_ret_stack_addr_ref) << lhsType->isReferenceType()
7479 << DR->getDecl()->getDeclName() << diagRange;
7480 } else if (isa<BlockExpr>(stackE)) { // local block.
7481 S.Diag(diagLoc, diag::err_ret_local_block) << diagRange;
7482 } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
7483 S.Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
7484 } else { // local temporary.
7485 // If there is an LValue->RValue conversion, then the value of the
7486 // reference type is used, not the reference.
7487 if (auto *ICE = dyn_cast<ImplicitCastExpr>(RetValExp)) {
7488 if (ICE->getCastKind() == CK_LValueToRValue) {
7492 S.Diag(diagLoc, diag::warn_ret_local_temp_addr_ref)
7493 << lhsType->isReferenceType() << diagRange;
7496 // Display the "trail" of reference variables that we followed until we
7497 // found the problematic expression using notes.
7498 for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
7499 const VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
7500 // If this var binds to another reference var, show the range of the next
7501 // var, otherwise the var binds to the problematic expression, in which case
7502 // show the range of the expression.
7503 SourceRange range = (i < e - 1) ? refVars[i + 1]->getSourceRange()
7504 : stackE->getSourceRange();
7505 S.Diag(VD->getLocation(), diag::note_ref_var_local_bind)
7506 << VD->getDeclName() << range;
7510 /// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
7511 /// check if the expression in a return statement evaluates to an address
7512 /// to a location on the stack, a local block, an address of a label, or a
7513 /// reference to local temporary. The recursion is used to traverse the
7514 /// AST of the return expression, with recursion backtracking when we
7515 /// encounter a subexpression that (1) clearly does not lead to one of the
7516 /// above problematic expressions (2) is something we cannot determine leads to
7517 /// a problematic expression based on such local checking.
7519 /// Both EvalAddr and EvalVal follow through reference variables to evaluate
7520 /// the expression that they point to. Such variables are added to the
7521 /// 'refVars' vector so that we know what the reference variable "trail" was.
7523 /// EvalAddr processes expressions that are pointers that are used as
7524 /// references (and not L-values). EvalVal handles all other values.
7525 /// At the base case of the recursion is a check for the above problematic
7528 /// This implementation handles:
7530 /// * pointer-to-pointer casts
7531 /// * implicit conversions from array references to pointers
7532 /// * taking the address of fields
7533 /// * arbitrary interplay between "&" and "*" operators
7534 /// * pointer arithmetic from an address of a stack variable
7535 /// * taking the address of an array element where the array is on the stack
7536 static const Expr *EvalAddr(const Expr *E,
7537 SmallVectorImpl<const DeclRefExpr *> &refVars,
7538 const Decl *ParentDecl) {
7539 if (E->isTypeDependent())
7542 // We should only be called for evaluating pointer expressions.
7543 assert((E->getType()->isAnyPointerType() ||
7544 E->getType()->isBlockPointerType() ||
7545 E->getType()->isObjCQualifiedIdType()) &&
7546 "EvalAddr only works on pointers");
7548 E = E->IgnoreParens();
7550 // Our "symbolic interpreter" is just a dispatch off the currently
7551 // viewed AST node. We then recursively traverse the AST by calling
7552 // EvalAddr and EvalVal appropriately.
7553 switch (E->getStmtClass()) {
7554 case Stmt::DeclRefExprClass: {
7555 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
7557 // If we leave the immediate function, the lifetime isn't about to end.
7558 if (DR->refersToEnclosingVariableOrCapture())
7561 if (const VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
7562 // If this is a reference variable, follow through to the expression that
7564 if (V->hasLocalStorage() &&
7565 V->getType()->isReferenceType() && V->hasInit()) {
7566 // Add the reference variable to the "trail".
7567 refVars.push_back(DR);
7568 return EvalAddr(V->getInit(), refVars, ParentDecl);
7574 case Stmt::UnaryOperatorClass: {
7575 // The only unary operator that make sense to handle here
7576 // is AddrOf. All others don't make sense as pointers.
7577 const UnaryOperator *U = cast<UnaryOperator>(E);
7579 if (U->getOpcode() == UO_AddrOf)
7580 return EvalVal(U->getSubExpr(), refVars, ParentDecl);
7584 case Stmt::BinaryOperatorClass: {
7585 // Handle pointer arithmetic. All other binary operators are not valid
7587 const BinaryOperator *B = cast<BinaryOperator>(E);
7588 BinaryOperatorKind op = B->getOpcode();
7590 if (op != BO_Add && op != BO_Sub)
7593 const Expr *Base = B->getLHS();
7595 // Determine which argument is the real pointer base. It could be
7596 // the RHS argument instead of the LHS.
7597 if (!Base->getType()->isPointerType())
7600 assert(Base->getType()->isPointerType());
7601 return EvalAddr(Base, refVars, ParentDecl);
7604 // For conditional operators we need to see if either the LHS or RHS are
7605 // valid DeclRefExpr*s. If one of them is valid, we return it.
7606 case Stmt::ConditionalOperatorClass: {
7607 const ConditionalOperator *C = cast<ConditionalOperator>(E);
7609 // Handle the GNU extension for missing LHS.
7610 // FIXME: That isn't a ConditionalOperator, so doesn't get here.
7611 if (const Expr *LHSExpr = C->getLHS()) {
7612 // In C++, we can have a throw-expression, which has 'void' type.
7613 if (!LHSExpr->getType()->isVoidType())
7614 if (const Expr *LHS = EvalAddr(LHSExpr, refVars, ParentDecl))
7618 // In C++, we can have a throw-expression, which has 'void' type.
7619 if (C->getRHS()->getType()->isVoidType())
7622 return EvalAddr(C->getRHS(), refVars, ParentDecl);
7625 case Stmt::BlockExprClass:
7626 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
7627 return E; // local block.
7630 case Stmt::AddrLabelExprClass:
7631 return E; // address of label.
7633 case Stmt::ExprWithCleanupsClass:
7634 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
7637 // For casts, we need to handle conversions from arrays to
7638 // pointer values, and pointer-to-pointer conversions.
7639 case Stmt::ImplicitCastExprClass:
7640 case Stmt::CStyleCastExprClass:
7641 case Stmt::CXXFunctionalCastExprClass:
7642 case Stmt::ObjCBridgedCastExprClass:
7643 case Stmt::CXXStaticCastExprClass:
7644 case Stmt::CXXDynamicCastExprClass:
7645 case Stmt::CXXConstCastExprClass:
7646 case Stmt::CXXReinterpretCastExprClass: {
7647 const Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
7648 switch (cast<CastExpr>(E)->getCastKind()) {
7649 case CK_LValueToRValue:
7651 case CK_BaseToDerived:
7652 case CK_DerivedToBase:
7653 case CK_UncheckedDerivedToBase:
7655 case CK_CPointerToObjCPointerCast:
7656 case CK_BlockPointerToObjCPointerCast:
7657 case CK_AnyPointerToBlockPointerCast:
7658 return EvalAddr(SubExpr, refVars, ParentDecl);
7660 case CK_ArrayToPointerDecay:
7661 return EvalVal(SubExpr, refVars, ParentDecl);
7664 if (SubExpr->getType()->isAnyPointerType() ||
7665 SubExpr->getType()->isBlockPointerType() ||
7666 SubExpr->getType()->isObjCQualifiedIdType())
7667 return EvalAddr(SubExpr, refVars, ParentDecl);
7676 case Stmt::MaterializeTemporaryExprClass:
7677 if (const Expr *Result =
7678 EvalAddr(cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
7679 refVars, ParentDecl))
7683 // Everything else: we simply don't reason about them.
7689 /// EvalVal - This function is complements EvalAddr in the mutual recursion.
7690 /// See the comments for EvalAddr for more details.
7691 static const Expr *EvalVal(const Expr *E,
7692 SmallVectorImpl<const DeclRefExpr *> &refVars,
7693 const Decl *ParentDecl) {
7695 // We should only be called for evaluating non-pointer expressions, or
7696 // expressions with a pointer type that are not used as references but
7698 // are l-values (e.g., DeclRefExpr with a pointer type).
7700 // Our "symbolic interpreter" is just a dispatch off the currently
7701 // viewed AST node. We then recursively traverse the AST by calling
7702 // EvalAddr and EvalVal appropriately.
7704 E = E->IgnoreParens();
7705 switch (E->getStmtClass()) {
7706 case Stmt::ImplicitCastExprClass: {
7707 const ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
7708 if (IE->getValueKind() == VK_LValue) {
7709 E = IE->getSubExpr();
7715 case Stmt::ExprWithCleanupsClass:
7716 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
7719 case Stmt::DeclRefExprClass: {
7720 // When we hit a DeclRefExpr we are looking at code that refers to a
7721 // variable's name. If it's not a reference variable we check if it has
7722 // local storage within the function, and if so, return the expression.
7723 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
7725 // If we leave the immediate function, the lifetime isn't about to end.
7726 if (DR->refersToEnclosingVariableOrCapture())
7729 if (const VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
7730 // Check if it refers to itself, e.g. "int& i = i;".
7731 if (V == ParentDecl)
7734 if (V->hasLocalStorage()) {
7735 if (!V->getType()->isReferenceType())
7738 // Reference variable, follow through to the expression that
7741 // Add the reference variable to the "trail".
7742 refVars.push_back(DR);
7743 return EvalVal(V->getInit(), refVars, V);
7751 case Stmt::UnaryOperatorClass: {
7752 // The only unary operator that make sense to handle here
7753 // is Deref. All others don't resolve to a "name." This includes
7754 // handling all sorts of rvalues passed to a unary operator.
7755 const UnaryOperator *U = cast<UnaryOperator>(E);
7757 if (U->getOpcode() == UO_Deref)
7758 return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
7763 case Stmt::ArraySubscriptExprClass: {
7764 // Array subscripts are potential references to data on the stack. We
7765 // retrieve the DeclRefExpr* for the array variable if it indeed
7766 // has local storage.
7767 const auto *ASE = cast<ArraySubscriptExpr>(E);
7768 if (ASE->isTypeDependent())
7770 return EvalAddr(ASE->getBase(), refVars, ParentDecl);
7773 case Stmt::OMPArraySectionExprClass: {
7774 return EvalAddr(cast<OMPArraySectionExpr>(E)->getBase(), refVars,
7778 case Stmt::ConditionalOperatorClass: {
7779 // For conditional operators we need to see if either the LHS or RHS are
7780 // non-NULL Expr's. If one is non-NULL, we return it.
7781 const ConditionalOperator *C = cast<ConditionalOperator>(E);
7783 // Handle the GNU extension for missing LHS.
7784 if (const Expr *LHSExpr = C->getLHS()) {
7785 // In C++, we can have a throw-expression, which has 'void' type.
7786 if (!LHSExpr->getType()->isVoidType())
7787 if (const Expr *LHS = EvalVal(LHSExpr, refVars, ParentDecl))
7791 // In C++, we can have a throw-expression, which has 'void' type.
7792 if (C->getRHS()->getType()->isVoidType())
7795 return EvalVal(C->getRHS(), refVars, ParentDecl);
7798 // Accesses to members are potential references to data on the stack.
7799 case Stmt::MemberExprClass: {
7800 const MemberExpr *M = cast<MemberExpr>(E);
7802 // Check for indirect access. We only want direct field accesses.
7806 // Check whether the member type is itself a reference, in which case
7807 // we're not going to refer to the member, but to what the member refers
7809 if (M->getMemberDecl()->getType()->isReferenceType())
7812 return EvalVal(M->getBase(), refVars, ParentDecl);
7815 case Stmt::MaterializeTemporaryExprClass:
7816 if (const Expr *Result =
7817 EvalVal(cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
7818 refVars, ParentDecl))
7823 // Check that we don't return or take the address of a reference to a
7824 // temporary. This is only useful in C++.
7825 if (!E->isTypeDependent() && E->isRValue())
7828 // Everything else: we simply don't reason about them.
7835 Sema::CheckReturnValExpr(Expr *RetValExp, QualType lhsType,
7836 SourceLocation ReturnLoc,
7838 const AttrVec *Attrs,
7839 const FunctionDecl *FD) {
7840 CheckReturnStackAddr(*this, RetValExp, lhsType, ReturnLoc);
7842 // Check if the return value is null but should not be.
7843 if (((Attrs && hasSpecificAttr<ReturnsNonNullAttr>(*Attrs)) ||
7844 (!isObjCMethod && isNonNullType(Context, lhsType))) &&
7845 CheckNonNullExpr(*this, RetValExp))
7846 Diag(ReturnLoc, diag::warn_null_ret)
7847 << (isObjCMethod ? 1 : 0) << RetValExp->getSourceRange();
7849 // C++11 [basic.stc.dynamic.allocation]p4:
7850 // If an allocation function declared with a non-throwing
7851 // exception-specification fails to allocate storage, it shall return
7852 // a null pointer. Any other allocation function that fails to allocate
7853 // storage shall indicate failure only by throwing an exception [...]
7855 OverloadedOperatorKind Op = FD->getOverloadedOperator();
7856 if (Op == OO_New || Op == OO_Array_New) {
7857 const FunctionProtoType *Proto
7858 = FD->getType()->castAs<FunctionProtoType>();
7859 if (!Proto->isNothrow(Context, /*ResultIfDependent*/true) &&
7860 CheckNonNullExpr(*this, RetValExp))
7861 Diag(ReturnLoc, diag::warn_operator_new_returns_null)
7862 << FD << getLangOpts().CPlusPlus11;
7867 //===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
7869 /// Check for comparisons of floating point operands using != and ==.
7870 /// Issue a warning if these are no self-comparisons, as they are not likely
7871 /// to do what the programmer intended.
7872 void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
7873 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
7874 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
7876 // Special case: check for x == x (which is OK).
7877 // Do not emit warnings for such cases.
7878 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
7879 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
7880 if (DRL->getDecl() == DRR->getDecl())
7883 // Special case: check for comparisons against literals that can be exactly
7884 // represented by APFloat. In such cases, do not emit a warning. This
7885 // is a heuristic: often comparison against such literals are used to
7886 // detect if a value in a variable has not changed. This clearly can
7887 // lead to false negatives.
7888 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
7892 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
7896 // Check for comparisons with builtin types.
7897 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
7898 if (CL->getBuiltinCallee())
7901 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
7902 if (CR->getBuiltinCallee())
7905 // Emit the diagnostic.
7906 Diag(Loc, diag::warn_floatingpoint_eq)
7907 << LHS->getSourceRange() << RHS->getSourceRange();
7910 //===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
7911 //===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
7915 /// Structure recording the 'active' range of an integer-valued
7918 /// The number of bits active in the int.
7921 /// True if the int is known not to have negative values.
7924 IntRange(unsigned Width, bool NonNegative)
7925 : Width(Width), NonNegative(NonNegative)
7928 /// Returns the range of the bool type.
7929 static IntRange forBoolType() {
7930 return IntRange(1, true);
7933 /// Returns the range of an opaque value of the given integral type.
7934 static IntRange forValueOfType(ASTContext &C, QualType T) {
7935 return forValueOfCanonicalType(C,
7936 T->getCanonicalTypeInternal().getTypePtr());
7939 /// Returns the range of an opaque value of a canonical integral type.
7940 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
7941 assert(T->isCanonicalUnqualified());
7943 if (const VectorType *VT = dyn_cast<VectorType>(T))
7944 T = VT->getElementType().getTypePtr();
7945 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
7946 T = CT->getElementType().getTypePtr();
7947 if (const AtomicType *AT = dyn_cast<AtomicType>(T))
7948 T = AT->getValueType().getTypePtr();
7950 // For enum types, use the known bit width of the enumerators.
7951 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
7952 EnumDecl *Enum = ET->getDecl();
7953 if (!Enum->isCompleteDefinition())
7954 return IntRange(C.getIntWidth(QualType(T, 0)), false);
7956 unsigned NumPositive = Enum->getNumPositiveBits();
7957 unsigned NumNegative = Enum->getNumNegativeBits();
7959 if (NumNegative == 0)
7960 return IntRange(NumPositive, true/*NonNegative*/);
7962 return IntRange(std::max(NumPositive + 1, NumNegative),
7963 false/*NonNegative*/);
7966 const BuiltinType *BT = cast<BuiltinType>(T);
7967 assert(BT->isInteger());
7969 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
7972 /// Returns the "target" range of a canonical integral type, i.e.
7973 /// the range of values expressible in the type.
7975 /// This matches forValueOfCanonicalType except that enums have the
7976 /// full range of their type, not the range of their enumerators.
7977 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
7978 assert(T->isCanonicalUnqualified());
7980 if (const VectorType *VT = dyn_cast<VectorType>(T))
7981 T = VT->getElementType().getTypePtr();
7982 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
7983 T = CT->getElementType().getTypePtr();
7984 if (const AtomicType *AT = dyn_cast<AtomicType>(T))
7985 T = AT->getValueType().getTypePtr();
7986 if (const EnumType *ET = dyn_cast<EnumType>(T))
7987 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
7989 const BuiltinType *BT = cast<BuiltinType>(T);
7990 assert(BT->isInteger());
7992 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
7995 /// Returns the supremum of two ranges: i.e. their conservative merge.
7996 static IntRange join(IntRange L, IntRange R) {
7997 return IntRange(std::max(L.Width, R.Width),
7998 L.NonNegative && R.NonNegative);
8001 /// Returns the infinum of two ranges: i.e. their aggressive merge.
8002 static IntRange meet(IntRange L, IntRange R) {
8003 return IntRange(std::min(L.Width, R.Width),
8004 L.NonNegative || R.NonNegative);
8008 IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
8009 if (value.isSigned() && value.isNegative())
8010 return IntRange(value.getMinSignedBits(), false);
8012 if (value.getBitWidth() > MaxWidth)
8013 value = value.trunc(MaxWidth);
8015 // isNonNegative() just checks the sign bit without considering
8017 return IntRange(value.getActiveBits(), true);
8020 IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
8021 unsigned MaxWidth) {
8023 return GetValueRange(C, result.getInt(), MaxWidth);
8025 if (result.isVector()) {
8026 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
8027 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
8028 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
8029 R = IntRange::join(R, El);
8034 if (result.isComplexInt()) {
8035 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
8036 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
8037 return IntRange::join(R, I);
8040 // This can happen with lossless casts to intptr_t of "based" lvalues.
8041 // Assume it might use arbitrary bits.
8042 // FIXME: The only reason we need to pass the type in here is to get
8043 // the sign right on this one case. It would be nice if APValue
8045 assert(result.isLValue() || result.isAddrLabelDiff());
8046 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
8049 QualType GetExprType(const Expr *E) {
8050 QualType Ty = E->getType();
8051 if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>())
8052 Ty = AtomicRHS->getValueType();
8056 /// Pseudo-evaluate the given integer expression, estimating the
8057 /// range of values it might take.
8059 /// \param MaxWidth - the width to which the value will be truncated
8060 IntRange GetExprRange(ASTContext &C, const Expr *E, unsigned MaxWidth) {
8061 E = E->IgnoreParens();
8063 // Try a full evaluation first.
8064 Expr::EvalResult result;
8065 if (E->EvaluateAsRValue(result, C))
8066 return GetValueRange(C, result.Val, GetExprType(E), MaxWidth);
8068 // I think we only want to look through implicit casts here; if the
8069 // user has an explicit widening cast, we should treat the value as
8070 // being of the new, wider type.
8071 if (const auto *CE = dyn_cast<ImplicitCastExpr>(E)) {
8072 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
8073 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
8075 IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE));
8077 bool isIntegerCast = CE->getCastKind() == CK_IntegralCast ||
8078 CE->getCastKind() == CK_BooleanToSignedIntegral;
8080 // Assume that non-integer casts can span the full range of the type.
8082 return OutputTypeRange;
8085 = GetExprRange(C, CE->getSubExpr(),
8086 std::min(MaxWidth, OutputTypeRange.Width));
8088 // Bail out if the subexpr's range is as wide as the cast type.
8089 if (SubRange.Width >= OutputTypeRange.Width)
8090 return OutputTypeRange;
8092 // Otherwise, we take the smaller width, and we're non-negative if
8093 // either the output type or the subexpr is.
8094 return IntRange(SubRange.Width,
8095 SubRange.NonNegative || OutputTypeRange.NonNegative);
8098 if (const auto *CO = dyn_cast<ConditionalOperator>(E)) {
8099 // If we can fold the condition, just take that operand.
8101 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
8102 return GetExprRange(C, CondResult ? CO->getTrueExpr()
8103 : CO->getFalseExpr(),
8106 // Otherwise, conservatively merge.
8107 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
8108 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
8109 return IntRange::join(L, R);
8112 if (const auto *BO = dyn_cast<BinaryOperator>(E)) {
8113 switch (BO->getOpcode()) {
8115 // Boolean-valued operations are single-bit and positive.
8124 return IntRange::forBoolType();
8126 // The type of the assignments is the type of the LHS, so the RHS
8127 // is not necessarily the same type.
8136 return IntRange::forValueOfType(C, GetExprType(E));
8138 // Simple assignments just pass through the RHS, which will have
8139 // been coerced to the LHS type.
8142 return GetExprRange(C, BO->getRHS(), MaxWidth);
8144 // Operations with opaque sources are black-listed.
8147 return IntRange::forValueOfType(C, GetExprType(E));
8149 // Bitwise-and uses the *infinum* of the two source ranges.
8152 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
8153 GetExprRange(C, BO->getRHS(), MaxWidth));
8155 // Left shift gets black-listed based on a judgement call.
8157 // ...except that we want to treat '1 << (blah)' as logically
8158 // positive. It's an important idiom.
8159 if (IntegerLiteral *I
8160 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
8161 if (I->getValue() == 1) {
8162 IntRange R = IntRange::forValueOfType(C, GetExprType(E));
8163 return IntRange(R.Width, /*NonNegative*/ true);
8169 return IntRange::forValueOfType(C, GetExprType(E));
8171 // Right shift by a constant can narrow its left argument.
8173 case BO_ShrAssign: {
8174 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
8176 // If the shift amount is a positive constant, drop the width by
8179 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
8180 shift.isNonNegative()) {
8181 unsigned zext = shift.getZExtValue();
8182 if (zext >= L.Width)
8183 L.Width = (L.NonNegative ? 0 : 1);
8191 // Comma acts as its right operand.
8193 return GetExprRange(C, BO->getRHS(), MaxWidth);
8195 // Black-list pointer subtractions.
8197 if (BO->getLHS()->getType()->isPointerType())
8198 return IntRange::forValueOfType(C, GetExprType(E));
8201 // The width of a division result is mostly determined by the size
8204 // Don't 'pre-truncate' the operands.
8205 unsigned opWidth = C.getIntWidth(GetExprType(E));
8206 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
8208 // If the divisor is constant, use that.
8209 llvm::APSInt divisor;
8210 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
8211 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
8212 if (log2 >= L.Width)
8213 L.Width = (L.NonNegative ? 0 : 1);
8215 L.Width = std::min(L.Width - log2, MaxWidth);
8219 // Otherwise, just use the LHS's width.
8220 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
8221 return IntRange(L.Width, L.NonNegative && R.NonNegative);
8224 // The result of a remainder can't be larger than the result of
8227 // Don't 'pre-truncate' the operands.
8228 unsigned opWidth = C.getIntWidth(GetExprType(E));
8229 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
8230 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
8232 IntRange meet = IntRange::meet(L, R);
8233 meet.Width = std::min(meet.Width, MaxWidth);
8237 // The default behavior is okay for these.
8245 // The default case is to treat the operation as if it were closed
8246 // on the narrowest type that encompasses both operands.
8247 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
8248 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
8249 return IntRange::join(L, R);
8252 if (const auto *UO = dyn_cast<UnaryOperator>(E)) {
8253 switch (UO->getOpcode()) {
8254 // Boolean-valued operations are white-listed.
8256 return IntRange::forBoolType();
8258 // Operations with opaque sources are black-listed.
8260 case UO_AddrOf: // should be impossible
8261 return IntRange::forValueOfType(C, GetExprType(E));
8264 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
8268 if (const auto *OVE = dyn_cast<OpaqueValueExpr>(E))
8269 return GetExprRange(C, OVE->getSourceExpr(), MaxWidth);
8271 if (const auto *BitField = E->getSourceBitField())
8272 return IntRange(BitField->getBitWidthValue(C),
8273 BitField->getType()->isUnsignedIntegerOrEnumerationType());
8275 return IntRange::forValueOfType(C, GetExprType(E));
8278 IntRange GetExprRange(ASTContext &C, const Expr *E) {
8279 return GetExprRange(C, E, C.getIntWidth(GetExprType(E)));
8282 /// Checks whether the given value, which currently has the given
8283 /// source semantics, has the same value when coerced through the
8284 /// target semantics.
8285 bool IsSameFloatAfterCast(const llvm::APFloat &value,
8286 const llvm::fltSemantics &Src,
8287 const llvm::fltSemantics &Tgt) {
8288 llvm::APFloat truncated = value;
8291 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
8292 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
8294 return truncated.bitwiseIsEqual(value);
8297 /// Checks whether the given value, which currently has the given
8298 /// source semantics, has the same value when coerced through the
8299 /// target semantics.
8301 /// The value might be a vector of floats (or a complex number).
8302 bool IsSameFloatAfterCast(const APValue &value,
8303 const llvm::fltSemantics &Src,
8304 const llvm::fltSemantics &Tgt) {
8305 if (value.isFloat())
8306 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
8308 if (value.isVector()) {
8309 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
8310 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
8315 assert(value.isComplexFloat());
8316 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
8317 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
8320 void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
8322 bool IsZero(Sema &S, Expr *E) {
8323 // Suppress cases where we are comparing against an enum constant.
8324 if (const DeclRefExpr *DR =
8325 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
8326 if (isa<EnumConstantDecl>(DR->getDecl()))
8329 // Suppress cases where the '0' value is expanded from a macro.
8330 if (E->getLocStart().isMacroID())
8334 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
8337 bool HasEnumType(Expr *E) {
8338 // Strip off implicit integral promotions.
8339 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
8340 if (ICE->getCastKind() != CK_IntegralCast &&
8341 ICE->getCastKind() != CK_NoOp)
8343 E = ICE->getSubExpr();
8346 return E->getType()->isEnumeralType();
8349 void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
8350 // Disable warning in template instantiations.
8351 if (S.inTemplateInstantiation())
8354 BinaryOperatorKind op = E->getOpcode();
8355 if (E->isValueDependent())
8358 if (op == BO_LT && IsZero(S, E->getRHS())) {
8359 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
8360 << "< 0" << "false" << HasEnumType(E->getLHS())
8361 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
8362 } else if (op == BO_GE && IsZero(S, E->getRHS())) {
8363 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
8364 << ">= 0" << "true" << HasEnumType(E->getLHS())
8365 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
8366 } else if (op == BO_GT && IsZero(S, E->getLHS())) {
8367 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
8368 << "0 >" << "false" << HasEnumType(E->getRHS())
8369 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
8370 } else if (op == BO_LE && IsZero(S, E->getLHS())) {
8371 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
8372 << "0 <=" << "true" << HasEnumType(E->getRHS())
8373 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
8377 void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, Expr *Constant,
8378 Expr *Other, const llvm::APSInt &Value,
8380 // Disable warning in template instantiations.
8381 if (S.inTemplateInstantiation())
8384 // TODO: Investigate using GetExprRange() to get tighter bounds
8385 // on the bit ranges.
8386 QualType OtherT = Other->getType();
8387 if (const auto *AT = OtherT->getAs<AtomicType>())
8388 OtherT = AT->getValueType();
8389 IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT);
8390 unsigned OtherWidth = OtherRange.Width;
8392 bool OtherIsBooleanType = Other->isKnownToHaveBooleanValue();
8394 // 0 values are handled later by CheckTrivialUnsignedComparison().
8395 if ((Value == 0) && (!OtherIsBooleanType))
8398 BinaryOperatorKind op = E->getOpcode();
8401 // Used for diagnostic printout.
8403 LiteralConstant = 0,
8406 } LiteralOrBoolConstant = LiteralConstant;
8408 if (!OtherIsBooleanType) {
8409 QualType ConstantT = Constant->getType();
8410 QualType CommonT = E->getLHS()->getType();
8412 if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT))
8414 assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) &&
8415 "comparison with non-integer type");
8417 bool ConstantSigned = ConstantT->isSignedIntegerType();
8418 bool CommonSigned = CommonT->isSignedIntegerType();
8420 bool EqualityOnly = false;
8423 // The common type is signed, therefore no signed to unsigned conversion.
8424 if (!OtherRange.NonNegative) {
8425 // Check that the constant is representable in type OtherT.
8426 if (ConstantSigned) {
8427 if (OtherWidth >= Value.getMinSignedBits())
8429 } else { // !ConstantSigned
8430 if (OtherWidth >= Value.getActiveBits() + 1)
8433 } else { // !OtherSigned
8434 // Check that the constant is representable in type OtherT.
8435 // Negative values are out of range.
8436 if (ConstantSigned) {
8437 if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits())
8439 } else { // !ConstantSigned
8440 if (OtherWidth >= Value.getActiveBits())
8444 } else { // !CommonSigned
8445 if (OtherRange.NonNegative) {
8446 if (OtherWidth >= Value.getActiveBits())
8448 } else { // OtherSigned
8449 assert(!ConstantSigned &&
8450 "Two signed types converted to unsigned types.");
8451 // Check to see if the constant is representable in OtherT.
8452 if (OtherWidth > Value.getActiveBits())
8454 // Check to see if the constant is equivalent to a negative value
8456 if (S.Context.getIntWidth(ConstantT) ==
8457 S.Context.getIntWidth(CommonT) &&
8458 Value.isNegative() && Value.getMinSignedBits() <= OtherWidth)
8460 // The constant value rests between values that OtherT can represent
8461 // after conversion. Relational comparison still works, but equality
8462 // comparisons will be tautological.
8463 EqualityOnly = true;
8467 bool PositiveConstant = !ConstantSigned || Value.isNonNegative();
8469 if (op == BO_EQ || op == BO_NE) {
8470 IsTrue = op == BO_NE;
8471 } else if (EqualityOnly) {
8473 } else if (RhsConstant) {
8474 if (op == BO_GT || op == BO_GE)
8475 IsTrue = !PositiveConstant;
8476 else // op == BO_LT || op == BO_LE
8477 IsTrue = PositiveConstant;
8479 if (op == BO_LT || op == BO_LE)
8480 IsTrue = !PositiveConstant;
8481 else // op == BO_GT || op == BO_GE
8482 IsTrue = PositiveConstant;
8485 // Other isKnownToHaveBooleanValue
8486 enum CompareBoolWithConstantResult { AFals, ATrue, Unkwn };
8487 enum ConstantValue { LT_Zero, Zero, One, GT_One, SizeOfConstVal };
8488 enum ConstantSide { Lhs, Rhs, SizeOfConstSides };
8490 static const struct LinkedConditions {
8491 CompareBoolWithConstantResult BO_LT_OP[SizeOfConstSides][SizeOfConstVal];
8492 CompareBoolWithConstantResult BO_GT_OP[SizeOfConstSides][SizeOfConstVal];
8493 CompareBoolWithConstantResult BO_LE_OP[SizeOfConstSides][SizeOfConstVal];
8494 CompareBoolWithConstantResult BO_GE_OP[SizeOfConstSides][SizeOfConstVal];
8495 CompareBoolWithConstantResult BO_EQ_OP[SizeOfConstSides][SizeOfConstVal];
8496 CompareBoolWithConstantResult BO_NE_OP[SizeOfConstSides][SizeOfConstVal];
8499 // Constant on LHS. | Constant on RHS. |
8500 // LT_Zero| Zero | One |GT_One| LT_Zero| Zero | One |GT_One|
8501 { { ATrue, Unkwn, AFals, AFals }, { AFals, AFals, Unkwn, ATrue } },
8502 { { AFals, AFals, Unkwn, ATrue }, { ATrue, Unkwn, AFals, AFals } },
8503 { { ATrue, ATrue, Unkwn, AFals }, { AFals, Unkwn, ATrue, ATrue } },
8504 { { AFals, Unkwn, ATrue, ATrue }, { ATrue, ATrue, Unkwn, AFals } },
8505 { { AFals, Unkwn, Unkwn, AFals }, { AFals, Unkwn, Unkwn, AFals } },
8506 { { ATrue, Unkwn, Unkwn, ATrue }, { ATrue, Unkwn, Unkwn, ATrue } }
8509 bool ConstantIsBoolLiteral = isa<CXXBoolLiteralExpr>(Constant);
8511 enum ConstantValue ConstVal = Zero;
8512 if (Value.isUnsigned() || Value.isNonNegative()) {
8514 LiteralOrBoolConstant =
8515 ConstantIsBoolLiteral ? CXXBoolLiteralFalse : LiteralConstant;
8517 } else if (Value == 1) {
8518 LiteralOrBoolConstant =
8519 ConstantIsBoolLiteral ? CXXBoolLiteralTrue : LiteralConstant;
8522 LiteralOrBoolConstant = LiteralConstant;
8529 CompareBoolWithConstantResult CmpRes;
8533 CmpRes = TruthTable.BO_LT_OP[RhsConstant][ConstVal];
8536 CmpRes = TruthTable.BO_GT_OP[RhsConstant][ConstVal];
8539 CmpRes = TruthTable.BO_LE_OP[RhsConstant][ConstVal];
8542 CmpRes = TruthTable.BO_GE_OP[RhsConstant][ConstVal];
8545 CmpRes = TruthTable.BO_EQ_OP[RhsConstant][ConstVal];
8548 CmpRes = TruthTable.BO_NE_OP[RhsConstant][ConstVal];
8555 if (CmpRes == AFals) {
8557 } else if (CmpRes == ATrue) {
8564 // If this is a comparison to an enum constant, include that
8565 // constant in the diagnostic.
8566 const EnumConstantDecl *ED = nullptr;
8567 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant))
8568 ED = dyn_cast<EnumConstantDecl>(DR->getDecl());
8570 SmallString<64> PrettySourceValue;
8571 llvm::raw_svector_ostream OS(PrettySourceValue);
8573 OS << '\'' << *ED << "' (" << Value << ")";
8577 S.DiagRuntimeBehavior(
8578 E->getOperatorLoc(), E,
8579 S.PDiag(diag::warn_out_of_range_compare)
8580 << OS.str() << LiteralOrBoolConstant
8581 << OtherT << (OtherIsBooleanType && !OtherT->isBooleanType()) << IsTrue
8582 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange());
8585 /// Analyze the operands of the given comparison. Implements the
8586 /// fallback case from AnalyzeComparison.
8587 void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
8588 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
8589 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
8592 /// \brief Implements -Wsign-compare.
8594 /// \param E the binary operator to check for warnings
8595 void AnalyzeComparison(Sema &S, BinaryOperator *E) {
8596 // The type the comparison is being performed in.
8597 QualType T = E->getLHS()->getType();
8599 // Only analyze comparison operators where both sides have been converted to
8601 if (!S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()))
8602 return AnalyzeImpConvsInComparison(S, E);
8604 // Don't analyze value-dependent comparisons directly.
8605 if (E->isValueDependent())
8606 return AnalyzeImpConvsInComparison(S, E);
8608 Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
8609 Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
8611 bool IsComparisonConstant = false;
8613 // Check whether an integer constant comparison results in a value
8614 // of 'true' or 'false'.
8615 if (T->isIntegralType(S.Context)) {
8616 llvm::APSInt RHSValue;
8617 bool IsRHSIntegralLiteral =
8618 RHS->isIntegerConstantExpr(RHSValue, S.Context);
8619 llvm::APSInt LHSValue;
8620 bool IsLHSIntegralLiteral =
8621 LHS->isIntegerConstantExpr(LHSValue, S.Context);
8622 if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral)
8623 DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true);
8624 else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral)
8625 DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false);
8627 IsComparisonConstant =
8628 (IsRHSIntegralLiteral && IsLHSIntegralLiteral);
8629 } else if (!T->hasUnsignedIntegerRepresentation())
8630 IsComparisonConstant = E->isIntegerConstantExpr(S.Context);
8632 // We don't do anything special if this isn't an unsigned integral
8633 // comparison: we're only interested in integral comparisons, and
8634 // signed comparisons only happen in cases we don't care to warn about.
8636 // We also don't care about value-dependent expressions or expressions
8637 // whose result is a constant.
8638 if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant)
8639 return AnalyzeImpConvsInComparison(S, E);
8641 // Check to see if one of the (unmodified) operands is of different
8643 Expr *signedOperand, *unsignedOperand;
8644 if (LHS->getType()->hasSignedIntegerRepresentation()) {
8645 assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
8646 "unsigned comparison between two signed integer expressions?");
8647 signedOperand = LHS;
8648 unsignedOperand = RHS;
8649 } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
8650 signedOperand = RHS;
8651 unsignedOperand = LHS;
8653 CheckTrivialUnsignedComparison(S, E);
8654 return AnalyzeImpConvsInComparison(S, E);
8657 // Otherwise, calculate the effective range of the signed operand.
8658 IntRange signedRange = GetExprRange(S.Context, signedOperand);
8660 // Go ahead and analyze implicit conversions in the operands. Note
8661 // that we skip the implicit conversions on both sides.
8662 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
8663 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
8665 // If the signed range is non-negative, -Wsign-compare won't fire,
8666 // but we should still check for comparisons which are always true
8668 if (signedRange.NonNegative)
8669 return CheckTrivialUnsignedComparison(S, E);
8671 // For (in)equality comparisons, if the unsigned operand is a
8672 // constant which cannot collide with a overflowed signed operand,
8673 // then reinterpreting the signed operand as unsigned will not
8674 // change the result of the comparison.
8675 if (E->isEqualityOp()) {
8676 unsigned comparisonWidth = S.Context.getIntWidth(T);
8677 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
8679 // We should never be unable to prove that the unsigned operand is
8681 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
8683 if (unsignedRange.Width < comparisonWidth)
8687 S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
8688 S.PDiag(diag::warn_mixed_sign_comparison)
8689 << LHS->getType() << RHS->getType()
8690 << LHS->getSourceRange() << RHS->getSourceRange());
8693 /// Analyzes an attempt to assign the given value to a bitfield.
8695 /// Returns true if there was something fishy about the attempt.
8696 bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
8697 SourceLocation InitLoc) {
8698 assert(Bitfield->isBitField());
8699 if (Bitfield->isInvalidDecl())
8702 // White-list bool bitfields.
8703 QualType BitfieldType = Bitfield->getType();
8704 if (BitfieldType->isBooleanType())
8707 if (BitfieldType->isEnumeralType()) {
8708 EnumDecl *BitfieldEnumDecl = BitfieldType->getAs<EnumType>()->getDecl();
8709 // If the underlying enum type was not explicitly specified as an unsigned
8710 // type and the enum contain only positive values, MSVC++ will cause an
8711 // inconsistency by storing this as a signed type.
8712 if (S.getLangOpts().CPlusPlus11 &&
8713 !BitfieldEnumDecl->getIntegerTypeSourceInfo() &&
8714 BitfieldEnumDecl->getNumPositiveBits() > 0 &&
8715 BitfieldEnumDecl->getNumNegativeBits() == 0) {
8716 S.Diag(InitLoc, diag::warn_no_underlying_type_specified_for_enum_bitfield)
8717 << BitfieldEnumDecl->getNameAsString();
8721 if (Bitfield->getType()->isBooleanType())
8724 // Ignore value- or type-dependent expressions.
8725 if (Bitfield->getBitWidth()->isValueDependent() ||
8726 Bitfield->getBitWidth()->isTypeDependent() ||
8727 Init->isValueDependent() ||
8728 Init->isTypeDependent())
8731 Expr *OriginalInit = Init->IgnoreParenImpCasts();
8732 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
8735 if (!OriginalInit->EvaluateAsInt(Value, S.Context,
8736 Expr::SE_AllowSideEffects)) {
8737 // The RHS is not constant. If the RHS has an enum type, make sure the
8738 // bitfield is wide enough to hold all the values of the enum without
8740 if (const auto *EnumTy = OriginalInit->getType()->getAs<EnumType>()) {
8741 EnumDecl *ED = EnumTy->getDecl();
8742 bool SignedBitfield = BitfieldType->isSignedIntegerType();
8744 // Enum types are implicitly signed on Windows, so check if there are any
8745 // negative enumerators to see if the enum was intended to be signed or
8747 bool SignedEnum = ED->getNumNegativeBits() > 0;
8749 // Check for surprising sign changes when assigning enum values to a
8750 // bitfield of different signedness. If the bitfield is signed and we
8751 // have exactly the right number of bits to store this unsigned enum,
8752 // suggest changing the enum to an unsigned type. This typically happens
8753 // on Windows where unfixed enums always use an underlying type of 'int'.
8754 unsigned DiagID = 0;
8755 if (SignedEnum && !SignedBitfield) {
8756 DiagID = diag::warn_unsigned_bitfield_assigned_signed_enum;
8757 } else if (SignedBitfield && !SignedEnum &&
8758 ED->getNumPositiveBits() == FieldWidth) {
8759 DiagID = diag::warn_signed_bitfield_enum_conversion;
8763 S.Diag(InitLoc, DiagID) << Bitfield << ED;
8764 TypeSourceInfo *TSI = Bitfield->getTypeSourceInfo();
8765 SourceRange TypeRange =
8766 TSI ? TSI->getTypeLoc().getSourceRange() : SourceRange();
8767 S.Diag(Bitfield->getTypeSpecStartLoc(), diag::note_change_bitfield_sign)
8768 << SignedEnum << TypeRange;
8771 // Compute the required bitwidth. If the enum has negative values, we need
8772 // one more bit than the normal number of positive bits to represent the
8774 unsigned BitsNeeded = SignedEnum ? std::max(ED->getNumPositiveBits() + 1,
8775 ED->getNumNegativeBits())
8776 : ED->getNumPositiveBits();
8778 // Check the bitwidth.
8779 if (BitsNeeded > FieldWidth) {
8780 Expr *WidthExpr = Bitfield->getBitWidth();
8781 S.Diag(InitLoc, diag::warn_bitfield_too_small_for_enum)
8783 S.Diag(WidthExpr->getExprLoc(), diag::note_widen_bitfield)
8784 << BitsNeeded << ED << WidthExpr->getSourceRange();
8791 unsigned OriginalWidth = Value.getBitWidth();
8793 if (!Value.isSigned() || Value.isNegative())
8794 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(OriginalInit))
8795 if (UO->getOpcode() == UO_Minus || UO->getOpcode() == UO_Not)
8796 OriginalWidth = Value.getMinSignedBits();
8798 if (OriginalWidth <= FieldWidth)
8801 // Compute the value which the bitfield will contain.
8802 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
8803 TruncatedValue.setIsSigned(BitfieldType->isSignedIntegerType());
8805 // Check whether the stored value is equal to the original value.
8806 TruncatedValue = TruncatedValue.extend(OriginalWidth);
8807 if (llvm::APSInt::isSameValue(Value, TruncatedValue))
8810 // Special-case bitfields of width 1: booleans are naturally 0/1, and
8811 // therefore don't strictly fit into a signed bitfield of width 1.
8812 if (FieldWidth == 1 && Value == 1)
8815 std::string PrettyValue = Value.toString(10);
8816 std::string PrettyTrunc = TruncatedValue.toString(10);
8818 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
8819 << PrettyValue << PrettyTrunc << OriginalInit->getType()
8820 << Init->getSourceRange();
8825 /// Analyze the given simple or compound assignment for warning-worthy
8827 void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
8828 // Just recurse on the LHS.
8829 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
8831 // We want to recurse on the RHS as normal unless we're assigning to
8833 if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) {
8834 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
8835 E->getOperatorLoc())) {
8836 // Recurse, ignoring any implicit conversions on the RHS.
8837 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
8838 E->getOperatorLoc());
8842 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
8845 /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
8846 void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
8847 SourceLocation CContext, unsigned diag,
8848 bool pruneControlFlow = false) {
8849 if (pruneControlFlow) {
8850 S.DiagRuntimeBehavior(E->getExprLoc(), E,
8852 << SourceType << T << E->getSourceRange()
8853 << SourceRange(CContext));
8856 S.Diag(E->getExprLoc(), diag)
8857 << SourceType << T << E->getSourceRange() << SourceRange(CContext);
8860 /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
8861 void DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext,
8862 unsigned diag, bool pruneControlFlow = false) {
8863 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
8867 /// Diagnose an implicit cast from a floating point value to an integer value.
8868 void DiagnoseFloatingImpCast(Sema &S, Expr *E, QualType T,
8870 SourceLocation CContext) {
8871 const bool IsBool = T->isSpecificBuiltinType(BuiltinType::Bool);
8872 const bool PruneWarnings = S.inTemplateInstantiation();
8874 Expr *InnerE = E->IgnoreParenImpCasts();
8875 // We also want to warn on, e.g., "int i = -1.234"
8876 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
8877 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
8878 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
8880 const bool IsLiteral =
8881 isa<FloatingLiteral>(E) || isa<FloatingLiteral>(InnerE);
8883 llvm::APFloat Value(0.0);
8885 E->EvaluateAsFloat(Value, S.Context, Expr::SE_AllowSideEffects);
8887 return DiagnoseImpCast(S, E, T, CContext,
8888 diag::warn_impcast_float_integer, PruneWarnings);
8891 bool isExact = false;
8893 llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
8894 T->hasUnsignedIntegerRepresentation());
8895 if (Value.convertToInteger(IntegerValue, llvm::APFloat::rmTowardZero,
8896 &isExact) == llvm::APFloat::opOK &&
8898 if (IsLiteral) return;
8899 return DiagnoseImpCast(S, E, T, CContext, diag::warn_impcast_float_integer,
8903 unsigned DiagID = 0;
8905 // Warn on floating point literal to integer.
8906 DiagID = diag::warn_impcast_literal_float_to_integer;
8907 } else if (IntegerValue == 0) {
8908 if (Value.isZero()) { // Skip -0.0 to 0 conversion.
8909 return DiagnoseImpCast(S, E, T, CContext,
8910 diag::warn_impcast_float_integer, PruneWarnings);
8912 // Warn on non-zero to zero conversion.
8913 DiagID = diag::warn_impcast_float_to_integer_zero;
8915 if (IntegerValue.isUnsigned()) {
8916 if (!IntegerValue.isMaxValue()) {
8917 return DiagnoseImpCast(S, E, T, CContext,
8918 diag::warn_impcast_float_integer, PruneWarnings);
8920 } else { // IntegerValue.isSigned()
8921 if (!IntegerValue.isMaxSignedValue() &&
8922 !IntegerValue.isMinSignedValue()) {
8923 return DiagnoseImpCast(S, E, T, CContext,
8924 diag::warn_impcast_float_integer, PruneWarnings);
8927 // Warn on evaluatable floating point expression to integer conversion.
8928 DiagID = diag::warn_impcast_float_to_integer;
8931 // FIXME: Force the precision of the source value down so we don't print
8932 // digits which are usually useless (we don't really care here if we
8933 // truncate a digit by accident in edge cases). Ideally, APFloat::toString
8934 // would automatically print the shortest representation, but it's a bit
8935 // tricky to implement.
8936 SmallString<16> PrettySourceValue;
8937 unsigned precision = llvm::APFloat::semanticsPrecision(Value.getSemantics());
8938 precision = (precision * 59 + 195) / 196;
8939 Value.toString(PrettySourceValue, precision);
8941 SmallString<16> PrettyTargetValue;
8943 PrettyTargetValue = Value.isZero() ? "false" : "true";
8945 IntegerValue.toString(PrettyTargetValue);
8947 if (PruneWarnings) {
8948 S.DiagRuntimeBehavior(E->getExprLoc(), E,
8950 << E->getType() << T.getUnqualifiedType()
8951 << PrettySourceValue << PrettyTargetValue
8952 << E->getSourceRange() << SourceRange(CContext));
8954 S.Diag(E->getExprLoc(), DiagID)
8955 << E->getType() << T.getUnqualifiedType() << PrettySourceValue
8956 << PrettyTargetValue << E->getSourceRange() << SourceRange(CContext);
8960 std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
8961 if (!Range.Width) return "0";
8963 llvm::APSInt ValueInRange = Value;
8964 ValueInRange.setIsSigned(!Range.NonNegative);
8965 ValueInRange = ValueInRange.trunc(Range.Width);
8966 return ValueInRange.toString(10);
8969 bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) {
8970 if (!isa<ImplicitCastExpr>(Ex))
8973 Expr *InnerE = Ex->IgnoreParenImpCasts();
8974 const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr();
8975 const Type *Source =
8976 S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
8977 if (Target->isDependentType())
8980 const BuiltinType *FloatCandidateBT =
8981 dyn_cast<BuiltinType>(ToBool ? Source : Target);
8982 const Type *BoolCandidateType = ToBool ? Target : Source;
8984 return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) &&
8985 FloatCandidateBT && (FloatCandidateBT->isFloatingPoint()));
8988 void CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall,
8989 SourceLocation CC) {
8990 unsigned NumArgs = TheCall->getNumArgs();
8991 for (unsigned i = 0; i < NumArgs; ++i) {
8992 Expr *CurrA = TheCall->getArg(i);
8993 if (!IsImplicitBoolFloatConversion(S, CurrA, true))
8996 bool IsSwapped = ((i > 0) &&
8997 IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false));
8998 IsSwapped |= ((i < (NumArgs - 1)) &&
8999 IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false));
9001 // Warn on this floating-point to bool conversion.
9002 DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(),
9003 CurrA->getType(), CC,
9004 diag::warn_impcast_floating_point_to_bool);
9009 void DiagnoseNullConversion(Sema &S, Expr *E, QualType T, SourceLocation CC) {
9010 if (S.Diags.isIgnored(diag::warn_impcast_null_pointer_to_integer,
9014 // Don't warn on functions which have return type nullptr_t.
9015 if (isa<CallExpr>(E))
9018 // Check for NULL (GNUNull) or nullptr (CXX11_nullptr).
9019 const Expr::NullPointerConstantKind NullKind =
9020 E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull);
9021 if (NullKind != Expr::NPCK_GNUNull && NullKind != Expr::NPCK_CXX11_nullptr)
9024 // Return if target type is a safe conversion.
9025 if (T->isAnyPointerType() || T->isBlockPointerType() ||
9026 T->isMemberPointerType() || !T->isScalarType() || T->isNullPtrType())
9029 SourceLocation Loc = E->getSourceRange().getBegin();
9031 // Venture through the macro stacks to get to the source of macro arguments.
9032 // The new location is a better location than the complete location that was
9034 while (S.SourceMgr.isMacroArgExpansion(Loc))
9035 Loc = S.SourceMgr.getImmediateMacroCallerLoc(Loc);
9037 while (S.SourceMgr.isMacroArgExpansion(CC))
9038 CC = S.SourceMgr.getImmediateMacroCallerLoc(CC);
9040 // __null is usually wrapped in a macro. Go up a macro if that is the case.
9041 if (NullKind == Expr::NPCK_GNUNull && Loc.isMacroID()) {
9042 StringRef MacroName = Lexer::getImmediateMacroNameForDiagnostics(
9043 Loc, S.SourceMgr, S.getLangOpts());
9044 if (MacroName == "NULL")
9045 Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
9048 // Only warn if the null and context location are in the same macro expansion.
9049 if (S.SourceMgr.getFileID(Loc) != S.SourceMgr.getFileID(CC))
9052 S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
9053 << (NullKind == Expr::NPCK_CXX11_nullptr) << T << clang::SourceRange(CC)
9054 << FixItHint::CreateReplacement(Loc,
9055 S.getFixItZeroLiteralForType(T, Loc));
9058 void checkObjCArrayLiteral(Sema &S, QualType TargetType,
9059 ObjCArrayLiteral *ArrayLiteral);
9060 void checkObjCDictionaryLiteral(Sema &S, QualType TargetType,
9061 ObjCDictionaryLiteral *DictionaryLiteral);
9063 /// Check a single element within a collection literal against the
9064 /// target element type.
9065 void checkObjCCollectionLiteralElement(Sema &S, QualType TargetElementType,
9066 Expr *Element, unsigned ElementKind) {
9067 // Skip a bitcast to 'id' or qualified 'id'.
9068 if (auto ICE = dyn_cast<ImplicitCastExpr>(Element)) {
9069 if (ICE->getCastKind() == CK_BitCast &&
9070 ICE->getSubExpr()->getType()->getAs<ObjCObjectPointerType>())
9071 Element = ICE->getSubExpr();
9074 QualType ElementType = Element->getType();
9075 ExprResult ElementResult(Element);
9076 if (ElementType->getAs<ObjCObjectPointerType>() &&
9077 S.CheckSingleAssignmentConstraints(TargetElementType,
9080 != Sema::Compatible) {
9081 S.Diag(Element->getLocStart(),
9082 diag::warn_objc_collection_literal_element)
9083 << ElementType << ElementKind << TargetElementType
9084 << Element->getSourceRange();
9087 if (auto ArrayLiteral = dyn_cast<ObjCArrayLiteral>(Element))
9088 checkObjCArrayLiteral(S, TargetElementType, ArrayLiteral);
9089 else if (auto DictionaryLiteral = dyn_cast<ObjCDictionaryLiteral>(Element))
9090 checkObjCDictionaryLiteral(S, TargetElementType, DictionaryLiteral);
9093 /// Check an Objective-C array literal being converted to the given
9095 void checkObjCArrayLiteral(Sema &S, QualType TargetType,
9096 ObjCArrayLiteral *ArrayLiteral) {
9100 const auto *TargetObjCPtr = TargetType->getAs<ObjCObjectPointerType>();
9104 if (TargetObjCPtr->isUnspecialized() ||
9105 TargetObjCPtr->getInterfaceDecl()->getCanonicalDecl()
9106 != S.NSArrayDecl->getCanonicalDecl())
9109 auto TypeArgs = TargetObjCPtr->getTypeArgs();
9110 if (TypeArgs.size() != 1)
9113 QualType TargetElementType = TypeArgs[0];
9114 for (unsigned I = 0, N = ArrayLiteral->getNumElements(); I != N; ++I) {
9115 checkObjCCollectionLiteralElement(S, TargetElementType,
9116 ArrayLiteral->getElement(I),
9121 /// Check an Objective-C dictionary literal being converted to the given
9123 void checkObjCDictionaryLiteral(Sema &S, QualType TargetType,
9124 ObjCDictionaryLiteral *DictionaryLiteral) {
9125 if (!S.NSDictionaryDecl)
9128 const auto *TargetObjCPtr = TargetType->getAs<ObjCObjectPointerType>();
9132 if (TargetObjCPtr->isUnspecialized() ||
9133 TargetObjCPtr->getInterfaceDecl()->getCanonicalDecl()
9134 != S.NSDictionaryDecl->getCanonicalDecl())
9137 auto TypeArgs = TargetObjCPtr->getTypeArgs();
9138 if (TypeArgs.size() != 2)
9141 QualType TargetKeyType = TypeArgs[0];
9142 QualType TargetObjectType = TypeArgs[1];
9143 for (unsigned I = 0, N = DictionaryLiteral->getNumElements(); I != N; ++I) {
9144 auto Element = DictionaryLiteral->getKeyValueElement(I);
9145 checkObjCCollectionLiteralElement(S, TargetKeyType, Element.Key, 1);
9146 checkObjCCollectionLiteralElement(S, TargetObjectType, Element.Value, 2);
9150 // Helper function to filter out cases for constant width constant conversion.
9151 // Don't warn on char array initialization or for non-decimal values.
9152 bool isSameWidthConstantConversion(Sema &S, Expr *E, QualType T,
9153 SourceLocation CC) {
9154 // If initializing from a constant, and the constant starts with '0',
9155 // then it is a binary, octal, or hexadecimal. Allow these constants
9156 // to fill all the bits, even if there is a sign change.
9157 if (auto *IntLit = dyn_cast<IntegerLiteral>(E->IgnoreParenImpCasts())) {
9158 const char FirstLiteralCharacter =
9159 S.getSourceManager().getCharacterData(IntLit->getLocStart())[0];
9160 if (FirstLiteralCharacter == '0')
9164 // If the CC location points to a '{', and the type is char, then assume
9165 // assume it is an array initialization.
9166 if (CC.isValid() && T->isCharType()) {
9167 const char FirstContextCharacter =
9168 S.getSourceManager().getCharacterData(CC)[0];
9169 if (FirstContextCharacter == '{')
9176 void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
9177 SourceLocation CC, bool *ICContext = nullptr) {
9178 if (E->isTypeDependent() || E->isValueDependent()) return;
9180 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
9181 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
9182 if (Source == Target) return;
9183 if (Target->isDependentType()) return;
9185 // If the conversion context location is invalid don't complain. We also
9186 // don't want to emit a warning if the issue occurs from the expansion of
9187 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
9188 // delay this check as long as possible. Once we detect we are in that
9189 // scenario, we just return.
9193 // Diagnose implicit casts to bool.
9194 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
9195 if (isa<StringLiteral>(E))
9196 // Warn on string literal to bool. Checks for string literals in logical
9197 // and expressions, for instance, assert(0 && "error here"), are
9198 // prevented by a check in AnalyzeImplicitConversions().
9199 return DiagnoseImpCast(S, E, T, CC,
9200 diag::warn_impcast_string_literal_to_bool);
9201 if (isa<ObjCStringLiteral>(E) || isa<ObjCArrayLiteral>(E) ||
9202 isa<ObjCDictionaryLiteral>(E) || isa<ObjCBoxedExpr>(E)) {
9203 // This covers the literal expressions that evaluate to Objective-C
9205 return DiagnoseImpCast(S, E, T, CC,
9206 diag::warn_impcast_objective_c_literal_to_bool);
9208 if (Source->isPointerType() || Source->canDecayToPointerType()) {
9209 // Warn on pointer to bool conversion that is always true.
9210 S.DiagnoseAlwaysNonNullPointer(E, Expr::NPCK_NotNull, /*IsEqual*/ false,
9215 // Check implicit casts from Objective-C collection literals to specialized
9216 // collection types, e.g., NSArray<NSString *> *.
9217 if (auto *ArrayLiteral = dyn_cast<ObjCArrayLiteral>(E))
9218 checkObjCArrayLiteral(S, QualType(Target, 0), ArrayLiteral);
9219 else if (auto *DictionaryLiteral = dyn_cast<ObjCDictionaryLiteral>(E))
9220 checkObjCDictionaryLiteral(S, QualType(Target, 0), DictionaryLiteral);
9222 // Strip vector types.
9223 if (isa<VectorType>(Source)) {
9224 if (!isa<VectorType>(Target)) {
9225 if (S.SourceMgr.isInSystemMacro(CC))
9227 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
9230 // If the vector cast is cast between two vectors of the same size, it is
9231 // a bitcast, not a conversion.
9232 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
9235 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
9236 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
9238 if (auto VecTy = dyn_cast<VectorType>(Target))
9239 Target = VecTy->getElementType().getTypePtr();
9241 // Strip complex types.
9242 if (isa<ComplexType>(Source)) {
9243 if (!isa<ComplexType>(Target)) {
9244 if (S.SourceMgr.isInSystemMacro(CC))
9247 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
9250 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
9251 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
9254 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
9255 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
9257 // If the source is floating point...
9258 if (SourceBT && SourceBT->isFloatingPoint()) {
9259 // ...and the target is floating point...
9260 if (TargetBT && TargetBT->isFloatingPoint()) {
9261 // ...then warn if we're dropping FP rank.
9263 // Builtin FP kinds are ordered by increasing FP rank.
9264 if (SourceBT->getKind() > TargetBT->getKind()) {
9265 // Don't warn about float constants that are precisely
9266 // representable in the target type.
9267 Expr::EvalResult result;
9268 if (E->EvaluateAsRValue(result, S.Context)) {
9269 // Value might be a float, a float vector, or a float complex.
9270 if (IsSameFloatAfterCast(result.Val,
9271 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
9272 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
9276 if (S.SourceMgr.isInSystemMacro(CC))
9279 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
9281 // ... or possibly if we're increasing rank, too
9282 else if (TargetBT->getKind() > SourceBT->getKind()) {
9283 if (S.SourceMgr.isInSystemMacro(CC))
9286 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_double_promotion);
9291 // If the target is integral, always warn.
9292 if (TargetBT && TargetBT->isInteger()) {
9293 if (S.SourceMgr.isInSystemMacro(CC))
9296 DiagnoseFloatingImpCast(S, E, T, CC);
9299 // Detect the case where a call result is converted from floating-point to
9300 // to bool, and the final argument to the call is converted from bool, to
9301 // discover this typo:
9303 // bool b = fabs(x < 1.0); // should be "bool b = fabs(x) < 1.0;"
9305 // FIXME: This is an incredibly special case; is there some more general
9306 // way to detect this class of misplaced-parentheses bug?
9307 if (Target->isBooleanType() && isa<CallExpr>(E)) {
9308 // Check last argument of function call to see if it is an
9309 // implicit cast from a type matching the type the result
9310 // is being cast to.
9311 CallExpr *CEx = cast<CallExpr>(E);
9312 if (unsigned NumArgs = CEx->getNumArgs()) {
9313 Expr *LastA = CEx->getArg(NumArgs - 1);
9314 Expr *InnerE = LastA->IgnoreParenImpCasts();
9315 if (isa<ImplicitCastExpr>(LastA) &&
9316 InnerE->getType()->isBooleanType()) {
9317 // Warn on this floating-point to bool conversion
9318 DiagnoseImpCast(S, E, T, CC,
9319 diag::warn_impcast_floating_point_to_bool);
9326 DiagnoseNullConversion(S, E, T, CC);
9328 S.DiscardMisalignedMemberAddress(Target, E);
9330 if (!Source->isIntegerType() || !Target->isIntegerType())
9333 // TODO: remove this early return once the false positives for constant->bool
9334 // in templates, macros, etc, are reduced or removed.
9335 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
9338 IntRange SourceRange = GetExprRange(S.Context, E);
9339 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
9341 if (SourceRange.Width > TargetRange.Width) {
9342 // If the source is a constant, use a default-on diagnostic.
9343 // TODO: this should happen for bitfield stores, too.
9344 llvm::APSInt Value(32);
9345 if (E->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) {
9346 if (S.SourceMgr.isInSystemMacro(CC))
9349 std::string PrettySourceValue = Value.toString(10);
9350 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
9352 S.DiagRuntimeBehavior(E->getExprLoc(), E,
9353 S.PDiag(diag::warn_impcast_integer_precision_constant)
9354 << PrettySourceValue << PrettyTargetValue
9355 << E->getType() << T << E->getSourceRange()
9356 << clang::SourceRange(CC));
9360 // People want to build with -Wshorten-64-to-32 and not -Wconversion.
9361 if (S.SourceMgr.isInSystemMacro(CC))
9364 if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
9365 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
9366 /* pruneControlFlow */ true);
9367 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
9370 if (TargetRange.Width == SourceRange.Width && !TargetRange.NonNegative &&
9371 SourceRange.NonNegative && Source->isSignedIntegerType()) {
9372 // Warn when doing a signed to signed conversion, warn if the positive
9373 // source value is exactly the width of the target type, which will
9374 // cause a negative value to be stored.
9377 if (E->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects) &&
9378 !S.SourceMgr.isInSystemMacro(CC)) {
9379 if (isSameWidthConstantConversion(S, E, T, CC)) {
9380 std::string PrettySourceValue = Value.toString(10);
9381 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
9383 S.DiagRuntimeBehavior(
9385 S.PDiag(diag::warn_impcast_integer_precision_constant)
9386 << PrettySourceValue << PrettyTargetValue << E->getType() << T
9387 << E->getSourceRange() << clang::SourceRange(CC));
9392 // Fall through for non-constants to give a sign conversion warning.
9395 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
9396 (!TargetRange.NonNegative && SourceRange.NonNegative &&
9397 SourceRange.Width == TargetRange.Width)) {
9398 if (S.SourceMgr.isInSystemMacro(CC))
9401 unsigned DiagID = diag::warn_impcast_integer_sign;
9403 // Traditionally, gcc has warned about this under -Wsign-compare.
9404 // We also want to warn about it in -Wconversion.
9405 // So if -Wconversion is off, use a completely identical diagnostic
9406 // in the sign-compare group.
9407 // The conditional-checking code will
9409 DiagID = diag::warn_impcast_integer_sign_conditional;
9413 return DiagnoseImpCast(S, E, T, CC, DiagID);
9416 // Diagnose conversions between different enumeration types.
9417 // In C, we pretend that the type of an EnumConstantDecl is its enumeration
9418 // type, to give us better diagnostics.
9419 QualType SourceType = E->getType();
9420 if (!S.getLangOpts().CPlusPlus) {
9421 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
9422 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
9423 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
9424 SourceType = S.Context.getTypeDeclType(Enum);
9425 Source = S.Context.getCanonicalType(SourceType).getTypePtr();
9429 if (const EnumType *SourceEnum = Source->getAs<EnumType>())
9430 if (const EnumType *TargetEnum = Target->getAs<EnumType>())
9431 if (SourceEnum->getDecl()->hasNameForLinkage() &&
9432 TargetEnum->getDecl()->hasNameForLinkage() &&
9433 SourceEnum != TargetEnum) {
9434 if (S.SourceMgr.isInSystemMacro(CC))
9437 return DiagnoseImpCast(S, E, SourceType, T, CC,
9438 diag::warn_impcast_different_enum_types);
9442 void CheckConditionalOperator(Sema &S, ConditionalOperator *E,
9443 SourceLocation CC, QualType T);
9445 void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
9446 SourceLocation CC, bool &ICContext) {
9447 E = E->IgnoreParenImpCasts();
9449 if (isa<ConditionalOperator>(E))
9450 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
9452 AnalyzeImplicitConversions(S, E, CC);
9453 if (E->getType() != T)
9454 return CheckImplicitConversion(S, E, T, CC, &ICContext);
9457 void CheckConditionalOperator(Sema &S, ConditionalOperator *E,
9458 SourceLocation CC, QualType T) {
9459 AnalyzeImplicitConversions(S, E->getCond(), E->getQuestionLoc());
9461 bool Suspicious = false;
9462 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
9463 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
9465 // If -Wconversion would have warned about either of the candidates
9466 // for a signedness conversion to the context type...
9467 if (!Suspicious) return;
9469 // ...but it's currently ignored...
9470 if (!S.Diags.isIgnored(diag::warn_impcast_integer_sign_conditional, CC))
9473 // ...then check whether it would have warned about either of the
9474 // candidates for a signedness conversion to the condition type.
9475 if (E->getType() == T) return;
9478 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
9479 E->getType(), CC, &Suspicious);
9481 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
9482 E->getType(), CC, &Suspicious);
9485 /// CheckBoolLikeConversion - Check conversion of given expression to boolean.
9486 /// Input argument E is a logical expression.
9487 void CheckBoolLikeConversion(Sema &S, Expr *E, SourceLocation CC) {
9488 if (S.getLangOpts().Bool)
9490 CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC);
9493 /// AnalyzeImplicitConversions - Find and report any interesting
9494 /// implicit conversions in the given expression. There are a couple
9495 /// of competing diagnostics here, -Wconversion and -Wsign-compare.
9496 void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
9497 QualType T = OrigE->getType();
9498 Expr *E = OrigE->IgnoreParenImpCasts();
9500 if (E->isTypeDependent() || E->isValueDependent())
9503 // For conditional operators, we analyze the arguments as if they
9504 // were being fed directly into the output.
9505 if (isa<ConditionalOperator>(E)) {
9506 ConditionalOperator *CO = cast<ConditionalOperator>(E);
9507 CheckConditionalOperator(S, CO, CC, T);
9511 // Check implicit argument conversions for function calls.
9512 if (CallExpr *Call = dyn_cast<CallExpr>(E))
9513 CheckImplicitArgumentConversions(S, Call, CC);
9515 // Go ahead and check any implicit conversions we might have skipped.
9516 // The non-canonical typecheck is just an optimization;
9517 // CheckImplicitConversion will filter out dead implicit conversions.
9518 if (E->getType() != T)
9519 CheckImplicitConversion(S, E, T, CC);
9521 // Now continue drilling into this expression.
9523 if (PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(E)) {
9524 // The bound subexpressions in a PseudoObjectExpr are not reachable
9525 // as transitive children.
9526 // FIXME: Use a more uniform representation for this.
9527 for (auto *SE : POE->semantics())
9528 if (auto *OVE = dyn_cast<OpaqueValueExpr>(SE))
9529 AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC);
9532 // Skip past explicit casts.
9533 if (isa<ExplicitCastExpr>(E)) {
9534 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
9535 return AnalyzeImplicitConversions(S, E, CC);
9538 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
9539 // Do a somewhat different check with comparison operators.
9540 if (BO->isComparisonOp())
9541 return AnalyzeComparison(S, BO);
9543 // And with simple assignments.
9544 if (BO->getOpcode() == BO_Assign)
9545 return AnalyzeAssignment(S, BO);
9548 // These break the otherwise-useful invariant below. Fortunately,
9549 // we don't really need to recurse into them, because any internal
9550 // expressions should have been analyzed already when they were
9551 // built into statements.
9552 if (isa<StmtExpr>(E)) return;
9554 // Don't descend into unevaluated contexts.
9555 if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
9557 // Now just recurse over the expression's children.
9558 CC = E->getExprLoc();
9559 BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
9560 bool IsLogicalAndOperator = BO && BO->getOpcode() == BO_LAnd;
9561 for (Stmt *SubStmt : E->children()) {
9562 Expr *ChildExpr = dyn_cast_or_null<Expr>(SubStmt);
9566 if (IsLogicalAndOperator &&
9567 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
9568 // Ignore checking string literals that are in logical and operators.
9569 // This is a common pattern for asserts.
9571 AnalyzeImplicitConversions(S, ChildExpr, CC);
9574 if (BO && BO->isLogicalOp()) {
9575 Expr *SubExpr = BO->getLHS()->IgnoreParenImpCasts();
9576 if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr))
9577 ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc());
9579 SubExpr = BO->getRHS()->IgnoreParenImpCasts();
9580 if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr))
9581 ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc());
9584 if (const UnaryOperator *U = dyn_cast<UnaryOperator>(E))
9585 if (U->getOpcode() == UO_LNot)
9586 ::CheckBoolLikeConversion(S, U->getSubExpr(), CC);
9589 } // end anonymous namespace
9591 /// Diagnose integer type and any valid implicit convertion to it.
9592 static bool checkOpenCLEnqueueIntType(Sema &S, Expr *E, const QualType &IntT) {
9593 // Taking into account implicit conversions,
9594 // allow any integer.
9595 if (!E->getType()->isIntegerType()) {
9596 S.Diag(E->getLocStart(),
9597 diag::err_opencl_enqueue_kernel_invalid_local_size_type);
9600 // Potentially emit standard warnings for implicit conversions if enabled
9601 // using -Wconversion.
9602 CheckImplicitConversion(S, E, IntT, E->getLocStart());
9606 // Helper function for Sema::DiagnoseAlwaysNonNullPointer.
9607 // Returns true when emitting a warning about taking the address of a reference.
9608 static bool CheckForReference(Sema &SemaRef, const Expr *E,
9609 const PartialDiagnostic &PD) {
9610 E = E->IgnoreParenImpCasts();
9612 const FunctionDecl *FD = nullptr;
9614 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) {
9615 if (!DRE->getDecl()->getType()->isReferenceType())
9617 } else if (const MemberExpr *M = dyn_cast<MemberExpr>(E)) {
9618 if (!M->getMemberDecl()->getType()->isReferenceType())
9620 } else if (const CallExpr *Call = dyn_cast<CallExpr>(E)) {
9621 if (!Call->getCallReturnType(SemaRef.Context)->isReferenceType())
9623 FD = Call->getDirectCallee();
9628 SemaRef.Diag(E->getExprLoc(), PD);
9630 // If possible, point to location of function.
9632 SemaRef.Diag(FD->getLocation(), diag::note_reference_is_return_value) << FD;
9638 // Returns true if the SourceLocation is expanded from any macro body.
9639 // Returns false if the SourceLocation is invalid, is from not in a macro
9640 // expansion, or is from expanded from a top-level macro argument.
9641 static bool IsInAnyMacroBody(const SourceManager &SM, SourceLocation Loc) {
9642 if (Loc.isInvalid())
9645 while (Loc.isMacroID()) {
9646 if (SM.isMacroBodyExpansion(Loc))
9648 Loc = SM.getImmediateMacroCallerLoc(Loc);
9654 /// \brief Diagnose pointers that are always non-null.
9655 /// \param E the expression containing the pointer
9656 /// \param NullKind NPCK_NotNull if E is a cast to bool, otherwise, E is
9657 /// compared to a null pointer
9658 /// \param IsEqual True when the comparison is equal to a null pointer
9659 /// \param Range Extra SourceRange to highlight in the diagnostic
9660 void Sema::DiagnoseAlwaysNonNullPointer(Expr *E,
9661 Expr::NullPointerConstantKind NullKind,
9662 bool IsEqual, SourceRange Range) {
9666 // Don't warn inside macros.
9667 if (E->getExprLoc().isMacroID()) {
9668 const SourceManager &SM = getSourceManager();
9669 if (IsInAnyMacroBody(SM, E->getExprLoc()) ||
9670 IsInAnyMacroBody(SM, Range.getBegin()))
9673 E = E->IgnoreImpCasts();
9675 const bool IsCompare = NullKind != Expr::NPCK_NotNull;
9677 if (isa<CXXThisExpr>(E)) {
9678 unsigned DiagID = IsCompare ? diag::warn_this_null_compare
9679 : diag::warn_this_bool_conversion;
9680 Diag(E->getExprLoc(), DiagID) << E->getSourceRange() << Range << IsEqual;
9684 bool IsAddressOf = false;
9686 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
9687 if (UO->getOpcode() != UO_AddrOf)
9690 E = UO->getSubExpr();
9694 unsigned DiagID = IsCompare
9695 ? diag::warn_address_of_reference_null_compare
9696 : diag::warn_address_of_reference_bool_conversion;
9697 PartialDiagnostic PD = PDiag(DiagID) << E->getSourceRange() << Range
9699 if (CheckForReference(*this, E, PD)) {
9704 auto ComplainAboutNonnullParamOrCall = [&](const Attr *NonnullAttr) {
9705 bool IsParam = isa<NonNullAttr>(NonnullAttr);
9707 llvm::raw_string_ostream S(Str);
9708 E->printPretty(S, nullptr, getPrintingPolicy());
9709 unsigned DiagID = IsCompare ? diag::warn_nonnull_expr_compare
9710 : diag::warn_cast_nonnull_to_bool;
9711 Diag(E->getExprLoc(), DiagID) << IsParam << S.str()
9712 << E->getSourceRange() << Range << IsEqual;
9713 Diag(NonnullAttr->getLocation(), diag::note_declared_nonnull) << IsParam;
9716 // If we have a CallExpr that is tagged with returns_nonnull, we can complain.
9717 if (auto *Call = dyn_cast<CallExpr>(E->IgnoreParenImpCasts())) {
9718 if (auto *Callee = Call->getDirectCallee()) {
9719 if (const Attr *A = Callee->getAttr<ReturnsNonNullAttr>()) {
9720 ComplainAboutNonnullParamOrCall(A);
9726 // Expect to find a single Decl. Skip anything more complicated.
9727 ValueDecl *D = nullptr;
9728 if (DeclRefExpr *R = dyn_cast<DeclRefExpr>(E)) {
9730 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
9731 D = M->getMemberDecl();
9734 // Weak Decls can be null.
9735 if (!D || D->isWeak())
9738 // Check for parameter decl with nonnull attribute
9739 if (const auto* PV = dyn_cast<ParmVarDecl>(D)) {
9740 if (getCurFunction() &&
9741 !getCurFunction()->ModifiedNonNullParams.count(PV)) {
9742 if (const Attr *A = PV->getAttr<NonNullAttr>()) {
9743 ComplainAboutNonnullParamOrCall(A);
9747 if (const auto *FD = dyn_cast<FunctionDecl>(PV->getDeclContext())) {
9748 auto ParamIter = llvm::find(FD->parameters(), PV);
9749 assert(ParamIter != FD->param_end());
9750 unsigned ParamNo = std::distance(FD->param_begin(), ParamIter);
9752 for (const auto *NonNull : FD->specific_attrs<NonNullAttr>()) {
9753 if (!NonNull->args_size()) {
9754 ComplainAboutNonnullParamOrCall(NonNull);
9758 for (unsigned ArgNo : NonNull->args()) {
9759 if (ArgNo == ParamNo) {
9760 ComplainAboutNonnullParamOrCall(NonNull);
9769 QualType T = D->getType();
9770 const bool IsArray = T->isArrayType();
9771 const bool IsFunction = T->isFunctionType();
9773 // Address of function is used to silence the function warning.
9774 if (IsAddressOf && IsFunction) {
9779 if (!IsAddressOf && !IsFunction && !IsArray)
9782 // Pretty print the expression for the diagnostic.
9784 llvm::raw_string_ostream S(Str);
9785 E->printPretty(S, nullptr, getPrintingPolicy());
9787 unsigned DiagID = IsCompare ? diag::warn_null_pointer_compare
9788 : diag::warn_impcast_pointer_to_bool;
9795 DiagType = AddressOf;
9796 else if (IsFunction)
9797 DiagType = FunctionPointer;
9799 DiagType = ArrayPointer;
9801 llvm_unreachable("Could not determine diagnostic.");
9802 Diag(E->getExprLoc(), DiagID) << DiagType << S.str() << E->getSourceRange()
9803 << Range << IsEqual;
9808 // Suggest '&' to silence the function warning.
9809 Diag(E->getExprLoc(), diag::note_function_warning_silence)
9810 << FixItHint::CreateInsertion(E->getLocStart(), "&");
9812 // Check to see if '()' fixit should be emitted.
9813 QualType ReturnType;
9814 UnresolvedSet<4> NonTemplateOverloads;
9815 tryExprAsCall(*E, ReturnType, NonTemplateOverloads);
9816 if (ReturnType.isNull())
9820 // There are two cases here. If there is null constant, the only suggest
9821 // for a pointer return type. If the null is 0, then suggest if the return
9822 // type is a pointer or an integer type.
9823 if (!ReturnType->isPointerType()) {
9824 if (NullKind == Expr::NPCK_ZeroExpression ||
9825 NullKind == Expr::NPCK_ZeroLiteral) {
9826 if (!ReturnType->isIntegerType())
9832 } else { // !IsCompare
9833 // For function to bool, only suggest if the function pointer has bool
9835 if (!ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
9838 Diag(E->getExprLoc(), diag::note_function_to_function_call)
9839 << FixItHint::CreateInsertion(getLocForEndOfToken(E->getLocEnd()), "()");
9842 /// Diagnoses "dangerous" implicit conversions within the given
9843 /// expression (which is a full expression). Implements -Wconversion
9844 /// and -Wsign-compare.
9846 /// \param CC the "context" location of the implicit conversion, i.e.
9847 /// the most location of the syntactic entity requiring the implicit
9849 void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
9850 // Don't diagnose in unevaluated contexts.
9851 if (isUnevaluatedContext())
9854 // Don't diagnose for value- or type-dependent expressions.
9855 if (E->isTypeDependent() || E->isValueDependent())
9858 // Check for array bounds violations in cases where the check isn't triggered
9859 // elsewhere for other Expr types (like BinaryOperators), e.g. when an
9860 // ArraySubscriptExpr is on the RHS of a variable initialization.
9861 CheckArrayAccess(E);
9863 // This is not the right CC for (e.g.) a variable initialization.
9864 AnalyzeImplicitConversions(*this, E, CC);
9867 /// CheckBoolLikeConversion - Check conversion of given expression to boolean.
9868 /// Input argument E is a logical expression.
9869 void Sema::CheckBoolLikeConversion(Expr *E, SourceLocation CC) {
9870 ::CheckBoolLikeConversion(*this, E, CC);
9873 /// Diagnose when expression is an integer constant expression and its evaluation
9874 /// results in integer overflow
9875 void Sema::CheckForIntOverflow (Expr *E) {
9876 // Use a work list to deal with nested struct initializers.
9877 SmallVector<Expr *, 2> Exprs(1, E);
9880 Expr *E = Exprs.pop_back_val();
9882 if (isa<BinaryOperator>(E->IgnoreParenCasts())) {
9883 E->IgnoreParenCasts()->EvaluateForOverflow(Context);
9887 if (auto InitList = dyn_cast<InitListExpr>(E))
9888 Exprs.append(InitList->inits().begin(), InitList->inits().end());
9889 } while (!Exprs.empty());
9893 /// \brief Visitor for expressions which looks for unsequenced operations on the
9895 class SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> {
9896 typedef EvaluatedExprVisitor<SequenceChecker> Base;
9898 /// \brief A tree of sequenced regions within an expression. Two regions are
9899 /// unsequenced if one is an ancestor or a descendent of the other. When we
9900 /// finish processing an expression with sequencing, such as a comma
9901 /// expression, we fold its tree nodes into its parent, since they are
9902 /// unsequenced with respect to nodes we will visit later.
9903 class SequenceTree {
9905 explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {}
9906 unsigned Parent : 31;
9907 unsigned Merged : 1;
9909 SmallVector<Value, 8> Values;
9912 /// \brief A region within an expression which may be sequenced with respect
9913 /// to some other region.
9915 explicit Seq(unsigned N) : Index(N) {}
9917 friend class SequenceTree;
9922 SequenceTree() { Values.push_back(Value(0)); }
9923 Seq root() const { return Seq(0); }
9925 /// \brief Create a new sequence of operations, which is an unsequenced
9926 /// subset of \p Parent. This sequence of operations is sequenced with
9927 /// respect to other children of \p Parent.
9928 Seq allocate(Seq Parent) {
9929 Values.push_back(Value(Parent.Index));
9930 return Seq(Values.size() - 1);
9933 /// \brief Merge a sequence of operations into its parent.
9935 Values[S.Index].Merged = true;
9938 /// \brief Determine whether two operations are unsequenced. This operation
9939 /// is asymmetric: \p Cur should be the more recent sequence, and \p Old
9940 /// should have been merged into its parent as appropriate.
9941 bool isUnsequenced(Seq Cur, Seq Old) {
9942 unsigned C = representative(Cur.Index);
9943 unsigned Target = representative(Old.Index);
9944 while (C >= Target) {
9947 C = Values[C].Parent;
9953 /// \brief Pick a representative for a sequence.
9954 unsigned representative(unsigned K) {
9955 if (Values[K].Merged)
9956 // Perform path compression as we go.
9957 return Values[K].Parent = representative(Values[K].Parent);
9962 /// An object for which we can track unsequenced uses.
9963 typedef NamedDecl *Object;
9965 /// Different flavors of object usage which we track. We only track the
9966 /// least-sequenced usage of each kind.
9968 /// A read of an object. Multiple unsequenced reads are OK.
9970 /// A modification of an object which is sequenced before the value
9971 /// computation of the expression, such as ++n in C++.
9973 /// A modification of an object which is not sequenced before the value
9974 /// computation of the expression, such as n++.
9977 UK_Count = UK_ModAsSideEffect + 1
9981 Usage() : Use(nullptr), Seq() {}
9983 SequenceTree::Seq Seq;
9987 UsageInfo() : Diagnosed(false) {}
9988 Usage Uses[UK_Count];
9989 /// Have we issued a diagnostic for this variable already?
9992 typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap;
9995 /// Sequenced regions within the expression.
9997 /// Declaration modifications and references which we have seen.
9998 UsageInfoMap UsageMap;
9999 /// The region we are currently within.
10000 SequenceTree::Seq Region;
10001 /// Filled in with declarations which were modified as a side-effect
10002 /// (that is, post-increment operations).
10003 SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect;
10004 /// Expressions to check later. We defer checking these to reduce
10006 SmallVectorImpl<Expr *> &WorkList;
10008 /// RAII object wrapping the visitation of a sequenced subexpression of an
10009 /// expression. At the end of this process, the side-effects of the evaluation
10010 /// become sequenced with respect to the value computation of the result, so
10011 /// we downgrade any UK_ModAsSideEffect within the evaluation to
10013 struct SequencedSubexpression {
10014 SequencedSubexpression(SequenceChecker &Self)
10015 : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) {
10016 Self.ModAsSideEffect = &ModAsSideEffect;
10018 ~SequencedSubexpression() {
10019 for (auto &M : llvm::reverse(ModAsSideEffect)) {
10020 UsageInfo &U = Self.UsageMap[M.first];
10021 auto &SideEffectUsage = U.Uses[UK_ModAsSideEffect];
10022 Self.addUsage(U, M.first, SideEffectUsage.Use, UK_ModAsValue);
10023 SideEffectUsage = M.second;
10025 Self.ModAsSideEffect = OldModAsSideEffect;
10028 SequenceChecker &Self;
10029 SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect;
10030 SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect;
10033 /// RAII object wrapping the visitation of a subexpression which we might
10034 /// choose to evaluate as a constant. If any subexpression is evaluated and
10035 /// found to be non-constant, this allows us to suppress the evaluation of
10036 /// the outer expression.
10037 class EvaluationTracker {
10039 EvaluationTracker(SequenceChecker &Self)
10040 : Self(Self), Prev(Self.EvalTracker), EvalOK(true) {
10041 Self.EvalTracker = this;
10043 ~EvaluationTracker() {
10044 Self.EvalTracker = Prev;
10046 Prev->EvalOK &= EvalOK;
10049 bool evaluate(const Expr *E, bool &Result) {
10050 if (!EvalOK || E->isValueDependent())
10052 EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context);
10057 SequenceChecker &Self;
10058 EvaluationTracker *Prev;
10062 /// \brief Find the object which is produced by the specified expression,
10064 Object getObject(Expr *E, bool Mod) const {
10065 E = E->IgnoreParenCasts();
10066 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
10067 if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec))
10068 return getObject(UO->getSubExpr(), Mod);
10069 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
10070 if (BO->getOpcode() == BO_Comma)
10071 return getObject(BO->getRHS(), Mod);
10072 if (Mod && BO->isAssignmentOp())
10073 return getObject(BO->getLHS(), Mod);
10074 } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) {
10075 // FIXME: Check for more interesting cases, like "x.n = ++x.n".
10076 if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts()))
10077 return ME->getMemberDecl();
10078 } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
10079 // FIXME: If this is a reference, map through to its value.
10080 return DRE->getDecl();
10084 /// \brief Note that an object was modified or used by an expression.
10085 void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) {
10086 Usage &U = UI.Uses[UK];
10087 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) {
10088 if (UK == UK_ModAsSideEffect && ModAsSideEffect)
10089 ModAsSideEffect->push_back(std::make_pair(O, U));
10094 /// \brief Check whether a modification or use conflicts with a prior usage.
10095 void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind,
10100 const Usage &U = UI.Uses[OtherKind];
10101 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq))
10105 Expr *ModOrUse = Ref;
10106 if (OtherKind == UK_Use)
10107 std::swap(Mod, ModOrUse);
10109 SemaRef.Diag(Mod->getExprLoc(),
10110 IsModMod ? diag::warn_unsequenced_mod_mod
10111 : diag::warn_unsequenced_mod_use)
10112 << O << SourceRange(ModOrUse->getExprLoc());
10113 UI.Diagnosed = true;
10116 void notePreUse(Object O, Expr *Use) {
10117 UsageInfo &U = UsageMap[O];
10118 // Uses conflict with other modifications.
10119 checkUsage(O, U, Use, UK_ModAsValue, false);
10121 void notePostUse(Object O, Expr *Use) {
10122 UsageInfo &U = UsageMap[O];
10123 checkUsage(O, U, Use, UK_ModAsSideEffect, false);
10124 addUsage(U, O, Use, UK_Use);
10127 void notePreMod(Object O, Expr *Mod) {
10128 UsageInfo &U = UsageMap[O];
10129 // Modifications conflict with other modifications and with uses.
10130 checkUsage(O, U, Mod, UK_ModAsValue, true);
10131 checkUsage(O, U, Mod, UK_Use, false);
10133 void notePostMod(Object O, Expr *Use, UsageKind UK) {
10134 UsageInfo &U = UsageMap[O];
10135 checkUsage(O, U, Use, UK_ModAsSideEffect, true);
10136 addUsage(U, O, Use, UK);
10140 SequenceChecker(Sema &S, Expr *E, SmallVectorImpl<Expr *> &WorkList)
10141 : Base(S.Context), SemaRef(S), Region(Tree.root()),
10142 ModAsSideEffect(nullptr), WorkList(WorkList), EvalTracker(nullptr) {
10146 void VisitStmt(Stmt *S) {
10147 // Skip all statements which aren't expressions for now.
10150 void VisitExpr(Expr *E) {
10151 // By default, just recurse to evaluated subexpressions.
10152 Base::VisitStmt(E);
10155 void VisitCastExpr(CastExpr *E) {
10156 Object O = Object();
10157 if (E->getCastKind() == CK_LValueToRValue)
10158 O = getObject(E->getSubExpr(), false);
10167 void VisitBinComma(BinaryOperator *BO) {
10168 // C++11 [expr.comma]p1:
10169 // Every value computation and side effect associated with the left
10170 // expression is sequenced before every value computation and side
10171 // effect associated with the right expression.
10172 SequenceTree::Seq LHS = Tree.allocate(Region);
10173 SequenceTree::Seq RHS = Tree.allocate(Region);
10174 SequenceTree::Seq OldRegion = Region;
10177 SequencedSubexpression SeqLHS(*this);
10179 Visit(BO->getLHS());
10183 Visit(BO->getRHS());
10185 Region = OldRegion;
10187 // Forget that LHS and RHS are sequenced. They are both unsequenced
10188 // with respect to other stuff.
10193 void VisitBinAssign(BinaryOperator *BO) {
10194 // The modification is sequenced after the value computation of the LHS
10195 // and RHS, so check it before inspecting the operands and update the
10197 Object O = getObject(BO->getLHS(), true);
10199 return VisitExpr(BO);
10203 // C++11 [expr.ass]p7:
10204 // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated
10207 // Therefore, for a compound assignment operator, O is considered used
10208 // everywhere except within the evaluation of E1 itself.
10209 if (isa<CompoundAssignOperator>(BO))
10212 Visit(BO->getLHS());
10214 if (isa<CompoundAssignOperator>(BO))
10215 notePostUse(O, BO);
10217 Visit(BO->getRHS());
10219 // C++11 [expr.ass]p1:
10220 // the assignment is sequenced [...] before the value computation of the
10221 // assignment expression.
10222 // C11 6.5.16/3 has no such rule.
10223 notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue
10224 : UK_ModAsSideEffect);
10227 void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) {
10228 VisitBinAssign(CAO);
10231 void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); }
10232 void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); }
10233 void VisitUnaryPreIncDec(UnaryOperator *UO) {
10234 Object O = getObject(UO->getSubExpr(), true);
10236 return VisitExpr(UO);
10239 Visit(UO->getSubExpr());
10240 // C++11 [expr.pre.incr]p1:
10241 // the expression ++x is equivalent to x+=1
10242 notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue
10243 : UK_ModAsSideEffect);
10246 void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); }
10247 void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); }
10248 void VisitUnaryPostIncDec(UnaryOperator *UO) {
10249 Object O = getObject(UO->getSubExpr(), true);
10251 return VisitExpr(UO);
10254 Visit(UO->getSubExpr());
10255 notePostMod(O, UO, UK_ModAsSideEffect);
10258 /// Don't visit the RHS of '&&' or '||' if it might not be evaluated.
10259 void VisitBinLOr(BinaryOperator *BO) {
10260 // The side-effects of the LHS of an '&&' are sequenced before the
10261 // value computation of the RHS, and hence before the value computation
10262 // of the '&&' itself, unless the LHS evaluates to zero. We treat them
10263 // as if they were unconditionally sequenced.
10264 EvaluationTracker Eval(*this);
10266 SequencedSubexpression Sequenced(*this);
10267 Visit(BO->getLHS());
10271 if (Eval.evaluate(BO->getLHS(), Result)) {
10273 Visit(BO->getRHS());
10275 // Check for unsequenced operations in the RHS, treating it as an
10276 // entirely separate evaluation.
10278 // FIXME: If there are operations in the RHS which are unsequenced
10279 // with respect to operations outside the RHS, and those operations
10280 // are unconditionally evaluated, diagnose them.
10281 WorkList.push_back(BO->getRHS());
10284 void VisitBinLAnd(BinaryOperator *BO) {
10285 EvaluationTracker Eval(*this);
10287 SequencedSubexpression Sequenced(*this);
10288 Visit(BO->getLHS());
10292 if (Eval.evaluate(BO->getLHS(), Result)) {
10294 Visit(BO->getRHS());
10296 WorkList.push_back(BO->getRHS());
10300 // Only visit the condition, unless we can be sure which subexpression will
10302 void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) {
10303 EvaluationTracker Eval(*this);
10305 SequencedSubexpression Sequenced(*this);
10306 Visit(CO->getCond());
10310 if (Eval.evaluate(CO->getCond(), Result))
10311 Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr());
10313 WorkList.push_back(CO->getTrueExpr());
10314 WorkList.push_back(CO->getFalseExpr());
10318 void VisitCallExpr(CallExpr *CE) {
10319 // C++11 [intro.execution]p15:
10320 // When calling a function [...], every value computation and side effect
10321 // associated with any argument expression, or with the postfix expression
10322 // designating the called function, is sequenced before execution of every
10323 // expression or statement in the body of the function [and thus before
10324 // the value computation of its result].
10325 SequencedSubexpression Sequenced(*this);
10326 Base::VisitCallExpr(CE);
10328 // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions.
10331 void VisitCXXConstructExpr(CXXConstructExpr *CCE) {
10332 // This is a call, so all subexpressions are sequenced before the result.
10333 SequencedSubexpression Sequenced(*this);
10335 if (!CCE->isListInitialization())
10336 return VisitExpr(CCE);
10338 // In C++11, list initializations are sequenced.
10339 SmallVector<SequenceTree::Seq, 32> Elts;
10340 SequenceTree::Seq Parent = Region;
10341 for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(),
10342 E = CCE->arg_end();
10344 Region = Tree.allocate(Parent);
10345 Elts.push_back(Region);
10349 // Forget that the initializers are sequenced.
10351 for (unsigned I = 0; I < Elts.size(); ++I)
10352 Tree.merge(Elts[I]);
10355 void VisitInitListExpr(InitListExpr *ILE) {
10356 if (!SemaRef.getLangOpts().CPlusPlus11)
10357 return VisitExpr(ILE);
10359 // In C++11, list initializations are sequenced.
10360 SmallVector<SequenceTree::Seq, 32> Elts;
10361 SequenceTree::Seq Parent = Region;
10362 for (unsigned I = 0; I < ILE->getNumInits(); ++I) {
10363 Expr *E = ILE->getInit(I);
10365 Region = Tree.allocate(Parent);
10366 Elts.push_back(Region);
10370 // Forget that the initializers are sequenced.
10372 for (unsigned I = 0; I < Elts.size(); ++I)
10373 Tree.merge(Elts[I]);
10376 } // end anonymous namespace
10378 void Sema::CheckUnsequencedOperations(Expr *E) {
10379 SmallVector<Expr *, 8> WorkList;
10380 WorkList.push_back(E);
10381 while (!WorkList.empty()) {
10382 Expr *Item = WorkList.pop_back_val();
10383 SequenceChecker(*this, Item, WorkList);
10387 void Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc,
10388 bool IsConstexpr) {
10389 CheckImplicitConversions(E, CheckLoc);
10390 if (!E->isInstantiationDependent())
10391 CheckUnsequencedOperations(E);
10392 if (!IsConstexpr && !E->isValueDependent())
10393 CheckForIntOverflow(E);
10394 DiagnoseMisalignedMembers();
10397 void Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
10398 FieldDecl *BitField,
10400 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
10403 static void diagnoseArrayStarInParamType(Sema &S, QualType PType,
10404 SourceLocation Loc) {
10405 if (!PType->isVariablyModifiedType())
10407 if (const auto *PointerTy = dyn_cast<PointerType>(PType)) {
10408 diagnoseArrayStarInParamType(S, PointerTy->getPointeeType(), Loc);
10411 if (const auto *ReferenceTy = dyn_cast<ReferenceType>(PType)) {
10412 diagnoseArrayStarInParamType(S, ReferenceTy->getPointeeType(), Loc);
10415 if (const auto *ParenTy = dyn_cast<ParenType>(PType)) {
10416 diagnoseArrayStarInParamType(S, ParenTy->getInnerType(), Loc);
10420 const ArrayType *AT = S.Context.getAsArrayType(PType);
10424 if (AT->getSizeModifier() != ArrayType::Star) {
10425 diagnoseArrayStarInParamType(S, AT->getElementType(), Loc);
10429 S.Diag(Loc, diag::err_array_star_in_function_definition);
10432 /// CheckParmsForFunctionDef - Check that the parameters of the given
10433 /// function are appropriate for the definition of a function. This
10434 /// takes care of any checks that cannot be performed on the
10435 /// declaration itself, e.g., that the types of each of the function
10436 /// parameters are complete.
10437 bool Sema::CheckParmsForFunctionDef(ArrayRef<ParmVarDecl *> Parameters,
10438 bool CheckParameterNames) {
10439 bool HasInvalidParm = false;
10440 for (ParmVarDecl *Param : Parameters) {
10441 // C99 6.7.5.3p4: the parameters in a parameter type list in a
10442 // function declarator that is part of a function definition of
10443 // that function shall not have incomplete type.
10445 // This is also C++ [dcl.fct]p6.
10446 if (!Param->isInvalidDecl() &&
10447 RequireCompleteType(Param->getLocation(), Param->getType(),
10448 diag::err_typecheck_decl_incomplete_type)) {
10449 Param->setInvalidDecl();
10450 HasInvalidParm = true;
10453 // C99 6.9.1p5: If the declarator includes a parameter type list, the
10454 // declaration of each parameter shall include an identifier.
10455 if (CheckParameterNames &&
10456 Param->getIdentifier() == nullptr &&
10457 !Param->isImplicit() &&
10458 !getLangOpts().CPlusPlus)
10459 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
10462 // If the function declarator is not part of a definition of that
10463 // function, parameters may have incomplete type and may use the [*]
10464 // notation in their sequences of declarator specifiers to specify
10465 // variable length array types.
10466 QualType PType = Param->getOriginalType();
10467 // FIXME: This diagnostic should point the '[*]' if source-location
10468 // information is added for it.
10469 diagnoseArrayStarInParamType(*this, PType, Param->getLocation());
10471 // MSVC destroys objects passed by value in the callee. Therefore a
10472 // function definition which takes such a parameter must be able to call the
10473 // object's destructor. However, we don't perform any direct access check
10475 if (getLangOpts().CPlusPlus && Context.getTargetInfo()
10477 .areArgsDestroyedLeftToRightInCallee()) {
10478 if (!Param->isInvalidDecl()) {
10479 if (const RecordType *RT = Param->getType()->getAs<RecordType>()) {
10480 CXXRecordDecl *ClassDecl = cast<CXXRecordDecl>(RT->getDecl());
10481 if (!ClassDecl->isInvalidDecl() &&
10482 !ClassDecl->hasIrrelevantDestructor() &&
10483 !ClassDecl->isDependentContext()) {
10484 CXXDestructorDecl *Destructor = LookupDestructor(ClassDecl);
10485 MarkFunctionReferenced(Param->getLocation(), Destructor);
10486 DiagnoseUseOfDecl(Destructor, Param->getLocation());
10492 // Parameters with the pass_object_size attribute only need to be marked
10493 // constant at function definitions. Because we lack information about
10494 // whether we're on a declaration or definition when we're instantiating the
10495 // attribute, we need to check for constness here.
10496 if (const auto *Attr = Param->getAttr<PassObjectSizeAttr>())
10497 if (!Param->getType().isConstQualified())
10498 Diag(Param->getLocation(), diag::err_attribute_pointers_only)
10499 << Attr->getSpelling() << 1;
10502 return HasInvalidParm;
10505 /// A helper function to get the alignment of a Decl referred to by DeclRefExpr
10507 static CharUnits getDeclAlign(Expr *E, CharUnits TypeAlign,
10508 ASTContext &Context) {
10509 if (const auto *DRE = dyn_cast<DeclRefExpr>(E))
10510 return Context.getDeclAlign(DRE->getDecl());
10512 if (const auto *ME = dyn_cast<MemberExpr>(E))
10513 return Context.getDeclAlign(ME->getMemberDecl());
10518 /// CheckCastAlign - Implements -Wcast-align, which warns when a
10519 /// pointer cast increases the alignment requirements.
10520 void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
10521 // This is actually a lot of work to potentially be doing on every
10522 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
10523 if (getDiagnostics().isIgnored(diag::warn_cast_align, TRange.getBegin()))
10526 // Ignore dependent types.
10527 if (T->isDependentType() || Op->getType()->isDependentType())
10530 // Require that the destination be a pointer type.
10531 const PointerType *DestPtr = T->getAs<PointerType>();
10532 if (!DestPtr) return;
10534 // If the destination has alignment 1, we're done.
10535 QualType DestPointee = DestPtr->getPointeeType();
10536 if (DestPointee->isIncompleteType()) return;
10537 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
10538 if (DestAlign.isOne()) return;
10540 // Require that the source be a pointer type.
10541 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
10542 if (!SrcPtr) return;
10543 QualType SrcPointee = SrcPtr->getPointeeType();
10545 // Whitelist casts from cv void*. We already implicitly
10546 // whitelisted casts to cv void*, since they have alignment 1.
10547 // Also whitelist casts involving incomplete types, which implicitly
10548 // includes 'void'.
10549 if (SrcPointee->isIncompleteType()) return;
10551 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
10553 if (auto *CE = dyn_cast<CastExpr>(Op)) {
10554 if (CE->getCastKind() == CK_ArrayToPointerDecay)
10555 SrcAlign = getDeclAlign(CE->getSubExpr(), SrcAlign, Context);
10556 } else if (auto *UO = dyn_cast<UnaryOperator>(Op)) {
10557 if (UO->getOpcode() == UO_AddrOf)
10558 SrcAlign = getDeclAlign(UO->getSubExpr(), SrcAlign, Context);
10561 if (SrcAlign >= DestAlign) return;
10563 Diag(TRange.getBegin(), diag::warn_cast_align)
10564 << Op->getType() << T
10565 << static_cast<unsigned>(SrcAlign.getQuantity())
10566 << static_cast<unsigned>(DestAlign.getQuantity())
10567 << TRange << Op->getSourceRange();
10570 /// \brief Check whether this array fits the idiom of a size-one tail padded
10571 /// array member of a struct.
10573 /// We avoid emitting out-of-bounds access warnings for such arrays as they are
10574 /// commonly used to emulate flexible arrays in C89 code.
10575 static bool IsTailPaddedMemberArray(Sema &S, const llvm::APInt &Size,
10576 const NamedDecl *ND) {
10577 if (Size != 1 || !ND) return false;
10579 const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
10580 if (!FD) return false;
10582 // Don't consider sizes resulting from macro expansions or template argument
10583 // substitution to form C89 tail-padded arrays.
10585 TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
10587 TypeLoc TL = TInfo->getTypeLoc();
10588 // Look through typedefs.
10589 if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) {
10590 const TypedefNameDecl *TDL = TTL.getTypedefNameDecl();
10591 TInfo = TDL->getTypeSourceInfo();
10594 if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) {
10595 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
10596 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
10602 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
10603 if (!RD) return false;
10604 if (RD->isUnion()) return false;
10605 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
10606 if (!CRD->isStandardLayout()) return false;
10609 // See if this is the last field decl in the record.
10610 const Decl *D = FD;
10611 while ((D = D->getNextDeclInContext()))
10612 if (isa<FieldDecl>(D))
10617 void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
10618 const ArraySubscriptExpr *ASE,
10619 bool AllowOnePastEnd, bool IndexNegated) {
10620 IndexExpr = IndexExpr->IgnoreParenImpCasts();
10621 if (IndexExpr->isValueDependent())
10624 const Type *EffectiveType =
10625 BaseExpr->getType()->getPointeeOrArrayElementType();
10626 BaseExpr = BaseExpr->IgnoreParenCasts();
10627 const ConstantArrayType *ArrayTy =
10628 Context.getAsConstantArrayType(BaseExpr->getType());
10632 llvm::APSInt index;
10633 if (!IndexExpr->EvaluateAsInt(index, Context, Expr::SE_AllowSideEffects))
10638 const NamedDecl *ND = nullptr;
10639 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
10640 ND = dyn_cast<NamedDecl>(DRE->getDecl());
10641 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
10642 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
10644 if (index.isUnsigned() || !index.isNegative()) {
10645 llvm::APInt size = ArrayTy->getSize();
10646 if (!size.isStrictlyPositive())
10649 const Type *BaseType = BaseExpr->getType()->getPointeeOrArrayElementType();
10650 if (BaseType != EffectiveType) {
10651 // Make sure we're comparing apples to apples when comparing index to size
10652 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
10653 uint64_t array_typesize = Context.getTypeSize(BaseType);
10654 // Handle ptrarith_typesize being zero, such as when casting to void*
10655 if (!ptrarith_typesize) ptrarith_typesize = 1;
10656 if (ptrarith_typesize != array_typesize) {
10657 // There's a cast to a different size type involved
10658 uint64_t ratio = array_typesize / ptrarith_typesize;
10659 // TODO: Be smarter about handling cases where array_typesize is not a
10660 // multiple of ptrarith_typesize
10661 if (ptrarith_typesize * ratio == array_typesize)
10662 size *= llvm::APInt(size.getBitWidth(), ratio);
10666 if (size.getBitWidth() > index.getBitWidth())
10667 index = index.zext(size.getBitWidth());
10668 else if (size.getBitWidth() < index.getBitWidth())
10669 size = size.zext(index.getBitWidth());
10671 // For array subscripting the index must be less than size, but for pointer
10672 // arithmetic also allow the index (offset) to be equal to size since
10673 // computing the next address after the end of the array is legal and
10674 // commonly done e.g. in C++ iterators and range-based for loops.
10675 if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
10678 // Also don't warn for arrays of size 1 which are members of some
10679 // structure. These are often used to approximate flexible arrays in C89
10681 if (IsTailPaddedMemberArray(*this, size, ND))
10684 // Suppress the warning if the subscript expression (as identified by the
10685 // ']' location) and the index expression are both from macro expansions
10686 // within a system header.
10688 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
10689 ASE->getRBracketLoc());
10690 if (SourceMgr.isInSystemHeader(RBracketLoc)) {
10691 SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
10692 IndexExpr->getLocStart());
10693 if (SourceMgr.isWrittenInSameFile(RBracketLoc, IndexLoc))
10698 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
10700 DiagID = diag::warn_array_index_exceeds_bounds;
10702 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
10703 PDiag(DiagID) << index.toString(10, true)
10704 << size.toString(10, true)
10705 << (unsigned)size.getLimitedValue(~0U)
10706 << IndexExpr->getSourceRange());
10708 unsigned DiagID = diag::warn_array_index_precedes_bounds;
10710 DiagID = diag::warn_ptr_arith_precedes_bounds;
10711 if (index.isNegative()) index = -index;
10714 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
10715 PDiag(DiagID) << index.toString(10, true)
10716 << IndexExpr->getSourceRange());
10720 // Try harder to find a NamedDecl to point at in the note.
10721 while (const ArraySubscriptExpr *ASE =
10722 dyn_cast<ArraySubscriptExpr>(BaseExpr))
10723 BaseExpr = ASE->getBase()->IgnoreParenCasts();
10724 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
10725 ND = dyn_cast<NamedDecl>(DRE->getDecl());
10726 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
10727 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
10731 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
10732 PDiag(diag::note_array_index_out_of_bounds)
10733 << ND->getDeclName());
10736 void Sema::CheckArrayAccess(const Expr *expr) {
10737 int AllowOnePastEnd = 0;
10739 expr = expr->IgnoreParenImpCasts();
10740 switch (expr->getStmtClass()) {
10741 case Stmt::ArraySubscriptExprClass: {
10742 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
10743 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
10744 AllowOnePastEnd > 0);
10747 case Stmt::OMPArraySectionExprClass: {
10748 const OMPArraySectionExpr *ASE = cast<OMPArraySectionExpr>(expr);
10749 if (ASE->getLowerBound())
10750 CheckArrayAccess(ASE->getBase(), ASE->getLowerBound(),
10751 /*ASE=*/nullptr, AllowOnePastEnd > 0);
10754 case Stmt::UnaryOperatorClass: {
10755 // Only unwrap the * and & unary operators
10756 const UnaryOperator *UO = cast<UnaryOperator>(expr);
10757 expr = UO->getSubExpr();
10758 switch (UO->getOpcode()) {
10770 case Stmt::ConditionalOperatorClass: {
10771 const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
10772 if (const Expr *lhs = cond->getLHS())
10773 CheckArrayAccess(lhs);
10774 if (const Expr *rhs = cond->getRHS())
10775 CheckArrayAccess(rhs);
10778 case Stmt::CXXOperatorCallExprClass: {
10779 const auto *OCE = cast<CXXOperatorCallExpr>(expr);
10780 for (const auto *Arg : OCE->arguments())
10781 CheckArrayAccess(Arg);
10790 //===--- CHECK: Objective-C retain cycles ----------------------------------//
10793 struct RetainCycleOwner {
10794 RetainCycleOwner() : Variable(nullptr), Indirect(false) {}
10797 SourceLocation Loc;
10800 void setLocsFrom(Expr *e) {
10801 Loc = e->getExprLoc();
10802 Range = e->getSourceRange();
10805 } // end anonymous namespace
10807 /// Consider whether capturing the given variable can possibly lead to
10808 /// a retain cycle.
10809 static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
10810 // In ARC, it's captured strongly iff the variable has __strong
10811 // lifetime. In MRR, it's captured strongly if the variable is
10812 // __block and has an appropriate type.
10813 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
10816 owner.Variable = var;
10818 owner.setLocsFrom(ref);
10822 static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
10824 e = e->IgnoreParens();
10825 if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
10826 switch (cast->getCastKind()) {
10828 case CK_LValueBitCast:
10829 case CK_LValueToRValue:
10830 case CK_ARCReclaimReturnedObject:
10831 e = cast->getSubExpr();
10839 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
10840 ObjCIvarDecl *ivar = ref->getDecl();
10841 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
10844 // Try to find a retain cycle in the base.
10845 if (!findRetainCycleOwner(S, ref->getBase(), owner))
10848 if (ref->isFreeIvar()) owner.setLocsFrom(ref);
10849 owner.Indirect = true;
10853 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
10854 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
10855 if (!var) return false;
10856 return considerVariable(var, ref, owner);
10859 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
10860 if (member->isArrow()) return false;
10862 // Don't count this as an indirect ownership.
10863 e = member->getBase();
10867 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
10868 // Only pay attention to pseudo-objects on property references.
10869 ObjCPropertyRefExpr *pre
10870 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
10872 if (!pre) return false;
10873 if (pre->isImplicitProperty()) return false;
10874 ObjCPropertyDecl *property = pre->getExplicitProperty();
10875 if (!property->isRetaining() &&
10876 !(property->getPropertyIvarDecl() &&
10877 property->getPropertyIvarDecl()->getType()
10878 .getObjCLifetime() == Qualifiers::OCL_Strong))
10881 owner.Indirect = true;
10882 if (pre->isSuperReceiver()) {
10883 owner.Variable = S.getCurMethodDecl()->getSelfDecl();
10884 if (!owner.Variable)
10886 owner.Loc = pre->getLocation();
10887 owner.Range = pre->getSourceRange();
10890 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
10891 ->getSourceExpr());
10902 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
10903 FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
10904 : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
10905 Context(Context), Variable(variable), Capturer(nullptr),
10906 VarWillBeReased(false) {}
10907 ASTContext &Context;
10910 bool VarWillBeReased;
10912 void VisitDeclRefExpr(DeclRefExpr *ref) {
10913 if (ref->getDecl() == Variable && !Capturer)
10917 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
10918 if (Capturer) return;
10919 Visit(ref->getBase());
10920 if (Capturer && ref->isFreeIvar())
10924 void VisitBlockExpr(BlockExpr *block) {
10925 // Look inside nested blocks
10926 if (block->getBlockDecl()->capturesVariable(Variable))
10927 Visit(block->getBlockDecl()->getBody());
10930 void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) {
10931 if (Capturer) return;
10932 if (OVE->getSourceExpr())
10933 Visit(OVE->getSourceExpr());
10935 void VisitBinaryOperator(BinaryOperator *BinOp) {
10936 if (!Variable || VarWillBeReased || BinOp->getOpcode() != BO_Assign)
10938 Expr *LHS = BinOp->getLHS();
10939 if (const DeclRefExpr *DRE = dyn_cast_or_null<DeclRefExpr>(LHS)) {
10940 if (DRE->getDecl() != Variable)
10942 if (Expr *RHS = BinOp->getRHS()) {
10943 RHS = RHS->IgnoreParenCasts();
10944 llvm::APSInt Value;
10946 (RHS && RHS->isIntegerConstantExpr(Value, Context) && Value == 0);
10951 } // end anonymous namespace
10953 /// Check whether the given argument is a block which captures a
10955 static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
10956 assert(owner.Variable && owner.Loc.isValid());
10958 e = e->IgnoreParenCasts();
10960 // Look through [^{...} copy] and Block_copy(^{...}).
10961 if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) {
10962 Selector Cmd = ME->getSelector();
10963 if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") {
10964 e = ME->getInstanceReceiver();
10967 e = e->IgnoreParenCasts();
10969 } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) {
10970 if (CE->getNumArgs() == 1) {
10971 FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl());
10973 const IdentifierInfo *FnI = Fn->getIdentifier();
10974 if (FnI && FnI->isStr("_Block_copy")) {
10975 e = CE->getArg(0)->IgnoreParenCasts();
10981 BlockExpr *block = dyn_cast<BlockExpr>(e);
10982 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
10985 FindCaptureVisitor visitor(S.Context, owner.Variable);
10986 visitor.Visit(block->getBlockDecl()->getBody());
10987 return visitor.VarWillBeReased ? nullptr : visitor.Capturer;
10990 static void diagnoseRetainCycle(Sema &S, Expr *capturer,
10991 RetainCycleOwner &owner) {
10993 assert(owner.Variable && owner.Loc.isValid());
10995 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
10996 << owner.Variable << capturer->getSourceRange();
10997 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
10998 << owner.Indirect << owner.Range;
11001 /// Check for a keyword selector that starts with the word 'add' or
11003 static bool isSetterLikeSelector(Selector sel) {
11004 if (sel.isUnarySelector()) return false;
11006 StringRef str = sel.getNameForSlot(0);
11007 while (!str.empty() && str.front() == '_') str = str.substr(1);
11008 if (str.startswith("set"))
11009 str = str.substr(3);
11010 else if (str.startswith("add")) {
11011 // Specially whitelist 'addOperationWithBlock:'.
11012 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
11014 str = str.substr(3);
11019 if (str.empty()) return true;
11020 return !isLowercase(str.front());
11023 static Optional<int> GetNSMutableArrayArgumentIndex(Sema &S,
11024 ObjCMessageExpr *Message) {
11025 bool IsMutableArray = S.NSAPIObj->isSubclassOfNSClass(
11026 Message->getReceiverInterface(),
11027 NSAPI::ClassId_NSMutableArray);
11028 if (!IsMutableArray) {
11032 Selector Sel = Message->getSelector();
11034 Optional<NSAPI::NSArrayMethodKind> MKOpt =
11035 S.NSAPIObj->getNSArrayMethodKind(Sel);
11040 NSAPI::NSArrayMethodKind MK = *MKOpt;
11043 case NSAPI::NSMutableArr_addObject:
11044 case NSAPI::NSMutableArr_insertObjectAtIndex:
11045 case NSAPI::NSMutableArr_setObjectAtIndexedSubscript:
11047 case NSAPI::NSMutableArr_replaceObjectAtIndex:
11058 Optional<int> GetNSMutableDictionaryArgumentIndex(Sema &S,
11059 ObjCMessageExpr *Message) {
11060 bool IsMutableDictionary = S.NSAPIObj->isSubclassOfNSClass(
11061 Message->getReceiverInterface(),
11062 NSAPI::ClassId_NSMutableDictionary);
11063 if (!IsMutableDictionary) {
11067 Selector Sel = Message->getSelector();
11069 Optional<NSAPI::NSDictionaryMethodKind> MKOpt =
11070 S.NSAPIObj->getNSDictionaryMethodKind(Sel);
11075 NSAPI::NSDictionaryMethodKind MK = *MKOpt;
11078 case NSAPI::NSMutableDict_setObjectForKey:
11079 case NSAPI::NSMutableDict_setValueForKey:
11080 case NSAPI::NSMutableDict_setObjectForKeyedSubscript:
11090 static Optional<int> GetNSSetArgumentIndex(Sema &S, ObjCMessageExpr *Message) {
11091 bool IsMutableSet = S.NSAPIObj->isSubclassOfNSClass(
11092 Message->getReceiverInterface(),
11093 NSAPI::ClassId_NSMutableSet);
11095 bool IsMutableOrderedSet = S.NSAPIObj->isSubclassOfNSClass(
11096 Message->getReceiverInterface(),
11097 NSAPI::ClassId_NSMutableOrderedSet);
11098 if (!IsMutableSet && !IsMutableOrderedSet) {
11102 Selector Sel = Message->getSelector();
11104 Optional<NSAPI::NSSetMethodKind> MKOpt = S.NSAPIObj->getNSSetMethodKind(Sel);
11109 NSAPI::NSSetMethodKind MK = *MKOpt;
11112 case NSAPI::NSMutableSet_addObject:
11113 case NSAPI::NSOrderedSet_setObjectAtIndex:
11114 case NSAPI::NSOrderedSet_setObjectAtIndexedSubscript:
11115 case NSAPI::NSOrderedSet_insertObjectAtIndex:
11117 case NSAPI::NSOrderedSet_replaceObjectAtIndexWithObject:
11124 void Sema::CheckObjCCircularContainer(ObjCMessageExpr *Message) {
11125 if (!Message->isInstanceMessage()) {
11129 Optional<int> ArgOpt;
11131 if (!(ArgOpt = GetNSMutableArrayArgumentIndex(*this, Message)) &&
11132 !(ArgOpt = GetNSMutableDictionaryArgumentIndex(*this, Message)) &&
11133 !(ArgOpt = GetNSSetArgumentIndex(*this, Message))) {
11137 int ArgIndex = *ArgOpt;
11139 Expr *Arg = Message->getArg(ArgIndex)->IgnoreImpCasts();
11140 if (OpaqueValueExpr *OE = dyn_cast<OpaqueValueExpr>(Arg)) {
11141 Arg = OE->getSourceExpr()->IgnoreImpCasts();
11144 if (Message->getReceiverKind() == ObjCMessageExpr::SuperInstance) {
11145 if (DeclRefExpr *ArgRE = dyn_cast<DeclRefExpr>(Arg)) {
11146 if (ArgRE->isObjCSelfExpr()) {
11147 Diag(Message->getSourceRange().getBegin(),
11148 diag::warn_objc_circular_container)
11149 << ArgRE->getDecl()->getName() << StringRef("super");
11153 Expr *Receiver = Message->getInstanceReceiver()->IgnoreImpCasts();
11155 if (OpaqueValueExpr *OE = dyn_cast<OpaqueValueExpr>(Receiver)) {
11156 Receiver = OE->getSourceExpr()->IgnoreImpCasts();
11159 if (DeclRefExpr *ReceiverRE = dyn_cast<DeclRefExpr>(Receiver)) {
11160 if (DeclRefExpr *ArgRE = dyn_cast<DeclRefExpr>(Arg)) {
11161 if (ReceiverRE->getDecl() == ArgRE->getDecl()) {
11162 ValueDecl *Decl = ReceiverRE->getDecl();
11163 Diag(Message->getSourceRange().getBegin(),
11164 diag::warn_objc_circular_container)
11165 << Decl->getName() << Decl->getName();
11166 if (!ArgRE->isObjCSelfExpr()) {
11167 Diag(Decl->getLocation(),
11168 diag::note_objc_circular_container_declared_here)
11169 << Decl->getName();
11173 } else if (ObjCIvarRefExpr *IvarRE = dyn_cast<ObjCIvarRefExpr>(Receiver)) {
11174 if (ObjCIvarRefExpr *IvarArgRE = dyn_cast<ObjCIvarRefExpr>(Arg)) {
11175 if (IvarRE->getDecl() == IvarArgRE->getDecl()) {
11176 ObjCIvarDecl *Decl = IvarRE->getDecl();
11177 Diag(Message->getSourceRange().getBegin(),
11178 diag::warn_objc_circular_container)
11179 << Decl->getName() << Decl->getName();
11180 Diag(Decl->getLocation(),
11181 diag::note_objc_circular_container_declared_here)
11182 << Decl->getName();
11189 /// Check a message send to see if it's likely to cause a retain cycle.
11190 void Sema::checkRetainCycles(ObjCMessageExpr *msg) {
11191 // Only check instance methods whose selector looks like a setter.
11192 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
11195 // Try to find a variable that the receiver is strongly owned by.
11196 RetainCycleOwner owner;
11197 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
11198 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
11201 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
11202 owner.Variable = getCurMethodDecl()->getSelfDecl();
11203 owner.Loc = msg->getSuperLoc();
11204 owner.Range = msg->getSuperLoc();
11207 // Check whether the receiver is captured by any of the arguments.
11208 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
11209 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
11210 return diagnoseRetainCycle(*this, capturer, owner);
11213 /// Check a property assign to see if it's likely to cause a retain cycle.
11214 void Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
11215 RetainCycleOwner owner;
11216 if (!findRetainCycleOwner(*this, receiver, owner))
11219 if (Expr *capturer = findCapturingExpr(*this, argument, owner))
11220 diagnoseRetainCycle(*this, capturer, owner);
11223 void Sema::checkRetainCycles(VarDecl *Var, Expr *Init) {
11224 RetainCycleOwner Owner;
11225 if (!considerVariable(Var, /*DeclRefExpr=*/nullptr, Owner))
11228 // Because we don't have an expression for the variable, we have to set the
11229 // location explicitly here.
11230 Owner.Loc = Var->getLocation();
11231 Owner.Range = Var->getSourceRange();
11233 if (Expr *Capturer = findCapturingExpr(*this, Init, Owner))
11234 diagnoseRetainCycle(*this, Capturer, Owner);
11237 static bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc,
11238 Expr *RHS, bool isProperty) {
11239 // Check if RHS is an Objective-C object literal, which also can get
11240 // immediately zapped in a weak reference. Note that we explicitly
11241 // allow ObjCStringLiterals, since those are designed to never really die.
11242 RHS = RHS->IgnoreParenImpCasts();
11244 // This enum needs to match with the 'select' in
11245 // warn_objc_arc_literal_assign (off-by-1).
11246 Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS);
11247 if (Kind == Sema::LK_String || Kind == Sema::LK_None)
11250 S.Diag(Loc, diag::warn_arc_literal_assign)
11252 << (isProperty ? 0 : 1)
11253 << RHS->getSourceRange();
11258 static bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc,
11259 Qualifiers::ObjCLifetime LT,
11260 Expr *RHS, bool isProperty) {
11261 // Strip off any implicit cast added to get to the one ARC-specific.
11262 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
11263 if (cast->getCastKind() == CK_ARCConsumeObject) {
11264 S.Diag(Loc, diag::warn_arc_retained_assign)
11265 << (LT == Qualifiers::OCL_ExplicitNone)
11266 << (isProperty ? 0 : 1)
11267 << RHS->getSourceRange();
11270 RHS = cast->getSubExpr();
11273 if (LT == Qualifiers::OCL_Weak &&
11274 checkUnsafeAssignLiteral(S, Loc, RHS, isProperty))
11280 bool Sema::checkUnsafeAssigns(SourceLocation Loc,
11281 QualType LHS, Expr *RHS) {
11282 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
11284 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
11287 if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false))
11293 void Sema::checkUnsafeExprAssigns(SourceLocation Loc,
11294 Expr *LHS, Expr *RHS) {
11296 // PropertyRef on LHS type need be directly obtained from
11297 // its declaration as it has a PseudoType.
11298 ObjCPropertyRefExpr *PRE
11299 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
11300 if (PRE && !PRE->isImplicitProperty()) {
11301 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
11303 LHSType = PD->getType();
11306 if (LHSType.isNull())
11307 LHSType = LHS->getType();
11309 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
11311 if (LT == Qualifiers::OCL_Weak) {
11312 if (!Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, Loc))
11313 getCurFunction()->markSafeWeakUse(LHS);
11316 if (checkUnsafeAssigns(Loc, LHSType, RHS))
11319 // FIXME. Check for other life times.
11320 if (LT != Qualifiers::OCL_None)
11324 if (PRE->isImplicitProperty())
11326 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
11330 unsigned Attributes = PD->getPropertyAttributes();
11331 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
11332 // when 'assign' attribute was not explicitly specified
11333 // by user, ignore it and rely on property type itself
11334 // for lifetime info.
11335 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
11336 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
11337 LHSType->isObjCRetainableType())
11340 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
11341 if (cast->getCastKind() == CK_ARCConsumeObject) {
11342 Diag(Loc, diag::warn_arc_retained_property_assign)
11343 << RHS->getSourceRange();
11346 RHS = cast->getSubExpr();
11349 else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
11350 if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true))
11356 //===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
11359 bool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
11360 SourceLocation StmtLoc,
11361 const NullStmt *Body) {
11362 // Do not warn if the body is a macro that expands to nothing, e.g:
11368 if (Body->hasLeadingEmptyMacro())
11371 // Get line numbers of statement and body.
11372 bool StmtLineInvalid;
11373 unsigned StmtLine = SourceMgr.getPresumedLineNumber(StmtLoc,
11375 if (StmtLineInvalid)
11378 bool BodyLineInvalid;
11379 unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
11381 if (BodyLineInvalid)
11384 // Warn if null statement and body are on the same line.
11385 if (StmtLine != BodyLine)
11390 } // end anonymous namespace
11392 void Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
11395 // Since this is a syntactic check, don't emit diagnostic for template
11396 // instantiations, this just adds noise.
11397 if (CurrentInstantiationScope)
11400 // The body should be a null statement.
11401 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
11405 // Do the usual checks.
11406 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
11409 Diag(NBody->getSemiLoc(), DiagID);
11410 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
11413 void Sema::DiagnoseEmptyLoopBody(const Stmt *S,
11414 const Stmt *PossibleBody) {
11415 assert(!CurrentInstantiationScope); // Ensured by caller
11417 SourceLocation StmtLoc;
11420 if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
11421 StmtLoc = FS->getRParenLoc();
11422 Body = FS->getBody();
11423 DiagID = diag::warn_empty_for_body;
11424 } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
11425 StmtLoc = WS->getCond()->getSourceRange().getEnd();
11426 Body = WS->getBody();
11427 DiagID = diag::warn_empty_while_body;
11429 return; // Neither `for' nor `while'.
11431 // The body should be a null statement.
11432 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
11436 // Skip expensive checks if diagnostic is disabled.
11437 if (Diags.isIgnored(DiagID, NBody->getSemiLoc()))
11440 // Do the usual checks.
11441 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
11444 // `for(...);' and `while(...);' are popular idioms, so in order to keep
11445 // noise level low, emit diagnostics only if for/while is followed by a
11446 // CompoundStmt, e.g.:
11447 // for (int i = 0; i < n; i++);
11451 // or if for/while is followed by a statement with more indentation
11452 // than for/while itself:
11453 // for (int i = 0; i < n; i++);
11455 bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
11456 if (!ProbableTypo) {
11457 bool BodyColInvalid;
11458 unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
11459 PossibleBody->getLocStart(),
11461 if (BodyColInvalid)
11464 bool StmtColInvalid;
11465 unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
11468 if (StmtColInvalid)
11471 if (BodyCol > StmtCol)
11472 ProbableTypo = true;
11475 if (ProbableTypo) {
11476 Diag(NBody->getSemiLoc(), DiagID);
11477 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
11481 //===--- CHECK: Warn on self move with std::move. -------------------------===//
11483 /// DiagnoseSelfMove - Emits a warning if a value is moved to itself.
11484 void Sema::DiagnoseSelfMove(const Expr *LHSExpr, const Expr *RHSExpr,
11485 SourceLocation OpLoc) {
11486 if (Diags.isIgnored(diag::warn_sizeof_pointer_expr_memaccess, OpLoc))
11489 if (inTemplateInstantiation())
11492 // Strip parens and casts away.
11493 LHSExpr = LHSExpr->IgnoreParenImpCasts();
11494 RHSExpr = RHSExpr->IgnoreParenImpCasts();
11496 // Check for a call expression
11497 const CallExpr *CE = dyn_cast<CallExpr>(RHSExpr);
11498 if (!CE || CE->getNumArgs() != 1)
11501 // Check for a call to std::move
11502 const FunctionDecl *FD = CE->getDirectCallee();
11503 if (!FD || !FD->isInStdNamespace() || !FD->getIdentifier() ||
11504 !FD->getIdentifier()->isStr("move"))
11507 // Get argument from std::move
11508 RHSExpr = CE->getArg(0);
11510 const DeclRefExpr *LHSDeclRef = dyn_cast<DeclRefExpr>(LHSExpr);
11511 const DeclRefExpr *RHSDeclRef = dyn_cast<DeclRefExpr>(RHSExpr);
11513 // Two DeclRefExpr's, check that the decls are the same.
11514 if (LHSDeclRef && RHSDeclRef) {
11515 if (!LHSDeclRef->getDecl() || !RHSDeclRef->getDecl())
11517 if (LHSDeclRef->getDecl()->getCanonicalDecl() !=
11518 RHSDeclRef->getDecl()->getCanonicalDecl())
11521 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType()
11522 << LHSExpr->getSourceRange()
11523 << RHSExpr->getSourceRange();
11527 // Member variables require a different approach to check for self moves.
11528 // MemberExpr's are the same if every nested MemberExpr refers to the same
11529 // Decl and that the base Expr's are DeclRefExpr's with the same Decl or
11530 // the base Expr's are CXXThisExpr's.
11531 const Expr *LHSBase = LHSExpr;
11532 const Expr *RHSBase = RHSExpr;
11533 const MemberExpr *LHSME = dyn_cast<MemberExpr>(LHSExpr);
11534 const MemberExpr *RHSME = dyn_cast<MemberExpr>(RHSExpr);
11535 if (!LHSME || !RHSME)
11538 while (LHSME && RHSME) {
11539 if (LHSME->getMemberDecl()->getCanonicalDecl() !=
11540 RHSME->getMemberDecl()->getCanonicalDecl())
11543 LHSBase = LHSME->getBase();
11544 RHSBase = RHSME->getBase();
11545 LHSME = dyn_cast<MemberExpr>(LHSBase);
11546 RHSME = dyn_cast<MemberExpr>(RHSBase);
11549 LHSDeclRef = dyn_cast<DeclRefExpr>(LHSBase);
11550 RHSDeclRef = dyn_cast<DeclRefExpr>(RHSBase);
11551 if (LHSDeclRef && RHSDeclRef) {
11552 if (!LHSDeclRef->getDecl() || !RHSDeclRef->getDecl())
11554 if (LHSDeclRef->getDecl()->getCanonicalDecl() !=
11555 RHSDeclRef->getDecl()->getCanonicalDecl())
11558 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType()
11559 << LHSExpr->getSourceRange()
11560 << RHSExpr->getSourceRange();
11564 if (isa<CXXThisExpr>(LHSBase) && isa<CXXThisExpr>(RHSBase))
11565 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType()
11566 << LHSExpr->getSourceRange()
11567 << RHSExpr->getSourceRange();
11570 //===--- Layout compatibility ----------------------------------------------//
11574 bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2);
11576 /// \brief Check if two enumeration types are layout-compatible.
11577 bool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) {
11578 // C++11 [dcl.enum] p8:
11579 // Two enumeration types are layout-compatible if they have the same
11580 // underlying type.
11581 return ED1->isComplete() && ED2->isComplete() &&
11582 C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType());
11585 /// \brief Check if two fields are layout-compatible.
11586 bool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) {
11587 if (!isLayoutCompatible(C, Field1->getType(), Field2->getType()))
11590 if (Field1->isBitField() != Field2->isBitField())
11593 if (Field1->isBitField()) {
11594 // Make sure that the bit-fields are the same length.
11595 unsigned Bits1 = Field1->getBitWidthValue(C);
11596 unsigned Bits2 = Field2->getBitWidthValue(C);
11598 if (Bits1 != Bits2)
11605 /// \brief Check if two standard-layout structs are layout-compatible.
11606 /// (C++11 [class.mem] p17)
11607 bool isLayoutCompatibleStruct(ASTContext &C,
11610 // If both records are C++ classes, check that base classes match.
11611 if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) {
11612 // If one of records is a CXXRecordDecl we are in C++ mode,
11613 // thus the other one is a CXXRecordDecl, too.
11614 const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2);
11615 // Check number of base classes.
11616 if (D1CXX->getNumBases() != D2CXX->getNumBases())
11619 // Check the base classes.
11620 for (CXXRecordDecl::base_class_const_iterator
11621 Base1 = D1CXX->bases_begin(),
11622 BaseEnd1 = D1CXX->bases_end(),
11623 Base2 = D2CXX->bases_begin();
11625 ++Base1, ++Base2) {
11626 if (!isLayoutCompatible(C, Base1->getType(), Base2->getType()))
11629 } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) {
11630 // If only RD2 is a C++ class, it should have zero base classes.
11631 if (D2CXX->getNumBases() > 0)
11635 // Check the fields.
11636 RecordDecl::field_iterator Field2 = RD2->field_begin(),
11637 Field2End = RD2->field_end(),
11638 Field1 = RD1->field_begin(),
11639 Field1End = RD1->field_end();
11640 for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) {
11641 if (!isLayoutCompatible(C, *Field1, *Field2))
11644 if (Field1 != Field1End || Field2 != Field2End)
11650 /// \brief Check if two standard-layout unions are layout-compatible.
11651 /// (C++11 [class.mem] p18)
11652 bool isLayoutCompatibleUnion(ASTContext &C,
11655 llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields;
11656 for (auto *Field2 : RD2->fields())
11657 UnmatchedFields.insert(Field2);
11659 for (auto *Field1 : RD1->fields()) {
11660 llvm::SmallPtrSet<FieldDecl *, 8>::iterator
11661 I = UnmatchedFields.begin(),
11662 E = UnmatchedFields.end();
11664 for ( ; I != E; ++I) {
11665 if (isLayoutCompatible(C, Field1, *I)) {
11666 bool Result = UnmatchedFields.erase(*I);
11676 return UnmatchedFields.empty();
11679 bool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) {
11680 if (RD1->isUnion() != RD2->isUnion())
11683 if (RD1->isUnion())
11684 return isLayoutCompatibleUnion(C, RD1, RD2);
11686 return isLayoutCompatibleStruct(C, RD1, RD2);
11689 /// \brief Check if two types are layout-compatible in C++11 sense.
11690 bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) {
11691 if (T1.isNull() || T2.isNull())
11694 // C++11 [basic.types] p11:
11695 // If two types T1 and T2 are the same type, then T1 and T2 are
11696 // layout-compatible types.
11697 if (C.hasSameType(T1, T2))
11700 T1 = T1.getCanonicalType().getUnqualifiedType();
11701 T2 = T2.getCanonicalType().getUnqualifiedType();
11703 const Type::TypeClass TC1 = T1->getTypeClass();
11704 const Type::TypeClass TC2 = T2->getTypeClass();
11709 if (TC1 == Type::Enum) {
11710 return isLayoutCompatible(C,
11711 cast<EnumType>(T1)->getDecl(),
11712 cast<EnumType>(T2)->getDecl());
11713 } else if (TC1 == Type::Record) {
11714 if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType())
11717 return isLayoutCompatible(C,
11718 cast<RecordType>(T1)->getDecl(),
11719 cast<RecordType>(T2)->getDecl());
11724 } // end anonymous namespace
11726 //===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----//
11729 /// \brief Given a type tag expression find the type tag itself.
11731 /// \param TypeExpr Type tag expression, as it appears in user's code.
11733 /// \param VD Declaration of an identifier that appears in a type tag.
11735 /// \param MagicValue Type tag magic value.
11736 bool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx,
11737 const ValueDecl **VD, uint64_t *MagicValue) {
11742 TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts();
11744 switch (TypeExpr->getStmtClass()) {
11745 case Stmt::UnaryOperatorClass: {
11746 const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr);
11747 if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) {
11748 TypeExpr = UO->getSubExpr();
11754 case Stmt::DeclRefExprClass: {
11755 const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr);
11756 *VD = DRE->getDecl();
11760 case Stmt::IntegerLiteralClass: {
11761 const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr);
11762 llvm::APInt MagicValueAPInt = IL->getValue();
11763 if (MagicValueAPInt.getActiveBits() <= 64) {
11764 *MagicValue = MagicValueAPInt.getZExtValue();
11770 case Stmt::BinaryConditionalOperatorClass:
11771 case Stmt::ConditionalOperatorClass: {
11772 const AbstractConditionalOperator *ACO =
11773 cast<AbstractConditionalOperator>(TypeExpr);
11775 if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) {
11777 TypeExpr = ACO->getTrueExpr();
11779 TypeExpr = ACO->getFalseExpr();
11785 case Stmt::BinaryOperatorClass: {
11786 const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr);
11787 if (BO->getOpcode() == BO_Comma) {
11788 TypeExpr = BO->getRHS();
11800 /// \brief Retrieve the C type corresponding to type tag TypeExpr.
11802 /// \param TypeExpr Expression that specifies a type tag.
11804 /// \param MagicValues Registered magic values.
11806 /// \param FoundWrongKind Set to true if a type tag was found, but of a wrong
11809 /// \param TypeInfo Information about the corresponding C type.
11811 /// \returns true if the corresponding C type was found.
11812 bool GetMatchingCType(
11813 const IdentifierInfo *ArgumentKind,
11814 const Expr *TypeExpr, const ASTContext &Ctx,
11815 const llvm::DenseMap<Sema::TypeTagMagicValue,
11816 Sema::TypeTagData> *MagicValues,
11817 bool &FoundWrongKind,
11818 Sema::TypeTagData &TypeInfo) {
11819 FoundWrongKind = false;
11821 // Variable declaration that has type_tag_for_datatype attribute.
11822 const ValueDecl *VD = nullptr;
11824 uint64_t MagicValue;
11826 if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue))
11830 if (TypeTagForDatatypeAttr *I = VD->getAttr<TypeTagForDatatypeAttr>()) {
11831 if (I->getArgumentKind() != ArgumentKind) {
11832 FoundWrongKind = true;
11835 TypeInfo.Type = I->getMatchingCType();
11836 TypeInfo.LayoutCompatible = I->getLayoutCompatible();
11837 TypeInfo.MustBeNull = I->getMustBeNull();
11846 llvm::DenseMap<Sema::TypeTagMagicValue,
11847 Sema::TypeTagData>::const_iterator I =
11848 MagicValues->find(std::make_pair(ArgumentKind, MagicValue));
11849 if (I == MagicValues->end())
11852 TypeInfo = I->second;
11855 } // end anonymous namespace
11857 void Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind,
11858 uint64_t MagicValue, QualType Type,
11859 bool LayoutCompatible,
11861 if (!TypeTagForDatatypeMagicValues)
11862 TypeTagForDatatypeMagicValues.reset(
11863 new llvm::DenseMap<TypeTagMagicValue, TypeTagData>);
11865 TypeTagMagicValue Magic(ArgumentKind, MagicValue);
11866 (*TypeTagForDatatypeMagicValues)[Magic] =
11867 TypeTagData(Type, LayoutCompatible, MustBeNull);
11871 bool IsSameCharType(QualType T1, QualType T2) {
11872 const BuiltinType *BT1 = T1->getAs<BuiltinType>();
11876 const BuiltinType *BT2 = T2->getAs<BuiltinType>();
11880 BuiltinType::Kind T1Kind = BT1->getKind();
11881 BuiltinType::Kind T2Kind = BT2->getKind();
11883 return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) ||
11884 (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) ||
11885 (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) ||
11886 (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar);
11888 } // end anonymous namespace
11890 void Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr,
11891 const Expr * const *ExprArgs) {
11892 const IdentifierInfo *ArgumentKind = Attr->getArgumentKind();
11893 bool IsPointerAttr = Attr->getIsPointer();
11895 const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()];
11896 bool FoundWrongKind;
11897 TypeTagData TypeInfo;
11898 if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context,
11899 TypeTagForDatatypeMagicValues.get(),
11900 FoundWrongKind, TypeInfo)) {
11901 if (FoundWrongKind)
11902 Diag(TypeTagExpr->getExprLoc(),
11903 diag::warn_type_tag_for_datatype_wrong_kind)
11904 << TypeTagExpr->getSourceRange();
11908 const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()];
11909 if (IsPointerAttr) {
11910 // Skip implicit cast of pointer to `void *' (as a function argument).
11911 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr))
11912 if (ICE->getType()->isVoidPointerType() &&
11913 ICE->getCastKind() == CK_BitCast)
11914 ArgumentExpr = ICE->getSubExpr();
11916 QualType ArgumentType = ArgumentExpr->getType();
11918 // Passing a `void*' pointer shouldn't trigger a warning.
11919 if (IsPointerAttr && ArgumentType->isVoidPointerType())
11922 if (TypeInfo.MustBeNull) {
11923 // Type tag with matching void type requires a null pointer.
11924 if (!ArgumentExpr->isNullPointerConstant(Context,
11925 Expr::NPC_ValueDependentIsNotNull)) {
11926 Diag(ArgumentExpr->getExprLoc(),
11927 diag::warn_type_safety_null_pointer_required)
11928 << ArgumentKind->getName()
11929 << ArgumentExpr->getSourceRange()
11930 << TypeTagExpr->getSourceRange();
11935 QualType RequiredType = TypeInfo.Type;
11937 RequiredType = Context.getPointerType(RequiredType);
11939 bool mismatch = false;
11940 if (!TypeInfo.LayoutCompatible) {
11941 mismatch = !Context.hasSameType(ArgumentType, RequiredType);
11943 // C++11 [basic.fundamental] p1:
11944 // Plain char, signed char, and unsigned char are three distinct types.
11946 // But we treat plain `char' as equivalent to `signed char' or `unsigned
11947 // char' depending on the current char signedness mode.
11949 if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(),
11950 RequiredType->getPointeeType())) ||
11951 (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType)))
11955 mismatch = !isLayoutCompatible(Context,
11956 ArgumentType->getPointeeType(),
11957 RequiredType->getPointeeType());
11959 mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType);
11962 Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch)
11963 << ArgumentType << ArgumentKind
11964 << TypeInfo.LayoutCompatible << RequiredType
11965 << ArgumentExpr->getSourceRange()
11966 << TypeTagExpr->getSourceRange();
11969 void Sema::AddPotentialMisalignedMembers(Expr *E, RecordDecl *RD, ValueDecl *MD,
11970 CharUnits Alignment) {
11971 MisalignedMembers.emplace_back(E, RD, MD, Alignment);
11974 void Sema::DiagnoseMisalignedMembers() {
11975 for (MisalignedMember &m : MisalignedMembers) {
11976 const NamedDecl *ND = m.RD;
11977 if (ND->getName().empty()) {
11978 if (const TypedefNameDecl *TD = m.RD->getTypedefNameForAnonDecl())
11981 Diag(m.E->getLocStart(), diag::warn_taking_address_of_packed_member)
11982 << m.MD << ND << m.E->getSourceRange();
11984 MisalignedMembers.clear();
11987 void Sema::DiscardMisalignedMemberAddress(const Type *T, Expr *E) {
11988 E = E->IgnoreParens();
11989 if (!T->isPointerType() && !T->isIntegerType())
11991 if (isa<UnaryOperator>(E) &&
11992 cast<UnaryOperator>(E)->getOpcode() == UO_AddrOf) {
11993 auto *Op = cast<UnaryOperator>(E)->getSubExpr()->IgnoreParens();
11994 if (isa<MemberExpr>(Op)) {
11995 auto MA = std::find(MisalignedMembers.begin(), MisalignedMembers.end(),
11996 MisalignedMember(Op));
11997 if (MA != MisalignedMembers.end() &&
11998 (T->isIntegerType() ||
11999 (T->isPointerType() &&
12000 Context.getTypeAlignInChars(T->getPointeeType()) <= MA->Alignment)))
12001 MisalignedMembers.erase(MA);
12006 void Sema::RefersToMemberWithReducedAlignment(
12008 llvm::function_ref<void(Expr *, RecordDecl *, FieldDecl *, CharUnits)>
12010 const auto *ME = dyn_cast<MemberExpr>(E);
12014 // No need to check expressions with an __unaligned-qualified type.
12015 if (E->getType().getQualifiers().hasUnaligned())
12018 // For a chain of MemberExpr like "a.b.c.d" this list
12019 // will keep FieldDecl's like [d, c, b].
12020 SmallVector<FieldDecl *, 4> ReverseMemberChain;
12021 const MemberExpr *TopME = nullptr;
12022 bool AnyIsPacked = false;
12024 QualType BaseType = ME->getBase()->getType();
12026 BaseType = BaseType->getPointeeType();
12027 RecordDecl *RD = BaseType->getAs<RecordType>()->getDecl();
12029 ValueDecl *MD = ME->getMemberDecl();
12030 auto *FD = dyn_cast<FieldDecl>(MD);
12031 // We do not care about non-data members.
12032 if (!FD || FD->isInvalidDecl())
12036 AnyIsPacked || (RD->hasAttr<PackedAttr>() || MD->hasAttr<PackedAttr>());
12037 ReverseMemberChain.push_back(FD);
12040 ME = dyn_cast<MemberExpr>(ME->getBase()->IgnoreParens());
12042 assert(TopME && "We did not compute a topmost MemberExpr!");
12044 // Not the scope of this diagnostic.
12048 const Expr *TopBase = TopME->getBase()->IgnoreParenImpCasts();
12049 const auto *DRE = dyn_cast<DeclRefExpr>(TopBase);
12050 // TODO: The innermost base of the member expression may be too complicated.
12051 // For now, just disregard these cases. This is left for future
12053 if (!DRE && !isa<CXXThisExpr>(TopBase))
12056 // Alignment expected by the whole expression.
12057 CharUnits ExpectedAlignment = Context.getTypeAlignInChars(E->getType());
12059 // No need to do anything else with this case.
12060 if (ExpectedAlignment.isOne())
12063 // Synthesize offset of the whole access.
12065 for (auto I = ReverseMemberChain.rbegin(); I != ReverseMemberChain.rend();
12067 Offset += Context.toCharUnitsFromBits(Context.getFieldOffset(*I));
12070 // Compute the CompleteObjectAlignment as the alignment of the whole chain.
12071 CharUnits CompleteObjectAlignment = Context.getTypeAlignInChars(
12072 ReverseMemberChain.back()->getParent()->getTypeForDecl());
12074 // The base expression of the innermost MemberExpr may give
12075 // stronger guarantees than the class containing the member.
12076 if (DRE && !TopME->isArrow()) {
12077 const ValueDecl *VD = DRE->getDecl();
12078 if (!VD->getType()->isReferenceType())
12079 CompleteObjectAlignment =
12080 std::max(CompleteObjectAlignment, Context.getDeclAlign(VD));
12083 // Check if the synthesized offset fulfills the alignment.
12084 if (Offset % ExpectedAlignment != 0 ||
12085 // It may fulfill the offset it but the effective alignment may still be
12086 // lower than the expected expression alignment.
12087 CompleteObjectAlignment < ExpectedAlignment) {
12088 // If this happens, we want to determine a sensible culprit of this.
12089 // Intuitively, watching the chain of member expressions from right to
12090 // left, we start with the required alignment (as required by the field
12091 // type) but some packed attribute in that chain has reduced the alignment.
12092 // It may happen that another packed structure increases it again. But if
12093 // we are here such increase has not been enough. So pointing the first
12094 // FieldDecl that either is packed or else its RecordDecl is,
12095 // seems reasonable.
12096 FieldDecl *FD = nullptr;
12097 CharUnits Alignment;
12098 for (FieldDecl *FDI : ReverseMemberChain) {
12099 if (FDI->hasAttr<PackedAttr>() ||
12100 FDI->getParent()->hasAttr<PackedAttr>()) {
12102 Alignment = std::min(
12103 Context.getTypeAlignInChars(FD->getType()),
12104 Context.getTypeAlignInChars(FD->getParent()->getTypeForDecl()));
12108 assert(FD && "We did not find a packed FieldDecl!");
12109 Action(E, FD->getParent(), FD, Alignment);
12113 void Sema::CheckAddressOfPackedMember(Expr *rhs) {
12114 using namespace std::placeholders;
12115 RefersToMemberWithReducedAlignment(
12116 rhs, std::bind(&Sema::AddPotentialMisalignedMembers, std::ref(*this), _1,