1 //== DynamicTypeChecker.cpp ------------------------------------ -*- C++ -*--=//
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
7 //===----------------------------------------------------------------------===//
9 // This checker looks for cases where the dynamic type of an object is unrelated
10 // to its static type. The type information utilized by this check is collected
11 // by the DynamicTypePropagation checker. This check does not report any type
12 // error for ObjC Generic types, in order to avoid duplicate erros from the
13 // ObjC Generics checker. This checker is not supposed to modify the program
14 // state, it is just the observer of the type information provided by other
17 //===----------------------------------------------------------------------===//
19 #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
20 #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
21 #include "clang/StaticAnalyzer/Core/Checker.h"
22 #include "clang/StaticAnalyzer/Core/CheckerManager.h"
23 #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
24 #include "clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h"
25 #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
26 #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
28 using namespace clang;
32 class DynamicTypeChecker : public Checker<check::PostStmt<ImplicitCastExpr>> {
33 mutable std::unique_ptr<BugType> BT;
34 void initBugType() const {
37 new BugType(this, "Dynamic and static type mismatch", "Type Error"));
40 class DynamicTypeBugVisitor : public BugReporterVisitor {
42 DynamicTypeBugVisitor(const MemRegion *Reg) : Reg(Reg) {}
44 void Profile(llvm::FoldingSetNodeID &ID) const override {
50 std::shared_ptr<PathDiagnosticPiece> VisitNode(const ExplodedNode *N,
51 BugReporterContext &BRC,
52 BugReport &BR) override;
55 // The tracked region.
59 void reportTypeError(QualType DynamicType, QualType StaticType,
60 const MemRegion *Reg, const Stmt *ReportedNode,
61 CheckerContext &C) const;
64 void checkPostStmt(const ImplicitCastExpr *CE, CheckerContext &C) const;
68 void DynamicTypeChecker::reportTypeError(QualType DynamicType,
71 const Stmt *ReportedNode,
72 CheckerContext &C) const {
75 llvm::raw_svector_ostream OS(Buf);
76 OS << "Object has a dynamic type '";
77 QualType::print(DynamicType.getTypePtr(), Qualifiers(), OS, C.getLangOpts(),
79 OS << "' which is incompatible with static type '";
80 QualType::print(StaticType.getTypePtr(), Qualifiers(), OS, C.getLangOpts(),
83 std::unique_ptr<BugReport> R(
84 new BugReport(*BT, OS.str(), C.generateNonFatalErrorNode()));
85 R->markInteresting(Reg);
86 R->addVisitor(llvm::make_unique<DynamicTypeBugVisitor>(Reg));
87 R->addRange(ReportedNode->getSourceRange());
88 C.emitReport(std::move(R));
91 std::shared_ptr<PathDiagnosticPiece>
92 DynamicTypeChecker::DynamicTypeBugVisitor::VisitNode(const ExplodedNode *N,
93 BugReporterContext &BRC,
95 ProgramStateRef State = N->getState();
96 ProgramStateRef StatePrev = N->getFirstPred()->getState();
98 DynamicTypeInfo TrackedType = getDynamicTypeInfo(State, Reg);
99 DynamicTypeInfo TrackedTypePrev = getDynamicTypeInfo(StatePrev, Reg);
100 if (!TrackedType.isValid())
103 if (TrackedTypePrev.isValid() &&
104 TrackedTypePrev.getType() == TrackedType.getType())
107 // Retrieve the associated statement.
108 const Stmt *S = PathDiagnosticLocation::getStmt(N);
112 const LangOptions &LangOpts = BRC.getASTContext().getLangOpts();
114 SmallString<256> Buf;
115 llvm::raw_svector_ostream OS(Buf);
117 QualType::print(TrackedType.getType().getTypePtr(), Qualifiers(), OS,
118 LangOpts, llvm::Twine());
119 OS << "' is inferred from ";
121 if (const auto *ExplicitCast = dyn_cast<ExplicitCastExpr>(S)) {
122 OS << "explicit cast (from '";
123 QualType::print(ExplicitCast->getSubExpr()->getType().getTypePtr(),
124 Qualifiers(), OS, LangOpts, llvm::Twine());
126 QualType::print(ExplicitCast->getType().getTypePtr(), Qualifiers(), OS,
127 LangOpts, llvm::Twine());
129 } else if (const auto *ImplicitCast = dyn_cast<ImplicitCastExpr>(S)) {
130 OS << "implicit cast (from '";
131 QualType::print(ImplicitCast->getSubExpr()->getType().getTypePtr(),
132 Qualifiers(), OS, LangOpts, llvm::Twine());
134 QualType::print(ImplicitCast->getType().getTypePtr(), Qualifiers(), OS,
135 LangOpts, llvm::Twine());
138 OS << "this context";
141 // Generate the extra diagnostic.
142 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
143 N->getLocationContext());
144 return std::make_shared<PathDiagnosticEventPiece>(Pos, OS.str(), true,
148 static bool hasDefinition(const ObjCObjectPointerType *ObjPtr) {
149 const ObjCInterfaceDecl *Decl = ObjPtr->getInterfaceDecl();
153 return Decl->getDefinition();
156 // TODO: consider checking explicit casts?
157 void DynamicTypeChecker::checkPostStmt(const ImplicitCastExpr *CE,
158 CheckerContext &C) const {
159 // TODO: C++ support.
160 if (CE->getCastKind() != CK_BitCast)
163 const MemRegion *Region = C.getSVal(CE).getAsRegion();
167 ProgramStateRef State = C.getState();
168 DynamicTypeInfo DynTypeInfo = getDynamicTypeInfo(State, Region);
170 if (!DynTypeInfo.isValid())
173 QualType DynType = DynTypeInfo.getType();
174 QualType StaticType = CE->getType();
176 const auto *DynObjCType = DynType->getAs<ObjCObjectPointerType>();
177 const auto *StaticObjCType = StaticType->getAs<ObjCObjectPointerType>();
179 if (!DynObjCType || !StaticObjCType)
182 if (!hasDefinition(DynObjCType) || !hasDefinition(StaticObjCType))
185 ASTContext &ASTCtxt = C.getASTContext();
187 // Strip kindeofness to correctly detect subtyping relationships.
188 DynObjCType = DynObjCType->stripObjCKindOfTypeAndQuals(ASTCtxt);
189 StaticObjCType = StaticObjCType->stripObjCKindOfTypeAndQuals(ASTCtxt);
191 // Specialized objects are handled by the generics checker.
192 if (StaticObjCType->isSpecialized())
195 if (ASTCtxt.canAssignObjCInterfaces(StaticObjCType, DynObjCType))
198 if (DynTypeInfo.canBeASubClass() &&
199 ASTCtxt.canAssignObjCInterfaces(DynObjCType, StaticObjCType))
202 reportTypeError(DynType, StaticType, Region, CE, C);
205 void ento::registerDynamicTypeChecker(CheckerManager &mgr) {
206 mgr.registerChecker<DynamicTypeChecker>();
209 bool ento::shouldRegisterDynamicTypeChecker(const LangOptions &LO) {