2 * Copyright (c) 2012 The FreeBSD Foundation
5 * This software was developed by Edward Tomasz Napierala under sponsorship
6 * from the FreeBSD Foundation.
8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions
11 * 1. Redistributions of source code must retain the above copyright
12 * notice, this list of conditions and the following disclaimer.
13 * 2. Redistributions in binary form must reproduce the above copyright
14 * notice, this list of conditions and the following disclaimer in the
15 * documentation and/or other materials provided with the distribution.
17 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
18 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
19 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
20 * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
21 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
22 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
23 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
24 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
25 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
26 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
31 #include <sys/cdefs.h>
32 __FBSDID("$FreeBSD$");
34 #include <sys/types.h>
35 #include <sys/ioctl.h>
41 #include <netinet/in.h>
44 #include "iscsi_proto.h"
47 login_nsg(const struct pdu *response)
49 struct iscsi_bhs_login_response *bhslr;
51 bhslr = (struct iscsi_bhs_login_response *)response->pdu_bhs;
53 return (bhslr->bhslr_flags & 0x03);
57 login_set_nsg(struct pdu *request, int nsg)
59 struct iscsi_bhs_login_request *bhslr;
61 assert(nsg == BHSLR_STAGE_SECURITY_NEGOTIATION ||
62 nsg == BHSLR_STAGE_OPERATIONAL_NEGOTIATION ||
63 nsg == BHSLR_STAGE_FULL_FEATURE_PHASE);
65 bhslr = (struct iscsi_bhs_login_request *)request->pdu_bhs;
67 bhslr->bhslr_flags &= 0xFC;
68 bhslr->bhslr_flags |= nsg;
72 login_set_csg(struct pdu *request, int csg)
74 struct iscsi_bhs_login_request *bhslr;
76 assert(csg == BHSLR_STAGE_SECURITY_NEGOTIATION ||
77 csg == BHSLR_STAGE_OPERATIONAL_NEGOTIATION ||
78 csg == BHSLR_STAGE_FULL_FEATURE_PHASE);
80 bhslr = (struct iscsi_bhs_login_request *)request->pdu_bhs;
82 bhslr->bhslr_flags &= 0xF3;
83 bhslr->bhslr_flags |= csg << 2;
87 login_target_error_str(int class, int detail)
92 * RFC 3270, 10.13.5. Status-Class and Status-Detail
98 return ("Target moved temporarily");
100 return ("Target moved permanently");
102 snprintf(msg, sizeof(msg), "unknown redirection; "
103 "Status-Class 0x%x, Status-Detail 0x%x",
110 return ("Initiator error");
112 return ("Authentication failure");
114 return ("Authorization failure");
116 return ("Not found");
118 return ("Target removed");
120 return ("Unsupported version");
122 return ("Too many connections");
124 return ("Missing parameter");
126 return ("Can't include in session");
128 return ("Session type not supported");
130 return ("Session does not exist");
132 return ("Invalid during login");
134 snprintf(msg, sizeof(msg), "unknown initiator error; "
135 "Status-Class 0x%x, Status-Detail 0x%x",
142 return ("Target error");
144 return ("Service unavailable");
146 return ("Out of resources");
148 snprintf(msg, sizeof(msg), "unknown target error; "
149 "Status-Class 0x%x, Status-Detail 0x%x",
154 snprintf(msg, sizeof(msg), "unknown error; "
155 "Status-Class 0x%x, Status-Detail 0x%x",
162 kernel_modify(const struct connection *conn, const char *target_address)
164 struct iscsi_session_modify ism;
167 memset(&ism, 0, sizeof(ism));
168 ism.ism_session_id = conn->conn_session_id;
169 memcpy(&ism.ism_conf, &conn->conn_conf, sizeof(ism.ism_conf));
170 strlcpy(ism.ism_conf.isc_target_addr, target_address,
171 sizeof(ism.ism_conf.isc_target));
172 error = ioctl(conn->conn_iscsi_fd, ISCSISMODIFY, &ism);
174 log_err(1, "failed to redirect to %s: ISCSISMODIFY",
180 * XXX: The way it works is suboptimal; what should happen is described
181 * in draft-gilligan-iscsi-fault-tolerance-00. That, however, would
182 * be much more complicated: we would need to keep "dependencies"
183 * for sessions, so that, in case described in draft and using draft
184 * terminology, we would have three sessions: one for discovery,
185 * one for initial target portal, and one for redirect portal.
186 * This would allow us to "backtrack" on connection failure,
187 * as described in draft.
190 login_handle_redirection(struct connection *conn, struct pdu *response)
192 struct iscsi_bhs_login_response *bhslr;
193 struct keys *response_keys;
194 const char *target_address;
196 bhslr = (struct iscsi_bhs_login_response *)response->pdu_bhs;
197 assert (bhslr->bhslr_status_class == 1);
199 response_keys = keys_new();
200 keys_load(response_keys, response);
202 target_address = keys_find(response_keys, "TargetAddress");
203 if (target_address == NULL)
204 log_errx(1, "received redirection without TargetAddress");
205 if (target_address[0] == '\0')
206 log_errx(1, "received redirection with empty TargetAddress");
207 if (strlen(target_address) >=
208 sizeof(conn->conn_conf.isc_target_addr) - 1)
209 log_errx(1, "received TargetAddress is too long");
211 log_debugx("received redirection to \"%s\"", target_address);
212 kernel_modify(conn, target_address);
213 keys_delete(response_keys);
217 login_receive(struct connection *conn)
219 struct pdu *response;
220 struct iscsi_bhs_login_response *bhslr;
221 const char *errorstr;
222 static bool initial = true;
224 response = pdu_new(conn);
225 pdu_receive(response);
226 if (response->pdu_bhs->bhs_opcode != ISCSI_BHS_OPCODE_LOGIN_RESPONSE) {
227 log_errx(1, "protocol error: received invalid opcode 0x%x",
228 response->pdu_bhs->bhs_opcode);
230 bhslr = (struct iscsi_bhs_login_response *)response->pdu_bhs;
232 * XXX: Implement the C flag some day.
234 if ((bhslr->bhslr_flags & BHSLR_FLAGS_CONTINUE) != 0)
235 log_errx(1, "received Login PDU with unsupported \"C\" flag");
236 if (bhslr->bhslr_version_max != 0x00)
237 log_errx(1, "received Login PDU with unsupported "
238 "Version-max 0x%x", bhslr->bhslr_version_max);
239 if (bhslr->bhslr_version_active != 0x00)
240 log_errx(1, "received Login PDU with unsupported "
241 "Version-active 0x%x", bhslr->bhslr_version_active);
242 if (bhslr->bhslr_status_class == 1) {
243 login_handle_redirection(conn, response);
244 log_debugx("redirection handled; exiting");
247 if (bhslr->bhslr_status_class != 0) {
248 errorstr = login_target_error_str(bhslr->bhslr_status_class,
249 bhslr->bhslr_status_detail);
250 fail(conn, errorstr);
251 log_errx(1, "target returned error: %s", errorstr);
253 if (initial == false &&
254 ntohl(bhslr->bhslr_statsn) != conn->conn_statsn + 1) {
256 * It's a warning, not an error, to work around what seems
257 * to be bug in NetBSD iSCSI target.
259 log_warnx("received Login PDU with wrong StatSN: "
260 "is %u, should be %u", ntohl(bhslr->bhslr_statsn),
261 conn->conn_statsn + 1);
263 conn->conn_tsih = ntohs(bhslr->bhslr_tsih);
264 conn->conn_statsn = ntohl(bhslr->bhslr_statsn);
272 login_new_request(struct connection *conn, int csg)
275 struct iscsi_bhs_login_request *bhslr;
278 request = pdu_new(conn);
279 bhslr = (struct iscsi_bhs_login_request *)request->pdu_bhs;
280 bhslr->bhslr_opcode = ISCSI_BHS_OPCODE_LOGIN_REQUEST |
281 ISCSI_BHS_OPCODE_IMMEDIATE;
283 bhslr->bhslr_flags = BHSLR_FLAGS_TRANSIT;
285 case BHSLR_STAGE_SECURITY_NEGOTIATION:
286 nsg = BHSLR_STAGE_OPERATIONAL_NEGOTIATION;
288 case BHSLR_STAGE_OPERATIONAL_NEGOTIATION:
289 nsg = BHSLR_STAGE_FULL_FEATURE_PHASE;
292 assert(!"invalid csg");
293 log_errx(1, "invalid csg %d", csg);
295 login_set_csg(request, csg);
296 login_set_nsg(request, nsg);
298 memcpy(bhslr->bhslr_isid, &conn->conn_isid, sizeof(bhslr->bhslr_isid));
299 bhslr->bhslr_tsih = htons(conn->conn_tsih);
300 bhslr->bhslr_initiator_task_tag = 0;
301 bhslr->bhslr_cmdsn = 0;
302 bhslr->bhslr_expstatsn = htonl(conn->conn_statsn + 1);
308 login_list_prefers(const char *list,
309 const char *choice1, const char *choice2)
311 char *tofree, *str, *token;
313 tofree = str = checked_strdup(list);
315 while ((token = strsep(&str, ",")) != NULL) {
316 if (strcmp(token, choice1) == 0) {
320 if (strcmp(token, choice2) == 0) {
330 login_negotiate_key(struct connection *conn, const char *name,
335 if (strcmp(name, "TargetAlias") == 0) {
336 strlcpy(conn->conn_target_alias, value,
337 sizeof(conn->conn_target_alias));
338 } else if (strcmp(value, "Irrelevant") == 0) {
340 } else if (strcmp(name, "HeaderDigest") == 0) {
341 which = login_list_prefers(value, "CRC32C", "None");
344 log_debugx("target prefers CRC32C "
345 "for header digest; we'll use it");
346 conn->conn_header_digest = CONN_DIGEST_CRC32C;
349 log_debugx("target prefers not to do "
350 "header digest; we'll comply");
353 log_warnx("target sent unrecognized "
354 "HeaderDigest value \"%s\"; will use None", value);
357 } else if (strcmp(name, "DataDigest") == 0) {
358 which = login_list_prefers(value, "CRC32C", "None");
361 log_debugx("target prefers CRC32C "
362 "for data digest; we'll use it");
363 conn->conn_data_digest = CONN_DIGEST_CRC32C;
366 log_debugx("target prefers not to do "
367 "data digest; we'll comply");
370 log_warnx("target sent unrecognized "
371 "DataDigest value \"%s\"; will use None", value);
374 } else if (strcmp(name, "MaxConnections") == 0) {
376 } else if (strcmp(name, "InitialR2T") == 0) {
377 if (strcmp(value, "Yes") == 0)
378 conn->conn_initial_r2t = true;
380 conn->conn_initial_r2t = false;
381 } else if (strcmp(name, "ImmediateData") == 0) {
382 if (strcmp(value, "Yes") == 0)
383 conn->conn_immediate_data = true;
385 conn->conn_immediate_data = false;
386 } else if (strcmp(name, "MaxRecvDataSegmentLength") == 0) {
387 tmp = strtoul(value, NULL, 10);
389 log_errx(1, "received invalid "
390 "MaxRecvDataSegmentLength");
391 if (tmp > ISCSI_MAX_DATA_SEGMENT_LENGTH) {
392 log_debugx("capping MaxRecvDataSegmentLength "
393 "from %d to %d", tmp, ISCSI_MAX_DATA_SEGMENT_LENGTH);
394 tmp = ISCSI_MAX_DATA_SEGMENT_LENGTH;
396 conn->conn_max_data_segment_length = tmp;
397 } else if (strcmp(name, "MaxBurstLength") == 0) {
398 if (conn->conn_immediate_data) {
399 tmp = strtoul(value, NULL, 10);
401 log_errx(1, "received invalid MaxBurstLength");
402 conn->conn_max_burst_length = tmp;
404 } else if (strcmp(name, "FirstBurstLength") == 0) {
405 tmp = strtoul(value, NULL, 10);
407 log_errx(1, "received invalid FirstBurstLength");
408 conn->conn_first_burst_length = tmp;
409 } else if (strcmp(name, "DefaultTime2Wait") == 0) {
411 } else if (strcmp(name, "DefaultTime2Retain") == 0) {
413 } else if (strcmp(name, "MaxOutstandingR2T") == 0) {
415 } else if (strcmp(name, "DataPDUInOrder") == 0) {
417 } else if (strcmp(name, "DataSequenceInOrder") == 0) {
419 } else if (strcmp(name, "ErrorRecoveryLevel") == 0) {
421 } else if (strcmp(name, "OFMarker") == 0) {
423 } else if (strcmp(name, "IFMarker") == 0) {
425 } else if (strcmp(name, "RDMAExtensions") == 0) {
426 if (conn->conn_conf.isc_iser == 1 &&
427 strcmp(value, "Yes") != 0) {
428 log_errx(1, "received unsupported RDMAExtensions");
430 } else if (strcmp(name, "InitiatorRecvDataSegmentLength") == 0) {
431 tmp = strtoul(value, NULL, 10);
433 log_errx(1, "received invalid "
434 "InitiatorRecvDataSegmentLength");
435 if ((size_t)tmp > conn->conn_limits.isl_max_data_segment_length) {
436 log_debugx("capping InitiatorRecvDataSegmentLength "
437 "from %d to %zd", tmp,
438 conn->conn_limits.isl_max_data_segment_length);
439 tmp = conn->conn_limits.isl_max_data_segment_length;
441 conn->conn_max_data_segment_length = tmp;
442 } else if (strcmp(name, "TargetPortalGroupTag") == 0) {
444 } else if (strcmp(name, "TargetRecvDataSegmentLength") == 0) {
445 tmp = strtoul(value, NULL, 10);
448 "received invalid TargetRecvDataSegmentLength");
450 if ((size_t)tmp > conn->conn_limits.isl_max_data_segment_length) {
451 log_debugx("capping TargetRecvDataSegmentLength "
452 "from %d to %zd", tmp,
453 conn->conn_limits.isl_max_data_segment_length);
454 tmp = conn->conn_limits.isl_max_data_segment_length;
456 conn->conn_max_data_segment_length = tmp;
458 log_debugx("unknown key \"%s\"; ignoring", name);
463 login_negotiate(struct connection *conn)
465 struct pdu *request, *response;
466 struct keys *request_keys, *response_keys;
467 struct iscsi_bhs_login_response *bhslr;
468 int i, nrequests = 0;
470 log_debugx("beginning operational parameter negotiation");
471 request = login_new_request(conn, BHSLR_STAGE_OPERATIONAL_NEGOTIATION);
472 request_keys = keys_new();
474 log_debugx("offload \"%s\" limits MaxRecvDataSegmentLength to %zd",
475 conn->conn_conf.isc_offload,
476 conn->conn_limits.isl_max_data_segment_length);
479 * The following keys are irrelevant for discovery sessions.
481 if (conn->conn_conf.isc_discovery == 0) {
482 if (conn->conn_conf.isc_header_digest != 0)
483 keys_add(request_keys, "HeaderDigest", "CRC32C");
485 keys_add(request_keys, "HeaderDigest", "None");
486 if (conn->conn_conf.isc_data_digest != 0)
487 keys_add(request_keys, "DataDigest", "CRC32C");
489 keys_add(request_keys, "DataDigest", "None");
491 keys_add(request_keys, "ImmediateData", "Yes");
492 keys_add_int(request_keys, "MaxBurstLength",
493 2 * conn->conn_limits.isl_max_data_segment_length);
494 keys_add_int(request_keys, "FirstBurstLength",
495 conn->conn_limits.isl_max_data_segment_length);
496 keys_add(request_keys, "InitialR2T", "Yes");
497 keys_add(request_keys, "MaxOutstandingR2T", "1");
498 if (conn->conn_conf.isc_iser == 1) {
499 keys_add_int(request_keys, "InitiatorRecvDataSegmentLength",
500 conn->conn_limits.isl_max_data_segment_length);
501 keys_add_int(request_keys, "TargetRecvDataSegmentLength",
502 conn->conn_limits.isl_max_data_segment_length);
503 keys_add(request_keys, "RDMAExtensions", "Yes");
505 keys_add_int(request_keys, "MaxRecvDataSegmentLength",
506 conn->conn_limits.isl_max_data_segment_length);
509 keys_add(request_keys, "HeaderDigest", "None");
510 keys_add(request_keys, "DataDigest", "None");
511 keys_add_int(request_keys, "MaxRecvDataSegmentLength",
512 conn->conn_limits.isl_max_data_segment_length);
515 keys_add(request_keys, "DefaultTime2Wait", "0");
516 keys_add(request_keys, "DefaultTime2Retain", "0");
517 keys_add(request_keys, "ErrorRecoveryLevel", "0");
518 keys_save(request_keys, request);
519 keys_delete(request_keys);
525 response = login_receive(conn);
526 response_keys = keys_new();
527 keys_load(response_keys, response);
528 for (i = 0; i < KEYS_MAX; i++) {
529 if (response_keys->keys_names[i] == NULL)
532 login_negotiate_key(conn,
533 response_keys->keys_names[i], response_keys->keys_values[i]);
536 keys_delete(response_keys);
537 response_keys = NULL;
540 bhslr = (struct iscsi_bhs_login_response *)response->pdu_bhs;
541 if ((bhslr->bhslr_flags & BHSLR_FLAGS_TRANSIT) != 0)
546 log_warnx("received login response "
547 "without the \"T\" flag too many times; giving up");
551 log_debugx("received login response "
552 "without the \"T\" flag; sending another request");
554 pdu_delete(response);
556 request = login_new_request(conn,
557 BHSLR_STAGE_OPERATIONAL_NEGOTIATION);
561 response = login_receive(conn);
564 if (login_nsg(response) != BHSLR_STAGE_FULL_FEATURE_PHASE)
565 log_warnx("received final login response with wrong NSG 0x%x",
566 login_nsg(response));
567 pdu_delete(response);
569 log_debugx("operational parameter negotiation done; "
570 "transitioning to Full Feature phase");
574 login_send_chap_a(struct connection *conn)
577 struct keys *request_keys;
579 request = login_new_request(conn, BHSLR_STAGE_SECURITY_NEGOTIATION);
580 request_keys = keys_new();
581 keys_add(request_keys, "CHAP_A", "5");
582 keys_save(request_keys, request);
583 keys_delete(request_keys);
589 login_send_chap_r(struct pdu *response)
591 struct connection *conn;
593 struct keys *request_keys, *response_keys;
595 const char *chap_a, *chap_c, *chap_i;
598 char *mutual_chap_c, *mutual_chap_i;
601 * As in the rest of the initiator, 'request' means
602 * 'initiator -> target', and 'response' means 'target -> initiator',
604 * So, here the 'response' from the target is the packet that contains
605 * CHAP challenge; our CHAP response goes into 'request'.
608 conn = response->pdu_connection;
610 response_keys = keys_new();
611 keys_load(response_keys, response);
614 * First, compute the response.
616 chap_a = keys_find(response_keys, "CHAP_A");
618 log_errx(1, "received CHAP packet without CHAP_A");
619 chap_c = keys_find(response_keys, "CHAP_C");
621 log_errx(1, "received CHAP packet without CHAP_C");
622 chap_i = keys_find(response_keys, "CHAP_I");
624 log_errx(1, "received CHAP packet without CHAP_I");
626 if (strcmp(chap_a, "5") != 0) {
627 log_errx(1, "received CHAP packet "
628 "with unsupported CHAP_A \"%s\"", chap_a);
631 rchap = rchap_new(conn->conn_conf.isc_secret);
632 error = rchap_receive(rchap, chap_i, chap_c);
634 log_errx(1, "received CHAP packet "
635 "with malformed CHAP_I or CHAP_C");
637 chap_r = rchap_get_response(rchap);
640 keys_delete(response_keys);
642 request = login_new_request(conn, BHSLR_STAGE_SECURITY_NEGOTIATION);
643 request_keys = keys_new();
644 keys_add(request_keys, "CHAP_N", conn->conn_conf.isc_user);
645 keys_add(request_keys, "CHAP_R", chap_r);
649 * If we want mutual authentication, we're expected to send
650 * our CHAP_I/CHAP_C now.
652 if (conn->conn_conf.isc_mutual_user[0] != '\0') {
653 log_debugx("requesting mutual authentication; "
654 "binary challenge size is %zd bytes",
655 sizeof(conn->conn_mutual_chap->chap_challenge));
657 assert(conn->conn_mutual_chap == NULL);
658 conn->conn_mutual_chap = chap_new();
659 mutual_chap_i = chap_get_id(conn->conn_mutual_chap);
660 mutual_chap_c = chap_get_challenge(conn->conn_mutual_chap);
661 keys_add(request_keys, "CHAP_I", mutual_chap_i);
662 keys_add(request_keys, "CHAP_C", mutual_chap_c);
667 keys_save(request_keys, request);
668 keys_delete(request_keys);
674 login_verify_mutual(const struct pdu *response)
676 struct connection *conn;
677 struct keys *response_keys;
678 const char *chap_n, *chap_r;
681 conn = response->pdu_connection;
683 response_keys = keys_new();
684 keys_load(response_keys, response);
686 chap_n = keys_find(response_keys, "CHAP_N");
688 log_errx(1, "received CHAP Response PDU without CHAP_N");
689 chap_r = keys_find(response_keys, "CHAP_R");
691 log_errx(1, "received CHAP Response PDU without CHAP_R");
693 error = chap_receive(conn->conn_mutual_chap, chap_r);
695 log_errx(1, "received CHAP Response PDU with invalid CHAP_R");
697 if (strcmp(chap_n, conn->conn_conf.isc_mutual_user) != 0) {
698 fail(conn, "Mutual CHAP failed");
699 log_errx(1, "mutual CHAP authentication failed: wrong user");
702 error = chap_authenticate(conn->conn_mutual_chap,
703 conn->conn_conf.isc_mutual_secret);
705 fail(conn, "Mutual CHAP failed");
706 log_errx(1, "mutual CHAP authentication failed: wrong secret");
709 keys_delete(response_keys);
710 chap_delete(conn->conn_mutual_chap);
711 conn->conn_mutual_chap = NULL;
713 log_debugx("mutual CHAP authentication succeeded");
717 login_chap(struct connection *conn)
719 struct pdu *response;
721 log_debugx("beginning CHAP authentication; sending CHAP_A");
722 login_send_chap_a(conn);
724 log_debugx("waiting for CHAP_A/CHAP_C/CHAP_I");
725 response = login_receive(conn);
727 log_debugx("sending CHAP_N/CHAP_R");
728 login_send_chap_r(response);
729 pdu_delete(response);
732 * XXX: Make sure this is not susceptible to MITM.
735 log_debugx("waiting for CHAP result");
736 response = login_receive(conn);
737 if (conn->conn_conf.isc_mutual_user[0] != '\0')
738 login_verify_mutual(response);
739 pdu_delete(response);
741 log_debugx("CHAP authentication done");
745 login(struct connection *conn)
747 struct pdu *request, *response;
748 struct keys *request_keys, *response_keys;
749 struct iscsi_bhs_login_response *bhslr2;
750 const char *auth_method;
753 log_debugx("beginning Login phase; sending Login PDU");
754 request = login_new_request(conn, BHSLR_STAGE_SECURITY_NEGOTIATION);
755 request_keys = keys_new();
756 if (conn->conn_conf.isc_mutual_user[0] != '\0') {
757 keys_add(request_keys, "AuthMethod", "CHAP");
758 } else if (conn->conn_conf.isc_user[0] != '\0') {
760 * Give target a chance to skip authentication if it
761 * doesn't feel like it.
763 * None is first, CHAP second; this is to work around
764 * what seems to be LIO (Linux target) bug: otherwise,
765 * if target is configured with no authentication,
766 * and we are configured to authenticate, the target
767 * will erroneously respond with AuthMethod=CHAP
768 * instead of AuthMethod=None, and will subsequently
769 * fail the connection. This usually happens with
770 * Discovery sessions, which default to no authentication.
772 keys_add(request_keys, "AuthMethod", "None,CHAP");
774 keys_add(request_keys, "AuthMethod", "None");
776 keys_add(request_keys, "InitiatorName",
777 conn->conn_conf.isc_initiator);
778 if (conn->conn_conf.isc_initiator_alias[0] != '\0') {
779 keys_add(request_keys, "InitiatorAlias",
780 conn->conn_conf.isc_initiator_alias);
782 if (conn->conn_conf.isc_discovery == 0) {
783 keys_add(request_keys, "SessionType", "Normal");
784 keys_add(request_keys,
785 "TargetName", conn->conn_conf.isc_target);
787 keys_add(request_keys, "SessionType", "Discovery");
789 keys_save(request_keys, request);
790 keys_delete(request_keys);
794 response = login_receive(conn);
796 response_keys = keys_new();
797 keys_load(response_keys, response);
799 for (i = 0; i < KEYS_MAX; i++) {
800 if (response_keys->keys_names[i] == NULL)
804 * Not interested in AuthMethod at this point; we only need
805 * to parse things such as TargetAlias.
807 * XXX: This is somewhat ugly. We should have a way to apply
808 * all the keys to the session and use that by default
809 * instead of discarding them.
811 if (strcmp(response_keys->keys_names[i], "AuthMethod") == 0)
814 login_negotiate_key(conn,
815 response_keys->keys_names[i], response_keys->keys_values[i]);
818 bhslr2 = (struct iscsi_bhs_login_response *)response->pdu_bhs;
819 if ((bhslr2->bhslr_flags & BHSLR_FLAGS_TRANSIT) != 0 &&
820 login_nsg(response) == BHSLR_STAGE_OPERATIONAL_NEGOTIATION) {
821 if (conn->conn_conf.isc_mutual_user[0] != '\0') {
822 log_errx(1, "target requested transition "
823 "to operational parameter negotiation, "
824 "but we require mutual CHAP");
827 log_debugx("target requested transition "
828 "to operational parameter negotiation");
829 keys_delete(response_keys);
830 pdu_delete(response);
831 login_negotiate(conn);
835 auth_method = keys_find(response_keys, "AuthMethod");
836 if (auth_method == NULL)
837 log_errx(1, "received response without AuthMethod");
838 if (strcmp(auth_method, "None") == 0) {
839 if (conn->conn_conf.isc_mutual_user[0] != '\0') {
840 log_errx(1, "target does not require authantication, "
841 "but we require mutual CHAP");
844 log_debugx("target does not require authentication");
845 keys_delete(response_keys);
846 pdu_delete(response);
847 login_negotiate(conn);
851 if (strcmp(auth_method, "CHAP") != 0) {
852 fail(conn, "Unsupported AuthMethod");
853 log_errx(1, "received response "
854 "with unsupported AuthMethod \"%s\"", auth_method);
857 if (conn->conn_conf.isc_user[0] == '\0' ||
858 conn->conn_conf.isc_secret[0] == '\0') {
859 fail(conn, "Authentication required");
860 log_errx(1, "target requests CHAP authentication, but we don't "
861 "have user and secret");
864 keys_delete(response_keys);
865 response_keys = NULL;
866 pdu_delete(response);
870 login_negotiate(conn);