]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Improve performance by using dmu_tx_hold_*_by_dnode()
authorMatthew Ahrens <mahrens@delphix.com>
Tue, 30 Jul 2019 16:18:30 +0000 (09:18 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Tue, 30 Jul 2019 16:18:30 +0000 (09:18 -0700)
commit0eb8ba6ab68801d4b0e6280e7388514a6355fc86
tree0c93c95bc24643bb354a3f4ebfd511b3ac3d82fa
parent1e620c98727a5a5cff1af70fef9bc25626b4e9d8
Improve performance by using dmu_tx_hold_*_by_dnode()

In zfs_write() and dmu_tx_hold_sa(), we can use dmu_tx_hold_*_by_dnode()
instead of dmu_tx_hold_*(), since we already have a dbuf from the target
dnode in hand.  This eliminates some calls to dnode_hold(), which can be
expensive.  This is especially impactful if several threads are
accessing objects that are in the same block of dnodes, because they
will contend for that dbuf's lock.

We are seeing 10-20% performance wins for the sequential_writes tests in
the performance test suite, when doing >=128K writes to files with
recordsize=8K.

This also removes some unnecessary casts that are in the area.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #9081
module/zfs/dmu_tx.c
module/zfs/sa.c
module/zfs/zfs_vnops.c