]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Stop setting if_linkmib in vlan(4) ifnets.
authormarkj <markj@FreeBSD.org>
Wed, 9 Jan 2019 16:47:16 +0000 (16:47 +0000)
committermarkj <markj@FreeBSD.org>
Wed, 9 Jan 2019 16:47:16 +0000 (16:47 +0000)
commit28d21deef8f51235b82a6921c55de8a3efdcb0f6
treeb30f4f2984172be388b333eacee48fdedf06627a
parent8bbf7468c52ce033e623a1df6c6f1791b1cb8ee3
Stop setting if_linkmib in vlan(4) ifnets.

There are several reasons:
- The structure being exported via IFDATA_LINKSPECIFIC doesn't appear
  to be a standard MIB.
- The structure being exported is private to the kernel and always
  has been.
- No other drivers in common use set the if_linkmib field.
- Because IFDATA_LINKSPECIFIC can be used to overwrite the linkmib
  structure, a privileged user could use it to corrupt internal
  vlan(4) state. [1]

PR: 219472
Reported by: CTurt <ecturt@gmail.com> [1]
Reviewed by: kp (previous version)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D18779
sys/net/if_vlan.c