]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
smb: fix SMB_READB, SMB_READW, SMB_PCALL to work as documented
authoravg <avg@FreeBSD.org>
Fri, 11 Nov 2016 14:41:02 +0000 (14:41 +0000)
committeravg <avg@FreeBSD.org>
Fri, 11 Nov 2016 14:41:02 +0000 (14:41 +0000)
commit3ebb6d29511774a74e04de9f34961ff9e590f9e1
treecae1cc3a71ad493424ed5bd893857096362d679d
parent9680845cca80c80a47eacaeb206d71f9e4482ae6
smb: fix SMB_READB, SMB_READW, SMB_PCALL to work as documented

Previously, those ioctls were defined as 'in' only, so rdata.byte and
rdata.word were never updated in the userland.  The read data went only
to rbuf if it was provided.  Thus, consumers were forced to always use it.

Now the ioctls are marked as in-out.
Compatibility handlers are provided for old ioctls.

PR: 213481
Reported by: Lewis Donzis <lew@perftech.com>
MFC after: 2 weeks
Relnotes: maybe
Differential Revision: https://reviews.freebsd.org/D8430
sys/dev/smbus/smb.c
sys/dev/smbus/smb.h