]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
ufs/extattr.h: Fix documentation of ea_name termination
authorcem <cem@FreeBSD.org>
Wed, 18 Jan 2017 17:55:49 +0000 (17:55 +0000)
committercem <cem@FreeBSD.org>
Wed, 18 Jan 2017 17:55:49 +0000 (17:55 +0000)
commit4d542f9fe888f3a1d5db9f54becd88b26308ff07
treec6ea260b6be6bfc545d0eeaea233f128224f8c3f
parent7de7dabf523e0d0f9884aa169afbda2a07cd6d2a
ufs/extattr.h: Fix documentation of ea_name termination

The ea_name string is not nul-terminated.  Correct the documentation.

Because the subsequent field is padded to 8 bytes, and the padding is
zeroed, the ea_name string will appear to be nul-terminated whenever the
length isn't exactly one (mod eight).

This was introduced in r167010 (2007).

Additionally, mark the length fields as unsigned.  This particularly
matters for the single byte ea_namelength field, which can represent
extended attribute names up to 255 bytes long.

No functional change.

PR: 216127
Reported by: dewayne at heuristicsystems.com.au
Reviewed by: kib@
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D9206
share/man/man5/fs.5
sys/ufs/ufs/extattr.h