pkg(7): address minor nits (mostly clang-analyze complaints)

pkg(7): address minor nits (mostly clang-analyze complaints)

- One (1) spurious whitespace.
- One (1) occurrence of "random(3) bad, arc4random(3)" good.
- Three (3) writes that will never be seen.

The latter two points are complaints from clang-analyze. Switching to
arc4random(3) is decidedly a good idea because we weren't doing any kind
of PRNG seeding anyways. The discarded assignments are arguably good
for future-proofing, but it's better to improve the S/N ratio from
clang-analyze.

Approved by:	re (gjb)

(cherry picked from commit b2c4ca8d2872bc4410626f2b1ceafa49de5828ce)
(cherry picked from commit 9ec09b04df17b3601e6f5ae8664c6ab81e1e4783)