]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
diff: Don't (ab)use sprintf() as a kind of strcat().
authorJohn Baldwin <jhb@FreeBSD.org>
Wed, 16 Nov 2022 03:17:36 +0000 (19:17 -0800)
committerJohn Baldwin <jhb@FreeBSD.org>
Wed, 16 Nov 2022 03:17:36 +0000 (19:17 -0800)
commit6100374ccf2644d3fd233bde8b8f4e73d9953c30
treedde186b3b5d945ba2db8e73cb217539b72872a03
parent4e0771714d6192119dcf7553b921bf88866d8925
diff: Don't (ab)use sprintf() as a kind of strcat().

Previously print_header() used sprintf() of a buffer to itself as a
kind of string builder but without checking for overflows.  This
raised -Wformat-truncation and -Wrestrict warnings in GCC.  Instead,
just conditionally print the new timestamp fields after the initial
strftime()-formatted string.  While here, use sizeof(buf) with
strftime() rather than a magic number.

Reviewed by: bapt
Differential Revision: https://reviews.freebsd.org/D36814
usr.bin/diff/diffreg.c