]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
SHA2Init() should use signed assertions when checking an enum
authorRichard Yao <richard.yao@alumni.stonybrook.edu>
Sat, 4 Mar 2023 20:53:58 +0000 (15:53 -0500)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 6 Mar 2023 23:26:43 +0000 (15:26 -0800)
commit8846139b45ff2ddd416f1a8b6227862e519898fc
treef63338522200783237ffeacf85e81b199b2d4696
parent47119d60eff666b7da4d230054cf8a113baf9b92
SHA2Init() should use signed assertions when checking an enum

The recent 4c5fec01a48acc184614ab8735e6954961990235 commit caused
Coverity to report that ASSERT3U(algotype, >=, SHA256_MECH_INFO_TYPE);
is always true. That is because the signed algotype and signed
SHA256_MECH_INFO_TYPE values were cast to unsigned types. To fix this,
we switch the assertions to use ASSERT3S(), which retains the signedness
of the original values for the comparison.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reported-by: Coverity (CID-1535300)
Closes #14573
module/icp/algs/sha2/sha2_generic.c