]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Remove a potential panic condition introduced by reduced TCP wait
authorRobert Watson <rwatson@FreeBSD.org>
Thu, 10 Apr 2003 20:33:10 +0000 (20:33 +0000)
committerRobert Watson <rwatson@FreeBSD.org>
Thu, 10 Apr 2003 20:33:10 +0000 (20:33 +0000)
commitcacd79e2c9f9c3c7a98f7b9e884b0eb5b1d02f1f
tree027d8706a8bea770ce4e8c638bda86ace427ad7e
parentcbd0150530f3f91a83f3aff3899d5dc046a58cda
Remove a potential panic condition introduced by reduced TCP wait
state.  Those changed attempted to work around the changed invariant
that inp->in_socket was sometimes now NULL, but the logic wasn't
quite right, meaning that inp->in_socket would be dereferenced by
cr_canseesocket() if security.bsd.see_other_uids, jail, or MAC
were in use.  Attempt to clarify and correct the logic.

Note: the work-around originally introduced with the reduced TCP
wait state handling to use cr_cansee() instead of cr_canseesocket()
in this case isn't really right, although it "Does the right thing"
for most of the cases in the base system.  We'll need to address
this at some point in the future.

Pointed out by: dcs
Obtained from: TrustedBSD Project
Sponsored by: DARPA, Network Associates Laboratories
sys/netinet/tcp_subr.c
sys/netinet/tcp_timewait.c