]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Remove sbinsertoob(), sbinsertoob_locked(). They violate (and have
authorRobert Watson <rwatson@FreeBSD.org>
Sat, 17 Jun 2006 22:48:34 +0000 (22:48 +0000)
committerRobert Watson <rwatson@FreeBSD.org>
Sat, 17 Jun 2006 22:48:34 +0000 (22:48 +0000)
commitcd3a3a269fdd1c16c55fce9c48d107cc760a9988
treeb5105f3d5dc063a772657e2b7eebc5923364ee33
parent5ce609a3e12715f081c6e4bd44b70d1229fe1f1b
Remove sbinsertoob(), sbinsertoob_locked().  They violate (and have
basically always violated) invariannts of soreceive(), which assume
that the first mbuf pointer in a receive socket buffer can't change
while the SB_LOCK sleepable lock is held on the socket buffer,
which is precisely what these functions do.  No current protocols
invoke these functions, and removing them will help discourage them
from ever being used.  I should have removed them years ago, but
lost track of it.

MFC after: 1 week
Prodded almost by accident by: peter
sys/kern/uipc_sockbuf.c
sys/kern/uipc_socket2.c
sys/sys/socketvar.h