]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
dtrace/fbt: fix return probe arguments on arm
authoravg <avg@FreeBSD.org>
Tue, 21 Jul 2020 07:41:36 +0000 (07:41 +0000)
committeravg <avg@FreeBSD.org>
Tue, 21 Jul 2020 07:41:36 +0000 (07:41 +0000)
commitda92170709cbce6ad57572d9b10bfffc9f6819eb
treec94037059b92d718a3e463ac9e066ae5a2ad3cfc
parent68e5b21917963443360ccec8cd297d52f6840511
dtrace/fbt: fix return probe arguments on arm

arg0 should be an offset of the return point within the function, arg1
should be the return value.  Previously the return probe had arguments as
if for the entry probe.

Tested on armv7.

andrew noted that the same problem seems to be present on arm64, mips,
and riscv.
I am not sure if I will get around to fixing those.  So, platform users
or anyone looking to make a contribution please be aware of this
opportunity.

Reviewed by: markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D25685
sys/cddl/dev/dtrace/arm/dtrace_subr.c
sys/cddl/dev/fbt/arm/fbt_isa.c