]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
[ofw] fix errneous checks for OF_finddevice(9) return value
authorgonzo <gonzo@FreeBSD.org>
Tue, 20 Mar 2018 00:03:49 +0000 (00:03 +0000)
committergonzo <gonzo@FreeBSD.org>
Tue, 20 Mar 2018 00:03:49 +0000 (00:03 +0000)
commitee59b6a5e7f12cd415e4da9cc453a51aaa1aff10
tree35821278566f932eed35ee949df3ea3e14a796a3
parentb5f2c5035d42fa10c839b0de6c21b6157d1e3ae5
[ofw] fix errneous checks for OF_finddevice(9) return value

OF_finddevices returns ((phandle_t)-1) in case of failure. Some code
in existing drivers checked return value to be equal to 0 or
less/equal to 0 which is also wrong because phandle_t is unsigned
type. Most of these checks were for negative cases that were never
triggered so trhere was no impact on functionality.

Reviewed by: nwhitehorn
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D14645
21 files changed:
sys/arm/amlogic/aml8726/aml8726_clkmsr.c
sys/arm/amlogic/aml8726/aml8726_mp.c
sys/arm/amlogic/aml8726/aml8726_usb_phy-m3.c
sys/arm/annapurna/alpine/alpine_machdep.c
sys/arm/broadcom/bcm2835/bcm2835_fb.c
sys/arm/broadcom/bcm2835/bcm2835_fbd.c
sys/arm/broadcom/bcm2835/bcm2835_machdep.c
sys/arm/freescale/fsl_ocotp.c
sys/arm/freescale/vybrid/vf_machdep.c
sys/arm/mv/mv_common.c
sys/arm/samsung/exynos/chrome_ec.c
sys/arm/samsung/exynos/exynos5_ehci.c
sys/arm/ti/am335x/am335x_lcd.c
sys/arm/ti/am335x/am335x_lcd_syscons.c
sys/dev/fdt/fdt_common.c
sys/dev/ofw/ofw_subr.c
sys/dev/ofw/openfirmio.c
sys/dev/ow/owc_gpiobus.c
sys/dev/vnic/thunder_bgx_fdt.c
sys/powerpc/cpufreq/mpc85xx_jog.c
sys/powerpc/pseries/platform_chrp.c