]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
MFC 323630: Avoid reusing the wrong buffer for a DDP AIO request.
authorjhb <jhb@FreeBSD.org>
Thu, 21 Sep 2017 23:10:59 +0000 (23:10 +0000)
committerjhb <jhb@FreeBSD.org>
Thu, 21 Sep 2017 23:10:59 +0000 (23:10 +0000)
commitfce10b30fadda47ff6a223a77a8c07e13756f642
tree96eded014d1cee59433886a120f51908c04db731
parent82925f9c9f03b31d8520c344e2f5b3da8b4707ff
MFC 323630: Avoid reusing the wrong buffer for a DDP AIO request.

To optimize the case of ping-ponging between two buffers, the DDP code
caches the last two buffers used keeping the pages wired and page pods
stored in the NIC's RAM.  If a new aio_read() request uses one of the
same buffers, then the work of holding pages, etc. can be avoided.
However, the starting virtual address of an aio buffer was not saved,
only the page count, length, and initial page offset.  Thus, an
aio_read() request could match a different buffer in the address
space.  (Earlier during development vm_fault_hold_quick_pages() was
always called and the vm_page_t values were compared, but that was
eventually removed without being adequately replaced.)  Fix by storing
the starting virtual address and comparing that (along with other
fields) to determine if a buffer can be reused.

Sponsored by: Chelsio Communications
sys/dev/cxgbe/tom/t4_ddp.c
sys/dev/cxgbe/tom/t4_tom.h