]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/log
FreeBSD/FreeBSD.git
20 years agoBump FreeBSD_version for getopt_long_only() adding
ache [Wed, 25 Feb 2004 01:27:32 +0000 (01:27 +0000)]
Bump FreeBSD_version for getopt_long_only() adding

20 years agoNo reason to disable this test on powerpc.
grehan [Wed, 25 Feb 2004 00:53:06 +0000 (00:53 +0000)]
No reason to disable this test on powerpc.

20 years agoUse signed char cast to avoid out-of-range error on PowerPC (which has
grehan [Wed, 25 Feb 2004 00:52:14 +0000 (00:52 +0000)]
Use signed char cast to avoid out-of-range error on PowerPC (which has
unsigned char by default). This is a no-op on all other current arches.

Tested by: md5 sum before/after same on i386

20 years agoo Use `I-O DATA' instead of `IO DATA' as the vendor uses the former
non [Wed, 25 Feb 2004 00:13:43 +0000 (00:13 +0000)]
o Use `I-O DATA' instead of `IO DATA' as the vendor uses the former
  on its own site (http://www.iodata.jp/).
o Add a missing cross reference to cardbus(4).

Submitted by: rushani

20 years agoAdd DDB_NUMSYM option which in addition to the symbolic representation
phk [Tue, 24 Feb 2004 22:51:42 +0000 (22:51 +0000)]
Add DDB_NUMSYM option which in addition to the symbolic representation
also prints the actual numerical value of the symbol in question.

Users of addr2line(1) will be less proficient in hex arithmetic as a
consequence.

This amongst other things means that traceback lines change from:
   siointr1(c4016800,c073bda0,0,c06b699c,69f) at siointr1+0xc5
to
   siointr1(c4016800,c073bda0,0,c06b699c,69f) at 0xc062b0bd = siointr1+0xc5

I made this an option to avoid bikesheds.
~
~
~

20 years agoUnconst. Somebody didn't compile LINT.
phk [Tue, 24 Feb 2004 22:16:40 +0000 (22:16 +0000)]
Unconst.  Somebody didn't compile LINT.

20 years ago- Clarify ambiguous statement about not being able to both slock and xlock
jhb [Tue, 24 Feb 2004 21:36:39 +0000 (21:36 +0000)]
- Clarify ambiguous statement about not being able to both slock and xlock
  a single lock at the same time.
- Avoid using "own" to refer to holding either a shared or exclusive lock
  as it is only really correct for exclusive locks.
- Reword the sentence about sleep-ability to read easier.

Requested by: truckman (1)

20 years agoHave edquota honour MAXLOGNAME rather than hardcoding the maximum
ceri [Tue, 24 Feb 2004 20:58:16 +0000 (20:58 +0000)]
Have edquota honour MAXLOGNAME rather than hardcoding the maximum
username length to 29 characters.

PR: misc/62944
Submitted by: David Hill <david@wmol.com>
Approved by: ru
MFC after: 1 week

20 years agostyle.Makefile(5):
johan [Tue, 24 Feb 2004 20:52:58 +0000 (20:52 +0000)]
style.Makefile(5):
Use WARNS?= instead of WARNS=.

20 years agostyle.Makefile(5):
johan [Tue, 24 Feb 2004 20:51:20 +0000 (20:51 +0000)]
style.Makefile(5):
Use WARNS?= instead of WARNS=.

While I'm here,
use INTERNALPROG, instead if overriding install
remove emty lines

20 years agoWhitespace cleanup
des [Tue, 24 Feb 2004 19:31:30 +0000 (19:31 +0000)]
Whitespace cleanup

20 years agostyle.Makefile(5):
johan [Tue, 24 Feb 2004 19:23:33 +0000 (19:23 +0000)]
style.Makefile(5):
Use WARNS?= instead of WARNS=

For this to work properly for all part is the subdirectories
the WARNS assignments in Makefile.inc0 are moved to the correspondning
Makefile.inc.

Approved by: obrien (binutils maintainer)
Tested by: make universe

20 years agoCheck that a pointer is non-NULL before dereferencing it, not after.
cperciva [Tue, 24 Feb 2004 18:01:43 +0000 (18:01 +0000)]
Check that a pointer is non-NULL before dereferencing it, not after.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoNote change of sizeof(struct tcpcb) and libkvm recompile.
andre [Tue, 24 Feb 2004 16:12:09 +0000 (16:12 +0000)]
Note change of sizeof(struct tcpcb) and libkvm recompile.

20 years agoin icmp6_mtudisc_update(), use ND link mtu to detect if the path MTU
ume [Tue, 24 Feb 2004 15:40:55 +0000 (15:40 +0000)]
in icmp6_mtudisc_update(), use ND link mtu to detect if the path MTU
should be updated.

Helped by: andre

20 years agoConvert the tcp segment reassembly queue to UMA and limit the maximum
andre [Tue, 24 Feb 2004 15:27:41 +0000 (15:27 +0000)]
Convert the tcp segment reassembly queue to UMA and limit the maximum
amount of segments it will hold.

The following tuneables and sysctls control the behaviour of the tcp
segment reassembly queue:

 net.inet.tcp.reass.maxsegments (loader tuneable)
  specifies the maximum number of segments all tcp reassemly queues can
  hold (defaults to 1/16 of nmbclusters).

 net.inet.tcp.reass.maxqlen
  specifies the maximum number of segments any individual tcp session queue
  can hold (defaults to 48).

 net.inet.tcp.reass.cursegments (readonly)
  counts the number of segments currently in all reassembly queues.

 net.inet.tcp.reass.overflows (readonly)
  counts how often either the global or local queue limit has been reached.

Tested by: bms, silby
Reviewed by: bms, silby

20 years agoWordsmithing
brueffer [Tue, 24 Feb 2004 15:00:03 +0000 (15:00 +0000)]
Wordsmithing

20 years agoDo not attempt to open NODEV
phk [Tue, 24 Feb 2004 09:59:35 +0000 (09:59 +0000)]
Do not attempt to open NODEV

20 years agoAdd getopt_long_only()
ache [Tue, 24 Feb 2004 08:09:20 +0000 (08:09 +0000)]
Add getopt_long_only()

20 years agoAdd getopt_long_only() from OpenBSD and other OpenBSD cleanups
ache [Tue, 24 Feb 2004 08:07:26 +0000 (08:07 +0000)]
Add getopt_long_only() from OpenBSD and other OpenBSD cleanups

PR:             63173
Submitted by:   Marius Strobl <marius@alchemy.franken.de>

20 years agoDon't set d_flags twice. The second setting clobbered D_NOGIANT.
bde [Tue, 24 Feb 2004 04:35:44 +0000 (04:35 +0000)]
Don't set d_flags twice.  The second setting clobbered D_NOGIANT.

20 years agoFixed the latest unsortings of CPU_ENABLE_*.
bde [Tue, 24 Feb 2004 04:18:07 +0000 (04:18 +0000)]
Fixed the latest unsortings of CPU_ENABLE_*.

20 years agoFixed missing libraries. This unbreaks the -DNO_DYNAMIC_ROOT and
bde [Tue, 24 Feb 2004 03:46:12 +0000 (03:46 +0000)]
Fixed missing libraries.  This unbreaks the -DNO_DYNAMIC_ROOT and
-DNOSHARED=yes cases.

20 years agoSend birthday presents to Wadham College, Oxford. :)
cperciva [Tue, 24 Feb 2004 01:44:47 +0000 (01:44 +0000)]
Send birthday presents to Wadham College, Oxford. :)

Approved by: rwatson (mentor)

20 years agoFix array overflow: If len=128, don't access [16] of a 16-byte IPv6
cperciva [Tue, 24 Feb 2004 01:20:51 +0000 (01:20 +0000)]
Fix array overflow: If len=128, don't access [16] of a 16-byte IPv6
address, even if we subsequently ignore its value by applying a >>8
to it.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor), {ume, suz} (KAME)

20 years agoPAO's work has been merged into FreeBSD not removed.
non [Mon, 23 Feb 2004 23:47:50 +0000 (23:47 +0000)]
PAO's work has been merged into FreeBSD not removed.
So remove the line.

Reviewed by: trhodes

20 years agoFix typo.
phk [Mon, 23 Feb 2004 23:39:42 +0000 (23:39 +0000)]
Fix typo.

Found by: imp

20 years agoFix typo
brueffer [Mon, 23 Feb 2004 22:00:44 +0000 (22:00 +0000)]
Fix typo

20 years agoApply style(9).
green [Mon, 23 Feb 2004 20:42:03 +0000 (20:42 +0000)]
Apply style(9).

Submitted by: "Christian S.J. Peron" <maneo@bsdpro.com>
PR: bin/63283

20 years agoAdd my birthday.
markus [Mon, 23 Feb 2004 20:39:23 +0000 (20:39 +0000)]
Add my birthday.

Approved by: arved (mentor)

20 years agostyle.Makefile(5):
johan [Mon, 23 Feb 2004 20:25:27 +0000 (20:25 +0000)]
style.Makefile(5):
Use WARNS?= instead of WARNS=.

20 years agoAdd support for Cronyx-Tau. For now I added only Tau-ISA files, system files
rik [Mon, 23 Feb 2004 20:19:00 +0000 (20:19 +0000)]
Add support for Cronyx-Tau. For now I added only Tau-ISA files, system files
would be changed in next patches, after extra verifications.

Approved by: imp (mentor)

20 years agostyle.Makefile:
johan [Mon, 23 Feb 2004 20:07:47 +0000 (20:07 +0000)]
style.Makefile:
Use WARNS?= instead of WARNS=.

20 years agoConnect gconcat(8) to the build.
pjd [Mon, 23 Feb 2004 20:06:56 +0000 (20:06 +0000)]
Connect gconcat(8) to the build.

Approved by: scottl (mentor)

20 years ago- Connect manual page for gconcat utility to the build.
pjd [Mon, 23 Feb 2004 20:06:21 +0000 (20:06 +0000)]
- Connect manual page for gconcat utility to the build.
- Fix usage.

Approved by: scottl (mentor) (implicity)

20 years agostyle.Makefile:
johan [Mon, 23 Feb 2004 20:05:14 +0000 (20:05 +0000)]
style.Makefile:
Use WARNS?= instead of WARNS=

20 years agoConnect geom_concat.ko module to the build.
pjd [Mon, 23 Feb 2004 20:03:53 +0000 (20:03 +0000)]
Connect geom_concat.ko module to the build.

Approved by: scottl (mentor)

20 years agoAdd ports-net-mgmt to the relevant supfiles.
marcus [Mon, 23 Feb 2004 19:07:47 +0000 (19:07 +0000)]
Add ports-net-mgmt to the relevant supfiles.

MFC after: 4 days

20 years agoA more accurate test in the new ufs_lock than that in 1.235.
mckusick [Mon, 23 Feb 2004 19:05:05 +0000 (19:05 +0000)]
A more accurate test in the new ufs_lock than that in 1.235.

20 years agoTeach rfcomm_pppd(8) how to register Bluetooth LAN service with local sdpd(8)
emax [Mon, 23 Feb 2004 17:30:59 +0000 (17:30 +0000)]
Teach rfcomm_pppd(8) how to register Bluetooth LAN service with local sdpd(8)
Add -u(unit) option

Reviewed by: imp (mentor), ru

20 years agoFix a problem with the USB keyboard driver not properly handling key
jhb [Mon, 23 Feb 2004 15:36:40 +0000 (15:36 +0000)]
Fix a problem with the USB keyboard driver not properly handling key
rollover resulting in duplicate keypress events.

PR: 57273
PR: 63171
Submitted by: plasma <plasma at freebsd.sinica.edu.tw>
Submitted by: Brian Candler <B.Candler at pobox.com>
MFC after: 1 week

20 years agoAdd missed CPU_ENABLE_LONGRON.
sobomax [Mon, 23 Feb 2004 14:49:15 +0000 (14:49 +0000)]
Add missed CPU_ENABLE_LONGRON.

Submitted by: Jon Noack <noackjr@alumni.rice.edu>

20 years agoAdd signal numbers to signal(3).
josef [Mon, 23 Feb 2004 13:20:03 +0000 (13:20 +0000)]
Add signal numbers to signal(3).

Approved by:    simon(mentor)
Reviewed by:    ru
Submitted by:   Stefan Farfeleder <stefan@fafoe.narf.at>
PR:             docs/60044

20 years agoAdded manual page for gconcat utility.
pjd [Mon, 23 Feb 2004 12:44:08 +0000 (12:44 +0000)]
Added manual page for gconcat utility.

Approved by: scottl (mentor) (implicity)
Reviewed by: simon

20 years agoTypo.
des [Mon, 23 Feb 2004 09:08:27 +0000 (09:08 +0000)]
Typo.

20 years agoFix vinums cdevsw{} to initialize d_version.
phk [Mon, 23 Feb 2004 08:55:13 +0000 (08:55 +0000)]
Fix vinums cdevsw{} to initialize d_version.

The nonstandard formatting made my mega-patch scripts miss it.

Retire the static major number while we're here anyway.

Reported by: Niels Chr. Bank-Pedersen <ncbp@bank-pedersen.dk>

20 years agoFix two oversights here: don't trash the freelist, and properly cleanup
phk [Mon, 23 Feb 2004 08:42:55 +0000 (08:42 +0000)]
Fix two oversights here:  don't trash the freelist, and properly cleanup
the cdevsw{}.

Submitted by: tegge

20 years agoIn the comment tell about optreset extension for NetBSD ghetopt_long()
ache [Mon, 23 Feb 2004 08:14:18 +0000 (08:14 +0000)]
In the comment tell about optreset extension for NetBSD ghetopt_long()

20 years agoIn the function clear_inodedeps(), a FREE_LOCK() should be called
mckusick [Mon, 23 Feb 2004 06:56:31 +0000 (06:56 +0000)]
In the function clear_inodedeps(), a FREE_LOCK() should be called
AFTER the call to vn_start_write(), not before it. Otherwise, it is
possible to unlock it multiple times if the vn_start_write() fails.

Submitted by: Juergen Hannken-Illjes <hannken@eis.cs.tu-bs.de>

20 years agoChange UFS from using vop_stdlock to using its own ufs_lock.
mckusick [Mon, 23 Feb 2004 06:40:17 +0000 (06:40 +0000)]
Change UFS from using vop_stdlock to using its own ufs_lock.
In ufs_lock, check for attempts to acquire shared locks on
snapshot files and change them to be exclusive locks. This
change eliminates deadlocks and machine lockups reported in
-current since most read requests started using shared lock
requests.

Submitted by: Jun Kuriyama <kuriyama@imgsrc.co.jp>

20 years agoAdd optarg, optind, opterr, optopt, optreset to SYNOPSYS
ache [Mon, 23 Feb 2004 05:07:11 +0000 (05:07 +0000)]
Add optarg, optind, opterr, optopt, optreset to SYNOPSYS

20 years agoAdd optreset to getopt.h too since NetBSD getopt_long() (but not GNU one)
ache [Mon, 23 Feb 2004 04:51:07 +0000 (04:51 +0000)]
Add optreset to getopt.h too since NetBSD getopt_long() (but not GNU one)
use it too.

20 years agoTry to better mimic GNU getopt.h which does not assume to make visible
ache [Mon, 23 Feb 2004 04:17:59 +0000 (04:17 +0000)]
Try to better mimic GNU getopt.h which does not assume to make visible
all unistd.h functions, use _GETOPT_DECLARE define for that.

20 years agoFix comment: GNU getopt.h to which this header tries to mimic does not declare
ache [Mon, 23 Feb 2004 03:47:28 +0000 (03:47 +0000)]
Fix comment: GNU getopt.h to which this header tries to mimic does not declare
getsubopt/optreset

20 years agoPOSIX clearly states that getsubopt() should be declared in <stdlib.h>
ache [Mon, 23 Feb 2004 03:32:10 +0000 (03:32 +0000)]
POSIX clearly states that getsubopt() should be declared in <stdlib.h>
not in <unistd.h>

20 years agoRemove unneccessary <unistd.h>
ache [Mon, 23 Feb 2004 03:30:02 +0000 (03:30 +0000)]
Remove unneccessary <unistd.h>

20 years agoLimit the amount of memory userspace processes can cause the kernel to
rwatson [Mon, 23 Feb 2004 03:18:18 +0000 (03:18 +0000)]
Limit the amount of memory userspace processes can cause the kernel to
allocate via DRI on r128 devices.

Obtained from: Thomas Biege <thomas@suse.de>
Reviewed by: scottl

20 years agoPOSIX clearly states that getsubopt() should be declared in <stdlib.h>,
ache [Mon, 23 Feb 2004 03:16:59 +0000 (03:16 +0000)]
POSIX clearly states that getsubopt() should be declared in <stdlib.h>,
not in <unistd.h>

20 years ago - Substitute bdone() and bwait() from vfs_bio.c for
alc [Mon, 23 Feb 2004 03:15:13 +0000 (03:15 +0000)]
 - Substitute bdone() and bwait() from vfs_bio.c for
   swap_pager_putpages()'s buffer completion code.  Note: the only
   difference between swp_pager_sync_iodone() and bdone(), aside from
   the locking in the latter, was the unnecessary clearing of B_ASYNC.
 - Remove an unnecessary pmap_page_protect() from
   swp_pager_async_iodone().

Reviewed by: tegge

20 years agoFix comment containing vop_readdir_args contents: a_cookies is really
tjr [Mon, 23 Feb 2004 01:43:00 +0000 (01:43 +0000)]
Fix comment containing vop_readdir_args contents: a_cookies is really
u_long ** not u_long *.

20 years agocookies is an array of u_long, not u_int, so MALLOC() it accordingly.
tjr [Mon, 23 Feb 2004 01:40:46 +0000 (01:40 +0000)]
cookies is an array of u_long, not u_int, so MALLOC() it accordingly.
Allocating it with the wrong size could have caused corruption on
64-bit architectures.

20 years agoCorrect some major SMP-harmful problems in the pipe implementation. First
green [Sun, 22 Feb 2004 23:00:14 +0000 (23:00 +0000)]
Correct some major SMP-harmful problems in the pipe implementation.  First
of all, PIPE_EOF is not checked pervasively after everything that can drop
the pipe mutex and msleep(), so fix.  Additionally, though it might not
harm anything, pipelock() and pipeunlock() are not used consistently.
Third, the kqueue support functions do not use the pipe mutex correctly.
Last, but absolutely not least, is a race: if pipe_busy is not set on
the closing side of the pipe, the other side that is trying to write to
that will crash BECAUSE PIPE_EOF IS NOT SET!  Unconditionally set
PIPE_EOF, and get rid of all the lockups/crashes I have seen trying
to build ports.

20 years agoYe/PCI is supported by cy driver, so we don't need to assign a number to it.
imp [Sun, 22 Feb 2004 20:39:09 +0000 (20:39 +0000)]
Ye/PCI is supported by cy driver, so we don't need to assign a number to it.

20 years agoAdd a note about cdevsw changes.
imp [Sun, 22 Feb 2004 19:02:38 +0000 (19:02 +0000)]
Add a note about cdevsw changes.

20 years agoUpdate man page to reflect additional flag to allow selection of threads.
deischen [Sun, 22 Feb 2004 18:12:56 +0000 (18:12 +0000)]
Update man page to reflect additional flag to allow selection of threads.

20 years agoAllow the -H option to show threads when selecting by uid, tty,
deischen [Sun, 22 Feb 2004 17:59:31 +0000 (17:59 +0000)]
Allow the -H option to show threads when selecting by uid, tty,
and pid.

20 years agoTeach kvm_getprocs() to recognize a sysctl flag for including threads.
deischen [Sun, 22 Feb 2004 17:57:10 +0000 (17:57 +0000)]
Teach kvm_getprocs() to recognize a sysctl flag for including threads.

20 years agoAdd sysctls to allow showing threads for pgrp, tty, uid, ruid,
deischen [Sun, 22 Feb 2004 17:54:32 +0000 (17:54 +0000)]
Add sysctls to allow showing threads for pgrp, tty, uid, ruid,
and pid.

20 years agoFix some cosmetic issues in warning and error messages.
des [Sun, 22 Feb 2004 16:45:21 +0000 (16:45 +0000)]
Fix some cosmetic issues in warning and error messages.

20 years agoUnbreak after the change to use vm_paddr_t. Since vm_paddr_t is
mux [Sun, 22 Feb 2004 16:27:28 +0000 (16:27 +0000)]
Unbreak after the change to use vm_paddr_t.  Since vm_paddr_t is
an integer type and the a cast to (void *) was added in the
definition of NULL for the kernel, we need to use 0 here instead.

Partly submitted by: cperciva

20 years agoReimplement sysctls handling by MAC framework.
pjd [Sun, 22 Feb 2004 12:31:44 +0000 (12:31 +0000)]
Reimplement sysctls handling by MAC framework.
Now I believe it is done in the right way.

Removed some XXMAC cases, we now assume 'high' integrity level for all
sysctls, except those with CTLFLAG_ANYBODY flag set. No more magic.

Reviewed by: rwatson
Approved by: rwatson, scottl (mentor)
Tested with: LINT (compilation), mac_biba(4) (functionality)

20 years agoReport login attempts to syslog. Due to the statically-linked nature of
cperciva [Sun, 22 Feb 2004 10:03:24 +0000 (10:03 +0000)]
Report login attempts to syslog.  Due to the statically-linked nature of
nologin(8), this causes a considerable (100K) increase in the binary size,
so I've added a NO_LOGIN_LOG option which disables this.

While I'm here, s/sizeof(MESSAGE)/sizeof(MESSAGE) - 1/, in order to
avoid writing the string-terminating zero byte.

No complaints from: -current
Approved by: rwatson (mentor)

20 years agoCheck that amrd_sc is non-NULL before dereferencing it, not after.
cperciva [Sun, 22 Feb 2004 10:00:05 +0000 (10:00 +0000)]
Check that amrd_sc is non-NULL before dereferencing it, not after.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoCheck that twed_sc is non-NULL before dereferencing it, not after.
cperciva [Sun, 22 Feb 2004 09:58:34 +0000 (09:58 +0000)]
Check that twed_sc is non-NULL before dereferencing it, not after.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoDon't free k_cfg until we're finished using it -- reverse the order of
cperciva [Sun, 22 Feb 2004 09:55:48 +0000 (09:55 +0000)]
Don't free k_cfg until we're finished using it -- reverse the order of
two free commands.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor), scottl

20 years agoDon't free meo until we're finished using it.
cperciva [Sun, 22 Feb 2004 09:52:46 +0000 (09:52 +0000)]
Don't free meo until we're finished using it.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor), scottl

20 years agoprotect new cdevsw entries with "#if (__FreeBSD_version > 502102)"
rees [Sun, 22 Feb 2004 05:49:38 +0000 (05:49 +0000)]
protect new cdevsw entries with "#if (__FreeBSD_version > 502102)"

20 years agosendmail 8.12.11 has been MFC'ed to RELENG_4
gshapiro [Sun, 22 Feb 2004 04:30:32 +0000 (04:30 +0000)]
sendmail 8.12.11 has been MFC'ed to RELENG_4

20 years agoCorrect a long-standing race condition in vm_object_page_remove() that
alc [Sun, 22 Feb 2004 03:36:51 +0000 (03:36 +0000)]
Correct a long-standing race condition in vm_object_page_remove() that
could result in a dirty page being unintentionally freed.

Reviewed by: tegge
MFC after: 7 days

20 years agoChange the syscall stub branch orders so that the static branch prediction
peter [Sun, 22 Feb 2004 02:11:39 +0000 (02:11 +0000)]
Change the syscall stub branch orders so that the static branch prediction
will assume that syscalls will succeed rather than fail.

20 years agoDo not pre-map the I/O port space. On the Intel Tiger 4 this conflicts
marcel [Sun, 22 Feb 2004 02:10:48 +0000 (02:10 +0000)]
Do not pre-map the I/O port space. On the Intel Tiger 4 this conflicts
with a memory mapped I/O range that's immediately before it and is
not 256MB aligned. As a result, when an address is accessed in the
memory mapped range and a direct mapping is added for it, it overlaps
with the pre-mapped I/O port space and causes a machine check.

Based on a patch from: arun@

20 years agoIf mountnfs returns an error, it will have already freed nam; no need to
cperciva [Sun, 22 Feb 2004 01:17:47 +0000 (01:17 +0000)]
If mountnfs returns an error, it will have already freed nam; no need to
free it again.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoCheck that periph is non-NULL before dereferencing it.
cperciva [Sun, 22 Feb 2004 01:14:54 +0000 (01:14 +0000)]
Check that periph is non-NULL before dereferencing it.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor), ken (scsi@)

20 years agoIf we're going to panic(), do it before dereferencing a NULL pointer.
cperciva [Sun, 22 Feb 2004 01:11:53 +0000 (01:11 +0000)]
If we're going to panic(), do it before dereferencing a NULL pointer.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoCheck that xfer != NULL before dereferencing it, not after.
cperciva [Sun, 22 Feb 2004 01:10:11 +0000 (01:10 +0000)]
Check that xfer != NULL before dereferencing it, not after.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoIf we're going to assert that logData != NULL, do it before we
cperciva [Sun, 22 Feb 2004 01:08:33 +0000 (01:08 +0000)]
If we're going to assert that logData != NULL, do it before we
try to dereference logData.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor), scottl

20 years agoWe want to allocate and zero sizeof(struct foo) bytes, not
cperciva [Sun, 22 Feb 2004 01:06:05 +0000 (01:06 +0000)]
We want to allocate and zero sizeof(struct foo) bytes, not
sizeof(struct foo *) bytes.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor), scottl

20 years agoFix off-by-one error: sc->twe_drive is an array of TWE_MAX_UNITS elements.
cperciva [Sun, 22 Feb 2004 01:03:38 +0000 (01:03 +0000)]
Fix off-by-one error: sc->twe_drive is an array of TWE_MAX_UNITS elements.

Reported by: "Ted Unangst" <tedu@coverity.com>
Approved by: rwatson (mentor)

20 years agoSome markup fixes, change some devices to a feature.
njl [Sun, 22 Feb 2004 00:50:00 +0000 (00:50 +0000)]
Some markup fixes, change some devices to a feature.

20 years agoUpdate my personal copyrights and NETA copyrights in the kernel
rwatson [Sun, 22 Feb 2004 00:33:12 +0000 (00:33 +0000)]
Update my personal copyrights and NETA copyrights in the kernel
to use the "year1-year3" format, as opposed to "year1, year2, year3".
This seems to make lawyers more happy, but also prevents the
lines from getting excessively long as the years start to add up.

Suggested by: imp

20 years agoUpdate the debug.acpi.disable section for missing devices and the special
njl [Sun, 22 Feb 2004 00:30:43 +0000 (00:30 +0000)]
Update the debug.acpi.disable section for missing devices and the special
"all" value.

20 years agobus_set_resource takes a rid, not a pointer to a rid.
njl [Sun, 22 Feb 2004 00:29:04 +0000 (00:29 +0000)]
bus_set_resource takes a rid, not a pointer to a rid.

20 years agoCheck for NODEV return from udev2dev()
phk [Sat, 21 Feb 2004 23:52:03 +0000 (23:52 +0000)]
Check for NODEV return from udev2dev()

20 years agoRegen (FWIW)
peter [Sat, 21 Feb 2004 23:38:58 +0000 (23:38 +0000)]
Regen (FWIW)

20 years agoTry and make the compat sigreturn prototypes closer to reality.
peter [Sat, 21 Feb 2004 23:37:33 +0000 (23:37 +0000)]
Try and make the compat sigreturn prototypes closer to reality.

20 years agoAdd a note about the landmine in the middle of struct ia32_sigframe.
peter [Sat, 21 Feb 2004 23:36:31 +0000 (23:36 +0000)]
Add a note about the landmine in the middle of struct ia32_sigframe.

20 years agoDOH!!! Fix signals for freebsd-4.x/i386 binaries. The ucontext has
peter [Sat, 21 Feb 2004 23:35:56 +0000 (23:35 +0000)]
DOH!!!  Fix signals for freebsd-4.x/i386 binaries.  The ucontext has
different alignments due to the sse fxsave dump area.

20 years agoCatch up with some proc/procsig locking improvements that were made to the
peter [Sat, 21 Feb 2004 23:34:42 +0000 (23:34 +0000)]
Catch up with some proc/procsig locking improvements that were made to the
i386 version and were not merged over.

20 years agoEliminate the second, unnecessary call to pmap_page_protect() near the end
alc [Sat, 21 Feb 2004 23:32:00 +0000 (23:32 +0000)]
Eliminate the second, unnecessary call to pmap_page_protect() near the end
of vm_pageout_flush().  Instead, assert that the page is still write
protected.

Discussed with: tegge

20 years agoin idmap_uid_to_name(), don't try to use the entry after freeing it, in the
rees [Sat, 21 Feb 2004 22:52:02 +0000 (22:52 +0000)]
in idmap_uid_to_name(), don't try to use the entry after freeing it, in the
idmap_add failure case (found by Ted Unangst via Colin Percival)

also convert idmap_hashf to return void, since it can't fail

also change some panics to error returns