]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/log
FreeBSD/FreeBSD.git
4 years agoTemporarily skip flakey test case
lwhsu [Wed, 24 Jul 2019 17:41:40 +0000 (17:41 +0000)]
Temporarily skip flakey test case
sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger

PR: 239425
Sponsored by: The FreeBSD Foundation

4 years agopf: zero output buffer in pfioctl
emaste [Wed, 24 Jul 2019 16:51:14 +0000 (16:51 +0000)]
pf: zero output buffer in pfioctl

Avoid potential structure padding leak.

Reported by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Reviewed by: kp
MFC after: 3 days
Security: Potential kernel memory disclosure
Sponsored by: The FreeBSD Foundation

4 years agoAllow set MTU more than 1500 bytes.
krion [Wed, 24 Jul 2019 16:10:20 +0000 (16:10 +0000)]
Allow set MTU more than 1500 bytes.

Submitted by: Alexandr Fedorov <aleksandr.fedorov_itglobal_dot_com>
Approved by: jhb, rgrimes
Sponsored by: ITGlobal.com
Differential Revision: https://reviews.freebsd.org/D19422

4 years agoRemove a redundant offset computation in elf_load_section().
markj [Wed, 24 Jul 2019 15:18:05 +0000 (15:18 +0000)]
Remove a redundant offset computation in elf_load_section().

With r344705 the offset is always zero.

Submitted by: Wuyang Chung <wuyang.chung1@gmail.com>

4 years agoAdd c++14 and c++17 to COMPILER_FEATURES
asomers [Wed, 24 Jul 2019 15:10:09 +0000 (15:10 +0000)]
Add c++14 and c++17 to COMPILER_FEATURES

This will be used to gate the fusefs tests. It's a partial merge of r348281
from projects/fuse2.

Reviewed by: kib, emaste
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D21044

4 years agopkgbase: Add the sub stage-packages targets to TGTS
manu [Wed, 24 Jul 2019 08:00:00 +0000 (08:00 +0000)]
pkgbase: Add the sub stage-packages targets to TGTS

This helps when you don't want to run the dependencies targets.

Reviewed by: bapt
Differential Revision: https://reviews.freebsd.org/D20955

4 years agoDon't use .Xr for things that have no man page.
kevlo [Wed, 24 Jul 2019 07:07:46 +0000 (07:07 +0000)]
Don't use .Xr for things that have no man page.

4 years agoVOP_FSYNC.9: update copyright after r345677
asomers [Tue, 23 Jul 2019 23:14:57 +0000 (23:14 +0000)]
VOP_FSYNC.9: update copyright after r345677

MFC after: 2 weeks
MFC-With: r345677
Sponsored by: The FreeBSD Foundation

4 years agoAdd a sysctl variable ts_offset_per_conn to change the computation
tuexen [Tue, 23 Jul 2019 21:28:20 +0000 (21:28 +0000)]
Add a sysctl variable ts_offset_per_conn to change the computation
of the TCP TS offset from taking the IP addresses and the TCP port
numbers into account to a version just taking only the IP addresses
into account. This works around broken middleboxes or endpoints.
The default is to keep the behaviour, which is also the behaviour
recommended in RFC 7323.

Reported by: devgs@ukr.net
Reviewed by: rrs@
MFC after: 2 weeks
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D20980

4 years agomqueuefs: fix struct file leak
emaste [Tue, 23 Jul 2019 20:59:36 +0000 (20:59 +0000)]
mqueuefs: fix struct file leak

In some error cases we previously leaked a stuct file.

Submitted by: mjg, markj

4 years agoMake `camcontrol hpa` and `camcontrol ama` trigger reprobe.
mav [Tue, 23 Jul 2019 19:42:03 +0000 (19:42 +0000)]
Make `camcontrol hpa` and `camcontrol ama` trigger reprobe.

This makes OS automatically see the disk's new disk size.

MFC after: 2 weeks
Sponsored by: iXsystems, Inc.

4 years agoFix the register layout for the Buffer Descript List Entry. It
scottl [Tue, 23 Jul 2019 18:40:07 +0000 (18:40 +0000)]
Fix the register layout for the Buffer Descript List Entry.  It
got jumbled around during some other cleanups and was causing
audio failures on some guests.

PR: 239341
Reported by: shamaz.mazum@gmail.com

4 years agoDon't hold a mutex while calling sbwait. This was found by syzkaller.
tuexen [Tue, 23 Jul 2019 18:31:07 +0000 (18:31 +0000)]
Don't hold a mutex while calling sbwait. This was found by syzkaller.

Submitted by: rrs@
Reported by: markj@
MFC after: 1 week

4 years agoixgbe(4): Fix enabling/disabling and reconfiguration of queues
erj [Tue, 23 Jul 2019 18:14:32 +0000 (18:14 +0000)]
ixgbe(4): Fix enabling/disabling and reconfiguration of queues

- Wrong order of casting and bit shift caused that enabling and disabling
  queues didn't work properly for queues number larger than 32. Use literals
  with right suffix instead.

- TX ring tail address was not updated during reinitiailzation of TX
  structures. It could block sending traffic.

- Also remove unused variables 'eims' and 'active_queues'.

Submitted by: Krzysztof Galazka <krzysztof.galazka@intel.com>
Reviewed by: erj@
Sponsored by: Intel Corporation
Differential Revision: https://reviews.freebsd.org/D20826

4 years agoFix a LOR in SCTP which was found by running syzkaller.
tuexen [Tue, 23 Jul 2019 18:07:36 +0000 (18:07 +0000)]
Fix a LOR in SCTP which was found by running syzkaller.

Submitted by: rrs@
Reported by: markj@
MFC after: 1 week

4 years agopciconf: report PCI Gen4 speeds
gallatin [Tue, 23 Jul 2019 16:28:17 +0000 (16:28 +0000)]
pciconf: report PCI Gen4 speeds

PCIe gen4 runs at 16GT/s.  Report this as
the speed of Gen4 links.

Reviewed by: imp
MFC after: 7 days
Sponsored by: Netflix

4 years agobhyve: correct out-of-bounds read in XHCI device emulation
emaste [Tue, 23 Jul 2019 16:27:36 +0000 (16:27 +0000)]
bhyve: correct out-of-bounds read in XHCI device emulation

Add appropriate bounds checks on the epid and streamid fields in the
device doorbell registers.

admbugs: 919
Submitted by: jhb
Reported by: Reno Robert <renorobert@gmail.com>
Reviewed by: markj
Approved by: so
Security: out-of-bounds read

4 years agoUpdate refcount(9).
kib [Tue, 23 Jul 2019 16:11:38 +0000 (16:11 +0000)]
Update refcount(9).

Describe missed functions.
Give some hint about refcount_release(9) memory ordering guarantees.

Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D21020

4 years agoAs with r350241 use the new UL macro on the main register mask.
andrew [Tue, 23 Jul 2019 14:52:46 +0000 (14:52 +0000)]
As with r350241 use the new UL macro on the main register mask.

MFC after: 1 week
Sponsored by: DARPA, AFRL

4 years agoEnsure the arm64 ID register fields are 64 bit types.
andrew [Tue, 23 Jul 2019 14:40:37 +0000 (14:40 +0000)]
Ensure the arm64 ID register fields are 64 bit types.

Previously only some of the ID register fields were 64 bit. To allow
for a script to generate these mark them all 64 bit. To allow for their
use in assembly we need to use the UINT64_C macro via a new UL macro
to stop the lines from being too long.

MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D20977

4 years agoEliminate rmlock from ipfw's BPF code.
ae [Tue, 23 Jul 2019 12:52:36 +0000 (12:52 +0000)]
Eliminate rmlock from ipfw's BPF code.

After r343631 pfil hooks are invoked in net_epoch_preempt section,
this allows to avoid extra locking. Add NET_EPOCH_ASSER() assertion
to each ipfw_bpf_*tap*() call to require to be called from inside
epoch section.

Use NET_EPOCH_WAIT() in ipfw_clone_destroy() to wait until it becomes
safe to free() ifnet. And use on-stack ifnet pointer in each
ipfw_bpf_*tap*() call to avoid NULL pointer dereference in case when
V_*log_if global variable will become NULL during ipfw_bpf_*tap*() call.

Sponsored by: Yandex LLC

4 years agoTemporarily skip flakey test case
lwhsu [Tue, 23 Jul 2019 09:39:27 +0000 (09:39 +0000)]
Temporarily skip flakey test case
sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger

PR: 239399
Sponsored by: The FreeBSD Foundation

4 years agoTemporarily skip flakey test case
lwhsu [Tue, 23 Jul 2019 09:19:58 +0000 (09:19 +0000)]
Temporarily skip flakey test case
sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger

PR: 239397
Sponsored by: The FreeBSD Foundation

4 years agoTemporarily skip flakey test case
lwhsu [Tue, 23 Jul 2019 07:56:42 +0000 (07:56 +0000)]
Temporarily skip flakey test case
sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop

PR: 220841
Sponsored by: The FreeBSD Foundation

4 years agoMake CAM ATA stack handle disk resizes.
mav [Tue, 23 Jul 2019 02:11:14 +0000 (02:11 +0000)]
Make CAM ATA stack handle disk resizes.

While for ATA disks resize is even more rare situation than for SCSI, it
may happen in case of HPA or AMA being used.  Make ATA XPT report minor
IDENTIFY DATA change to upper layers with AC_GETDEV_CHANGED, and ada(4)
periph driver handle that event, recalculating all the disk properties and
signalling resize to GEOM.  Since ATA has no mechanism of UNIT ATTENTIONs,
like SCSI, it has no way to detect that something has changed.  That is why
this functionality depends on explicit reprobe via XPT_REPROBE_LUN call.

MFC after: 2 weeks
Relnotes: yes
Sponsored by: iXsystems, Inc.

4 years agopowerpc: Unbreak 64-bit pmap from 350206
jhibbits [Mon, 22 Jul 2019 22:59:50 +0000 (22:59 +0000)]
powerpc: Unbreak 64-bit pmap from 350206

oldpvo is never explicitly NULL'd by moea64_pvo_enter(), so don't check for
NULL to do anything, only check error.

PR: 239372
Reported by: Francis Little

4 years agoCorrect spelling, partion -> partition.
ian [Mon, 22 Jul 2019 22:41:44 +0000 (22:41 +0000)]
Correct spelling, partion -> partition.

4 years agoarm: ti: Add a driver for ti,sysc bus
manu [Mon, 22 Jul 2019 21:55:33 +0000 (21:55 +0000)]
arm: ti: Add a driver for ti,sysc bus

ti,sysc is a simple-bus like driver.
Add a driver for it so child nodes can attach.

4 years agoarm: ti: Get the hwmods property from the parent node
manu [Mon, 22 Jul 2019 21:53:58 +0000 (21:53 +0000)]
arm: ti: Get the hwmods property from the parent node

Since the Linux 5.0 dts the ti,hwmods property is on the parent
ti.sysc node.

4 years agoata_xpt: Use the correct union member when accessing valid.
brooks [Mon, 22 Jul 2019 21:07:58 +0000 (21:07 +0000)]
ata_xpt: Use the correct union member when accessing valid.

In principle this should not matter as it's a union and they point to
the same memory location but based on the code above we should be
accessing .sata and not .ata.

Submitted by: arichardson
Reviewed by: scottl, imp
Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D21002

4 years ago[skip ci] Fix the comment for cache_purge(9)
asomers [Mon, 22 Jul 2019 21:03:52 +0000 (21:03 +0000)]
[skip ci] Fix the comment for cache_purge(9)

This is a merge of r348738 from projects/fuse2

Reviewed by: kib
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

4 years agoRemove the USE_RFC2292BIS option and reap dead code
asomers [Mon, 22 Jul 2019 20:11:33 +0000 (20:11 +0000)]
Remove the USE_RFC2292BIS option and reap dead code

This option was imported as part of the KAME project in r62627 (in 2000).
It was turned on unconditionally in r121472 (in 2003) and has been on ever
since. The old alternative code has bitrotted. Reap the dead code.

Reported by: Ján Sučan <jansucan@gmail.com>
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D20938

4 years agoAllow "update" option to be used in the fstab(5). Document possible use case.
sobomax [Mon, 22 Jul 2019 20:04:55 +0000 (20:04 +0000)]
Allow "update" option to be used in the fstab(5). Document possible use case.

Approved by: mckusick
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D18586

4 years agoTemporarily skip sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4
lwhsu [Mon, 22 Jul 2019 18:54:26 +0000 (18:54 +0000)]
Temporarily skip sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4
on i386 as they are flakey on it

PR: 239380
Sponsored by: The FreeBSD Foundation

4 years agoFix URL.
lwhsu [Mon, 22 Jul 2019 18:43:46 +0000 (18:43 +0000)]
Fix URL.

Sponsored by: The FreeBSD Foundation

4 years agoTemporarily skip lib.libc.regex.exhaust_test.regcomp_too_big and
lwhsu [Mon, 22 Jul 2019 18:42:55 +0000 (18:42 +0000)]
Temporarily skip lib.libc.regex.exhaust_test.regcomp_too_big and
lib.libregex.exhaust_test.regcomp_too_big on i386 as they are flakey on it

PR: 237450
Sponsored by: The FreeBSD Foundation

4 years agoBe consistent about temporary variable use in adjacent loops.
brooks [Mon, 22 Jul 2019 18:27:17 +0000 (18:27 +0000)]
Be consistent about temporary variable use in adjacent loops.

Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL

4 years agoWakeup the application when doing PD-API for unordered DATA chunks.
tuexen [Mon, 22 Jul 2019 18:11:35 +0000 (18:11 +0000)]
Wakeup the application when doing PD-API for unordered DATA chunks.
Work done with rrs@.

MFC after: 1 week

4 years agomptutil: emit a warning on big-endian architectures
emaste [Mon, 22 Jul 2019 17:25:35 +0000 (17:25 +0000)]
mptutil: emit a warning on big-endian architectures

It is known to be broken.

PR: 162513
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

4 years agoUnify BTL parsing for `camcontrol debug` and `reset`.
mav [Mon, 22 Jul 2019 17:08:18 +0000 (17:08 +0000)]
Unify BTL parsing for `camcontrol debug` and `reset`.

This makes `camcontrol debug` also allow peripheral device specification.

While there, make BTL parser more strict and switch from strtok() to
strsep().

MFC after: 2 weeks

4 years agoRemove unused header.
br [Mon, 22 Jul 2019 16:50:37 +0000 (16:50 +0000)]
Remove unused header.

Sponsored by: DARPA, AFRL

4 years agoo Add support for BERI IOMMU device
br [Mon, 22 Jul 2019 16:01:20 +0000 (16:01 +0000)]
o Add support for BERI IOMMU device
o Add an experimental IOMMU support to xDMA framework

The BERI IOMMU device is the part of CHERI device-model project [1]. It
translates memory addresses for various BERI peripherals modelled in
software. It accepts FreeBSD/mips64 page directories format and manages
BERI TLB.

1. https://github.com/CTSRD-CHERI/device-model

Sponsored by: DARPA, AFRL

4 years agoTemporarily skip flakey test case
lwhsu [Mon, 22 Jul 2019 10:37:56 +0000 (10:37 +0000)]
Temporarily skip flakey test case
sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger

PR: 239292
Sponsored by: The FreeBSD Foundation

4 years agoarm: Use -O2 instead of -O as optimization flag
manu [Mon, 22 Jul 2019 10:17:59 +0000 (10:17 +0000)]
arm: Use -O2 instead of -O as optimization flag

When using Clang -O is equivalent to -O2, change it -O2 to make it
consistent with other platforms.

Reference: https://clang.llvm.org/docs/ClangCommandLineReference.html#optimization-level

Submitted by: Daniel Engberg (daniel.engberg.lists@pyret.net)
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D21021

4 years agoVOP_PATHCONF.9: correct the type of the retval argument
asomers [Mon, 22 Jul 2019 04:14:53 +0000 (04:14 +0000)]
VOP_PATHCONF.9: correct the type of the retval argument

It was changed from int to register_t in r22521 and from register_t to long
in r328099, but the man page wasn't updated either time.

MFC after: 2 weeks

4 years agopowerpc64/mmu: Make moea64_pvo_enter() return if an entry already exists
jhibbits [Mon, 22 Jul 2019 03:11:54 +0000 (03:11 +0000)]
powerpc64/mmu: Make moea64_pvo_enter() return if an entry already exists

Summary:
Instead of searching for a PVO entry before adding, take advantage of
the fact that RB_INSERT() returns NULL if it inserts, and the existing entry if
an entry exists, without inserting a new entry.  This saves an extra tree
traversal in the cases where the PVO does not exist.

Reviewed by: luporl
Differential Revision: https://reviews.freebsd.org/D20944

4 years agoSwitch the rest of the refcount(9) functions to bool return type.
kib [Sun, 21 Jul 2019 20:16:48 +0000 (20:16 +0000)]
Switch the rest of the refcount(9) functions to bool return type.

There are some explicit comparisions of refcount_release(9) result
with 0/1, which are fine.

Reviewed by: markj, mjg
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D21014

4 years agoAdd support for setting the aging/frequency-offset register via sysctl.
ian [Sun, 21 Jul 2019 17:14:39 +0000 (17:14 +0000)]
Add support for setting the aging/frequency-offset register via sysctl.

The 2127 and 2129 chips support a frequency tuning value in the range of
-7 through +8 PPM; add a sysctl handler to read and set the value.

4 years agoWith the introduction of software dirty bit emulation for managed mappings,
alc [Sun, 21 Jul 2019 17:00:19 +0000 (17:00 +0000)]
With the introduction of software dirty bit emulation for managed mappings,
we should test ATTR_SW_DBM, not ATTR_AP_RW, to determine whether to set
PGA_WRITEABLE.  In effect, we are currently setting PGA_WRITEABLE based on
whether the dirty bit is preset, not whether the mapping is writeable.
Correct this mistake.

Reviewed by: markj
X-MFC with: r350004
Differential Revision: https://reviews.freebsd.org/D21013

4 years agoLink fileargs_lstat.3.
markj [Sun, 21 Jul 2019 16:35:49 +0000 (16:35 +0000)]
Link fileargs_lstat.3.

Sponsored by: The FreeBSD Foundation

4 years agoFix userspace build after r350199.
kib [Sun, 21 Jul 2019 16:24:40 +0000 (16:24 +0000)]
Fix userspace build after r350199.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

4 years agoCheck and avoid overflow when incrementing fp->f_count in
kib [Sun, 21 Jul 2019 15:07:12 +0000 (15:07 +0000)]
Check and avoid overflow when incrementing fp->f_count in
fget_unlocked() and fhold().

On sufficiently large machine, f_count can be legitimately very large,
e.g. malicious code can dup same fd up to the per-process
filedescriptors limit, and then fork as much as it can.
On some smaller machine, I see
kern.maxfilesperproc: 939132
kern.maxprocperuid: 34203
which already overflows u_int.  More, the malicious code can create
transient references by sending fds over unix sockets.

I realized that this check is missed after reading
https://secfault-security.com/blog/FreeBSD-SA-1902.fd.html

Reviewed by: markj (previous version), mjg
Tested by: pho (previous version)
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D20947

4 years agoMark Felder has stepped down from portmgr and ports-secteam
rene [Sun, 21 Jul 2019 11:07:39 +0000 (11:07 +0000)]
Mark Felder has stepped down from portmgr and ports-secteam

4 years agoIntroduce pmap_store(), and use it to replace pmap_load_store() in places
alc [Sun, 21 Jul 2019 03:26:26 +0000 (03:26 +0000)]
Introduce pmap_store(), and use it to replace pmap_load_store() in places
where the page table entry was previously invalid.  (Note that I did not
replace pmap_load_store() when it was followed by a TLB invalidation, even
if we are not using the return value from pmap_load_store().)

Correct an error in pmap_enter().  A test for determining when to set
PGA_WRITEABLE was always true, even if the mapping was read only.

In pmap_enter_l2(), when replacing an empty kernel page table page by a
superpage mapping, clear the old l2 entry and issue a TLB invalidation.  My
reading of the ARM architecture manual leads me to believe that the TLB
could hold an intermediate entry referencing the empty kernel page table
page even though it contains no valid mappings.

Replace a couple direct uses of atomic_clear_64() by the new
pmap_clear_bits().

In a couple comments, replace the term "paging-structure caches", which is
an Intel-specific term for the caches that hold intermediate entries in the
page table, with wording that is more consistent with the ARM architecture
manual.

Reviewed by: markj
X-MFC after: r350004
Differential Revision: https://reviews.freebsd.org/D20998

4 years agopowerpc: Remove an unnecessary #ifdef guard from slb.c
jhibbits [Sun, 21 Jul 2019 03:19:54 +0000 (03:19 +0000)]
powerpc: Remove an unnecessary #ifdef guard from slb.c

slb.c is only compiled for powerpc64, so no need for the #ifdef in this block.

4 years agoTreat any inode with bad content as unknown (i.e., ask if it should
mckusick [Sat, 20 Jul 2019 21:39:32 +0000 (21:39 +0000)]
Treat any inode with bad content as unknown (i.e., ask if it should
be cleared).

Sponsored by: Netflix

4 years agoWhen running with journaled soft updates, some updated inodes were not
mckusick [Sat, 20 Jul 2019 21:20:40 +0000 (21:20 +0000)]
When running with journaled soft updates, some updated inodes were not
having their check hashes recomputed which resulted in spurious inode
check-hash errors when the system came back up after a crash.

Reported by:  Alan Somers
Sponsored by: Netflix

4 years agoRewrite the nxprtc chip init to extend battery life by using power-saving
ian [Sat, 20 Jul 2019 21:10:27 +0000 (21:10 +0000)]
Rewrite the nxprtc chip init to extend battery life by using power-saving
features offered by the chips.

For 2127 and 2129 chips, fix the detection of when chip-init is needed.  The
chip config needs to be reset whenever power was lost, but the logic was
wrong for 212x chips (it only worked for 8523).  Now the "oscillator
stopped" bit rather than the power manager mode is used to detect startup
after powerfail.

For all chips, disable the clock output pin.

For chips that have a timestamp/tamper-monitor feature, turn off monitoring
of the timestamp trigger pin.

The 8523, 2127, and 2129 chips have a "power manager" feature that offers
several options.  We've been using the default mode which enables
everything.  Now the code sets the power manager options to

 - direct-switch (when Vdd < Vbat, without extra threshold check)
 - no battery monitor
 - no external powerfail monitor

This reduces the current draw while running on battery from 1930nA to 880nA,
which should roughly double the lifespan of the battery under load.

Because battery checking is a nice thing to have, the code now does a check
at startup, and then once a day after that, instead of checking continuously
(but only actually reporting at startup).  The battery check is now done by
setting the power manager back to default mode, sleeping briefly while it
makes a voltage measurement, then switching back to power-saving mode.

4 years agomotd: Generate from template to /var/run
cem [Sat, 20 Jul 2019 20:56:31 +0000 (20:56 +0000)]
motd: Generate from template to /var/run

Update login(1), its manual pages, similar utilities, and motd.5 to refer to
the new location.

Suggested by: delphij@ (re: r349256)
Reviewed by: bcr (manpages), delphij
Differential Revision: https://reviews.freebsd.org/D20721

4 years agoIn trimming on startup, invoke swapon before closing the fd used for
dougm [Sat, 20 Jul 2019 20:47:07 +0000 (20:47 +0000)]
In trimming on startup, invoke swapon before closing the fd used for
trimming so that a geli device isn't detached before swapon is
invoked.

Submitted by: sigsys_gmail.com
Discussed with: alc
Approved by: markj (mentor)
Differential Revision: https://reviews.freebsd.org/D21006

4 years agoRename vm_page_{import,release}() to vm_page_zone_{import,release}().
markj [Sat, 20 Jul 2019 18:25:41 +0000 (18:25 +0000)]
Rename vm_page_{import,release}() to vm_page_zone_{import,release}().

I would like to use the name vm_page_release() for a different purpose,
and vm_page_{import,release}() are local to vm_page.c.

Reviewed by: kib
MFC after: 1 week

4 years agopowerpc/SPE: Enable SPV bit for EFSCFD instruction emulation
jhibbits [Sat, 20 Jul 2019 18:22:01 +0000 (18:22 +0000)]
powerpc/SPE: Enable SPV bit for EFSCFD instruction emulation

EFSCFD (floating point single convert from double) emulation requires saving
the high word of the register, which uses SPE instructions.  Enable the SPE
to avoid an SPV Unavailable exception.

MFC after: 1 week

4 years agodtso: allwinner: Add an overlay for H3 i2c0
manu [Sat, 20 Jul 2019 17:42:46 +0000 (17:42 +0000)]
dtso: allwinner: Add an overlay for H3 i2c0

Most of the H3 boards don't enable i2c as it is unused.
Add an overlay so it's easier for user to use i2c device.

4 years agoexpand_number(3) parses suffixes, not prefixes.
jhb [Sat, 20 Jul 2019 16:03:54 +0000 (16:03 +0000)]
expand_number(3) parses suffixes, not prefixes.

While here, tidy the opening sentence a bit.

MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D20791

4 years agoImprove the precision of bhyve's vPIT.
jhb [Sat, 20 Jul 2019 15:59:49 +0000 (15:59 +0000)]
Improve the precision of bhyve's vPIT.

Use 'struct bintime' instead of 'sbintime_t' to manage times in vPIT
to postpone rounding to final results rather than intermediate
results.  In tests performed by Joyent, this reduced the error measured
by Linux guests by 59 ppm.

Smart OS bug: https://smartos.org/bugview/OS-6923
Submitted by: Patrick Mooney
Reviewed by: rgrimes
Obtained from: SmartOS / Joyent
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D20335

4 years agoMerge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp
dim [Sat, 20 Jul 2019 15:26:21 +0000 (15:26 +0000)]
Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp
8.0.1 final release r366581.  The only functional change is a fix for a
mismerge of upstream r360816, which properly restores the r2 register
when unwinding on PowerPC64 (See https://reviews.freebsd.org/D20337).

Relnotes: yes
PR: 236062
MFC after: 3 days
X-MFC-With: r349004

4 years agoarm64: Implement HWCAP
manu [Sat, 20 Jul 2019 14:29:11 +0000 (14:29 +0000)]
arm64: Implement HWCAP

Add HWCAP support for arm64.
defines are the same as in Linux and a userland program can use
elf_aux_info to get the data.
We only save the common denominator for all cores in case the
big and little cluster have different support (this is known to
exists even if we don't support those SoCs in FreeBSD)

Differential Revision: https://reviews.freebsd.org/D17137

4 years agoAdd emmc support for Rockchip RK3399 SoC.
ganbold [Sat, 20 Jul 2019 02:53:06 +0000 (02:53 +0000)]
Add emmc support for Rockchip RK3399 SoC.
Tested on NanoPC-T4 board.

Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D20156

4 years agoAdd driver for Rockchip RK3399 eMMC PHY.
ganbold [Sat, 20 Jul 2019 02:03:31 +0000 (02:03 +0000)]
Add driver for Rockchip RK3399 eMMC PHY.
Tested on NanoPC-T4 board.

Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D20840

4 years agoAvoid copying too much from the input string.
brooks [Fri, 19 Jul 2019 23:58:30 +0000 (23:58 +0000)]
Avoid copying too much from the input string.

This avoids reading past the end of the static strings.  On a system
with bounds checking these tests fault.

Reviewed by: asomers
Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D21004

4 years agoMake setting mips endian and ABI less verbose.
brooks [Fri, 19 Jul 2019 23:39:21 +0000 (23:39 +0000)]
Make setting mips endian and ABI less verbose.

Allow ABI to be over ridden to allow (with other changes) programs to be
built targeting ABIs other than the default.  This is used in CheriBSD.

Reviewed by: imp
Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D21001

4 years agoRemove an unneeded temporary variable in two functions.
brooks [Fri, 19 Jul 2019 23:10:43 +0000 (23:10 +0000)]
Remove an unneeded temporary variable in two functions.

There is no need to convert an intptr_t to a long just to cast it to a
(void *).

Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL

4 years agoUse the __DECONST macro rather than hand rolling it.
brooks [Fri, 19 Jul 2019 22:54:09 +0000 (22:54 +0000)]
Use the __DECONST macro rather than hand rolling it.

Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL

4 years agoFix leak of memory and file refs with sendmsg(2) over unix domain sockets.
kib [Fri, 19 Jul 2019 20:51:39 +0000 (20:51 +0000)]
Fix leak of memory and file refs with sendmsg(2) over unix domain sockets.

When sendmsg(2) sucessfully internalized one SCM_RIGHTS control
message, but failed to process some other control message later, both
file references and filedescent memory needs to be freed. This was not
done, only mbuf chain was freed.

Noted, test case written, reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D21000

4 years agoDefine vm_map_entry_in_transition to handle an in-transition map
dougm [Fri, 19 Jul 2019 20:47:35 +0000 (20:47 +0000)]
Define vm_map_entry_in_transition to handle an in-transition map
entry, combining code currently in vm_map_unwire and
vm_map_wire_locked into a single function, called by each of them for
entries in transition.

Discussed with: kib, markj
Reviewed by: alc
Approved by: kib, markj (mentors, implicit)
Tested by: pho
Differential Revision: https://reviews.freebsd.org/D20833

4 years agoRemove RELEASE_CRUNCH here
imp [Fri, 19 Jul 2019 20:04:31 +0000 (20:04 +0000)]
Remove RELEASE_CRUNCH here

If someone wants to subset, they can set MK_ICONV=no. We no longer use it for
the release.

4 years agoRemove RELEASE_CRUNCH in example
imp [Fri, 19 Jul 2019 20:04:26 +0000 (20:04 +0000)]
Remove RELEASE_CRUNCH in example

RELEASE_CRUNCH is no longer relevant.

4 years agoRemove obsolete RELEASE_CRUNCH
imp [Fri, 19 Jul 2019 20:04:21 +0000 (20:04 +0000)]
Remove obsolete RELEASE_CRUNCH

Remove documentation of RELEASE_CRUNCH here. It's obsolete and no longer a good
example.

4 years agoRemove RELEASE_CRUNCH
imp [Fri, 19 Jul 2019 20:04:13 +0000 (20:04 +0000)]
Remove RELEASE_CRUNCH

RELEASE_CRUNCH isn't used for releases any more. If someone wants to subset,
then they can set MK_JAIL=no instead.

4 years agoProperly report ACS revisions alike to kernel.
mav [Fri, 19 Jul 2019 20:02:01 +0000 (20:02 +0000)]
Properly report ACS revisions alike to kernel.

MFC after: 2 weeks

4 years agoAdd Accessible Max Address Configuration support to camcontrol.
mav [Fri, 19 Jul 2019 19:15:08 +0000 (19:15 +0000)]
Add Accessible Max Address Configuration support to camcontrol.

AMA replaced HPA in ACS-3 specification.  It allows to limit size of the
disk alike to HPA, but declares inaccessible data as indeterminate.  One
of its practical use cases is to under-provision SATA SSDs for better
reliability and performance.

While there, fix HPA Security detection/reporting.

MFC after: 2 weeks
Relnotes: yes
Sponsored by: iXsystems, Inc.

4 years agoRestore WARNS?=1 here. I missed that libexec/bootpd/bootpgw existed.
brooks [Fri, 19 Jul 2019 18:47:13 +0000 (18:47 +0000)]
Restore WARNS?=1 here.  I missed that libexec/bootpd/bootpgw existed.

4 years agoKeep track of the number of commands that exhaust their retry limit.
imp [Fri, 19 Jul 2019 18:39:24 +0000 (18:39 +0000)]
Keep track of the number of commands that exhaust their retry limit.

While we print failure messages on the console, sometimes logs are lost or
overwhelmed. Keeping a count of how many times we've failed retriable commands
helps get a magnitude of the problem.

4 years agoKeep track of the number of retried commands.
imp [Fri, 19 Jul 2019 18:39:18 +0000 (18:39 +0000)]
Keep track of the number of retried commands.

Retried commands can indicate a performance degredation of an nvme drive. Keep
track of the number of retries and report it out via sysctl, just like number of
commands an interrupts.

4 years agoRemove pre-FreeBSD 7.0 compatibility.
imp [Fri, 19 Jul 2019 18:38:47 +0000 (18:38 +0000)]
Remove pre-FreeBSD 7.0 compatibility.

4 years agoChain Makefile.inc's so default are inherited as expected.
brooks [Fri, 19 Jul 2019 17:52:23 +0000 (17:52 +0000)]
Chain Makefile.inc's so default are inherited as expected.

Remove unneeded or duplicate variables.

No functional change.

Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL

4 years agoAdd comments about KERN_OPT here.
imp [Fri, 19 Jul 2019 17:48:29 +0000 (17:48 +0000)]
Add comments about KERN_OPT here.

4 years agopkgbase: move man pages from runtime-manual to runtime
manu [Fri, 19 Jul 2019 15:12:20 +0000 (15:12 +0000)]
pkgbase: move man pages from runtime-manual to runtime

We don't split the other man pages in their own package so do the same for runtime.

Reviewed by: bapt, gjb
Differential Revision: https://reviews.freebsd.org/D20962

4 years agobsd.confs.mk: Test the correct value for the destination package
manu [Fri, 19 Jul 2019 15:11:32 +0000 (15:11 +0000)]
bsd.confs.mk: Test the correct value for the destination package

Reviewed by: bapt, gjb
Differential Revision: https://reviews.freebsd.org/D20961

4 years agopkgbase: Add a FreeBSD-dpv package
manu [Fri, 19 Jul 2019 15:10:53 +0000 (15:10 +0000)]
pkgbase: Add a FreeBSD-dpv package

Move the dpv related files from FreeBSD-runtime to a new package named
FreeBSD-dpv
The only consumer is bsdinstall which is already in it's own package.

Reviewed by: bapt, gjb
Differential Revision: https://reviews.freebsd.org/D20960

4 years agopkgbase: Add a FreeBSD-bluetooth package
manu [Fri, 19 Jul 2019 15:10:03 +0000 (15:10 +0000)]
pkgbase: Add a FreeBSD-bluetooth package

Move the bluetooth related files from FreeBSD-runtime to a new package named
FreeBSD-bluetooth
The FreeBSD runtime is only intended to have everything for a working
FreeBSD installation and bluetooth isn't needed for that.

Reviewed by: bapt, gjb
Differential Revision: https://reviews.freebsd.org/D20959

4 years agopkgbase: Add a FreeBSD-hostapd package
manu [Fri, 19 Jul 2019 15:09:00 +0000 (15:09 +0000)]
pkgbase: Add a FreeBSD-hostapd package

Move the hostapd related files from FreeBSD-runtime to a new package n
FreeBSD-hostapd
The FreeBSD runtime is only intended to have everything for a working
FreeBSD installation and hostapd isn't needed for that.

Reviewed by: bapt, gjb
Differential Revision: https://reviews.freebsd.org/D20958

4 years agopkgbase: Add a FreeBSD-wpa package
manu [Fri, 19 Jul 2019 15:07:30 +0000 (15:07 +0000)]
pkgbase: Add a FreeBSD-wpa package

Move the wpa related files from FreeBSD-runtime to a new package named
FreeBSD-wpa
The FreeBSD runtime is only intended to have everything for a working
FreeBSD installation and wpa isn't needed for that.

Reviewed by:    bapt, gjb
Differential Revision:  https://reviews.freebsd.org/D20957

4 years agoUse sysctl + CTLRWTUN for hw.nvme.verbose_cmd_dump.
imp [Fri, 19 Jul 2019 00:32:56 +0000 (00:32 +0000)]
Use sysctl + CTLRWTUN for hw.nvme.verbose_cmd_dump.

Also convert it to a bool. While the rest of the driver isn't yet bool clean,
this will help.

Reviewed by: cem@
Differential Revision: https://reviews.freebsd.org/D20988

4 years agoRework some multi-output target dependency handling.
bdrewery [Fri, 19 Jul 2019 00:15:25 +0000 (00:15 +0000)]
Rework some multi-output target dependency handling.

This reworks my last commit in r301285 to more closely match what was in
r241298 (but reverted in r294878).

This is addressing "missing .meta file" rebuilds but also ensuring that
files are always generated when needed in each case.

Note that this is not a complete rework of the problem areas identified
in r301285 as most are "good enough" right now as the new pattern
is too verbose. It's only worth making this current change where headers
may be generated in the INCS list; where missing .meta file rebuilds are
spotted.

--- Technical details follow ---

Several attempts to deal with this problem of multi-output targets, with and
without META MODE, were explained in r241298, r294878, and r301285.

The general problem is with multi-output targets such as:
        foo.c foo.h:
                touch foo.c foo.h
        foo.c foo.h:
                touch foo.c
                touch foo.h
        foo.c foo.h: foo.in
                ./generator ${.ALLSRC}

This pattern is problematic in jobs mode as both files end up being
built concurrently and leads to races. With META MODE it is worse
as both targets end up rebuilding if they lack a .meta file. So the
generator is force built twice even though it is only needed once.
There are also problems in that 'make foo.h' may be ran before 'make foo.c';
The order of make generating the targets is not guaranteed.

An older attempted workaround to this (discussed in r294878) was:
        foo.h: foo.c
        foo.c: foo.in
                ./generator ${.ALLSRC}
This appears fine except that if foo.h is missing and foo.c exists then
foo.h will never be regenerated. This pattern is close to the solution
in this commit though:

        foo.h: foo.c .NOMETA
        .if !exists(foo.h)
        foo.c: .PHONY .META
        .endif
        foo.c: foo.in
                ./generator ${.ALLSRC}

There's 2 differences here:
1. foo.h will never expect to have a .meta file since the foo.c target
   will generate both and own the .meta file.
2. If foo.h does not exist then it needs to force foo.c to be rebuilt
   with .PHONY. That normally disables META MODE though so .META is
   given to tell bmake we do really expect a .meta file.

This pattern cannot work with implicit suffix rules since the .c and .h files
may be generated at different times (buildincludes vs depend/all).

Sponsored by: Dell EMC
MFC after: 2 weeks

4 years agoProvide new tunable hw.nvme.verbose_cmd_dump
imp [Thu, 18 Jul 2019 21:58:51 +0000 (21:58 +0000)]
Provide new tunable hw.nvme.verbose_cmd_dump

The nvme drive dumps only the most relevant details about a command when it
fails. However, there are times this is not sufficient (such as debugging weird
issues for a new drive with a vendor). Setting hw.nvme.verbose_cmd_dump=1
in loader.conf will enable more complete debugging information about each
command that fails.

Reviewed by: rpokala
Sponsored by: Netflix
Differential Version: https://reviews.freebsd.org/D20988

4 years agoInclude a mode when creating files with openat().
brooks [Thu, 18 Jul 2019 21:37:50 +0000 (21:37 +0000)]
Include a mode when creating files with openat().

Reviewed by: asomers
Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D20989

4 years agoDocument that setmode(3) is not thread safe.
brooks [Thu, 18 Jul 2019 21:33:55 +0000 (21:33 +0000)]
Document that setmode(3) is not thread safe.

In some circumstances, setmode(3) may call umask(2) twice to retrieve
the current mode and then restore it.  Between calls, the process will
have a umask of 0.

Reviewed by: markj
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D20982

4 years agoProvide macros to extract the sub-fields of the CAP_LO and CAP_HI registers.
imp [Thu, 18 Jul 2019 15:41:10 +0000 (15:41 +0000)]
Provide macros to extract the sub-fields of the CAP_LO and CAP_HI registers.

These macros make places where we extract these easier to read. The shift and
mask stuff is also a bit tedious and error prone. Start with the CAP_LO and
CAP_HI registers since their scope is somewhat constrained. This is style
chagne only, no functional changes.

Reviewed by: chuck
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D20979

4 years agoRename arm64 macros in preperation for a script to generate them.
andrew [Thu, 18 Jul 2019 13:58:04 +0000 (13:58 +0000)]
Rename arm64 macros in preperation for a script to generate them.

I have a script to generate most of the ID_AA64* macros from the Arm
XML source [1]. In preperation for using this we need to clean up the
macros to be in line with what the script will generate. This is the
first step, rename the macros to follow the names in said XML.

[1] https://developer.arm.com/architectures/cpu-architecture/a-profile/exploration-tools

MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D20976