]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/log
FreeBSD/FreeBSD.git
2 years agoAdd new vnode dumper to support live minidumps
Mitchell Horne [Tue, 23 Mar 2021 20:47:14 +0000 (17:47 -0300)]
Add new vnode dumper to support live minidumps

This dumper can instantiate and write the dump's contents to a
file-backed vnode.

Unlike existing disk or network dumpers, the vnode dumper should not be
invoked during a system panic, and therefore is not added to the global
dumper_configs list. Instead, the vnode dumper is constructed ad-hoc
when a live dump is requested using the new ioctl on /dev/mem. This is
similar in spirit to a kgdb session against the live system via
/dev/mem.

As described briefly in the mem(4) man page, live dumps are not
guaranteed to result in a usuable output file, but offer some debugging
value where forcefully panicing a system to dump its memory is not
desirable/feasible.

A future change to savecore(8) will add an option to save a live dump.

Reviewed by: markj, Pau Amma <pauamma@gundo.com> (manpages)
Discussed with: kib
MFC after: 3 weeks
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D33813

2 years agoSplit out dumper allocation from list insertion
Mitchell Horne [Mon, 9 Aug 2021 17:21:07 +0000 (14:21 -0300)]
Split out dumper allocation from list insertion

Add a new function, dumper_create(), to allocate a dumper.
dumper_insert() will call this function and retains the existing
behaviour.

This is desirable for performing live dumps of the system. Here, there
is a need to allocate and configure a dumper structure that is invoked
outside of the typical debugger context. Therefore, it should be
excluded from the list of panic-time dumpers.

free_single_dumper() is made public and renamed to dumper_destroy().

Reviewed by: kib, markj
MFC after: 1 week
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D34068

2 years agomem(4): Improve ioctl section formatting
Mitchell Horne [Thu, 24 Feb 2022 16:15:17 +0000 (12:15 -0400)]
mem(4): Improve ioctl section formatting

Add the missing .El which fixes the indentation of the memory range
definitions and operation. Add subsection headings to further clarify
this section. Do the same for the RETURN VALUES section, and mention
explicitly that MEM_EXTRACT_PADDR always returns zero.

Reviewed by: markj, 0mp, Pau Amma <pauamma@gundo.com>
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D34574

2 years agoUnbreak the build: Also define NFSV42_OLDNPROCS here.
Warner Losh [Tue, 5 Apr 2022 17:54:20 +0000 (11:54 -0600)]
Unbreak the build: Also define NFSV42_OLDNPROCS here.

If nfsproto.h is included before nfsport.h, then NFSV42_OLDNPROCS would
be undefined when it is used in struct nfsstatsov1.

Sponsored by: Netflix

2 years agonfscl: Add support for a NFSv4 AppendWrite RPC
Rick Macklem [Tue, 5 Apr 2022 15:11:37 +0000 (08:11 -0700)]
nfscl: Add support for a NFSv4 AppendWrite RPC

For IO_APPEND VOP_WRITE()s, the code first does a
Getattr RPC to acquire the file's size, before it
can do the Write RPC.

Although NFS does not have an append write operation,
an NFSv4 compound can use a Verify operation to check
that the client's notion of the file's size is
correct before doing the Write operation.

This patch prepares the NFSv4 client for such an
RPC, which will be added in a future commit.

This patch does not cause any semantics change.

2 years agomrsas: if controller reset is in progress, refrain from firing DCMDs to
Chandrakanth Patil [Fri, 21 Jan 2022 09:24:37 +0000 (14:54 +0530)]
mrsas: if controller reset is in progress, refrain from firing DCMDs to
firmware in shutdown

If controller reset is in progress, at same time if system shutdown is
issued then corresponding shutdown function in driver will be invoked
where driver is waiting 15 seconds to complete the controller reset.

If the reset is not complteted within that time frame driver will go
ahead and fire cache flush and shutdown DCMDs which will end up
accessing the the queues which are not initialized due to undergoing
reset leads to FMU error in firmware.

Fix:
In shutdown function, if controller reset is not finished within 15
seconds than driver will return to the OS without firing any DCMDs.

Reviewed by: imp
PR: 261375

2 years agomrsas: remove additional MPT command allocation for R1 FP command
Chandrakanth Patil [Fri, 21 Jan 2022 12:11:49 +0000 (17:41 +0530)]
mrsas: remove additional MPT command allocation for R1 FP command

There is an additional MPT command allocation for R1 fp command which
will lead to MPT command unavailablity in case of rigorous R1 FP IOs.

Remove additional MPT command allocation for R1 FP.

Reviewed by: imp
PR: 261377

2 years agotcp cc: don't recurse on non recursive mutex
Michael Tuexen [Tue, 5 Apr 2022 11:50:49 +0000 (13:50 +0200)]
tcp cc: don't recurse on non recursive mutex

This issue was found by syzkaller.

Reviewed by: rrs
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D34743

2 years agostress2: Added a syzkaller reproducer
Peter Holm [Tue, 5 Apr 2022 08:47:27 +0000 (10:47 +0200)]
stress2: Added a syzkaller reproducer

2 years agolocales: fix installation of some collation files
Baptiste Daroussin [Tue, 5 Apr 2022 07:12:24 +0000 (09:12 +0200)]
locales: fix installation of some collation files

When the unicode locales files where split off the non unicode locales
be_BY.ISO8859-5 and ca_IT.ISO8859-15 where non installed one due to
a typo, the other one was just missing its entry in the Makefile.

It was only notice a year later, by some postgres developpers as it was
breaking some of their tests.

Reported by: tmunro

2 years agolinuxkpi: move io_mapping_create_wc to .c
Warner Losh [Tue, 5 Apr 2022 05:06:37 +0000 (23:06 -0600)]
linuxkpi: move io_mapping_create_wc to .c

Move io_mapping_create_wc to .c because it encodes the size of struct
io_mapping so we move this from the client module to the linuxkpi
module.

Sponsored by: Netflix
Reviewed by: hselasky, emaste
Differential Revision: https://reviews.freebsd.org/D34776

2 years agolinuxkpi: Move lkpi_pcim_iomap_devres_find to .c file
Warner Losh [Tue, 5 Apr 2022 05:06:29 +0000 (23:06 -0600)]
linuxkpi: Move lkpi_pcim_iomap_devres_find to .c file

lkpi_pcim_iomap_devres_find encodes the size of struct pcim_iomap_devres
in the code, so move from .h to .c to move from client driver to
linuxkpi module.

Sponsored by: Netflix
Reviewed by: hselasky
Differential Revision: https://reviews.freebsd.org/D34775

2 years agolinuxkpi: Move pci_alloc_irq_vectors to .c file
Warner Losh [Tue, 5 Apr 2022 05:06:21 +0000 (23:06 -0600)]
linuxkpi: Move pci_alloc_irq_vectors to .c file

pci_alloc_irq_vectors encodes the size of struct msix_entry
into its code. Move from .h to .c to move this knowledge from
client modules to linuxkpi module.

Sponsored by: Netflix
Reviewed by: hselasky
Differential Revision: https://reviews.freebsd.org/D34774

2 years agolinuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c
Warner Losh [Tue, 5 Apr 2022 05:06:14 +0000 (23:06 -0600)]
linuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c

Both pci_request_region and _lkpi_pci_iomap encode the size of struct
pci_mmio_region into their code. Move from .h to .c files to move that
knowledge from the client drivers into the linuxkpi module.

Sponsored by: Netflix
Reviewed by: hselasky
Differential Revision: https://reviews.freebsd.org/D34773

2 years agolinuxkpi: Move lkpi_pci_devres_get_alloc into .c file
Warner Losh [Tue, 5 Apr 2022 05:06:06 +0000 (23:06 -0600)]
linuxkpi: Move lkpi_pci_devres_get_alloc into .c file

lkpi_pci_devres_get_alloc encodes the struct pci_devres into its
code. Move from .h file to .c file to move this knowledge into linuxkpi
module.

Sponsored by: Netflix
Reviewed by: hselasky, emaste
Differential Revision: https://reviews.freebsd.org/D34772

2 years agolinuxkpi: Move cdev_alloc into .c file
Warner Losh [Tue, 5 Apr 2022 05:05:59 +0000 (23:05 -0600)]
linuxkpi: Move cdev_alloc into .c file

Move cdev_alloc into linux_compat.c since it encodes the size of struct
linux_cdev into the client modules otherwise.

Sponsored by: Netflix
Reviewed by: hselasky, emaste
Differential Revision: https://reviews.freebsd.org/D34771

2 years agolinuxkpi: Remove write only variable from lkpi_iicbb_reset
Warner Losh [Tue, 5 Apr 2022 05:05:52 +0000 (23:05 -0600)]
linuxkpi: Remove write only variable from lkpi_iicbb_reset

Sponsored by: Netflix
Reviewed by: hselasky
Differential Revision: https://reviews.freebsd.org/D34770

2 years agolinuxkpi: Move class_create to .c file
Warner Losh [Tue, 5 Apr 2022 05:05:43 +0000 (23:05 -0600)]
linuxkpi: Move class_create to .c file

class_create encodes the size of struct class into the generated
code. Move from .h file to .c file to move this knowledge from the
client modules that call this into the linuxkpi module.

Sponsored by: Netflix
Reviewed by: hselasky, emaste
Differential Revision: https://reviews.freebsd.org/D34769

2 years agolinuxkpi: Move device_create_groups_vargs to linux_compat.c
Warner Losh [Tue, 5 Apr 2022 05:05:36 +0000 (23:05 -0600)]
linuxkpi: Move device_create_groups_vargs to linux_compat.c

device_create_groups_vargs encodes the size of struct device. Move
definition from .h to .c to move this size into the linuxkpi module
rather than encoding it in all client driver modules.

Sponsored by: Netflix
Reviewed by: hselasky, emaste
Differential Revision: https://reviews.freebsd.org/D34768

2 years agolinuxkpi: move kobject_create to .c file
Warner Losh [Tue, 5 Apr 2022 05:05:26 +0000 (23:05 -0600)]
linuxkpi: move kobject_create to .c file

kobject_create knows the size of struct kobject. Move it to
linux_compat.c so this knowledge is confined to the loadable module and
not the clients.

Sponsored by: Netflix
Reviewed by: hselasky, emaste
Differential Revision: https://reviews.freebsd.org/D34767

2 years agosvc_vc_rendezvous_stat: eliminiate write only variable stat
Warner Losh [Tue, 5 Apr 2022 02:43:03 +0000 (20:43 -0600)]
svc_vc_rendezvous_stat: eliminiate write only variable stat

Sponsored by: Netflix

2 years agoclnt_vc_destroy: eliminiate write only variable stat
Warner Losh [Tue, 5 Apr 2022 02:42:37 +0000 (20:42 -0600)]
clnt_vc_destroy: eliminiate write only variable stat

Sponsored by: Netflix

2 years agokrpc_call: eliminiate write only variable nam
Warner Losh [Tue, 5 Apr 2022 02:42:08 +0000 (20:42 -0600)]
krpc_call: eliminiate write only variable nam

Sponsored by: Netflix

2 years agobootpc_decode_reply: eliminiate write only variable ip
Warner Losh [Tue, 5 Apr 2022 02:41:28 +0000 (20:41 -0600)]
bootpc_decode_reply: eliminiate write only variable ip

Sponsored by: Netflix

2 years agosmb_smb_treedisconnect: eliminate write only variable mbp
Warner Losh [Tue, 5 Apr 2022 02:40:38 +0000 (20:40 -0600)]
smb_smb_treedisconnect: eliminate write only variable mbp

Sponsored by: Netflix

2 years agosmb_iod_main: eliminate write only variable error
Warner Losh [Tue, 5 Apr 2022 02:40:16 +0000 (20:40 -0600)]
smb_iod_main: eliminate write only variable error

Sponsored by: Netflix

2 years agopim6_input: eliminate write only variable rc
Warner Losh [Tue, 5 Apr 2022 02:39:25 +0000 (20:39 -0600)]
pim6_input: eliminate write only variable rc

Sponsored by: Netflix

2 years agosysctl_dumpentry: move error to inner scope
Warner Losh [Tue, 5 Apr 2022 02:38:56 +0000 (20:38 -0600)]
sysctl_dumpentry: move error to inner scope

Sponsored by: Netflix

2 years agoroute_ctl: eliminate write only variables ifa and nh
Warner Losh [Tue, 5 Apr 2022 02:37:59 +0000 (20:37 -0600)]
route_ctl: eliminate write only variables ifa and nh

Sponsored by: Netflix

2 years agoget_nhop: eliminate write only variable gateway
Warner Losh [Tue, 5 Apr 2022 02:37:22 +0000 (20:37 -0600)]
get_nhop: eliminate write only variable gateway

Sponsored by: Netflix

2 years agoxl_attach: eliminate write only variable unit
Warner Losh [Tue, 5 Apr 2022 02:33:25 +0000 (20:33 -0600)]
xl_attach: eliminate write only variable unit

Sponsored by: Netflix

2 years agovtpci_legacy_register_msix: eliminate write only variable dev
Warner Losh [Tue, 5 Apr 2022 02:33:01 +0000 (20:33 -0600)]
vtpci_legacy_register_msix: eliminate write only variable dev

Sponsored by: Netflix

2 years agoustorage_fs_verify: eliminate write only variables file_offset and file_offset
Warner Losh [Tue, 5 Apr 2022 02:31:54 +0000 (20:31 -0600)]
ustorage_fs_verify: eliminate write only variables file_offset and file_offset

Sponsored by: Netflix

2 years agomgue: eliminate write only variables ret, err and error
Warner Losh [Tue, 5 Apr 2022 02:31:06 +0000 (20:31 -0600)]
mgue: eliminate write only variables ret, err and error

Sponsored by: Netflix

2 years agocp2112iic_intr_write_callback: eliminate write only variable psc
Warner Losh [Tue, 5 Apr 2022 02:29:43 +0000 (20:29 -0600)]
cp2112iic_intr_write_callback: eliminate write only variable psc

Sponsored by: Netflix

2 years agowsp_intr_callback: eliminate write only variable h
Warner Losh [Tue, 5 Apr 2022 02:29:20 +0000 (20:29 -0600)]
wsp_intr_callback: eliminate write only variable h

Sponsored by: Netflix

2 years agouss820dci: eliminate unused variables sc, ep_no
Warner Losh [Tue, 5 Apr 2022 02:28:29 +0000 (20:28 -0600)]
uss820dci: eliminate unused variables sc, ep_no

Sponsored by: Netflix

2 years agouhci_xfer_setup: eliminate write only variable sc
Warner Losh [Tue, 5 Apr 2022 02:27:58 +0000 (20:27 -0600)]
uhci_xfer_setup: eliminate write only variable sc

Sponsored by: Netflix

2 years agomusb: eliminate write only variable sc
Warner Losh [Tue, 5 Apr 2022 02:27:08 +0000 (20:27 -0600)]
musb: eliminate write only variable sc

Sponsored by: Netflix

2 years agoatmegadci: eliminate unused variables sc, ep_no
Warner Losh [Tue, 5 Apr 2022 02:26:21 +0000 (20:26 -0600)]
atmegadci: eliminate unused variables sc, ep_no

Sponsored by: Netflix

2 years agohdspe_dmapsetmap: eliminate write only variable sc
Warner Losh [Tue, 5 Apr 2022 02:25:54 +0000 (20:25 -0600)]
hdspe_dmapsetmap: eliminate write only variable sc

Sponsored by: Netflix

2 years agoquicc_bus_setsig: eliminate write only variable bas
Warner Losh [Tue, 5 Apr 2022 02:25:23 +0000 (20:25 -0600)]
quicc_bus_setsig: eliminate write only variable bas

Sponsored by: Netflix

2 years agohdaa_eld_dump: eliminate write only variable len
Warner Losh [Tue, 5 Apr 2022 02:24:21 +0000 (20:24 -0600)]
hdaa_eld_dump: eliminate write only variable len

Sponsored by: Netflix

2 years agoemu10kx: eliminate write only variables val, r and move i to loop
Warner Losh [Tue, 5 Apr 2022 02:23:43 +0000 (20:23 -0600)]
emu10kx: eliminate write only variables val, r and move i to loop

Sponsored by: Netflix

2 years agoemu10kx-pci: eliminate write only variable r
Warner Losh [Tue, 5 Apr 2022 02:19:06 +0000 (20:19 -0600)]
emu10kx-pci: eliminate write only variable r

Sponsored by: Netflix

2 years agoemu_midi_probe: eliminate write only variable r
Warner Losh [Tue, 5 Apr 2022 02:18:10 +0000 (20:18 -0600)]
emu_midi_probe: eliminate write only variable r

Sponsored by: Netflix

2 years agopcmcsa_attach: eliminate write only variable unit
Warner Losh [Tue, 5 Apr 2022 02:17:30 +0000 (20:17 -0600)]
pcmcsa_attach: eliminate write only variable unit

Sponsored by: Netflix

2 years agomidicsa_attach: eliminate write only variable func
Warner Losh [Tue, 5 Apr 2022 02:16:49 +0000 (20:16 -0600)]
midicsa_attach: eliminate write only variable func

Sponsored by: Netflix

2 years agocs4281: eliminate write only variable codecno
Warner Losh [Tue, 5 Apr 2022 02:16:20 +0000 (20:16 -0600)]
cs4281: eliminate write only variable codecno

Sponsored by: Netflix

2 years agosb_probe: eliminate write only variable r
Warner Losh [Tue, 5 Apr 2022 02:15:50 +0000 (20:15 -0600)]
sb_probe: eliminate write only variable r

Sponsored by: Netflix

2 years agosb16_probe: eliminate write only variable r
Warner Losh [Tue, 5 Apr 2022 02:14:21 +0000 (20:14 -0600)]
sb16_probe: eliminate write only variable r

Sponsored by: Netflix

2 years agoess_probe: eliminate write only variable r
Warner Losh [Tue, 5 Apr 2022 02:13:56 +0000 (20:13 -0600)]
ess_probe: eliminate write only variable r

Sponsored by: Netflix

2 years agosis_attach: Move waittime definition into for loop
Warner Losh [Tue, 5 Apr 2022 02:13:32 +0000 (20:13 -0600)]
sis_attach: Move waittime definition into for loop

Sponsored by: Netflix

2 years agoppc_detect_fifo: eliminate write only variable cc
Warner Losh [Tue, 5 Apr 2022 02:12:44 +0000 (20:12 -0600)]
ppc_detect_fifo: eliminate write only variable cc

Sponsored by: Netflix

2 years agoppi_probe: eliminate unused variable ppi
Warner Losh [Tue, 5 Apr 2022 02:12:17 +0000 (20:12 -0600)]
ppi_probe: eliminate unused variable ppi

Sponsored by: Netflix

2 years agoMark cfg as __unused to avoid ifdef soup
Warner Losh [Tue, 5 Apr 2022 02:11:40 +0000 (20:11 -0600)]
Mark cfg as __unused to avoid ifdef soup

Sponsored by: Netflix

2 years agomxge_rss_ethp_z8e_fw_modevent: eliminate write only variable parent
Warner Losh [Tue, 5 Apr 2022 02:10:45 +0000 (20:10 -0600)]
mxge_rss_ethp_z8e_fw_modevent: eliminate write only variable parent

Sponsored by: Netflix

2 years agomxge_rss_eth_z8e_fw_modevent: eliminate write only variable parent
Warner Losh [Tue, 5 Apr 2022 02:09:57 +0000 (20:09 -0600)]
mxge_rss_eth_z8e_fw_modevent: eliminate write only variable parent

Sponsored by: Netflix

2 years agomxge_ethp_z8e_fw_modevent: eliminate write only variable parent
Warner Losh [Tue, 5 Apr 2022 02:09:27 +0000 (20:09 -0600)]
mxge_ethp_z8e_fw_modevent: eliminate write only variable parent

Sponsored by: Netflix

2 years agomxge_eth_z8e_fw_modevent: eliminate write only variable parent
Warner Losh [Tue, 5 Apr 2022 02:08:56 +0000 (20:08 -0600)]
mxge_eth_z8e_fw_modevent: eliminate write only variable parent

Sponsored by: Netflix

2 years agomge: eliminate write only variables ifp, sc and error
Warner Losh [Tue, 5 Apr 2022 02:08:21 +0000 (20:08 -0600)]
mge: eliminate write only variables ifp, sc and error

Sponsored by: Netflix

2 years agotmp461_signed_extend32 is unused, remove it
Warner Losh [Tue, 5 Apr 2022 01:38:02 +0000 (19:38 -0600)]
tmp461_signed_extend32 is unused, remove it

Sponsored by: Netflix

2 years agorx8803_settime: remove write only variable bus
Warner Losh [Tue, 5 Apr 2022 01:35:22 +0000 (19:35 -0600)]
rx8803_settime: remove write only variable bus

Sponsored by: Netflix

2 years agotca6416: remove write only sc
Warner Losh [Tue, 5 Apr 2022 01:34:59 +0000 (19:34 -0600)]
tca6416: remove write only sc

Sponsored by: Netflix

2 years agoarmv7_allocate_pmc: remove write only variable pac
Warner Losh [Tue, 5 Apr 2022 01:34:12 +0000 (19:34 -0600)]
armv7_allocate_pmc: remove write only variable pac

Sponsored by: Netflix

2 years agopmc_save_user_callchain: eliminate write only td variable
Warner Losh [Tue, 5 Apr 2022 00:05:03 +0000 (18:05 -0600)]
pmc_save_user_callchain: eliminate write only td variable

Sponsored by: Netflix

2 years agohpen_battery_strenght_cb: eliminate write only data variable
Warner Losh [Tue, 5 Apr 2022 00:04:38 +0000 (18:04 -0600)]
hpen_battery_strenght_cb: eliminate write only data variable

Sponsored by: Netflix

2 years agomx25l_task: eliminate dev write only variable
Warner Losh [Tue, 5 Apr 2022 00:04:15 +0000 (18:04 -0600)]
mx25l_task: eliminate dev write only variable

Sponsored by: Netflix

2 years agofd_probe: only define unit on x86, other platforms don't use this code
Warner Losh [Tue, 5 Apr 2022 00:03:54 +0000 (18:03 -0600)]
fd_probe: only define unit on x86, other platforms don't use this code

Sponsored by: Netflix

2 years agoe6000sw_set_atustat: eliminate write only ret variable
Warner Losh [Tue, 5 Apr 2022 00:03:18 +0000 (18:03 -0600)]
e6000sw_set_atustat: eliminate write only ret variable

Sponsored by: Netflix

2 years agocyapa_raw_input: elimmminate write only k variable
Warner Losh [Tue, 5 Apr 2022 00:02:52 +0000 (18:02 -0600)]
cyapa_raw_input: elimmminate write only k variable

Sponsored by: Netflix

2 years agobwn_lo_measure_gain_values: eliminate write only trsw_rx variable
Warner Losh [Tue, 5 Apr 2022 00:02:33 +0000 (18:02 -0600)]
bwn_lo_measure_gain_values: eliminate write only trsw_rx variable

Sponsored by: Netflix

2 years agobhnd_nvram_store_export_child: eliminate num_props write only variable
Warner Losh [Mon, 4 Apr 2022 23:59:13 +0000 (17:59 -0600)]
bhnd_nvram_store_export_child: eliminate num_props write only variable

Sponsored by: Netflix

2 years agobhnd_pmu_sdiod_drive_strength_init: eliminate write only intr_val variable
Warner Losh [Mon, 4 Apr 2022 23:58:17 +0000 (17:58 -0600)]
bhnd_pmu_sdiod_drive_strength_init: eliminate write only intr_val variable

Sponsored by: Netflix

2 years agobhnd_pwrctl_attach: eliminate write only bus variable
Warner Losh [Mon, 4 Apr 2022 23:57:49 +0000 (17:57 -0600)]
bhnd_pwrctl_attach: eliminate write only bus variable

Sponsored by: Netflix

2 years agofdt_win_process_child: eliminate write only size variable
Warner Losh [Mon, 4 Apr 2022 23:56:31 +0000 (17:56 -0600)]
fdt_win_process_child: eliminate write only size variable

Sponsored by: Netflix

2 years agoplatform_mpp_init: eliminate write only tuples variable
Warner Losh [Mon, 4 Apr 2022 23:56:02 +0000 (17:56 -0600)]
platform_mpp_init: eliminate write only tuples variable

Sponsored by: Netflix

2 years agomv_rtc_attach: eliminate write only unit variable
Warner Losh [Mon, 4 Apr 2022 23:55:30 +0000 (17:55 -0600)]
mv_rtc_attach: eliminate write only unit variable

Sponsored by: Netflix

2 years agovfp_init: eliminate fpexc write only variable
Warner Losh [Mon, 4 Apr 2022 23:54:55 +0000 (17:54 -0600)]
vfp_init: eliminate fpexc write only variable

Sponsored by: Netflix

2 years agosendsig: eliminate write only code variable
Warner Losh [Mon, 4 Apr 2022 23:54:23 +0000 (17:54 -0600)]
sendsig: eliminate write only code variable

Sponsored by: Netflix

2 years agoget_cachetype_cp15: eliminate write only multilier
Warner Losh [Mon, 4 Apr 2022 23:53:58 +0000 (17:53 -0600)]
get_cachetype_cp15: eliminate write only multilier

Sponsored by: Netflix

2 years agoARMADAXP: Add extres pseudo devices to some kernel
Warner Losh [Tue, 8 Mar 2022 17:52:31 +0000 (10:52 -0700)]
ARMADAXP: Add extres pseudo devices to some kernel

Add extres and related pseudo devices to allow this to compile.

Sponsored by: Netflix
PR: 262417

2 years agogeom_vinum: fix set but not used warnings
Robert Wing [Mon, 4 Apr 2022 21:23:47 +0000 (13:23 -0800)]
geom_vinum: fix set but not used warnings

2 years agogeom_eli: fix set but not used warning
Robert Wing [Mon, 4 Apr 2022 21:20:27 +0000 (13:20 -0800)]
geom_eli: fix set but not used warning

2 years agoFix typo (interrups -> interrupts) in a sysctl description in tcp_lro.c.
Navdeep Parhar [Mon, 4 Apr 2022 20:48:32 +0000 (13:48 -0700)]
Fix typo (interrups -> interrupts) in a sysctl description in tcp_lro.c.

MFC after: 3 days

2 years agolibpfctl: relocate implementations of pfr_add/get/set_addrs
Reid Linnemann [Mon, 4 Apr 2022 14:43:38 +0000 (16:43 +0200)]
libpfctl: relocate implementations of pfr_add/get/set_addrs

Reviewed by: kp
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D34740

2 years agozlib: replace CRLF line endings in zlib.map
Ed Maste [Mon, 4 Apr 2022 19:09:19 +0000 (15:09 -0400)]
zlib: replace CRLF line endings in zlib.map

MFC after: 3 days

2 years agowpa/hostapd: Fix 100% CPU when USB wlan NIC removed
Cy Schubert [Sun, 3 Apr 2022 03:54:50 +0000 (20:54 -0700)]
wpa/hostapd: Fix 100% CPU when USB wlan NIC removed

hostapd calls pcap_next(3) to read the next packet off the wlan interface.
pcap_next() returns a pointer to the packet header but does not indicate
success or failure. Unfortunately this results in an infinite loop (100%
CPU) when the wlan device disappears, i.e. when a USB wlan device is
manually removed or a USB error results in the device removal. However
pcap_next_ex(3) does return success or failure. To resolve this we use
pcap_next_ex(), forcing hostapd to exit when the error is encountered.

An error message is printed to syslog or stderr when debugging (-d flag)
is enabled. Unfortunately wpa_printf() only works when debugging is enabled.

PR: 253608
Reported by: Damjan Jovanovic <damjan.jov@gmail.com>,
bz (privately)
MFC after: 3 days

2 years agoshare/mk heimdal: Remove unnecessary trailing backslash
Cy Schubert [Sat, 2 Apr 2022 03:41:34 +0000 (20:41 -0700)]
share/mk heimdal: Remove unnecessary trailing backslash

Remove the trailing backslash from the last list item. This is a NOP and
never bothered anything because the next line was a blank line. Remove
it for correctness sake.

MFC after: 3 days

2 years agocpufreq.4: Use Xr for drivers with manuals
Mateusz Piotrowski [Mon, 4 Apr 2022 12:25:41 +0000 (14:25 +0200)]
cpufreq.4: Use Xr for drivers with manuals

While here, do not use Pa for drivers.

MFC after: 1 week

2 years agoCorrect a grammo.
Jens Schweikhardt [Mon, 4 Apr 2022 09:00:09 +0000 (11:00 +0200)]
Correct a grammo.

2 years agobsdinstall/partedit: Replace libdialog with libbsddialog
Alfonso S. Siciliano [Sun, 3 Apr 2022 23:52:00 +0000 (01:52 +0200)]
bsdinstall/partedit: Replace libdialog with libbsddialog

bsdinstall/partedit: Replace (LGPL) libdialog with (BSD-2-Clause)
libbsddialog. Rewrite diskeditor.c and rename diskmenu.c because
it uses an API for menu totally incompatible with libbsddialog.
This is a User Interface change everything else is unchanged.

Approved by: bapt (mentor)
Differential Revision: https://reviews.freebsd.org/D34639

2 years agoLinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors
Bjoern A. Zeeb [Wed, 30 Mar 2022 17:38:23 +0000 (17:38 +0000)]
LinuxKPI: PCI: add counter for linux_dma_map_phys_common() errors

LinuxKPI is asking for single-segment mappings.  Some (wireless) drivers
are using this to map multi-pages and our busdma framework is not very
friendly to that as single-segments [D31823].  Add a counter so we can
track when this happens to gather more information.

Sponsored by: The FreeBSD Foundation
Reviewed by: hselasky
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D34715

2 years agosys/contrib/zlib: Always define Z_U8 and Z_U4
Xin LI [Sun, 3 Apr 2022 18:45:38 +0000 (11:45 -0700)]
sys/contrib/zlib: Always define Z_U8 and Z_U4

This is a temporary hack for zlib to make sure that the library
still builds when building with Z_SOLO (used in kernel and loader),
as zlib is depending on limits.h which is only available in STDC
case.

PR: kern/262977
MFC after: 3 days

2 years agolib/libz: remove ZLIBprivate_1.0 namespace.
Xin LI [Sun, 3 Apr 2022 18:32:47 +0000 (11:32 -0700)]
lib/libz: remove ZLIBprivate_1.0 namespace.

These symbols were hidden and no longer exposed, and were never exposed in headers.

MFC after: 3 days

2 years agobsddialog(1): Improve --hline (help subtitle)
Alfonso S. Siciliano [Sun, 3 Apr 2022 20:22:52 +0000 (22:22 +0200)]
bsddialog(1): Improve --hline (help subtitle)

Improvement for bsdconfig(8): avoid to draw delimiters (or spaces) on
the bottom line if the argument of --hline is an empty string.

2 years agoMerge bmake-20220330
Simon J. Gerraty [Sun, 3 Apr 2022 19:55:42 +0000 (12:55 -0700)]
Merge bmake-20220330
Merge commit 'a052cb432096794be5070dc68a2b302eaf5a4783'

2 years agoImport bmake-20220330
Simon J. Gerraty [Sun, 3 Apr 2022 19:52:08 +0000 (12:52 -0700)]
Import bmake-20220330

Most relevant change:

o parse.c: try to include 'posix.mk' the first time
.POSIX: is encountered, to allow for beter POSIX compliance.

Others

o cond.c: make debug logging for comparisons less technical
o lst.c: fix mem leak in Lst_Remove
o job.c: fix echoing of command with '-' in silent target in jobs mode
o var.c: make debug logs more readable
prefer 'long long' over 'long' on 32-bit C99 platforms
fix crash on .undef of an environment variable

2 years agomii_fdt: fix a set-but-not-used warning
Mitchell Horne [Wed, 30 Mar 2022 21:45:54 +0000 (18:45 -0300)]
mii_fdt: fix a set-but-not-used warning

2 years agomii: include missing sources in loadable module
Milan Obuch [Sat, 2 Apr 2022 18:28:33 +0000 (15:28 -0300)]
mii: include missing sources in loadable module

As of today, using 'kldload miibus' is not equivalent to using 'device
miibus' in a kernel config. Newly introduced PHY drivers (DP83822,
DP83867, VSCPHY) and source files/PHY driver for FDT-enabled kernels
are missing. Without including them, kernel modules using any function
from dev/mii/mii_fdt.c refuse to load. Additionally, miivar.h directly
includes opt_platform.h.

Add the missing sources to the module build, with the FDT-only files
gated behind an OPT_FDT check. Maintain the alphabetical listing of
SRCS, but move the required header files to a separate line to improve
readability.

Reviewed by: mhorne, mindal@semihalf.com
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D34256