]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/log
FreeBSD/FreeBSD.git
6 years agostand/lua: Correct some trivial errors in config
Kyle Evans [Sat, 17 Feb 2018 04:22:36 +0000 (04:22 +0000)]
stand/lua: Correct some trivial errors in config

An empty module_path to start with isn't ideal, but if all modules are
contained within a kernel directory (which is what we just tested) then it
isn't strictly an error. Don't assume that module_path has a value already.

When we fail to load the kernel, printing the result (which is guaranteed to
be nil) is not intended; print the name of the kernel.

6 years agostand/lua: Color non-default kernels blue
Kyle Evans [Sat, 17 Feb 2018 04:07:16 +0000 (04:07 +0000)]
stand/lua: Color non-default kernels blue

6 years agostand/lua: Correct interpretation of autoboot_delay
Kyle Evans [Sat, 17 Feb 2018 03:39:55 +0000 (03:39 +0000)]
stand/lua: Correct interpretation of autoboot_delay

autoboot_delay=NO is documented to wait for input and *not* autoboot, which
is the exact opposite of the current behavior.

Additionally, autoboot_delay=-1 is documented to disallow the user from
interrupting the boot (i.e. autoboot immediately), which was not previously
honored.

This also fixes the case insensitive comparison to be truly case
insensitive. This is kind of nit-picky, but the previous version would only
accept "no" and "NO".

6 years agostand/lua: Enable menu autoboot; it seems to work
Kyle Evans [Sat, 17 Feb 2018 03:13:05 +0000 (03:13 +0000)]
stand/lua: Enable menu autoboot; it seems to work

6 years agostand/lua: Don't set autoboot_delay=NO in menu autoboot sequence
Kyle Evans [Sat, 17 Feb 2018 03:12:35 +0000 (03:12 +0000)]
stand/lua: Don't set autoboot_delay=NO in menu autoboot sequence

We'll set it later if "Escape to loader prompt" is actually chosen, there's
no need to be setting it here.

6 years agoOn process exit signal the parent after dropping the proctree lock.
Mateusz Guzik [Sat, 17 Feb 2018 00:24:50 +0000 (00:24 +0000)]
On process exit signal the parent after dropping the proctree lock.

6 years agoUnref the prison after proctree is dropped.
Mateusz Guzik [Sat, 17 Feb 2018 00:23:56 +0000 (00:23 +0000)]
Unref the prison after proctree is dropped.

6 years agoPostpone sx_sunlock(&proctree_lock) on fork until after allproc is dropped.
Mateusz Guzik [Sat, 17 Feb 2018 00:23:28 +0000 (00:23 +0000)]
Postpone sx_sunlock(&proctree_lock) on fork until after allproc is dropped.

There is a significant contention on the lock during -j 128 package build.
This change drops total wait time on this lock by 60%.

6 years agoTidy up kern_wait6
Mateusz Guzik [Sat, 17 Feb 2018 00:21:50 +0000 (00:21 +0000)]
Tidy up kern_wait6

- don't relock curproc in msleep
- don't relock proctree if P_STATCHILD is spotted
- reformat the proc_to_reap call in the main loop

6 years agoRevert r329269.
Benno Rice [Sat, 17 Feb 2018 00:12:30 +0000 (00:12 +0000)]
Revert r329269.

I tried to rework a section to fit inside 80 columns but the change ended
up being functional. Back this out so I can readdress.

6 years agostand/lua: Make CAROUSEL_ENTRY func parameters consistent with name
Kyle Evans [Fri, 16 Feb 2018 23:59:50 +0000 (23:59 +0000)]
stand/lua: Make CAROUSEL_ENTRY func parameters consistent with name

We have no need for the index yet, but add it anyways to keep signatures
consistent.

6 years agoRemove unused symbols.
Konstantin Belousov [Fri, 16 Feb 2018 23:18:42 +0000 (23:18 +0000)]
Remove unused symbols.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

6 years agostand/lua: Don't reload kernel config if we only have one kernel
Kyle Evans [Fri, 16 Feb 2018 22:57:52 +0000 (22:57 +0000)]
stand/lua: Don't reload kernel config if we only have one kernel

Don't move this into config.reload because we may want to force reloads if
/boot changes out from under us later.

As a caution: changing kernels in lualoader at the moment might not be
loading all of your modules (in my testing, at least) from loader.conf(5).
This is a known problem.

6 years agostand/lua: Don't try to divide by 0; do nothing
Kyle Evans [Fri, 16 Feb 2018 22:51:08 +0000 (22:51 +0000)]
stand/lua: Don't try to divide by 0; do nothing

6 years agostand/lua: Allow MENU_RETURN items to have a func, fix escape to prompt
Kyle Evans [Fri, 16 Feb 2018 22:17:30 +0000 (22:17 +0000)]
stand/lua: Allow MENU_RETURN items to have a func, fix escape to prompt

6 years agozfs: fix formatting in a log statement
Alan Somers [Fri, 16 Feb 2018 21:59:08 +0000 (21:59 +0000)]
zfs: fix formatting in a log statement

Submitted by: Dave Baukus <daveb@spectralogic.com>
MFC after: 3 weeks
Sponsored by: Spectra Logic Corp

6 years agotrpt(8): Clean up build hack to detect ancient compiler
Conrad Meyer [Fri, 16 Feb 2018 20:46:44 +0000 (20:46 +0000)]
trpt(8): Clean up build hack to detect ancient compiler

Detect ancient GCC specifically, rather than using target architecture as a
crude heuristic.

Side note: compilers should really ignore -Wno- and -Wno-error= flags they
don't recognize.  Seems like modern compilers produce warnings instead of
errors.  Though, with -Werror they turn into errors.  Clang's error can be
disabled with -Wno-error=unknown-warning-option, but GCC doesn't seem to
have a named method to disable the specific warning.

Submitted by: rpokala@ (earlier version)
Suggested by: rpokala@
Reviewed by: tinderbox
Sponsored by: Dell EMC Isilon

6 years agoUpgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
Dimitry Andric [Fri, 16 Feb 2018 20:45:32 +0000 (20:45 +0000)]
Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
6.0.0 (branches/release_60 r325330).

MFC after: 3 months
X-MFC-With: r327952
PR: 224669

6 years agolua-test: Image the loader test directory if it doesn't exist yet
Kyle Evans [Fri, 16 Feb 2018 20:26:18 +0000 (20:26 +0000)]
lua-test: Image the loader test directory if it doesn't exist yet

6 years agoDefault to /tmp/loadertest for lua test scripts
Kyle Evans [Fri, 16 Feb 2018 20:23:48 +0000 (20:23 +0000)]
Default to /tmp/loadertest for lua test scripts

6 years agoVendor import of llvm release_60 branch r325330:
Dimitry Andric [Fri, 16 Feb 2018 19:10:15 +0000 (19:10 +0000)]
Vendor import of llvm release_60 branch r325330:
https://llvm.org/svn/llvm-project/llvm/branches/release_60@325330

6 years agostand/lua: Use escaped dot instead of single character class
Kyle Evans [Fri, 16 Feb 2018 18:50:06 +0000 (18:50 +0000)]
stand/lua: Use escaped dot instead of single character class

6 years agoFollow r329348 in ipcs for getting rid of the requirement to include SysV IPC
Li-Wen Hsu [Fri, 16 Feb 2018 18:07:04 +0000 (18:07 +0000)]
Follow r329348 in ipcs for getting rid of the requirement to include SysV IPC
headers with _KERNEL

Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D14398

6 years agoxen/pv: remove the attach of the ISA bus from the Xen PV bus
Roger Pau Monné [Fri, 16 Feb 2018 18:04:27 +0000 (18:04 +0000)]
xen/pv: remove the attach of the ISA bus from the Xen PV bus

There's no need to attach the ISA bus from the Xen PV one.

Sponsored by:           Citrix Systems R&D

6 years agoDefine CK_MD_TSO for the relevant arches (i386, amd64 and sparc64).
Olivier Houchard [Fri, 16 Feb 2018 17:50:06 +0000 (17:50 +0000)]
Define CK_MD_TSO for the relevant arches (i386, amd64 and sparc64).
Defaulting to CK_MD_RMO has the unfortunate side effect of generating
memory barriers that are useless on those arches, and the even more
unfortunate side effect of generating lfence/sfence/mfence on i386, even
if older CPUs don't support it.
This should fix the panic reported when using IPFW on a Pentium 3.
Note that mfence and sfence might still be used in a few case, but that
shouldn't happen in FreeBSD right now, and should be fixed upstream first.

MFC after: 1 week

6 years agostand/lua: Chop off the decimal for numbers passed to setcursor
Kyle Evans [Fri, 16 Feb 2018 17:46:07 +0000 (17:46 +0000)]
stand/lua: Chop off the decimal for numbers passed to setcursor

Decimals screw up the escape sequence and the cursor will not get set. Right
now this only affects setting the cursor for drawing "Welcome to FreeBSD" --
the resulting number after our (x+(w/2)-9) calculation gets output as
"14.0."

This should be fixed at the interpreter level, rather than here, but this is
not a widespread problem at the moment so we'll fix it up in further work.

Reported by: David Wolfskill <david@catwhisker.org>
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D14375

6 years agostand/lua: Correct usage and acceptance of BACKSPACE/DELETE keys
Kyle Evans [Fri, 16 Feb 2018 17:42:38 +0000 (17:42 +0000)]
stand/lua: Correct usage and acceptance of BACKSPACE/DELETE keys

6 years agoHandle generic pathconf attributes in the .zfs ctldir
Alan Somers [Fri, 16 Feb 2018 16:56:09 +0000 (16:56 +0000)]
Handle generic pathconf attributes in the .zfs ctldir

MFC instructions: change the value of _PC_LINK_MAX to INT_MAX

Reported by: jhb
MFC after: 19 days
X-MFC-With: 329265
Sponsored by: Spectra Logic Corp

6 years agoPut the pine64 root filesystem on teh correct partition.
Andrew Turner [Fri, 16 Feb 2018 16:22:54 +0000 (16:22 +0000)]
Put the pine64 root filesystem on teh correct partition.

The Pine64 root filesystem was incorrectly created directly on the MBR
partition. This can cause the loader to get confused when loading the
kernel from this filesystem.

The loader will see this as a small partition meaning later checks to
ensure it doesn't read past the end of the disk incorrectly report a
failure. This seems to work mostly by accident with the released images as
they are smaller than the reported size, however after growfs has run the
image may no longer boot.

Reviewed by: gjb, emaste, imp
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D14343

6 years agoImplement mutex_trylock_recursive() in the LinuxKPI.
Hans Petter Selasky [Fri, 16 Feb 2018 16:01:39 +0000 (16:01 +0000)]
Implement mutex_trylock_recursive() in the LinuxKPI.

MFC after: 1 week
Submitted by: Johannes Lundberg <johalun0@gmail.com>
Sponsored by: Mellanox Technologies

6 years agoImplement memdup_user_nul() in the LinuxKPI.
Hans Petter Selasky [Fri, 16 Feb 2018 15:52:28 +0000 (15:52 +0000)]
Implement memdup_user_nul() in the LinuxKPI.

MFC after: 1 week
Submitted by: Johannes Lundberg <johalun0@gmail.com>
Sponsored by: Mellanox Technologies

6 years agoImplement tasklet_enable() and tasklet_disable() in the LinuxKPI.
Hans Petter Selasky [Fri, 16 Feb 2018 15:41:16 +0000 (15:41 +0000)]
Implement tasklet_enable() and tasklet_disable() in the LinuxKPI.

MFC after: 1 week
Requested by: Johannes Lundberg <johalun0@gmail.com>
Sponsored by: Mellanox Technologies

6 years agoFix a memory leak introduced in r328426.
Mark Johnston [Fri, 16 Feb 2018 15:41:03 +0000 (15:41 +0000)]
Fix a memory leak introduced in r328426.

ffs_sbget() may return a superblock buffer even if it fails, so the
caller must be prepared to free it in this case. Moreover, when tasting
alternate superblock locations in a loop, ffs_sbget()'s readfunc
callback must free the previously allocated buffer.

Reported and tested by: pho
Reviewed by: kib (previous version)
Differential Revision: https://reviews.freebsd.org/D14390

6 years agoUse the conventional name for an array of pages.
Mark Johnston [Fri, 16 Feb 2018 15:38:22 +0000 (15:38 +0000)]
Use the conventional name for an array of pages.

No functional change intended.

Discussed with: kib
MFC after: 3 days

6 years agoCorrect module symbol export handling
Ed Maste [Fri, 16 Feb 2018 15:38:02 +0000 (15:38 +0000)]
Correct module symbol export handling

EXPORT_SYMS can be set to YES, NO, a list of symbols to export from a
module, or to a filename containing such a list.  For the case that it
is set to a symbol list, replace spaces in the list with newlines, so
the created file is in the format expected by kmod_syms.awk.

Reviewed by: imp, jhb
MFC after: 1 month
Sponsored by: Turing Robotic Industries Inc.
Differential Revision: https://reviews.freebsd.org/D14284

6 years agoImplement enable_irq() and disable_irq() in the LinuxKPI.
Hans Petter Selasky [Fri, 16 Feb 2018 15:37:33 +0000 (15:37 +0000)]
Implement enable_irq() and disable_irq() in the LinuxKPI.

MFC after: 1 week
Submitted by: Johannes Lundberg <johalun0@gmail.com>
Sponsored by: Mellanox Technologies

6 years agoAllow the cmpxchg() macro in the LinuxKPI to work on pointers without
Hans Petter Selasky [Fri, 16 Feb 2018 15:20:21 +0000 (15:20 +0000)]
Allow the cmpxchg() macro in the LinuxKPI to work on pointers without
generating compiler warnings, -Wint-conversion .

Requested by: Johannes Lundberg <johalun0@gmail.com>
Sponsored by: Mellanox Technologies

6 years agoRationalize license text on Linuxolator files
Ed Maste [Fri, 16 Feb 2018 15:00:14 +0000 (15:00 +0000)]
Rationalize license text on Linuxolator files

Many licenses on Linuxolator files contained small variations from the
standard FreeBSD license text.  To avoid license proliferation switch to
the standard 2-clause FreeBSD license for those files where I have
permission from each of the listed copyright holders.  Additional files
waiting on permission from others are listed in review D14210.

Approved by: kan, marcel, sos, rdivacky
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

6 years agostand/lua: Remove sneaky kernel assignment
Kyle Evans [Fri, 16 Feb 2018 14:59:11 +0000 (14:59 +0000)]
stand/lua: Remove sneaky kernel assignment

6 years agostand/lua: Create/use some MENU_ constants where applicable
Kyle Evans [Fri, 16 Feb 2018 14:57:42 +0000 (14:57 +0000)]
stand/lua: Create/use some MENU_ constants where applicable

6 years agostand/lua: Create a "carousel" menu entry type
Kyle Evans [Fri, 16 Feb 2018 14:39:41 +0000 (14:39 +0000)]
stand/lua: Create a "carousel" menu entry type

This is a pre-cursor to boot environment support in lualoader. Create a new
menu item type, "carousel_entry", that generally provides a callback to get
the list of items, a carousel_id for storing the current value, and the
standard name/func functions that an entry has.

The difference between this and a normal menu item, functionally, is that
selecting a carousel item will automatically rotate through available items
and wrap back at the beginning when the list is exhausted.

The 'name' function takes the choice index, current choice, and the list of
choices as parameters so that the menu item can decorate the name freely as
desired.

The 'func' function takes the current choice as a parameter, so it can act
accordingly.

The kernel menu item has been rewritten to use the carousel_entry type as
both an example and initial test of its functionality before it is used for
boot environment options.

6 years agostand/lua: Set ACPI's default the proper way (setACPI)
Kyle Evans [Fri, 16 Feb 2018 13:57:43 +0000 (13:57 +0000)]
stand/lua: Set ACPI's default the proper way (setACPI)

6 years agoUse local symbol for offset.
Konstantin Belousov [Fri, 16 Feb 2018 13:32:46 +0000 (13:32 +0000)]
Use local symbol for offset.

Small global symbols confuse ddb which matches them against small
unrelated displacements and makes the disassembly ugly.

Reported by: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

6 years agomove vintr_intercept_enabled under INVARIANTS
Andriy Gapon [Fri, 16 Feb 2018 07:02:14 +0000 (07:02 +0000)]
move vintr_intercept_enabled under INVARIANTS

The function is not used outside of INVARIANTS since r328622.

MFC after: 1 week

6 years agoread-behind / read-ahead support for zfs_getpages()
Andriy Gapon [Fri, 16 Feb 2018 06:59:35 +0000 (06:59 +0000)]
read-behind / read-ahead support for zfs_getpages()

ZFS caches blocks it reads in its ARC, so in general the optional
pages are not as useful as with filesystems that read the data
directly into the target pages.  But still the optional pages
are useful to reduce the number of page faults and associated
VM / VFS / ZFS calls.
Another case that gets optimized (as a side effect) is paging in
from a hole.  ZFS DMU does not currently provide a convenient
API to check for a hole.  Instead it creates a temporary zero-filled
block and allows accessing it as if it were a normal data block.
Getting multiple pages one by one from a hole results in repeated
creation and destruction of the temporary block (and an associated
ARC header).

Tested with fsx using various supported blocks sizes from 512 bytes
to 128 KB and additionally 1 MB.

Please note that in illumos and ZoL they do not do the range-locking in
the page-in path. This is because ZFS has a double-caching problem
between ARC and page cache and that requires zfs_read() and zfs_write()
to consult pages in the page cache. So, in those functions they first
lock a range and then lock pages corresponding to the range. While in
the page-in (and maybe page-out) path they first lock the pages and then
would lock the range. So, they would have a deadlock.

I believe that FreeBSD does not have that problem, because the page-in
deals only with invalid pages while zfs_read() and zfs_write() need to
access only valid pages. They do not wait on a busy page unless it's
already valid.

Reviewed by: kib
MFC after: 3 weeks
Differential Revision: https://reviews.freebsd.org/D14263

6 years agoPrevent savecore from reading bounds from the current directory.
Mike Silbersack [Fri, 16 Feb 2018 06:51:39 +0000 (06:51 +0000)]
Prevent savecore from reading bounds from the current directory.

Rev 244218 removed the requirement that you provide a dump
directory when checking if there is a coredump ready to be written.
That had the side-effect of causing the bounds file to be read
from the current working directory instead of the dump directory.
As the bounds file is irrelevant when just checking, the simplest
fix is to not read the bounds file when checking.

Reviewed by: markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D14383

6 years agoDocument memset_s(3). memset_s(3) is defined in
Cy Schubert [Fri, 16 Feb 2018 05:48:45 +0000 (05:48 +0000)]
Document memset_s(3). memset_s(3) is defined in
C11 standard (ISO/IEC 9899:2011) K.3.7.4.1 The memset_s function
(p: 621-622)

Fix memset(3) portion of the man page by replacing the first argument
(destination) "b" with "dest", which is more descriptive than "b".
This also makes it consistent with the term used in the memset_s()
portion of the man page.

See also http://en.cppreference.com/w/c/string/byte/memset.

Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D13682

6 years agoThis change fixes duplicate detection of same IOMMU/AMD-Vi device for Ryzen with...
Anish Gupta [Fri, 16 Feb 2018 05:17:00 +0000 (05:17 +0000)]
This change fixes duplicate detection of same IOMMU/AMD-Vi device for Ryzen with EFR support.

IVRS can have entry of type legacy and non-legacy present at same time for same AMD-Vi device. ivhd driver will ignore legacy if new IVHD type is present as specified in AMD-Vi specification. Earlier both of IVHD entries used and two ivhd devices were created.
Add support for new IVHD type 0x11 and 0x40 in ACPI. Create new struct of type acpi_ivrs_hardware_new for these new type of IVHDs. Legacy type 0x10 will continue to use acpi_ivrs_hardware.

Reviewed by: avg
Approved by: grehan
Differential Revision:https://reviews.freebsd.org/D13160

6 years agostand/lua: Remove a magic number/string (not a trivial literal)
Kyle Evans [Fri, 16 Feb 2018 04:59:21 +0000 (04:59 +0000)]
stand/lua: Remove a magic number/string (not a trivial literal)

We'll arbitrarily use KEYSTR_ for string representations of non-trivial
characters.

6 years agostand/lua: Say "loader prompt" instead of "lua interpreter"
Kyle Evans [Fri, 16 Feb 2018 04:50:14 +0000 (04:50 +0000)]
stand/lua: Say "loader prompt" instead of "lua interpreter"

Noting that we're in lualoader is nice, but it's not a difference we raelly
need to expose to Fred. Re-word it to match the 4th wording and reduce
differences.

6 years agostand/lua: Remove explicit alias from "Back to main menu"
Kyle Evans [Fri, 16 Feb 2018 04:45:53 +0000 (04:45 +0000)]
stand/lua: Remove explicit alias from "Back to main menu"

This removes a redundant alias that has since been converted into a global
alias. It was converted to a global alias before to ensure that we always
have a way to go up one level in the menu.

6 years agostand/lua: Allow menu items to not have explicit aliases
Kyle Evans [Fri, 16 Feb 2018 04:44:47 +0000 (04:44 +0000)]
stand/lua: Allow menu items to not have explicit aliases

This will generally be used for cases like "Back to main menu" that already
have global aliases installed.

6 years agostand/lua: Move kernel selection into main menu
Kyle Evans [Fri, 16 Feb 2018 04:31:09 +0000 (04:31 +0000)]
stand/lua: Move kernel selection into main menu

This matches the corresponding 4th behavior.

6 years agotrpt(8): Work around GCC4 shenanigans
Conrad Meyer [Fri, 16 Feb 2018 04:30:57 +0000 (04:30 +0000)]
trpt(8): Work around GCC4 shenanigans

Reduce warns to known good value and do not add -Wno- flag the ancient GCC4
does not understand.

Reported by: jhibbits
Sponsored by: Dell EMC Isilon

6 years agoAdd inline to errno.d for translating int to string
Devin Teske [Fri, 16 Feb 2018 04:22:29 +0000 (04:22 +0000)]
Add inline to errno.d for translating int to string

Gives DTrace scripts strerror(3) functionality.

Reviewed by: markj
Sponsored by: Smule, Inc.
Differential Revision: https://reviews.freebsd.org/D14386

6 years agostand/lua: Consistently use semicolons for line endings
Kyle Evans [Fri, 16 Feb 2018 04:10:10 +0000 (04:10 +0000)]
stand/lua: Consistently use semicolons for line endings

6 years agostand/lua: Set reasonable ACPI default based on presence
Kyle Evans [Fri, 16 Feb 2018 04:03:15 +0000 (04:03 +0000)]
stand/lua: Set reasonable ACPI default based on presence

Set it based on hint.acpi.0.rsdp. Initially, hint.acpi.0.disabled will be
respected. "Using System Defaults" will override whether it's explicitly
disabled by hint and re-load it based on whether it's present on the system.

Unlike the 4th version, this is not restricted to x86. I have no strong
reasoning for this, so this is definitely open to change.

6 years agostand/lua: Don't descend into an empty kernels submenu
Kyle Evans [Fri, 16 Feb 2018 03:14:23 +0000 (03:14 +0000)]
stand/lua: Don't descend into an empty kernels submenu

This submenu is likely going to go away in favor of kernel selection as it
is done in forth at the moment, but for the time being don't descend into it
if we have no kernels available for listing.

6 years agostand/lua: Reduce magic numbers
Kyle Evans [Fri, 16 Feb 2018 03:12:24 +0000 (03:12 +0000)]
stand/lua: Reduce magic numbers

Enter/backspace values are hardcoded in both the menu and password scripts.
Separate these out to core for reuse between the two.

6 years agoGet rid of the requirement to include SysV IPC headers with _KERNEL
Brooks Davis [Fri, 16 Feb 2018 01:33:01 +0000 (01:33 +0000)]
Get rid of the requirement to include SysV IPC headers with _KERNEL
defined in ipcrm by introducing _WANT_SYSVxxx_INTERNALS defines.

Reviewed by: jhb
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D14271

6 years agoNote that on amd64 pmap_enter(psind = 1) works (since r321378).
Konstantin Belousov [Fri, 16 Feb 2018 01:08:32 +0000 (01:08 +0000)]
Note that on amd64 pmap_enter(psind = 1) works (since r321378).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

6 years agorc.conf.5: Flip default background_fsck language to match defaults
Conrad Meyer [Fri, 16 Feb 2018 01:03:08 +0000 (01:03 +0000)]
rc.conf.5: Flip default background_fsck language to match defaults

Reviewed by: Daniel O'Connor <darius AT dons.net.au>
Sponsored by: Dell EMC Isilon

6 years agoEliminate bsd.stand.mk and -fPIC 32-bit intel builds
Warner Losh [Fri, 16 Feb 2018 00:17:32 +0000 (00:17 +0000)]
Eliminate bsd.stand.mk and -fPIC 32-bit intel builds

OK. We don't really need a bsd.stand.mk, and it was causing a -fPIC
for the toolchain to be added (bogusly) when building on amd64. Pull
all relevant defs back into defs.mk and delete bsd.stand.mk.

This saves about 15-20k on i386 loader and zfsloader which when
combined with Lua give us a lot more stack space in those constrained
environments.

6 years agoOptimize zfsd for the happy case
Alan Somers [Thu, 15 Feb 2018 21:30:30 +0000 (21:30 +0000)]
Optimize zfsd for the happy case

If there are no damaged pools, then ignore all GEOM events.  We only use
them to fix damaged pools.  However, still pay attention to ZFS events.

MFC after: 20 days
X-MFC-With: 329284
Sponsored by: Spectra Logic Corp

6 years agoReduce duplication in __acl_*_(file|link).
Brooks Davis [Thu, 15 Feb 2018 21:24:43 +0000 (21:24 +0000)]
Reduce duplication in __acl_*_(file|link).

Add const to new kern_ functions and push down as required.

Reviewed by: rwatson
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D14174

6 years agotrpt(8): Sprinkle style(9) and adddress warnings
Conrad Meyer [Thu, 15 Feb 2018 21:06:56 +0000 (21:06 +0000)]
trpt(8): Sprinkle style(9) and adddress warnings

Update function definitions to post-ISO style; remove deprecated "register"
keyword.  Correct indentation.  Sprinkle 'static' on file-local variables.

Appease warnings at WARNS=6, for both Clang and GCC.

Sponsored by: Dell EMC Isilon

6 years agoChange size of padding to reflect reality. No functional change.
Jung-uk Kim [Thu, 15 Feb 2018 20:42:38 +0000 (20:42 +0000)]
Change size of padding to reflect reality.  No functional change.

Discussed with: kib

6 years agolibsa: Consolidate tftp sendrecv into net.c sendrecv
Kyle Evans [Thu, 15 Feb 2018 19:49:15 +0000 (19:49 +0000)]
libsa: Consolidate tftp sendrecv into net.c sendrecv

bootp/arp/rarp/rpc all use the sendrecv implementation in net.c. tftp has
its own implementation because it passes an extra parameter into the recv
callback for the received payload type to be held.

These sendrecv implementations are otherwise equivalent, so consolidate
them. The other users of sendrecv won't be using the extra argument to recv,
but this gives us only one place to worry about respecting timeouts and one
consistent timeout behavior.

Tested by: sbruno
Reviewed by: sbruno, tsoome
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D14373

6 years agoSimplify building before installing.
Warner Losh [Thu, 15 Feb 2018 18:58:03 +0000 (18:58 +0000)]
Simplify building before installing.

6 years agoReport the number of remaining retries when we have an error that
Warner Losh [Thu, 15 Feb 2018 18:57:54 +0000 (18:57 +0000)]
Report the number of remaining retries when we have an error that
we're retrying.

6 years agoReduce duplication in __mac_*_(file|link)(2) implementation.
Brooks Davis [Thu, 15 Feb 2018 18:57:22 +0000 (18:57 +0000)]
Reduce duplication in __mac_*_(file|link)(2) implementation.

Reviewed by: rwatson
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D14175

6 years agobnxt: Update man page with newly supported devices, options, etc
Stephen Hurd [Thu, 15 Feb 2018 18:39:43 +0000 (18:39 +0000)]
bnxt: Update man page with newly supported devices, options, etc

update man page with

* Newly supported devices
* Newly added options
* 'maintained by' Email ID

Submitted by: Siva Kallam <siva.kallam@@broadcom.com>
Reviewed by: shurd, sbruno
Approved by: shurd
Sponsored by: Broadcom Limited
Differential Revision: https://reviews.freebsd.org/D13982

6 years agoAdd the following errno definitions to /usr/lib/dtrace/errno.d
Devin Teske [Thu, 15 Feb 2018 18:37:32 +0000 (18:37 +0000)]
Add the following errno definitions to /usr/lib/dtrace/errno.d

ENOTCAPABLE (93)
ECAPMODE (94)
ENOTRECOVERABLE (95)
EOWNERDEAD (96)
ERELOOKUP (-5)

and update ELAST (92 -> 96)

Reviewed by: markj
Sponsored by: Smule, Inc.
Differential Revision: https://reviews.freebsd.org/D14340

6 years agoRegen after r329322.
Brooks Davis [Thu, 15 Feb 2018 18:32:11 +0000 (18:32 +0000)]
Regen after r329322.

6 years agoRemove freebsd32_getdirentries(), it will be unused after the next
Brooks Davis [Thu, 15 Feb 2018 18:31:43 +0000 (18:31 +0000)]
Remove freebsd32_getdirentries(), it will be unused after the next
commit.

6 years agotrpt(8): Fully remove and undocument '-t' option disabled in 1999
Conrad Meyer [Thu, 15 Feb 2018 18:26:45 +0000 (18:26 +0000)]
trpt(8): Fully remove and undocument '-t' option disabled in 1999

The relevant code was commented out in r50680.

PR: 57045
Submitted by: Fernando Apesteguía <fernando.apesteguia AT gmail.com>

6 years agopmap_qenter.9: Clarify that not all arch can map NX
Conrad Meyer [Thu, 15 Feb 2018 18:19:25 +0000 (18:19 +0000)]
pmap_qenter.9: Clarify that not all arch can map NX

The goal is to use security features when architectures provide them.

Reported by: kib
Sponsored by: Dell EMC Isilon

6 years agostand/lua: Always boot on 'enter' keypress in menus
Kyle Evans [Thu, 15 Feb 2018 18:16:16 +0000 (18:16 +0000)]
stand/lua: Always boot on 'enter' keypress in menus

6 years agoRevert r329323. I missed something in my testing.
Brooks Davis [Thu, 15 Feb 2018 17:58:51 +0000 (17:58 +0000)]
Revert r329323.  I missed something in my testing.

6 years agoBuild loader before installing it in lua-img.sh
Kyle Evans [Thu, 15 Feb 2018 17:56:45 +0000 (17:56 +0000)]
Build loader before installing it in lua-img.sh

Slightly more foolproof when all you're wanting to do is quickly get off the
ground with testing the lua loader.

6 years agoSet svn:executable on lua-img.sh
Kyle Evans [Thu, 15 Feb 2018 17:47:43 +0000 (17:47 +0000)]
Set svn:executable on lua-img.sh

6 years agoFix the test for SET_FOREACH termination.
Mark Johnston [Thu, 15 Feb 2018 17:35:40 +0000 (17:35 +0000)]
Fix the test for SET_FOREACH termination.

Unlike the queue(3) _FOREACH macros, the iterator for a SET_FOREACH is
not NULL after the end of the set is reached.

6 years agoRegen after r329322: Fix getdirentries(2) under 32-bit compat.
Brooks Davis [Thu, 15 Feb 2018 17:27:19 +0000 (17:27 +0000)]
Regen after r329322: Fix getdirentries(2) under 32-bit compat.

Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D14379

6 years agoFix getdirentries(2) under 32-bit compat.
Brooks Davis [Thu, 15 Feb 2018 17:26:30 +0000 (17:26 +0000)]
Fix getdirentries(2) under 32-bit compat.

The latest version of getdirentries (syscall 554) takes a pointer
an an off_t as the last argument. The old version which copies out
an int32_t was being used instead. Use the standard sys_getdirentries()
implementation instead.

Reviewed by: kib
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D14379

6 years agoRename the ACPI variant of the gicv2m driver from "gicv2m" to "gicv2m_acpi".
Olivier Houchard [Thu, 15 Feb 2018 15:46:14 +0000 (15:46 +0000)]
Rename the ACPI variant of the gicv2m driver from "gicv2m" to "gicv2m_acpi".
The FDT variant is called "gicv2m" too, and as both would try to register
on gic, only one of them would succeed, while we want them both in a
GENERIC kernel.

Reviewed by: andrew

6 years agostand: Fix ubldr after r329190
Kyle Evans [Thu, 15 Feb 2018 15:01:07 +0000 (15:01 +0000)]
stand: Fix ubldr after r329190

metadata load files were consolidated in r329190, and these relocation fixup
bits were inadvertently dropped in the process. Re-add them to fix boot with
ubldr.

Glanced over by: jhibbits
X-MFC-With: r329190

6 years agoMFV r329313: 8857 zio_remove_child() panic due to already destroyed parent zio
Andriy Gapon [Thu, 15 Feb 2018 14:46:29 +0000 (14:46 +0000)]
MFV r329313: 8857 zio_remove_child() panic due to already destroyed parent zio

illumos/illumos-gate@d6e1c446d7897003fd9fd36ef5aa7da350b7f6af
https://github.com/illumos/illumos-gate/commit/d6e1c446d7897003fd9fd36ef5aa7da350b7f6af

https://www.illumos.org/issues/8857
  I had an OS panic on one of our servers:

  ffffff01809128c0 vpanic()
  ffffff01809128e0 mutex_panic+0x58(fffffffffb94c904ffffff597dde7f80)
  ffffff0180912950 mutex_vector_enter+0x347(ffffff597dde7f80)
  ffffff01809129b0 zio_remove_child+0x50(ffffff597dde7c58ffffff32bd901ac0,
  ffffff3373370908)
  ffffff0180912a40 zio_done+0x390(ffffff32bd901ac0)
  ffffff0180912a70 zio_execute+0x78(ffffff32bd901ac0)
  ffffff0180912b30 taskq_thread+0x2d0(ffffff33bae44140)
  ffffff0180912b40 thread_start+8()

  It panicked here:
  http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/fs/zfs/
  zio.c#430

  pio->io_lock is DEAD, thus a panic. Further analysis shows the "pio"
  (parent zio of "cio") has already been destroyed.

Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Andriy Gapon <avg@FreeBSD.org>
Reviewed by: Youzhong Yang <youzhong@gmail.com>
Approved by: Dan McDonald <danmcd@omniti.com>
Author: George Wilson <george.wilson@delphix.com>

PR: 223803
Tested by: shiva.bhanujan@quorum.com
MFC after: 2 weeks

6 years ago8857 zio_remove_child() panic due to already destroyed parent zio
Andriy Gapon [Thu, 15 Feb 2018 14:34:18 +0000 (14:34 +0000)]
8857 zio_remove_child() panic due to already destroyed parent zio

illumos/illumos-gate@d6e1c446d7897003fd9fd36ef5aa7da350b7f6af
https://github.com/illumos/illumos-gate/commit/d6e1c446d7897003fd9fd36ef5aa7da350b7f6af

https://www.illumos.org/issues/8857
  I had an OS panic on one of our servers:

  ffffff01809128c0 vpanic()
  ffffff01809128e0 mutex_panic+0x58(fffffffffb94c904ffffff597dde7f80)
  ffffff0180912950 mutex_vector_enter+0x347(ffffff597dde7f80)
  ffffff01809129b0 zio_remove_child+0x50(ffffff597dde7c58ffffff32bd901ac0,
  ffffff3373370908)
  ffffff0180912a40 zio_done+0x390(ffffff32bd901ac0)
  ffffff0180912a70 zio_execute+0x78(ffffff32bd901ac0)
  ffffff0180912b30 taskq_thread+0x2d0(ffffff33bae44140)
  ffffff0180912b40 thread_start+8()

  It panicked here:
  http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/fs/zfs/
  zio.c#430

  pio->io_lock is DEAD, thus a panic. Further analysis shows the "pio"
  (parent zio of "cio") has already been destroyed.

Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Andriy Gapon <avg@FreeBSD.org>
Reviewed by: Youzhong Yang <youzhong@gmail.com>
Approved by: Dan McDonald <danmcd@omniti.com>
Author: George Wilson <george.wilson@delphix.com>

6 years agoetc: clean up trailing whitespace in autofs
Eitan Adler [Thu, 15 Feb 2018 11:41:38 +0000 (11:41 +0000)]
etc: clean up trailing whitespace in autofs

Obtained from: DragonFlyBSD (48a93f514f93ff671b7b6c9bbed54d45b3f65180)

6 years agoshare: update pci_vendors to 2018.02.15
Eitan Adler [Thu, 15 Feb 2018 11:13:21 +0000 (11:13 +0000)]
share: update pci_vendors to 2018.02.15

MFC After: 1 week

6 years agoxen: fix smp boot after r328157
Mateusz Guzik [Thu, 15 Feb 2018 07:23:41 +0000 (07:23 +0000)]
xen: fix smp boot after r328157

mce_stack was left unset leading to early crashes

6 years agodevd: don't pass &fds in useless parameters to select(2)
Eitan Adler [Thu, 15 Feb 2018 03:22:53 +0000 (03:22 +0000)]
devd: don't pass &fds in useless parameters to select(2)

select(2) should be declared as restrict. In addition the only fd in
the fdset is open O_RDONLY, and it's not a socket that can provide OOB
notifications,

Reviewed by: ian, imp, vangyzen

6 years agomxge(4) should pass unhandled ioctls to ether_ioctl()
Ravi Pokala [Thu, 15 Feb 2018 03:22:04 +0000 (03:22 +0000)]
mxge(4) should pass unhandled ioctls to ether_ioctl()

Panasas discovered that ioctl(SIOCGLAGGPORT) returns ENOTTY for mxge(4) when
the NIC is not a member of a lagg. This came as a surprise, because the
SIOCGLAGGPORT handler in if_lagg.c only returns ENOENT (if run against the
laggX interface, rather than a physical port) or EINVAL (if run against a
non-member physical port). This behavior was not seen with other drivers,
such as bge(4), igb(4), and cxl(4). When I compared their respective ioctl
handlers, I found that they all called ether_ioctl() for the default (i.e.
unhandled) case; by contrast, mxge(4) only calls ether_ioctl() for two
specific cases, and returns ENOTTY for the default case.

Remove the two cases which explicitly call ether_ioctl(), and let the
default case call it instead. This matches what the vast majority of the NIC
drivers do.

Reviewed by: kmacy
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D14381

6 years agozfsd: Allow zfsd to work on any type of GEOM provider
Alan Somers [Wed, 14 Feb 2018 23:52:39 +0000 (23:52 +0000)]
zfsd: Allow zfsd to work on any type of GEOM provider

cddl/usr.sbin/zfsd/zfsd_event.cc
Remove the check for da and ada devices.  This way zfsd can work on md,
geli, glabel, gstripe, etc devices.  geli in particular is useful
combined with ZFS.  gnop is also useful for simulating drive pulls in
the ZFSD test suite.

Also, eliminate the DevfsEvent class entirely.  Move its
responsibilities into GeomEvent.  We can get everything we need to know
just from listening to GEOM events.

lib/libdevdctl/event.cc
Fix GeomEvent::DevName for CREATE events.  Oddly, the relevant field is
named "cdev" for CREATE events but "devname" for disk events.

MFC after: 3 weeks
Relnotes: Yes (probably worth mentioning the geli part)
Sponsored by: Spectra Logic Corp

6 years agopmap_qenter.9: Document API NX mapping
Conrad Meyer [Wed, 14 Feb 2018 23:47:04 +0000 (23:47 +0000)]
pmap_qenter.9: Document API NX mapping

A follow-up to r329281.

Sponsored by: Dell EMC Isilon

6 years agox86 pmap: Make memory mapped via pmap_qenter() non-executable
Conrad Meyer [Wed, 14 Feb 2018 23:35:47 +0000 (23:35 +0000)]
x86 pmap: Make memory mapped via pmap_qenter() non-executable

The idea is, the pmap_qenter() API is now defined to not produce executable
mappings.  If you need executable mappings, use another API.

Add pg_nx flag in pmap_qenter on x86 to make kernel pages non-executable.

Other architectures that support execute-specific permissons on page table
entries should subsequently be updated to match.

Submitted by: Darrick Lew <darrick.freebsd AT gmail.com>
Reviewed by: markj
Discussed with: alc, jhb, kib
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D14062

6 years agong_pppoe(8): add support for user-supplied Host-Uniq tag.
Eugene Grosbein [Wed, 14 Feb 2018 21:17:44 +0000 (21:17 +0000)]
ng_pppoe(8): add support for user-supplied Host-Uniq tag.

A few ISP filter PADI requests based on such tag,
to force the use of their own routers.
The custom Host-Uniq tag is passed in the NGM_PPPOE_CONNECT
control message, so it can be used with FreeBSD ppp(8)
and mpd without any other change.

Add support to send and receive PADM messages,
HURL and MOTM, often used by service providers to provide
ACS information and other configuration settings
to the user CPE.

Submitted by: ale
Approved by: mav (mentor)
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D9270

6 years agoAdd mtree entry for 329275
Alan Somers [Wed, 14 Feb 2018 21:02:38 +0000 (21:02 +0000)]
Add mtree entry for 329275

MFC after: 3 weeks
X-MFC-With: 329275
Sponsored by: Spectra Logic Corp

6 years agorwlock: diff-reduction of runlock compared to sx sunlock
Mateusz Guzik [Wed, 14 Feb 2018 20:37:33 +0000 (20:37 +0000)]
rwlock: diff-reduction of runlock compared to sx sunlock

6 years agogpart: append partition name to the underlying provider's physical path
Alan Somers [Wed, 14 Feb 2018 20:26:09 +0000 (20:26 +0000)]
gpart: append partition name to the underlying provider's physical path

If the underlying provider's physical path is null, then the gpart device's
physical path will be, too. Otherwise, it will append the partition name,
such as "/p1" or "/s1/a". This will make gpart work better with zfsd(8).

PR: 224965
MFC after: 3 weeks
Differential Revision: https://reviews.freebsd.org/D14010