]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/log
FreeBSD/FreeBSD.git
5 years agorm(1): Formalize non-functional status of -P flag
cem [Sat, 10 Nov 2018 20:26:55 +0000 (20:26 +0000)]
rm(1): Formalize non-functional status of -P flag

-P was introduced in 4.4BSD-Lite2 around 1994.  It overwrote file contents
with a pass of 0xff, 0x00, then 0xff, in a low effort attempt to "really
delete" files.

It has no user-visible effect; at the end of the day, the file is unlinked via
the filesystem.  Furthermore, the utility of overwriting files with patterned
data is extremely limited due to caveats at every layer of the stack[0] and
therefore mostly futile.  At the least, three passes is likely wasteful on
modern hardware[1].  It could also be seen as a violation of the "Unix
Philosophy" to do one thing per tiny, composable program.

Since 1994, FreeBSD has left it alone; OpenBSD replaced it with a single
pass of arc4random(3) output in 2012[2]; and NetBSD implemented partial, but
explicitly incomplete support for U.S. DoD 5220.22-M, "National Industrial
Security Program Operating Manual" in 2004[3].

NetBSD's enhanced comment above rm_overwrite makes a strong case for removing
the flag entirely:

> This is an expensive way to keep people from recovering files from your
> non-snapshotted FFS filesystems using fsdb(8).  Really.  No more.
>
> It is impossible to actually conform to the exact procedure given in
> [NISPOM] if one is overwriting a file, not an entire disk, because the
> procedure requires examination and comparison of the disk's defect lists.
> Any program that claims to securely erase *files* while conforming to the
> standard, then, is not correct.
>
> Furthermore, the presence of track caches, disk and controller write
> caches, and so forth make it extremely difficult to ensure that data have
> actually been written to the disk, particularly when one tries to repeatedly
> overwrite the same sectors in quick succession.  We call fsync(), but
> controllers with nonvolatile cache, as well as IDE disks that just plain lie
> about the stable storage of data, will defeat this.
>
> [NISPOM] requires physical media destruction, rather than any technique of
> the sort attempted here, for secret data.

As a first step towards evental removal, make it a placebo.  It's not like
it was serving any security function.  It is not defined in or mentioned by
POSIX.

If you are security conscious and need to erase your files, use a
woodchipper.  At a minimum, the entire disk needs to be overwritten, not
just one file.

[0]: https://www.ru.nl/publish/pages/909282/draft-paper.pdf
[1]: https://commons.erau.edu/cgi/viewcontent.cgi?article=1131&context=jdfsl
[2]: https://github.com/openbsd/src/commit/7c5c57ba81b5fe8ff2d4899ff643af18c
[3]: https://github.com/NetBSD/src/commit/fdf0a7a25e59af958fca1e2159921562cd

Reviewed by: markj, Daniel O'Connor <darius AT dons.net.au> (previous version)
Differential Revision: https://reviews.freebsd.org/D17906

5 years agobuild(7): clarify buildenv target can be used for non-cross builds
emaste [Sat, 10 Nov 2018 20:26:19 +0000 (20:26 +0000)]
build(7): clarify buildenv target can be used for non-cross builds

make buildenv can be used for building for the same architecture as
the host (perhaps this is a degenerate case of cross-building).
TARGET and TARGET_ARCH do not need to be set in this case.

Reviewed by: bdrewery
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D10759

5 years agoUpdate comment about 'universe' disk usage
vangyzen [Sat, 10 Nov 2018 19:09:48 +0000 (19:09 +0000)]
Update comment about 'universe' disk usage

It's 167 GB now (or 81 GB with ZFS lz4).

MFC after: 2 weeks
Sponsored by: Dell EMC Isilon

5 years agoweekly/340.noid: suppress warning on non-existent jail.conf
eugen [Sat, 10 Nov 2018 17:49:19 +0000 (17:49 +0000)]
weekly/340.noid: suppress warning on non-existent jail.conf

MFC after: 1 month

5 years agoAdd UPDATING entry for newsyslog.conf changes introduced by r340318
woodsb02 [Sat, 10 Nov 2018 16:58:07 +0000 (16:58 +0000)]
Add UPDATING entry for newsyslog.conf changes introduced by r340318

Approved by: cem
Differential Revision: https://reviews.freebsd.org/D17936

5 years agonetmap: pkt-gen: several updates from upstream
vmaffione [Sat, 10 Nov 2018 15:10:22 +0000 (15:10 +0000)]
netmap: pkt-gen: several updates from upstream

Various improvements to the netmap pkt-gen program:

 - indentation fixes
 - support for IPV6
 - fixes to checksum computation
 - support for NS_MOREFRAG
 - rate limiting in ping mode

Reviewed by: bcr, 0mp
Approved by: gnn (mentor)
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D17698

5 years agoSigh... Fix another breakage after r340322: spell "sysrc" correctly.
eugen [Sat, 10 Nov 2018 14:35:12 +0000 (14:35 +0000)]
Sigh... Fix another breakage after r340322: spell "sysrc" correctly.

MFC after: 1 month

5 years agoFix breakage after r340322: add missing "-n" to invocation of sysrc.
eugen [Sat, 10 Nov 2018 14:25:37 +0000 (14:25 +0000)]
Fix breakage after r340322: add missing "-n" to invocation of sysrc.

MFH: 1 month

5 years agoPrevent periodic/etc/weekly/340.noid from descending into root directories
eugen [Sat, 10 Nov 2018 14:21:26 +0000 (14:21 +0000)]
Prevent periodic/etc/weekly/340.noid from descending into root directories
of jails. Jails have their own user/group databases and this script
can produce multiple false warnings, not to mention significant extra
load in case of large jailed subtrees. Leave this check for jailed
invocations of the same script.

MFC after: 1 month

5 years agoMove definition of $jail_conf variable to /etc/defaults/rc.conf
eugen [Sat, 10 Nov 2018 14:11:54 +0000 (14:11 +0000)]
Move definition of $jail_conf variable to /etc/defaults/rc.conf
from jail startup script so it can be successfully queried
with the command "sysrc jail_conf".

MFC after: 1 month

5 years agojail(8): introduce new command option -e to exhibit
eugen [Sat, 10 Nov 2018 12:03:57 +0000 (12:03 +0000)]
jail(8): introduce new command option -e to exhibit
a list of configured non-wildcard jails with their parameters,
no matter running or not.

The option -e takes separator argument that is used
to separate printed parameters. It will be used with following
additions to system periodic scripts to differentiate parts
of directory tree belonging jails as opposed to host's.

MFC after: 1 month

5 years agonewsyslog.conf: Restrict included files in default config to [!.]*.conf
woodsb02 [Sat, 10 Nov 2018 10:46:38 +0000 (10:46 +0000)]
newsyslog.conf: Restrict included files in default config to [!.]*.conf

The new default config will only include files from the following
directories which end with '.conf' and do not beginning with a '.'
character:
- /etc/newsyslog.conf.d/
- /usr/local/etc/newsyslog.conf.d/

This matches the syslog.conf(5) functionality, and also prevents '.sample' or
'.pkgnew' files being included. This is important for ports which install files
in /usr/local/etc/newsyslog.conf.d/ and also for pkgbase.

Approved by: eadler
Approved by: bapt
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D17086

5 years agolibjail: fix handling of allow.mount.fusefs in jailparam_init
asomers [Sat, 10 Nov 2018 03:10:22 +0000 (03:10 +0000)]
libjail: fix handling of allow.mount.fusefs in jailparam_init

fusefs is inconsistently named. The kernel module is named "fuse", but the
mount helper is named "mount_fusefs" and the jail(8) parameter is named
"allow.mount.fusefs". Special case it in libjail.

Reviewed by: jamie
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D17929

5 years agoEnsure that IP fragments do not extend beyond IP_MAXPACKET.
markj [Sat, 10 Nov 2018 03:00:36 +0000 (03:00 +0000)]
Ensure that IP fragments do not extend beyond IP_MAXPACKET.

Such fragments are obviously invalid, and when processed may end up
violating the sort order (by offset) of fragments of a given packet.
This doesn't appear to be exploitable, however.

Reviewed by: emaste
Discussed with: jtl
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17914

5 years agopowerpc: Use MAX() macro instead of max() inline function to calculate Maxmem
jhibbits [Sat, 10 Nov 2018 02:37:56 +0000 (02:37 +0000)]
powerpc: Use MAX() macro instead of max() inline function to calculate Maxmem

Maxmem is the highest address for physical memory in the system.  It's
measured in pages which, since max() returns a u_int, should allow for up to
2^44 bytes of memory addressable by the system.  However, on POWER9 systems
at least, memory addressed by additional socketed CPUs begins at addresses
far above the 2^44 mark, causing issues with memory accesses and DMA, when
memory is addressed on the auxiliary CPUs.  Use the MAX() macro instead,
which doesn't convert arguments, so retains Maxmem and all calculations as
its defined long type (64-bit on powerpc64), keeping the maximum address
correct.

Submitted by: mmacy

5 years agoDo not ignore arc_adjust() return value.
mav [Sat, 10 Nov 2018 01:58:37 +0000 (01:58 +0000)]
Do not ignore arc_adjust() return value.

This covers scenario when ARC may not shrink as fast as it could:
1. arc_size < arc_c and arc_adjust() does not evict anything, returning
   zero to arc_reclaim_thread();
2. arc_available_memory() reports memory pressure, which can not be
   satisfied by arc_kmem_reap_now();
3. arc_shrink() reduces arc_c and calls arc_adjust(), return of which is
   ignored;
4. even if the last arc_adjust() could not satisfy arc_size < arc_c,
   arc_reclaim_thread() will still go to sleep, since the first one
   returned zero.

Reviewed by: allanjude, markj, sef
MFC after: 2 weeks
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D17927

5 years agoFix first-packet completion
shurd [Fri, 9 Nov 2018 22:18:43 +0000 (22:18 +0000)]
Fix first-packet completion

The first packet after the ring is initialized was never
completed as isc_txd_credits_update() would not include it in the
count of completed packets. This caused netmap to never complete
a batch. See PR 233022 for more details.

PR: 233022
Reported by: lev
Reviewed by: lev
MFC after: 3 days
Sponsored by: Limelight Networks
Differential Revision: https://reviews.freebsd.org/D17931

5 years agoUse tcp_state_change() in the cxgbe(4) TOE module.
jhb [Fri, 9 Nov 2018 21:16:45 +0000 (21:16 +0000)]
Use tcp_state_change() in the cxgbe(4) TOE module.

r254889 added tcp_state_change() as a centralized place to log state
changes in TCP connections for DTrace.  r294869 and r296881 took
advantage of this central location to manage per-state counters.
However, TOE sockets were still performing some (but not all) state
change updates via direct assignments to t_state.  This resulted in
state counters underflowing when TOE was in use.  Fix by using
tcp_state_change() when changing a TOE connection's state.

Reviewed by: np, markj
MFC after: 1 month
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D17915

5 years agoRegen after r340302: Fix freebsd32 mknod(at).
brooks [Fri, 9 Nov 2018 21:02:07 +0000 (21:02 +0000)]
Regen after r340302: Fix freebsd32 mknod(at).

Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17928

5 years agoFix freebsd32 mknod(at).
brooks [Fri, 9 Nov 2018 21:01:16 +0000 (21:01 +0000)]
Fix freebsd32 mknod(at).

As dev_t is now a 64-bit integer, it requires special handling as a
system call argument.  64-bit arguments are split between two 64-bit
integers due to the way arguments are promoted to allow reuse of most
system call implementations.  They must be reassembled before use.
Further, 64-bit arguments at an odd offset (counting from zero) are
padded and slid to the next slot on powerpc and mips.  Fix the
non-COMPAT11 system call by adding a freebsd32_mknodat() and
appropriately padded declerations.

The COMPAT11 system calls are fully compatible with the 64-bit
implementations so remove the freebsd32_ versions.

Use uint32_t consistently as the type of the old dev_t.  This matches
the old definition.

Reviewed by: kib
MFC after: 3 days
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17928

5 years agoAdd comment to explain kernel ldscript 0x200000 constant
emaste [Fri, 9 Nov 2018 20:33:38 +0000 (20:33 +0000)]
Add comment to explain kernel ldscript 0x200000 constant

Reported by: linimon

5 years agolibllvm: Move SampleProfWriter to SRCS_MIN
emaste [Fri, 9 Nov 2018 19:51:26 +0000 (19:51 +0000)]
libllvm: Move SampleProfWriter to SRCS_MIN

It is required by llvm-profdata, now built by default under the
LLVM_COV knob.  The additional complexity that would come from avoiding
building it if CLANG_EXTRAS and LLVM_COV are both disabled is not worth
the small savings in build time.

Sponsored by: The FreeBSD Foundation

5 years agoOcteon SDK: avoid use of uninitialized variable
emaste [Fri, 9 Nov 2018 19:17:25 +0000 (19:17 +0000)]
Octeon SDK: avoid use of uninitialized variable

Reported by: Clang
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

5 years agouse -m ${LD_EMULATION} for binary->elf link invocation
emaste [Fri, 9 Nov 2018 19:16:01 +0000 (19:16 +0000)]
use -m ${LD_EMULATION} for binary->elf link invocation

r306041 changed ld invocations for converting binary files to kernel
ELF objects to pass -m, but missed bespoke ld invocations in a pair of
arm file configs (one of which has since been removed).

This is needed to support some external toolchains and lld.

Sponsored by: The FreeBSD Foundation

5 years agoUse ${ECHO} in dtb/dtbo build, pass in from dtb.mk for -s
kevans [Fri, 9 Nov 2018 18:56:40 +0000 (18:56 +0000)]
Use ${ECHO} in dtb/dtbo build, pass in from dtb.mk for -s

Reported by: sbruno
MFC after: 3 days

5 years agoMove llvm-profdata build into MK_LLVM_COV block
emaste [Fri, 9 Nov 2018 18:35:09 +0000 (18:35 +0000)]
Move llvm-profdata build into MK_LLVM_COV block

llvm-profdata is used with llvm-cov for code coverage (although llvm-cov
can also operate independently in a gcov-compatible mode).
Although llvm-profdata can be used independently of llvm-cov it makes
sense to group these under one option.

Also handle these in OptionalObsoleteFiles.inc while here.

Sponsored by: The FreeBSD Foundation

5 years agoRegen after r340294: Fix a number of bugs in freebsd32's capabilities.conf.
brooks [Fri, 9 Nov 2018 18:06:25 +0000 (18:06 +0000)]
Regen after r340294: Fix a number of bugs in freebsd32's capabilities.conf.

Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17925

5 years agoFix a number of bugs in freebsd32's capabilities.conf.
brooks [Fri, 9 Nov 2018 18:03:01 +0000 (18:03 +0000)]
Fix a number of bugs in freebsd32's capabilities.conf.

Bugs range from failure to update after changing syscall implementaion
names to using the wrong name.  Somewhat confusingly, the name in
capabilities.conf is exactly the string that appears in syscalls.master,
not the name with a COMPAT* prefix which is the actual function name.

Found while making a change to use the default capabilities.conf.

Fixes: r335177, r336980, r340272, r340274, others
Reviewed by: kib, emaste
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17925

5 years agollvm-cov: also install as gcov (if GNU gcov is disabled)
emaste [Fri, 9 Nov 2018 17:43:19 +0000 (17:43 +0000)]
llvm-cov: also install as gcov (if GNU gcov is disabled)

llvm-cov provides a gcov-compatible interface when invoked as gcov.

Reviewed by: dim, markj
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17923

5 years agonvi: remove superfluous space before ^\
emaste [Fri, 9 Nov 2018 17:39:57 +0000 (17:39 +0000)]
nvi: remove superfluous space before ^\

This fixes alignment in vi's 'viusage' command and has been fixed
upstream and in OpenBSD.

Submitted by: Raf Czlonka (github:rjc)
MFC after: 1 week
Pull Request: https://github.com/freebsd/freebsd/pull/122

5 years agoConsolidate gcov entries in OptionalObsoleteFiles
emaste [Fri, 9 Nov 2018 15:27:41 +0000 (15:27 +0000)]
Consolidate gcov entries in OptionalObsoleteFiles

Sponsored by: The FreeBSD Foundation

5 years agoFix test: sys.netpfil.pf.pass_block.noalias
lwhsu [Fri, 9 Nov 2018 15:24:24 +0000 (15:24 +0000)]
Fix test: sys.netpfil.pf.pass_block.noalias

Replace hard-coded epair0b with the variable holds the real epair interface
used for testing.

Reviewed by: kp
Approved by: emaste, markj (mentors)
MFC with: r339836
Sponsored by: The FreeBSD Foundation

5 years agokldxref: use appropriate Elf_Off type for offsets
emaste [Fri, 9 Nov 2018 15:02:53 +0000 (15:02 +0000)]
kldxref: use appropriate Elf_Off type for offsets

Submitted by: Mitchell Horne <mhorne063@gmail.com>
Reviewed by: kib
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D13957

5 years agosh: Unify EXERROR and EXEXEC
jilles [Fri, 9 Nov 2018 14:58:24 +0000 (14:58 +0000)]
sh: Unify EXERROR and EXEXEC

The difference between EXERROR and EXEXEC was that EXEXEC passed along
exitstatus and EXERROR set exitstatus to 2 in the handling code.

By changing the places that raised EXERROR to set exitstatus to 2, the
handling of EXERROR and EXEXEC becomes the same.

5 years agoCross-reference nohup(1) and daemon(8).
0mp [Fri, 9 Nov 2018 13:47:06 +0000 (13:47 +0000)]
Cross-reference nohup(1) and daemon(8).

Reviewed by: bcr
Approved by: krion (mentor, implicit), mat (mentor, implicit)
Differential Revision: https://reviews.freebsd.org/D17920

5 years agonetmap: add load balancer program
vmaffione [Fri, 9 Nov 2018 08:43:40 +0000 (08:43 +0000)]
netmap: add load balancer program

Add the lb program, which is able to load-balance input traffic
received from a netmap port over M groups, with N netmap pipes in
each group. Each received packet is forwarded to one of the pipes
chosen from each group (using an L3/L4 connection-consistent hash function).
This also adds a man page for lb and some cross-references in related
man pages.

Reviewed by: bcr, 0mp
Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D17735

5 years agoReset persistent mbstates when rune locale encoding changes.
yuripv [Fri, 9 Nov 2018 03:32:53 +0000 (03:32 +0000)]
Reset persistent mbstates when rune locale encoding changes.

This was shown to be a problem by side effect of now-enabled test case,
which was going through C, en_US.UTF-8, ja_JP.SJIS, and ja_JP.eucJP,
and failing eventually as data in mbrtowc's mbstate, that was
perfectly correct for en_US.UTF-8 was treated as incorrect for
ja_JP.SJIS, failing the entire test case.

This makes the persistent mbstates to be per ctype-component,
and not per-locale so we could easily reset the mbstates when
only LC_CTYPE is changed.

Reviewed by: bapt, pfg
Approved by: kib (mentor, implicit)
Differential Revision: https://reviews.freebsd.org/D17796

5 years agoRegen after r340274: Make freebsd32_utmx_op follow the freebsd32_foo
brooks [Fri, 9 Nov 2018 00:46:50 +0000 (00:46 +0000)]
Regen after r340274: Make freebsd32_utmx_op follow the freebsd32_foo
convention.

5 years agoMake freebsd32_umtx_op follow the freebsd32_foo convention.
brooks [Fri, 9 Nov 2018 00:46:10 +0000 (00:46 +0000)]
Make freebsd32_umtx_op follow the freebsd32_foo convention.

Sponsored by: DARPA, AFRL

5 years agoRegen after 340272: Make __sysctl follow the freebsd32_foo convention
brooks [Fri, 9 Nov 2018 00:22:45 +0000 (00:22 +0000)]
Regen after 340272: Make __sysctl follow the freebsd32_foo convention

Sponsored by: DARPA, AFRL

5 years agoMake __sysctl follow the freebsd32_foo convention.
brooks [Fri, 9 Nov 2018 00:21:58 +0000 (00:21 +0000)]
Make __sysctl follow the freebsd32_foo convention.

Sponsored by: DARPA, AFRL

5 years agopf tests: Test PR 183198
kp [Thu, 8 Nov 2018 21:56:06 +0000 (21:56 +0000)]
pf tests: Test PR 183198

Create a table which is only used inside an anchor, ensure that the
table exists.

PR: 183198
MFC after: 2 weeks

5 years agopf: Prevent tables referenced by rules in anchors from getting disabled.
kp [Thu, 8 Nov 2018 21:54:40 +0000 (21:54 +0000)]
pf: Prevent tables referenced by rules in anchors from getting disabled.

PR: 183198
Obtained from: OpenBSD
MFC after: 2 weeks

5 years agopfctl: Populate ifname in ifa_lookup()
kp [Thu, 8 Nov 2018 21:53:09 +0000 (21:53 +0000)]
pfctl: Populate ifname in ifa_lookup()

pfctl_adjust_skip_ifaces() relies on this name.

MFC after: 2 weeks

5 years agopowerpc64: Fix "show spr" command on ELFv2 kernels
jhibbits [Thu, 8 Nov 2018 20:48:44 +0000 (20:48 +0000)]
powerpc64: Fix "show spr" command on ELFv2 kernels

Summary: When compiling for ELFv2, it is necessary to adjust the offset to
get_spr and factor in the function prologue to ensure the correct instruction is
being edited.

Test Plan:
Before:
```
db> show spr 110
KDB: reentering
KDB: stack backtrace:
0xc008000020fb96e0: at 0xc000000002bb2e34 = kdb_backtrace+0x68
0xc008000020fb97f0: at 0xc000000002bb3798 = kdb_reenter+0x54
0xc008000020fb9860: at 0xc000000002f87090 = trap+0x4e4
0xc008000020fb9990: at 0xc000000002f78a60 = powerpc_interrupt+0x110
0xc008000020fb9a20: kernel trap 0xe40 by 0xc000000002401978 = get_spr+0x8: srr1=0x9000000000001032
            r1=0xc008000020fb9cd0 cr=0x80009438 xer=0x20040000 ctr=0xc000000002f7b40c r2=0xc0000000037fd000
saved LR(0xfffffffffffffffb) is invalid.
```

After:

```
db> show spr 110
SPR 272(110): c000000003cae900
```

Submitted by: git_bdragon.rtk0.net
Differential Revision: https://reviews.freebsd.org/D17813

5 years agopowerpc/powernv: Restrict the busdma tag to only POWER8
jhibbits [Thu, 8 Nov 2018 20:31:12 +0000 (20:31 +0000)]
powerpc/powernv: Restrict the busdma tag to only POWER8

It seems this tag is causing problems on POWER9 systems.  Since no POWER9 user
has encountered the problem fixed by r339589 just restrict it to POWER8 for now.
A better fix will likely be to update powerpc/busdma_machdep.c to handle the
window correctly.

Reported by: mmacy, others

5 years agoAvoid buffer underwrite in icmp_error
emaste [Thu, 8 Nov 2018 20:17:36 +0000 (20:17 +0000)]
Avoid buffer underwrite in icmp_error

icmp_error allocates either an mbuf (with pkthdr) or a cluster depending
on the size of data to be quoted in the ICMP reply, but the calculation
failed to account for the additional padding that m_align may apply.

Include the ip header in the size passed to m_align.  On 64-bit archs
this will have the net effect of moving everything 4 bytes later in the
mbuf or cluster.  This will result in slightly pessimal alignment for
the ICMP data copy.

Also add an assertion that we do not move m_data before the beginning of
the mbuf or cluster.

Reported by: A reddit user
Reviewed by: bz, jtl
MFC after: 3 days
Security: CVE-2018-17156
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17909

5 years agoin6_ifattach_linklocal: handle immediate removal of the new LLA
vangyzen [Thu, 8 Nov 2018 19:50:23 +0000 (19:50 +0000)]
in6_ifattach_linklocal: handle immediate removal of the new LLA

If another thread immediately removes the link-local address
added by in6_update_ifa(), in6ifa_ifpforlinklocal() can return NULL,
so the following assertion (or dereference) is wrong.
Remove the assertion, and handle NULL somewhat better than panicking.
This matches all of the other callers of in6_update_ifa().

PR: 219250
Reviewed by: bz, dab (both an earlier version)
MFC after: 1 week
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D17898

5 years agoixl/iavf(4): Fix TSO offloads when TXCSUM is disabled
erj [Thu, 8 Nov 2018 19:10:43 +0000 (19:10 +0000)]
ixl/iavf(4): Fix TSO offloads when TXCSUM is disabled

From Jake:
The iflib stack does not disable TSO automatically when TXCSUM is
disabled, instead assuming that the driver will correctly handle TSOs
even when CSUM_IP is not set.

This results in iflib calling ixl_isc_txd_encap with packets which have
CSUM_IP_TSO, but do not have CSUM_IP or CSUM_IP_TCP set. Because of
this, ixl_tx_setup_offload will not setup the IPv4 checksum offloading.

This results in bad TSO packets being sent if a user disables TXCSUM
without disabling TSO.

Fix this by updating the ixl_tx_setup_offload function to check both
CSUM_IP and CSUM_IP_TSO when deciding whether to enable IPv4 checksums.

Once this is corrected, another issue for TSO packets is revealed. The
driver sets IFLIB_NEED_ZERO_CSUM in order to enable a work around that
causes the ip->sum field to be zero'd. This is necessary for ixl
hardware to correctly perform TSOs.

However, if TXCSUM is disabled, then the work around is not enabled, as
CSUM_IP will not be set when the iflib stack checks to see if it should
clear the sum field.

Fix this by adding IFLIB_TSO_INIT_IP to the iflib flags for the iavf and
ixl interface files.

It is uncertain if the hardware needs IFLIB_NEED_ZERO_CSUM for any other
case besides TSO, so leave that flag assigned. It may be worth
investigating to see if this work around flag could be disabled in
a future change.

Once both of these changes are made, the ixl driver should correctly
offload TSO packets when TSO4 offload is enabled, regardless of whether
TXCSUM is enabled or disabled.

Submitted by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed by: erj@, shurd@
MFC after: 0 days
Sponsored by: Intel Corporation
Differential Revision: https://reviews.freebsd.org/D17900

5 years agoUse --work-tree instead of specifying an absolute path.
markj [Thu, 8 Nov 2018 17:20:00 +0000 (17:20 +0000)]
Use --work-tree instead of specifying an absolute path.

Otherwise the diff command being run from outside the checkout resulted
in warnings.

Discussed with: emaste
X-MFC with: r340083

5 years agoPut a size limit on the opensm.log and use bzip2(1).
hselasky [Thu, 8 Nov 2018 17:00:05 +0000 (17:00 +0000)]
Put a size limit on the opensm.log and use bzip2(1).

Discussed with: markj@
Sponsored by: Mellanox Technologies

5 years agoRevert r340246.
hselasky [Thu, 8 Nov 2018 16:23:09 +0000 (16:23 +0000)]
Revert r340246.

Sponsored by: Mellanox Technologies

5 years agoamd64: align memset buffers to 16 bytes before using rep stos
mjg [Thu, 8 Nov 2018 15:12:36 +0000 (15:12 +0000)]
amd64: align memset buffers to 16 bytes before using rep stos

Both Intel manual and Agner Fog's docs suggest aligning to 16.

See the review for benchmark results.

Reviewed by: kib (previous version)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17661

5 years agoUpdate rum(4) and run(4) man pages to reflect that newer versions
bz [Thu, 8 Nov 2018 14:46:21 +0000 (14:46 +0000)]
Update rum(4) and run(4) man pages to reflect that newer versions
of TP-LINK TL-WN321G are run(4) and not rum(4) anymore.

Reported by: J (tech-lists zyxst.net)
MFC after: 3 days

5 years agoipfw.8: fix small syntax error in an example
eugen [Thu, 8 Nov 2018 13:17:38 +0000 (13:17 +0000)]
ipfw.8: fix small syntax error in an example

MFC after: 3 days

5 years agoDon't read the USB audio sync endpoint when we don't use it to save
hselasky [Thu, 8 Nov 2018 12:46:47 +0000 (12:46 +0000)]
Don't read the USB audio sync endpoint when we don't use it to save
isochronous bandwidth.

MFC after: 3 days
Sponsored by: Mellanox Technologies

5 years agoAdd /var/log/opensm.log to list of rotating log files.
hselasky [Thu, 8 Nov 2018 12:43:13 +0000 (12:43 +0000)]
Add /var/log/opensm.log to list of rotating log files.

MFC after: 3 days
Sponsored by: Mellanox Technologies

5 years agoping(8): improve diagnostics in case of wrong arguments.
eugen [Thu, 8 Nov 2018 09:45:13 +0000 (09:45 +0000)]
ping(8): improve diagnostics in case of wrong arguments.

For example, in case of super-user:
$ sudo ping -s -64 127.0.0.1
PING 127.0.0.1 (127.0.0.1): -64 data bytes
ping: sendto: Invalid argument

For unprivileged user:
$ ping -s -64 127.0.0.1
ping: packet size too large: 18446744073709551552 > 56: Operation not permitted

Fix this by switching from strtoul() to strtol() for integer arguments
and adding explicit checks for negative values.

MFC after: 1 month

5 years agoAdd a top-level make target to rebuild all sysent files.
brooks [Thu, 8 Nov 2018 00:35:00 +0000 (00:35 +0000)]
Add a top-level make target to rebuild all sysent files.

The sysent target is useful when changing makesyscalls.sh, when
making paired changes to syscalls.master files, or in a future where
freebsd32 sysent entries are built from the default syscalls.master.

Reviewed by: bdrewery
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17899

5 years agoFix a use-after-free in swp_pager_meta_free().
markj [Wed, 7 Nov 2018 23:28:11 +0000 (23:28 +0000)]
Fix a use-after-free in swp_pager_meta_free().

This was introduced in r326329 and explains the crashes mentioned in
the commit log message for r339934.  In particular, on INVARIANTS
kernels, UMA trashing causes the loop to exit early, leaving swap
blocks behind when they should have been freed.  After r336984 this
became more problematic since new anonymous mappings were more
likely to reuse swapped-out subranges of existing VM objects, so faults
would trigger pageins of freed memory rather than returning zeroed
pages.

Reviewed by: kib
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17897

5 years agoloader: ptable_open() check for ptable_cd9660read result is wrong
tsoome [Wed, 7 Nov 2018 21:36:52 +0000 (21:36 +0000)]
loader: ptable_open() check for ptable_cd9660read result is wrong

The ptable_*read() functions return NULL on read errors (and partition table
closed as an side effect). The ptable_open must check the return value and
act properly.

PR: 232483
Reported by: lev
Reviewed by: lev,cem
Differential Revision: https://reviews.freebsd.org/D17890

5 years agobspatch: simplify capsicumization
oshogbo [Wed, 7 Nov 2018 21:01:14 +0000 (21:01 +0000)]
bspatch: simplify capsicumization

Assume that user wants to run with capsicum support if he builds the software
with HAVE_CAPSICUM. Treat running application without capsicum in the kernel as
an error.

MFC after: 3 weeks

5 years agonewvers.sh: avoid regenerating vers.c if content unchanged
emaste [Wed, 7 Nov 2018 20:36:57 +0000 (20:36 +0000)]
newvers.sh: avoid regenerating vers.c if content unchanged

When reproducible build mode is enabled vers.c may be unchanged between
successive builds.  In this case avoid changing the file's metadata so
that it does not cause dependent targets to be rebuilt.

Sponsored by: The FreeBSD Foundation
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D17892

5 years agoFix rxcsum issue introduced in r338838
shurd [Wed, 7 Nov 2018 19:31:48 +0000 (19:31 +0000)]
Fix rxcsum issue introduced in r338838

r338838 attempted to fix issues with rxcsum and rxcsum6.
However, the rxcsum bits were set as though if_setcapenablebit() was
being called, not if_togglecapenable() which is in use. As a result,
it was not possible to disable rxcsum when rxcsum6 was supported.

PR: 233004
Reported by: lev
Reviewed by: lev
MFC after: 3 days
Sponsored by: Limelight Networks
Differential Revision: https://reviews.freebsd.org/D17881

5 years agoEnable non-executable stacks by default on RISC-V.
jhb [Wed, 7 Nov 2018 18:32:02 +0000 (18:32 +0000)]
Enable non-executable stacks by default on RISC-V.

Reviewed by: markj
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D17878

5 years agoDrop the legacy ELF brandinfo for the old rtld from arm64 and riscv.
jhb [Wed, 7 Nov 2018 18:28:55 +0000 (18:28 +0000)]
Drop the legacy ELF brandinfo for the old rtld from arm64 and riscv.

These architectures never shipped binaries with an rtld path of
/usr/libexec/ld-elf.so.1.

Reviewed by: markj
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D17876

5 years agoEnable use of a global shared page for RISC-V.
jhb [Wed, 7 Nov 2018 18:27:43 +0000 (18:27 +0000)]
Enable use of a global shared page for RISC-V.

machine/vmparam.h already defines the SHAREDPAGE constant.  This
change just enables it for ELF executables.  The only use of the
shared page currently is to hold the signal trampoline.

Reviewed by: markj, kib
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D17875

5 years agorc.subr(8): Document when required_* variables are processed
0mp [Wed, 7 Nov 2018 16:56:32 +0000 (16:56 +0000)]
rc.subr(8): Document when required_* variables are processed

At the moment rc.subr(8) supports the following required_* variables:
required_dirs, required_files, required_modules and required_vars.

This patch documents when every of those required_* variables is actually
processed (before or after running start_precmd).

Reviewed by: bcr
Approved by: krion (mentor, implicit), mat (mentor, implicit)
Sponsored by: Bally Wulff Games & Entertainment GmbH
Differential Revision: https://reviews.freebsd.org/D17895

5 years agoRegen after r340221: allow pointer return types.
brooks [Wed, 7 Nov 2018 16:56:07 +0000 (16:56 +0000)]
Regen after r340221: allow pointer return types.

Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17873

5 years agomakesyscalls.sh: allow pointer return types.
brooks [Wed, 7 Nov 2018 16:55:04 +0000 (16:55 +0000)]
makesyscalls.sh: allow pointer return types.

The previous code required that the return type be a single word.  This
allows it to be a pointer without using a typedef.

Update the return types of break, mmap, and shmat to be void * as
declared.  This only effects systrace output in-tree, but can aid in
generating system call wrappers from syscalls.master.

Reviewed by: kib
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17873

5 years agoRevert r340187, it breaks EOD (end-of-device) detection logic. Turns out,
sobomax [Wed, 7 Nov 2018 16:28:09 +0000 (16:28 +0000)]
Revert r340187, it breaks EOD (end-of-device) detection logic. Turns out,
i/o into last_sector+N is handled differently for N==1 and N>1 cases to
accomodate that, so some other approach would be needed to fix DIOCGDELETE
ioctl(2).

5 years agoHandle the DT_MIPS_RLD_MAP_REL dynamic tag in RTLD
arichardson [Wed, 7 Nov 2018 15:04:41 +0000 (15:04 +0000)]
Handle the DT_MIPS_RLD_MAP_REL dynamic tag in RTLD

This dynamic tag contains the location of the .rld_map section relative to
the location of the dynamic tag. For PIE MIPS binaries DT_MIPS_RLD_MAP can
not be used since it contains an absolute address. Without this change
GDB can not find the function program counters in other libraries and once
I apply this change I can successfully run info sharedlibraries again.

Reviewed By: kib
Differential Revision: https://reviews.freebsd.org/D17867

5 years agoAdd benchmarks for lstat(2) and readlink(2).
trasz [Wed, 7 Nov 2018 11:46:12 +0000 (11:46 +0000)]
Add benchmarks for lstat(2) and readlink(2).

MFC after: 2 weeks
Sponsored by: DARPA, AFRL

5 years agoloader: always set media size from partition.
tsoome [Wed, 7 Nov 2018 11:14:22 +0000 (11:14 +0000)]
loader: always set media size from partition.

The disk access is validated by using partition table definitions, therefore
we have no need for if statements, just set the disk size.

Of course the partition table itself may be incorrect/inconsistent, but if
so, we are in trouble anyhow.

Differential Revision: https://reviews.freebsd.org/D17822

5 years agoAdd the (untested) mips and sparc64 .init call sequences.
andrew [Wed, 7 Nov 2018 09:49:25 +0000 (09:49 +0000)]
Add the (untested) mips and sparc64 .init call sequences.

The BSD crtbegin/crtend code now builds on all architectures, however
further work is needed to check if it works correctly.

MFC with: r339738
Sponsored by: DARPA, AFRL

5 years agoSometimes the complete split packet may be queued too early and the
hselasky [Wed, 7 Nov 2018 08:25:44 +0000 (08:25 +0000)]
Sometimes the complete split packet may be queued too early and the
transaction translator will return a NAK. Ignore this message and
retry the complete split instead.

MFC after: 3 days
Sponsored by: Mellanox Technologies

5 years agoComestic change to try to inline the memset with SSE/AVX instructions.
araujo [Wed, 7 Nov 2018 06:29:01 +0000 (06:29 +0000)]
Comestic change to try to inline the memset with SSE/AVX instructions.
Also switch from int to size_t to keep portability.

Reviewed by: brooks
Sponsored by: iXsystems Inc.
Differential Revision: https://reviews.freebsd.org/D17795

5 years agoRevert my bogus attempt to silence coverity on r340045, it created
araujo [Wed, 7 Nov 2018 04:20:29 +0000 (04:20 +0000)]
Revert my bogus attempt to silence coverity on r340045, it created
more bad side effects than good.

PR: 233038
Submitted by: We Maag <jwmaag@gmail.com>

5 years agopowerpc/atomic: Loosen the memory barrier on atomic_load_acq_*()
jhibbits [Wed, 7 Nov 2018 01:42:00 +0000 (01:42 +0000)]
powerpc/atomic: Loosen the memory barrier on atomic_load_acq_*()

'sync' is pretty heavy-handed, and is unnecessary for this use case.  It's a
full barrier, which is applicable for all storage types.  However,
atomic_load_acq_*() is only expected to operate on physical memory, not
device memory, so lwsync is sufficient (lwsync provides access ordering on
memory that is marked as Coherency Required and is not Write Through nor
Cache Inhibited).  On 32-bit systems, this is a nop, since powerpc_lwsync()
is defined to use sync, as a workaround for a silicon bug in the Freescale
e500 core.

5 years agoAvoid fixing the tty_info() buffer size in tty.h.
markj [Tue, 6 Nov 2018 23:41:44 +0000 (23:41 +0000)]
Avoid fixing the tty_info() buffer size in tty.h.

Different compilation units may otherwise get a different view of the
layout of struct tty depending on whether they include opt_printf.h.
This caused a blowup in the number of types defined in the kernel's
CTF file after r339468; thanks to dim@ for bisecting down to that
revision.

PR: 232675
Reported by: dim
Reviewed by: cem (previous version)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17877

5 years agoChange nfs_advlock() so that the NFSVOPUNLOCK() is mostly done at the end.
rmacklem [Tue, 6 Nov 2018 22:50:50 +0000 (22:50 +0000)]
Change nfs_advlock() so that the NFSVOPUNLOCK() is mostly done at the end.

Prior to this patch, nfs_advlock() did NFSVOPUNLOCK(); return (error);
in many places. This patch replaces these code sequenences with a "goto out;"
and does the NFSVOPUNLOCK(); return (error); at the end of the function
in order to make the vnode locking simpler.
This patch does not change the semantics of nfs_advlock().

Suggested by: kib
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D17853

5 years agoTreat the memory lengths for CHELSIO_T4_GET_MEM as unsigned.
jhb [Tue, 6 Nov 2018 22:33:36 +0000 (22:33 +0000)]
Treat the memory lengths for CHELSIO_T4_GET_MEM as unsigned.

Previously attempts to read the MC region were failing since the
length was greater than 2^31.

Reviewed by: np
MFC after: 2 months
Differential Revision: https://reviews.freebsd.org/D17857

5 years agoAvoid specifying VM_PROT_EXECUTE in mappings from pipe_map and exec_map.
markj [Tue, 6 Nov 2018 21:57:03 +0000 (21:57 +0000)]
Avoid specifying VM_PROT_EXECUTE in mappings from pipe_map and exec_map.

These submaps are used for mapping pipe buffers and execv() argument
strings respectively, so there's no need for such mappings to have
execute permissions.

Reported by: jhb
Reviewed by: alc, jhb, kib
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17827

5 years agoCleanup locale tools:
yuripv [Tue, 6 Nov 2018 21:49:50 +0000 (21:49 +0000)]
Cleanup locale tools:

- Simplify the source dir specification, and update README
  appropriately
- Drop the LC (doonly) processing, it's broken, and even if fixed, not
  really useful
- Don't remove the target directories while installing new data as it
  removes Makefile.depend which we don't manage; only rm the files we
  are going to add/replace/delete instead
- Restrict adding bsd.endian.mk to colldef and ctypedef Makefiles, it's
  not needed in other (text-only) categories
- GC unused scripts; they don't seem to be particularly helpful standalone
  as well

Reviewed by: bapt
Approved by: kib (mentor, implicit)
Differential Revision: https://reviews.freebsd.org/D17858

5 years agoWe need opt_stack.h after r339605.
markj [Tue, 6 Nov 2018 21:47:22 +0000 (21:47 +0000)]
We need opt_stack.h after r339605.

Reviewed by: cem
Sponsored by: The FreeBSD Foundation

5 years agoUpdate some comments made obsolete by recent commits.
brooks [Tue, 6 Nov 2018 20:45:15 +0000 (20:45 +0000)]
Update some comments made obsolete by recent commits.

5 years agoRegen after r340199: Use declared types for caddr_t arguments.
brooks [Tue, 6 Nov 2018 18:47:29 +0000 (18:47 +0000)]
Regen after r340199: Use declared types for caddr_t arguments.

Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17852

5 years agoUse declared types for caddr_t arguments.
brooks [Tue, 6 Nov 2018 18:46:38 +0000 (18:46 +0000)]
Use declared types for caddr_t arguments.

Leave ptrace(2) alone for the moment as it's defined to take a caddr_t.

Reviewed by: kib
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D17852

5 years agoRemove ppoll. freebsd32 doesn't define a ppoll syscall.
oshogbo [Tue, 6 Nov 2018 18:26:40 +0000 (18:26 +0000)]
Remove ppoll. freebsd32 doesn't define a ppoll syscall.

Reported by: jhb

5 years agoRegenerate after r340195.
oshogbo [Tue, 6 Nov 2018 18:06:52 +0000 (18:06 +0000)]
Regenerate after r340195.

5 years agoTurn off BUILD_WITH_STRICT_TMPPATH by default
arichardson [Tue, 6 Nov 2018 18:06:52 +0000 (18:06 +0000)]
Turn off BUILD_WITH_STRICT_TMPPATH by default

Building with a strict $PATH (without inheriting from the parent
environment) still causes build failures in some workflows/environemnts
that I have not yet tested.
I will try to bring this back once these issues have all been resolved
since it is actually extremely useful in tracking broken dependencies
and wrong assumptions about the build environemt.

Discussed With: brooks

5 years agocapsicum: Add ppoll and freebsd32_ppoll to compat32.
oshogbo [Tue, 6 Nov 2018 18:05:46 +0000 (18:05 +0000)]
capsicum: Add ppoll and freebsd32_ppoll to compat32.

PR: 232495
Pointed out by: brooks
MFC after: 2 weeks

5 years agoRegenerate after r340129.
oshogbo [Tue, 6 Nov 2018 18:03:04 +0000 (18:03 +0000)]
Regenerate after r340129.

Pointed out by: brooks

5 years agoAdd the KUBSAN options to the arm64 and amd64 GENERIC kernel config files.
andrew [Tue, 6 Nov 2018 17:47:58 +0000 (17:47 +0000)]
Add the KUBSAN options to the arm64 and amd64 GENERIC kernel config files.
As the kernel file size may be too large to run with a stock loader comment
them out for now.

Sponsored by: DARPA, AFRL

5 years agoUse plain atomic_{add,subtract} when that's sufficient.
markj [Tue, 6 Nov 2018 17:32:25 +0000 (17:32 +0000)]
Use plain atomic_{add,subtract} when that's sufficient.

CID: 1386920
MFC after: 2 weeks

5 years agoPort the NetBSD ubsan runtime to the FreeBSD kernel.
andrew [Tue, 6 Nov 2018 17:32:07 +0000 (17:32 +0000)]
Port the NetBSD ubsan runtime to the FreeBSD kernel.

This allows us to build the ubsan code added in r340189 into the kernel
with the KUBSAN option. This will report when undefined behaviour is
detected in the currently running kernel.

As it can be large, the kernel is 65MB on arm64, loader may not be able to
load the kernel on all architectures so is disabled by default for now.

Sponsored by: DARPA, AFRL

5 years agoImport the NetBSD micro ubsan code for the kernel.
andrew [Tue, 6 Nov 2018 16:56:49 +0000 (16:56 +0000)]
Import the NetBSD micro ubsan code for the kernel.

This imports revision 1.3 of common/lib/libc/misc/ubsan.c from NetBSD, the
micro-ubsan code. It is an implementation of the Undefined Behavior
Sanitizer runtime for use with recent clang and gcc.

The uubsan code will be used in a later commit to implement kubsan to help
find undefined behavior in the kernel.

Sponsored by: DARPA, AFRL

5 years agoRegen src.conf.5 after r340186
emaste [Tue, 6 Nov 2018 15:57:17 +0000 (15:57 +0000)]
Regen src.conf.5 after r340186

5 years agoDon't allow BIO_READ, BIO_WRITE or BIO_DELETE requests that are
sobomax [Tue, 6 Nov 2018 15:55:41 +0000 (15:55 +0000)]
Don't allow BIO_READ, BIO_WRITE or BIO_DELETE requests that are
fully beyond the end of providers media. The only exception is made
for the zero length transfers which are allowed to be just on the
boundary. Previously, any requests starting on the boundary (i.e. next
byte after the last one) have been allowed to go through.

No response from: freebsd-geom@, phk
MFC after: 1 month

5 years agoAdd a WITH_BIND_NOW build knob
emaste [Tue, 6 Nov 2018 15:52:49 +0000 (15:52 +0000)]
Add a WITH_BIND_NOW build knob

The linker's -z now flag sets the DF_BIND_NOW flag, which signals to the
runtime loader that all relocation processing should be performed at
process startup rather than on demand.  In combination with lld's
default of enabling relro this causes the GOT to be made read-only when
the process starts, preventing straightforward GOT overwrite attacks.

Shawn Webb discovered a failure on HardenedBSD with BIND_NOW and ifunc
use, which resulted in my rtld fix in r340137.  Add a BIND_NOW knob as
it is trivial to do so and is a useful ELF hardening feature.  This
change is equivalent to HardenedBSD's but not identical as there are
other diffs/conflicts nearby.

Note that our ELF Tool Chain readelf does not currently decode the
DF_BIND_NOW flag - see PR232983.

Reviewed by: brooks
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17846