]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/log
FreeBSD/FreeBSD.git
7 years agoMFC r315018:
markj [Mon, 13 Mar 2017 19:12:18 +0000 (19:12 +0000)]
MFC r315018:
Typo.

7 years agoSwitch from the usage of vm_map_find()/vm_map_insert() to vm_map_fixed().
kib [Mon, 13 Mar 2017 10:49:36 +0000 (10:49 +0000)]
Switch from the usage of vm_map_find()/vm_map_insert() to vm_map_fixed().

MFC r314487:
Use vm_map_insert() instead of vm_map_find() in elf_map_insert().

MFC r314773:
Instead of direct use of vm_map_insert(), call vm_map_fixed(MAP_CHECK_EXCL).

7 years agoMFC r314486:
kib [Mon, 13 Mar 2017 10:41:47 +0000 (10:41 +0000)]
MFC r314486:
When deallocating the vm object in elf_map_insert() due to
vm_map_insert() failure, drop the vnode lock around the call to
vm_object_deallocate().

7 years agoMFC r314715:
ae [Mon, 13 Mar 2017 08:04:25 +0000 (08:04 +0000)]
MFC r314715:
  Reject invalid object types that can not be used with specific opcodes.

  When we doing reference counting of named objects in the new rule,
  for existing objects check that opcode references to correct object,
  otherwise return EINVAL.

  PR: 217391

7 years agoMFC r314786: Import mpr(4) driver P12 to P14 diff from vendor site.
mav [Mon, 13 Mar 2017 06:51:50 +0000 (06:51 +0000)]
MFC r314786: Import mpr(4) driver P12 to P14 diff from vendor site.

This is mostly a version bump to stay in version number sync with firmware.
The only change there was cosmetic:  Display degraded speed message upon
receiving Active Cable Exception Event with DEGRADED reason code.

7 years agoMFC r314807:
ngie [Mon, 13 Mar 2017 01:34:40 +0000 (01:34 +0000)]
MFC r314807:

Move ATF_TC_WITHOUT_HEAD(getgrent) near the testcase it annotates

7 years agoMFC r314793,r314796,r314797,r314798,r314799,r314800,r314801,r314802,r314803,r314804...
ngie [Mon, 13 Mar 2017 01:17:33 +0000 (01:17 +0000)]
MFC r314793,r314796,r314797,r314798,r314799,r314800,r314801,r314802,r314803,r314804,r314805:

r314793:

Fix ATF_TP_ADD_TCS example in atf-c-api(3)

ATF_TP_ADD_TC should use `tp` as the second argument, not `tcs`, as
ATF_TP_ADD_TCS uses `tp` as its first argument.

Bump .Dd for the change.

r314796:

Fix atf-sh(3) manpage issues

- Fix spelling errors (specifiying -> specifying) [1]
- Escape '.' at start of lines using & to tell the roff processor
  that the line isn't meant to be treated as a command [2].

Bump .Dd for the change

r314797:

Fix grammar warning noted by igor

Remove surrounding ellipses in e.g. section and add a comma before and after
the e.g. reference.

r314798:

Fix out-of-order sections in atf-sh(1)

- `.Op` must be used in the SYNOPSIS section, not the NAME section.
- Move ATF_SHELL environment variable description up to first
  ENVIRONMENT section. Garbage collect the duplicate ENVIRONMENT
  section.

Bump .Dd for the change

r314799:

Fix manlint issues with atf-check(1)

- Use `.Bf Em`/`.Ef` instead of prefixing lines with `.Em`. The forms
  are equivalent with traditional roff, but unnecessarily verbose. The
  former form applies the .Em macro to the enclosed block.
- Move EXIT_STATUS section down so the section complies with section
  ordering specified by mdoc(7) and enforced by manlint(1).

Bump .Dd for the change

r314800:

Fix issues with atf-check(1) found by igor and refer to atf-check(1)

- Fix typo (specifiying -> specifying)
- Add atf-check(1) to SEE ALSO section for completeness. It's mentioned
  above, but by convention the SEE ALSO section should list all relevant
  references to other tools and APIs.

Bump .Dd for the change

r314801:

Fix igor/manlint issues with atf-c(3)

- Remove surrounding ellipses in i.e. section and add a comma before
  and after the i.e. reference [1].
- Fix typo (specifiying -> specifying) [1].
- Escape '.' at start of lines using & to tell the roff processor
  that the line isn't meant to be treated as a command [2].

Bump .Dd for the change

r314802:

Fix atf-c-api(3) manpage issues

- Fix typo (specifiying -> specifying).
- Remove surrounding ellipses in i.e. section and add a comma before
  and after the i.e. reference.

Bump .Dd for the change

r314803:

Fix typos

- specifiying -> specifying
- manged -> managed

Bump .Dd for the change

r314804:

Fix issues noted by igor/manlint

- Fix typos [1]:
-- manged -> managed
-- specifiying -> specifying
- Escape '.' at start of lines using & to tell the roff processor
  that the line isn't meant to be treated as a command [2].

Bump .Dd for the change

r314805:

Remove *-api(3) manpages removed in ATF 0.21

I overlooked the fact that these manpages had been removed upstream
and replaced with their non *-api(3) equivalents. Follow upstream's
lead and remove the unused manpages.

7 years agoMFC r314686: sh: Fix crash if a -T trap is taken during command substitution
jilles [Sun, 12 Mar 2017 18:38:03 +0000 (18:38 +0000)]
MFC r314686: sh: Fix crash if a -T trap is taken during command substitution

Code like  t=$(stat -f %m "$file")  segfaulted if -T was active and a trap
was taken while the shell was waiting for the child process to finish.

What happened was that the dotrap() call in waitforjob() was hit. This
re-entered command execution (including expand.c) at a point not expected by
expbackq(), and global state (unallocated stack string and argbackq) was
corrupted.

To fix this, change expbackq() to prepare for command execution to be
re-entered.

Reported by: bdrewery

7 years agoMFC r314637: sh: Add some already working tests that exercise new code paths
jilles [Sun, 12 Mar 2017 18:24:45 +0000 (18:24 +0000)]
MFC r314637: sh: Add some already working tests that exercise new code paths

7 years agoMFH (r314598): load default options before requesting ticket
des [Sun, 12 Mar 2017 13:22:35 +0000 (13:22 +0000)]
MFH (r314598): load default options before requesting ticket

PR: 213909

7 years agoMFH (r314554): fix date in previous commit
des [Sun, 12 Mar 2017 13:18:48 +0000 (13:18 +0000)]
MFH (r314554): fix date in previous commit

7 years agoMFH (r314528): update to reflect the state of SHA-1
des [Sun, 12 Mar 2017 13:14:49 +0000 (13:14 +0000)]
MFH (r314528): update to reflect the state of SHA-1

7 years agoMFC r314960:
kib [Sun, 12 Mar 2017 12:11:11 +0000 (12:11 +0000)]
MFC r314960:
Fix typo in comment.

7 years agoMFC r314308: Fix LUN enabling on wildcard target, as done by CTL.
mav [Sun, 12 Mar 2017 06:19:58 +0000 (06:19 +0000)]
MFC r314308: Fix LUN enabling on wildcard target, as done by CTL.

7 years agoMFC r314307: Add support for SIMs without autosense.
mav [Sun, 12 Mar 2017 06:18:08 +0000 (06:18 +0000)]
MFC r314307: Add support for SIMs without autosense.

If we asked to send sense data by setting CAM_SEND_SENSE, but SIM didn't
confirm transmission by setting CAM_SENT_SENSE, assume it was not sent.
Queue the I/O back to CTL for later REQUEST SENSE with ctl_queue_sense().
This is needed for error reporting on SPI HBAs like ahc(4)/ahd(4).

7 years agoMFC r314321:
pfg [Sun, 12 Mar 2017 05:35:28 +0000 (05:35 +0000)]
MFC r314321:
dc(1): Merge minor changes from OpenBSD.

Prefer setvbuf() to setlinebuf() for portability.
Some style(9) and redundant tests for NULL.

These are only meant to ease up merging newer changes.

Obtained from: OpenBSD

7 years agoMFC r314542:
ngie [Sun, 12 Mar 2017 04:59:02 +0000 (04:59 +0000)]
MFC r314542:

kern.cam.da.X.delete_method: add -width to .Bl macro call

Now the section width is set appropriately per the BIO_DELETE
parameter being described.

7 years agoMFC r314545:
ngie [Sun, 12 Mar 2017 04:57:35 +0000 (04:57 +0000)]
MFC r314545:

Add missing section to .Xr macro calls for wpifw(4)

The driver manpage for wpifw(4) is missing, but will be added soon. This
fixes the other 2 .Xr calls lacking sections to match the 3rd,
syntactically correct, reference in the SEE ALSO section.

7 years agoMFC r314610:
ngie [Sun, 12 Mar 2017 04:56:21 +0000 (04:56 +0000)]
MFC r314610:

Clean up ddb(4) slightly

- Delete empty Li macro uses [1]. This removes some spaces between
  the optional command/subcommand arguments.
- Attempt to clarify "show lock" subcommand by being more
  terse/direct. This addresses an issue with a contraction [2].

7 years agoMFC r314233:
ngie [Sun, 12 Mar 2017 04:55:06 +0000 (04:55 +0000)]
MFC r314233:

Parameterize out the length of struct filed->f_lasttime as `MAXDATELEN`

This removes the hardcoded value for the field (16) and the equivalent
hardcoded lengths in logmsg(..).

This change is being done to help stage future work to add RFC5424/RFC5434
support to syslogd(8).

Obtained from: Isilon OneFS (dcd33d13da) (as part of a larger change)

7 years agoMFC r314189,r314190,r314191:
ngie [Sun, 12 Mar 2017 04:53:48 +0000 (04:53 +0000)]
MFC r314189,r314190,r314191:

r314189:

Fix up NULL/'\0' uses and fix 2 derefs after NULL

CID: 10188981018899

r314190:

Fix some minor style nits: put parentheses around return values

r314191:

Fix up r314189

The conditional in do_buff_decode(..) after the while loop was accidentally
inverted. Only increment the pointer for fmt if it's not NUL.

7 years agoMFC r314650:
ngie [Sun, 12 Mar 2017 04:52:09 +0000 (04:52 +0000)]
MFC r314650:

Fix warnings in lib/msun/tests/... to help pave way for WARNS?= 6.

- Staticize variables.
- Use nitems liberally. Wherever nitems is used, use unsigned integers
- Remove unused variables (argc, argv, etc)

This fixes most issues -- some issues remain in logarithm_test though.

7 years agoMFC r314644:
ngie [Sun, 12 Mar 2017 04:41:38 +0000 (04:41 +0000)]
MFC r314644:

Fix "make depend" with geom_uzip.ko: add opt_geom.h to SRCS

7 years agoMFC r305283,r314649:
ngie [Sun, 12 Mar 2017 04:40:01 +0000 (04:40 +0000)]
MFC r305283,r314649:

r305283:

Skip :test_large on i386

More assertions are failing on ^/head now.

PR: 205446

r314649:

Convert lib/msun/ctrig_test from TAP to ATF

This is being done as a precursor for work needed to annontate failing
testcases with clang 4.0+.

PR: 217528

7 years agoMFC r314645:
ngie [Sun, 12 Mar 2017 04:33:44 +0000 (04:33 +0000)]
MFC r314645:

Fix "make depend" with nvme.ko: add opt_cam.h to SRCS

7 years agoMFC r314239:
ngie [Sun, 12 Mar 2017 04:32:15 +0000 (04:32 +0000)]
MFC r314239:

Add shutdown/poweroff support to rescue(8)

shutdown is a safer way to power off than reboot (in general), because of
the added shutdown process that it executes via /etc/rc.shutdown . It was
odd that it was missing from rescue(8) since reboot and friends were
added in past commits.

While here, alias poweroff to shutdown for parity with sbin/shutdown/Makefile

7 years agoMFC r314240:
ngie [Sun, 12 Mar 2017 04:12:22 +0000 (04:12 +0000)]
MFC r314240:

Conditionally compile certain programs into rescue(8) if requested

MK_CCD - ccdconfig
MK_ROUTED - routed, rtquery

7 years agoMFC 308106:
lwhsu [Sun, 12 Mar 2017 00:46:49 +0000 (00:46 +0000)]
MFC 308106:
- Use virtualbox-ose-additions-nox11 for vagrant image to reduce size

7 years agoMFC r314896:
cy [Sat, 11 Mar 2017 18:06:20 +0000 (18:06 +0000)]
MFC r314896:

Remove extraneous arguments and options, which don't make sense for
a file documented in volume 5.

7 years agoMFC r314768:
cy [Sat, 11 Mar 2017 17:57:22 +0000 (17:57 +0000)]
MFC r314768:

Fix mismerge of r280849.

Reported by: des

7 years agoMFC r312886:
cy [Sat, 11 Mar 2017 17:46:59 +0000 (17:46 +0000)]
MFC r312886:

Fix lookup of original destination address when using a redirect rule.
Transparent proxying, e.g. to squid, is an example of this.

Obtained from: NetBSD ip_nat.c r1.17, ip_nat6.c r1.10

7 years agoMFC r314274: l2arc: fix write size calculation broken by Compressed ARC commit
avg [Sat, 11 Mar 2017 15:30:28 +0000 (15:30 +0000)]
MFC r314274: l2arc: fix write size calculation broken by Compressed ARC commit

7 years agoMFC r314666: ioat: don't specify inline for function with variable argument list
avg [Sat, 11 Mar 2017 15:26:36 +0000 (15:26 +0000)]
MFC r314666: ioat: don't specify inline for function with variable argument list

7 years agoMFC r314253:
kib [Sat, 11 Mar 2017 09:22:53 +0000 (09:22 +0000)]
MFC r314253:
Do not leak mount references for dying threads.

7 years agoMFC r303464 (by brooks@):
dchagin [Sat, 11 Mar 2017 08:39:24 +0000 (08:39 +0000)]
MFC r303464 (by brooks@):

Don't create pointless backups of generated files in "make sysent".

Any sensible workflow will include a revision control system from which
to restore the old files if required.  In normal usage, developers just
have to clean up the mess.

7 years agoMFC r314556-r314558
brooks [Sat, 11 Mar 2017 02:51:29 +0000 (02:51 +0000)]
MFC r314556-r314558

r314556:
Correct MDSRCS use in <arch>/string/Makefile.inc.

- Remove .c files which duplicate entries in MISRCS.
- Use the same, less merge conflict prone style in all cases.
- Use MDSRCS for mips (.c and .S files both ended up in SRCS).
- Remove pointless sparc64 Makefile.inc.
- Remove uninformative foreign VCS ID entries.

Reviewed by: emaste, imp, jhb
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D9841

r314557:
Correct an misunderstanding of MDSRCS.

MDSRCS it intended to allow assembly versions of funtions with C
implementations listed in MISRCS. The selection of the correct
machdep_ldis?.c for a given architecture does not follow this pattern
and the file should be added to SRCS directly.

Reviewed by: emaste, imp, jhb
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D9841

r314558:
Garbage collect unused gdtoa related files on mips.

Reviewed by: emase, imp, jhb
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D9841

7 years agoMFC r313021, r313027, r313044:
gjb [Sat, 11 Mar 2017 02:20:11 +0000 (02:20 +0000)]
MFC r313021, r313027, r313044:

 r313021 (brd):
  Force a few variables to be upper case when they are evaulated.

 r313027 (brd):
  Add a new vagrant-box target, to make it easier and less redundant
  to only produce the Vagrant box and not upload it.

 r313044 (brd):
  Add some comments with examples on how to build Vagrant images.

Sponsored by: The FreeBSD Foundation

7 years agoMFC r314916:
gjb [Sat, 11 Mar 2017 02:12:39 +0000 (02:12 +0000)]
MFC r314916:
 Fix permissions on /tmp when installing the runtime package.

PR: 217574
Sponsored by: The FreeBSD Foundation

7 years agoMFC r314626
vangyzen [Fri, 10 Mar 2017 20:30:17 +0000 (20:30 +0000)]
MFC r314626

Fix grammar in some comments in subr_sleepqueue.c

While I'm here, remove trailing whitespace.

7 years agoMFC r313820
vangyzen [Fri, 10 Mar 2017 20:25:43 +0000 (20:25 +0000)]
MFC r313820

pf: use inet_ntoa_r() instead of inet_ntoa(); maybe fix IPv6 OS fingerprinting

inet_ntoa() cannot be used safely in a multithreaded environment
because it uses a static local buffer. Instead, use inet_ntoa_r()
with a buffer on the caller's stack.

This code had an INET6 conditional before this commit, but opt_inet6.h
was not included, so INET6 was never defined.  Apparently, pf's OS
fingerprinting hasn't worked with IPv6 for quite some time.
This commit might fix it, but I didn't test that.

Relnotes: yes (if I/someone can test pf OS fingerprinting with IPv6)
Sponsored by: Dell EMC

7 years agoMFC r314055
vangyzen [Fri, 10 Mar 2017 20:06:17 +0000 (20:06 +0000)]
MFC r314055

Make several improvements and corrections in the kenv(2) man page

Sponsored by: Dell EMC

7 years agoMFC r313817
vangyzen [Fri, 10 Mar 2017 19:33:37 +0000 (19:33 +0000)]
MFC r313817

acpica: remove a superfluous NULL check

The address-of operator can't produce NULL (in practice).
Remove an unnecessary NULL check.

Sponsored by: Dell EMC

7 years agoMFC r313748, r313749:
markj [Fri, 10 Mar 2017 18:56:23 +0000 (18:56 +0000)]
MFC r313748, r313749:
Register nss_atexit() before parsing nsswitch.conf for the first time.

7 years agoMFC r314153, r314154:
markj [Fri, 10 Mar 2017 18:54:48 +0000 (18:54 +0000)]
MFC r314153, r314154:
Fix some memory leaks in CDDL code.

7 years agoMFC r314625:
markj [Fri, 10 Mar 2017 18:53:44 +0000 (18:53 +0000)]
MFC r314625:
Fix a ticks comparison in sched_pctcpu_update().

7 years agoMFC r313841, r313850:
markj [Fri, 10 Mar 2017 18:51:47 +0000 (18:51 +0000)]
MFC r313841, r313850:
Prevent CPU migration when checking the DTrace nofault flag on x86.

7 years agoMFC r314211:
kib [Fri, 10 Mar 2017 10:58:31 +0000 (10:58 +0000)]
MFC r314211:
Remove cpu_deepest_sleep variable.

7 years agoMFC r314592: Fix JSON output.
mav [Fri, 10 Mar 2017 06:17:54 +0000 (06:17 +0000)]
MFC r314592: Fix JSON output.

7 years agoMFC r314614:
ae [Fri, 10 Mar 2017 05:44:14 +0000 (05:44 +0000)]
MFC r314614:
  Fix matching table entry value. Use real table value instead of its index
  in valuestate array.

  When opcode has size equal to ipfw_insn_u32, this means that it should
  additionally match value specified in d[0] with table entry value.
  ipfw_table_lookup() returns table value index, use TARG_VAL() macro to
  convert it to its value. The actual 32-bit value stored in the tag field
  of table_value structure, where all unspecified u32 values are kept.

  PR: 217262

7 years agoMFC r314145, r314158
pfg [Thu, 9 Mar 2017 02:58:02 +0000 (02:58 +0000)]
MFC r314145, r314158
vxge(4): double assignments.

Fix some suspicious code, likely caused by excessive copy-pasting.

Found with: coccinelle (da.cocci)

7 years agoMFC r314505:
pfg [Wed, 8 Mar 2017 22:38:40 +0000 (22:38 +0000)]
MFC r314505:
Split the ficl CFLAGS when they refer to an arch-specific include path.

This is a minimal attempt to keep consistency in the Makefiles so that
moving ficl to somwehere like contrib will be less error prone.

7 years agoMFC r314219
mmokhi [Wed, 8 Mar 2017 13:09:12 +0000 (13:09 +0000)]
MFC r314219
Add linux_preadv() and linux_pwritev() syscalls to Linuxulator.

Approved by: dchagin

7 years agoMFC r314497:
ae [Wed, 8 Mar 2017 07:59:45 +0000 (07:59 +0000)]
MFC r314497:
  Do not invoke the resize event when previous provider's size was zero.
  This is similar to r303637 fix for geom_disk.

7 years agoMFC r314061:
dim [Wed, 8 Mar 2017 07:58:29 +0000 (07:58 +0000)]
MFC r314061:

Add __int128-related symbols to libcxxrt's version map.  Put these into
the same CXXABI verions as recent libstdc++.

Note that __int128 types are only available on arches where long long is
128 bit wide.

Noticed by: harti

MFC r314104:

Surround any unmangled C++ names in libcxxrt's version map with 'extern
"C++"', otherwise ld refuses to make the symbols global in the final
library.  This causes the __int128-related symbols to go missing when
the library is stripped during installation.

Helpful hints: emaste

7 years agoPull in r291403 from upstream clang trunk (by Richard Smith):
dim [Tue, 7 Mar 2017 21:44:05 +0000 (21:44 +0000)]
Pull in r291403 from upstream clang trunk (by Richard Smith):

  PR30305: Implement proposed DR resolution to prevent slicing via
  inherited constructor.

  The rule we use is that a construction of a class type T from an
  argument of type U cannot use an inherited constructor if U is the
  same as T or is derived from T (or if the initialization would first
  convert it to such a type). This (approximately) matches the rule in
  use by GCC, and matches the current proposed DR resolution.

Pull in r291955 from upstream clang trunk (by Richard Smith):

  PR31606: Generalize our tentative DR resolution for inheriting
  copy/move constructors to better match the pre-P0136R1 behavior.

Together, these fix an issue with C++ using declarations sometimes
enabling illegal implicit casts.

Direct commit to stable/11, since head already has clang 4.0.0, which
includes this change.

Reported by: kami
PR: 215969

7 years agoMFC 313879
jpaetzel [Tue, 7 Mar 2017 18:27:35 +0000 (18:27 +0000)]
MFC 313879

MVF: 313876

7504 kmem_reap hangs spa_sync and administrative tasks

illumos/illumos-gate@405a5a0f5c3ab36cb76559467d1a62ba648bd809
https://github.com/illumos/illumos-gate/commit/405a5a0f5c3ab36cb76559467d1a62ba648bd80

https://www.illumos.org/issues/7504

  We see long spa_sync(). We are waiting to hold dp_config_rwlock for writer. Some
  other thread holds dp_config_rwlock for reader, then calls arc_get_data_buf(),
  which finds that arc_is_overflowing()==B_TRUE. So it waits (while holding
  dp_config_rwlock for reader) for arc_reclaim_thread to signal arc_reclaim_waiters_cv.
  Before signaling, arc_reclaim_thread does arc_kmem_reap_now(), which takes ~seconds.

Author: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Approved by: Dan McDonald <danmcd@omniti.com>

7 years agoMFC r314058: zfs: lower priority of zio_write_issue threads by four
avg [Tue, 7 Mar 2017 15:27:40 +0000 (15:27 +0000)]
MFC r314058: zfs: lower priority of zio_write_issue threads by four

Obtained from: Panzura
Sponsored by: Panzura

7 years agoMFC r314429:
kib [Tue, 7 Mar 2017 12:16:47 +0000 (12:16 +0000)]
MFC r314429:
Initialize pcb_save for thread0.

7 years agoMFC r314374: Add safety check against too long CDB.
mav [Tue, 7 Mar 2017 05:56:48 +0000 (05:56 +0000)]
MFC r314374: Add safety check against too long CDB.

SBP-2 specification defined maximum CDB length as 12 bytes.  Newer SBP-3
specification allows CDB of any size, but this driver is too old.  Proper
solution would be to look on maximal ORB size supported by the target.

7 years agoMFC r314627:
cy [Tue, 7 Mar 2017 05:35:14 +0000 (05:35 +0000)]
MFC r314627:

Fix leak (free str before returning when ctx's calloc fails).

Submitted by: trix_juniper.net (Tom Rix)
Reviewed by: cy, ngie
Discovered by: clang's static analyzer
Differential Revision: D9877

7 years agoMFC r314430:
ae [Tue, 7 Mar 2017 03:01:09 +0000 (03:01 +0000)]
MFC r314430:
  When IPv6 fragments reassembly is complete, update mbuf's csum_data
  and csum_flags using information from all fragments. This fixes
  dropping of reassembled packets due to wrong checksum when the IPv6
  checksum offloading is enabled on a network card.

7 years agoMFC r314242:
ngie [Tue, 7 Mar 2017 02:16:40 +0000 (02:16 +0000)]
MFC r314242:

Remove MK_CRYPT stub

It doesn't directly control what gets installed today; it indirectly
pulls other knobs (like MK_KERBEROS, etc).

7 years agoMFC r314226:
ngie [Tue, 7 Mar 2017 02:02:23 +0000 (02:02 +0000)]
MFC r314226:

Use SRCTOP instead of .CURDIR relative paths with ".."

This simplifies pathing in make/displayed output

7 years agoMFC r313009:
ngie [Tue, 7 Mar 2017 02:01:02 +0000 (02:01 +0000)]
MFC r313009:

Expose symbols in lib/libclang_rt/profile to fix --coverage

The symbols currently hidden in libprofile_rt are needed for linking with
`clang --coverage` to add coverage counters at link time and produce
coverage numbers at runtime.

In collaboration with: dim

7 years agoMFC r313438:
ngie [Tue, 7 Mar 2017 01:58:39 +0000 (01:58 +0000)]
MFC r313438:

Clean up trailing and leading whitespace for variables to make it
consistent with the rest of the file and style.Makefile(9) a bit
more

7 years agoMFC r313439,r314450:
ngie [Tue, 7 Mar 2017 01:52:56 +0000 (01:52 +0000)]
MFC r313439,r314450:

r313439:

Merge content from ^/projects/netbsd-tests-upstream-01-2017 into ^/head

The primary end-goal of this drop is ease future merges with NetBSD and
collaborate further with the NetBSD project.

The goal was (largely, not completely as some items are still oustanding
in the NetBSD GNATS system) achieved by doing the following:
- Pushing as many changes required to port contrib/netbsd-tests
  back to NetBSD as possible, then pull the upstream applied changes
  back in to FreeBSD.
- Diff reduce with upstream where possible by:
-- Improving libnetbsd header, etc compat glue.
-- Using _SED variables to modify test scripts on the fly for items
   that could not be upstreamed to NetBSD.

As a bonus for this work, this change also introduces testcases for
uniq(1).

Many thanks to Christos for working with me to get many of the changes
back into the NetBSD project.

In collaboration with: Christos Zoulas <christos@netbsd.org>

r314450:

Add additional __FreeBSD_version guards around the hsearch_r testcases

The reasoning for this is the same as r276046: to ease MFCing the tests
to ^/stable/10 .

This was accidentally missed in r313439

7 years agoMFC r314062
davidcs [Mon, 6 Mar 2017 20:25:33 +0000 (20:25 +0000)]
MFC r314062
add bus_dmamap_unload in ql_free_dmabuf()

7 years agoMFC r314509 and r314578.
np [Mon, 6 Mar 2017 15:14:59 +0000 (15:14 +0000)]
MFC r314509 and r314578.

r314509:
cxgbe/iw_cxgbe: Do not check the size of the memory region being
registered.  T4/5/6 have no internal limit on this size.  This is
probably a copy paste from the T3 iw_cxgb driver.

r314578:
cxgbe/iw_cxgbe: Implement sq/rq drain operation.

ULPs can set a qp's state to ERROR and then post a work request on the
sq and/or rq.  When the reply for that work request comes back it is
guaranteed that all previous work requests posted on that queue have
been drained.

Sponsored by: Chelsio Communications

7 years agoMFC r314338: Polish handling of different reset flavours.
mav [Mon, 6 Mar 2017 06:46:21 +0000 (06:46 +0000)]
MFC r314338: Polish handling of different reset flavours.

The biggest change is that ctl_remove_initiator() now generates I_T NEXUS
LOSS event, cleaning part of LUs state related to the initiator.

7 years agoMFC r314326: Send TERMINATE to firmware when aborting active ATIO.
mav [Mon, 6 Mar 2017 06:45:00 +0000 (06:45 +0000)]
MFC r314326: Send TERMINATE to firmware when aborting active ATIO.

7 years agoMFC r314496: Add check missed in r314257.
mav [Mon, 6 Mar 2017 06:42:47 +0000 (06:42 +0000)]
MFC r314496: Add check missed in r314257.

7 years agoMFC r314387: Make ctl_queue_sense() not sleep.
mav [Mon, 6 Mar 2017 06:40:33 +0000 (06:40 +0000)]
MFC r314387: Make ctl_queue_sense() not sleep.

It may be called in non-sleepable frontend context.

7 years agoMFC r314302: Return better error code in case of too long CDB.
mav [Mon, 6 Mar 2017 06:39:10 +0000 (06:39 +0000)]
MFC r314302: Return better error code in case of too long CDB.

Its more important for SPI HBAs, as they don't support CDBs above 12 bytes.
The new error code makes CAM to fall back to alternative commands.

7 years agoMFC r314299, r314300: Fix residual length reporting in target mode.
mav [Mon, 6 Mar 2017 06:37:44 +0000 (06:37 +0000)]
MFC r314299, r314300: Fix residual length reporting in target mode.

This allows to properly handle cases when target wants to receive or send
more data then initiator wants to send or receive.  Previously in such
cases isp(4) returned CAM_DATA_RUN_ERR, while now it returns resid > 0.

7 years agoMFC r314257: Add reporting SAS protocol, in case we ever have one.
mav [Mon, 6 Mar 2017 06:36:15 +0000 (06:36 +0000)]
MFC r314257: Add reporting SAS protocol, in case we ever have one.

7 years agoMFC r314255: Reenable CTL_WITH_CA, optimizing it for lower memory usage.
mav [Mon, 6 Mar 2017 06:35:02 +0000 (06:35 +0000)]
MFC r314255: Reenable CTL_WITH_CA, optimizing it for lower memory usage.

This code was disabled due to its high memory usage.  But now we need this
functionality for cfumass(4) frontend, since USB MS BBB transport does not
support autosense.

7 years agoMFC r314247: Axe out some forever disabled questionable functionality.
mav [Mon, 6 Mar 2017 06:32:50 +0000 (06:32 +0000)]
MFC r314247: Axe out some forever disabled questionable functionality.

This code is complicated enough even in its base shape.

7 years agoMFC r314246: Improve CAM target frontend reference counting.
mav [Mon, 6 Mar 2017 06:31:42 +0000 (06:31 +0000)]
MFC r314246: Improve CAM target frontend reference counting.

Before this change it was possible to trigger some use-after-free panics
by disabling LUNs/ports under heavy load.

7 years agoMFC r314208: Respecting r314204 tighten ATIO cleanup requirements.
mav [Mon, 6 Mar 2017 06:30:27 +0000 (06:30 +0000)]
MFC r314208: Respecting r314204 tighten ATIO cleanup requirements.

Every ATIO must complete with either successfully sent status or XPT_ABORT.

7 years agoMFC r314204: Explicitly abort ATIO if CTIO sending status has failed.
mav [Mon, 6 Mar 2017 06:29:10 +0000 (06:29 +0000)]
MFC r314204: Explicitly abort ATIO if CTIO sending status has failed.

This helps SIM to free related resources in questionable cases.

7 years agoMFC r314203: Fix missing xpt_done() for ATIO/INOT on missing LUN.
mav [Mon, 6 Mar 2017 06:27:59 +0000 (06:27 +0000)]
MFC r314203: Fix missing xpt_done() for ATIO/INOT on missing LUN.

7 years agoMFC r314200: We can't access periph after ctlfe_free_ccb().
mav [Mon, 6 Mar 2017 06:27:15 +0000 (06:27 +0000)]
MFC r314200: We can't access periph after ctlfe_free_ccb().

7 years agoMFC r314196: Unify ATIO/INOT CCBs requeuing.
mav [Mon, 6 Mar 2017 06:25:33 +0000 (06:25 +0000)]
MFC r314196: Unify ATIO/INOT CCBs requeuing.

7 years agoMFC r314193: Some code cleanup.
mav [Mon, 6 Mar 2017 06:24:24 +0000 (06:24 +0000)]
MFC r314193: Some code cleanup.

7 years agoMFC r314088: Slightly polish isp_dump_atpd().
mav [Mon, 6 Mar 2017 06:23:17 +0000 (06:23 +0000)]
MFC r314088: Slightly polish isp_dump_atpd().

7 years agoMFC r314086: Fix multiple problems around LUN disable under load.
mav [Mon, 6 Mar 2017 06:22:07 +0000 (06:22 +0000)]
MFC r314086: Fix multiple problems around LUN disable under load.

 - Move private data about ATIOs/INOTs from per-LUN to per-channel data.
This allows active commands to continue operation after LUN destruction.
This also simplifies lookup of the data by tag in some situations.
 - Unify three restart_queue processing implementations.
 - Complete all ATIOs from restart_queue on LUN disable.
 - Delete ATIO private data when command completed or aborted, not depending
on the ATIO being requeued, that was ugly hack and could never happen.  CAM
should always call ether XPT_CONT_TARGET_IO with status or XPT_ABORT.
 - Implement XPT_ABORT for queued ATIOs/INOTs to allow CAM do graceful
shutdown, not depending on LUN disable, as it is done in ahd(4)/targ(4).
 - Unify isp_endcmd() arguments to make it more usable in generic code.
 - Remove never really used LUN state reference counter.

7 years agoMFC r314045: Remove duplicate INOT allocation.
mav [Mon, 6 Mar 2017 06:20:58 +0000 (06:20 +0000)]
MFC r314045: Remove duplicate INOT allocation.

For some reason isp_handle_platform_notify_fc() allocated INOT just
before calling isp_handle_platform_target_tmf(), which also allocates
INOT.  It seems to be a braino introduced in r196008.

7 years agoMFC r314038: Remove ancient __FreeBSD_version checks.
mav [Mon, 6 Mar 2017 06:19:42 +0000 (06:19 +0000)]
MFC r314038: Remove ancient __FreeBSD_version checks.

7 years agoMFC r314027: Do not blindly free completed ATIOs/INOTs on invalidation.
mav [Mon, 6 Mar 2017 06:18:30 +0000 (06:18 +0000)]
MFC r314027: Do not blindly free completed ATIOs/INOTs on invalidation.

When LUN is disabled, SIM starts returning queued ATIOs/INOTs.  But at the
same time there can be some ATIOs/INOTs still carrying real new requests.
If we free those, SIM may leak some resources, forever expecting for any
response from us.  So try to be careful, separating ATIOs/INOTs carrying
requests which still must be processed, from ATIOs/INOTs completed with
errors which can be freed.

7 years agoMFC r314358: Announce that sbp_targ(4) does not support initiator mode.
mav [Mon, 6 Mar 2017 06:08:17 +0000 (06:08 +0000)]
MFC r314358: Announce that sbp_targ(4) does not support initiator mode.

7 years agoMFC r313733:
badger [Mon, 6 Mar 2017 01:11:34 +0000 (01:11 +0000)]
MFC r313733:

sleepq_catch_signals: do thread suspension before signal check

Since locks are dropped when a thread suspends, it's possible for another
thread to deliver a signal to the suspended thread. If the thread awakens from
suspension without checking for signals, it may go to sleep despite having
a pending signal that should wake it up. Therefore the suspension check is
done first, so any signals sent while suspended will be caught in the
subsequent signal check.

Approved by: kib (mentor)
Sponsored by: Dell EMC

7 years agoMFC r314572:
mm [Sun, 5 Mar 2017 21:41:48 +0000 (21:41 +0000)]
MFC r314572:

Fix null pointer dereference in zfs_freebsd_setacl().

Prevents unprivileged users from panicking the kernel by calling
__acl_delete_*() on files or directories inside a ZFS mount.

7 years agopf: Fix a crash in low-memory situations
kp [Sun, 5 Mar 2017 13:14:18 +0000 (13:14 +0000)]
pf: Fix a crash in low-memory situations

If the call to pf_state_key_clone() in pf_get_translation() fails (i.e. there's
no more memory for it) it frees skp. This is wrong, because skp is a
pf_state_key **, so we need to free *skp, as is done later in the function.
Getting it wrong means we try to free a stack variable of the calling
pf_test_rule() function, and we panic.

7 years agoMFC r313936, r313937: Move CTIO waitq from per-LUN to per-channel.
mav [Sun, 5 Mar 2017 05:17:02 +0000 (05:17 +0000)]
MFC r313936, r313937: Move CTIO waitq from per-LUN to per-channel.

All resources lack of which may put CTIO into the queue are either
per-channel or potentially per-queue, but none of them are per-LUN.

This is a first step to fix live LUN disabling.  Before this change
any CTIOs held in a queue in time of disabling were just leaked.

7 years agoMFC r313945: Remove broken remnants of obsolete INOT API.
mav [Sun, 5 Mar 2017 05:15:02 +0000 (05:15 +0000)]
MFC r313945: Remove broken remnants of obsolete INOT API.

7 years agoMFC r314562:
kib [Sun, 5 Mar 2017 00:34:12 +0000 (00:34 +0000)]
MFC r314562:
Style.

7 years agoMFC r313909:
bdrewery [Sat, 4 Mar 2017 18:07:30 +0000 (18:07 +0000)]
MFC r313909:

  Fix panic with unlocked vnode to vrecycle().

7 years agoMFC r314273: zfs: call spa_deadman on a taskqueue thread
avg [Sat, 4 Mar 2017 12:42:52 +0000 (12:42 +0000)]
MFC r314273: zfs: call spa_deadman on a taskqueue thread

7 years agoMFC r314272: call vm_lowmem hook in uma_reclaim_worker
avg [Sat, 4 Mar 2017 12:05:46 +0000 (12:05 +0000)]
MFC r314272: call vm_lowmem hook in uma_reclaim_worker

7 years agoMFC r314357: edge-triggered interrupt mode is set by clearing APIC_LVT_TM
avg [Sat, 4 Mar 2017 12:04:19 +0000 (12:04 +0000)]
MFC r314357: edge-triggered interrupt mode is set by clearing APIC_LVT_TM