]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
vdev_ops: don't try to call vdev_op_hold or vdev_op_rele when NULL
authorfbynite <52733326+fbynite@users.noreply.github.com>
Sun, 21 Feb 2021 04:19:20 +0000 (19:19 -0900)
committerGitHub <noreply@github.com>
Sun, 21 Feb 2021 04:19:20 +0000 (20:19 -0800)
commit11f2e9a491baa2ae3fc00f6b8b892fa91a852ca1
tree948b0833d73cac362d03fcbefbddc28883d6b703
parent7e56b05058c8d2af2b5bc8b0b1475d9fdd6cd7dc
vdev_ops: don't try to call vdev_op_hold or vdev_op_rele when NULL

This prevents a panic after a SLOG add/removal on the root pool followed
by a zpool scrub.

When a SLOG is removed, a hole takes its place - the vdev_ops for a hole
is vdev_hole_ops, which defines the handler functions of vdev_op_hold
and vdev_op_rele as NULL.

This bug has been reported in illumos and FreeBSD, a different trigger
in the FreeBSD report though.

Credit for this patch goes to Patrick Mooney <pmooney@pfmooney.com>

Obtained from: illumos-gate commit: c65bd18728f34725
External-issue: https://www.illumos.org/issues/12981
External-issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252396
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Wing <rob.fx907@gmail.com>
Closes #11623
module/zfs/vdev.c